[{"id":1766967,"web_url":"http://patchwork.ozlabs.org/comment/1766967/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:30:11","subject":"Re: [U-Boot] [PATCH v2 05/21] efi_loader: add device-path utils","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Rob,\n\nOn 10 September 2017 at 05:21, Rob Clark wrote:\n> Helpers to construct device-paths from devices, partitions, files, and\n> for parsing and manipulating device-paths.\n>\n> For non-legacy devices, this will use u-boot's device-model to construct\n> device-paths which include bus hierarchy to construct device-paths. For\n> legacy devices we still fake it, but slightly more convincingly.\n>\n> Signed-off-by: Rob Clark \n> ---\n> include/efi_api.h | 10 +\n> include/efi_loader.h | 26 ++\n> lib/efi_loader/Makefile | 2 +-\n> lib/efi_loader/efi_boottime.c | 13 +-\n> lib/efi_loader/efi_device_path.c | 563 +++++++++++++++++++++++++++++++++++++++\n> 5 files changed, 611 insertions(+), 3 deletions(-)\n> create mode 100644 lib/efi_loader/efi_device_path.c\n\nSince this is new code we should not need the ifdef CONFIG_BLK,\nDM_MMC, etc. here, right?\n\nThe deadline for CONFIG_BLK has been set as 2018.05.\n\nAlso can we add some simple unit tests for this code somewhere?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"oBM/V0T5\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"DI5oKj0e\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4Xg3rmGz9t3h\n\tfor ;\n\tTue, 12 Sep 2017 22:54:39 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 7FBF2C220FF; Tue, 12 Sep 2017 12:37:51 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9A176C2209A;\n\tTue, 12 Sep 2017 12:37:49 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid B9C35C2208D; Tue, 12 Sep 2017 12:30:37 +0000 (UTC)","from mail-qt0-f178.google.com (mail-qt0-f178.google.com\n\t[209.85.216.178])\n\tby lists.denx.de (Postfix) with ESMTPS id D5750C21FE8\n\tfor ; Tue, 12 Sep 2017 12:30:33 +0000 (UTC)","by mail-qt0-f178.google.com with SMTP id b1so15401150qtc.4\n\tfor ; Tue, 12 Sep 2017 05:30:33 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:30:11 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=uNMdg1l15mmPXc8NZCOFQ6Klg+a/Wdvw1dMBzbVj8dU=;\n\tb=oBM/V0T5rkMkbqwK3PXovs0rrGsfNgqG66ERlwvZpcZiYrTzBeoH/MiW52D2ACx4MD\n\t2dmRo/HpZtvk3yU/mEKDJcmIOEyfoLgcg3WUZLcsgJPo3Wa+GpfaFIkiLFkrb5TFxOWH\n\t3q25oav939Ch6rlFE48WluG9+9Jpb0OvcWPW52akJXvw66cbQZzNcJ5JWLHNguINkHli\n\tMjcGTqOu1nZXW3y+s3gB0+51ouKQZDTHGj1PHTO8pba8vq4A7LStBuFKdiSF7GUYXyJF\n\tn28G5UvLty7L9xaxV7FLPumHFbRmSIQ2cBDOqpL9xs7CXy1zjVD5qtfBgPTVIKNyGw+b\n\tye+w==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=uNMdg1l15mmPXc8NZCOFQ6Klg+a/Wdvw1dMBzbVj8dU=;\n\tb=DI5oKj0eXUCzjCeJ6bsbsjNtrUc0h6HZ07mrgsTnlHCxhPgTQUVL60uWm02weRV9DB\n\tPuYcUPVI2HJ2fU8QbVbaS4KTT0Cagw4u0bqGbOuXHJVUC7d3yEEgUet3Ul4SKIcJZuKE\n\tylPioAaVBGbHvlph1l1RNbZ4ZFvQ2goMGED1g="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=uNMdg1l15mmPXc8NZCOFQ6Klg+a/Wdvw1dMBzbVj8dU=;\n\tb=km3PVIicNHu+ZlVUoApsVfAjMcA1QXV9+QBM6Rrjhz5S4MB1bc7gu30MbwwVWpTl+F\n\t2nLl6ZxDHhxSenzQoNUxfmR0IUD+nFpIOiGae1SvpPJVn2ClU51f1N7oY3p4iu/UP0O6\n\t/cUSzOSSH26bIZKUIqiuF1hVwt/hegBEL+dR+Dd/dd/S/NCrWPywKR8n8zWeTuLODur1\n\tF1ibLBiWd9GvM3WPvluhj6U3Mfmj2J46JvekAz/o76tnitG6d79+k1o7ogClXMwueusM\n\t194kdS1l8Akc0L87EKPpGrVPeGdCh2RNMHt70A81Y0IbS9k40xuC5m3dhzSQN+WAElHc\n\tALhw==","X-Gm-Message-State":"AHPjjUhKAG/CLYLNQGeEciEBFWb2uJozwYXYu4uic00R7ccHKbDKkbGS\n\tEfmhDWWlKw1RauKWbjDmZZssfuBdBE5Z2jOZaru5uPCU","X-Google-Smtp-Source":"AOwi7QBFuoAOqLtsVIgcjsqvfBWJEQhSTB3B5a8PyWIUUm+L1R3hV8sorvKUlNWmWRX+2AB0OpAiI7qLyzRUb5r6aPc=","X-Received":"by 10.200.23.252 with SMTP id r57mr21810481qtk.76.1505219432641; \n\tTue, 12 Sep 2017 05:30:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170910112149.21358-10-robdclark@gmail.com>","References":"<20170910112149.21358-1-robdclark@gmail.com>\n\t<20170910112149.21358-10-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:30:11 -0600","X-Google-Sender-Auth":"DNMtoIOrIWeya2d4fwqvOBS3Eg4","Message-ID":"","To":"Rob Clark ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ,\n\tPeter Jones ","Subject":"Re: [U-Boot] [PATCH v2 05/21] efi_loader: add device-path utils","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767006,"web_url":"http://patchwork.ozlabs.org/comment/1767006/","msgid":"","list_archive_url":null,"date":"2017-09-12T13:05:00","subject":"Re: [U-Boot] [PATCH v2 05/21] efi_loader: add device-path utils","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Tue, Sep 12, 2017 at 8:30 AM, Simon Glass wrote:\n> Hi Rob,\n>\n> On 10 September 2017 at 05:21, Rob Clark wrote:\n>> Helpers to construct device-paths from devices, partitions, files, and\n>> for parsing and manipulating device-paths.\n>>\n>> For non-legacy devices, this will use u-boot's device-model to construct\n>> device-paths which include bus hierarchy to construct device-paths. For\n>> legacy devices we still fake it, but slightly more convincingly.\n>>\n>> Signed-off-by: Rob Clark \n>> ---\n>> include/efi_api.h | 10 +\n>> include/efi_loader.h | 26 ++\n>> lib/efi_loader/Makefile | 2 +-\n>> lib/efi_loader/efi_boottime.c | 13 +-\n>> lib/efi_loader/efi_device_path.c | 563 +++++++++++++++++++++++++++++++++++++++\n>> 5 files changed, 611 insertions(+), 3 deletions(-)\n>> create mode 100644 lib/efi_loader/efi_device_path.c\n>\n> Since this is new code we should not need the ifdef CONFIG_BLK,\n> DM_MMC, etc. here, right?\n\nAlexander was pretty much against dropping support for legacy\ndevices.. so I think we need that.\n\nThere are a bunch of different places where efi_loader can be cleaned\nup when we require DM..\n\n> The deadline for CONFIG_BLK has been set as 2018.05.\n>\n> Also can we add some simple unit tests for this code somewhere?\n>\n\nGetting some Shell.efi into the py tests would exercise this and a\nwhole lot more. Although I think we need to add an aarch64 qemu\ndevice to travis?\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HZwzrKhU\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4lh6xPhz9rxl\n\tfor ;\n\tTue, 12 Sep 2017 23:05:20 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 90058C22081; Tue, 12 Sep 2017 13:05:06 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 380D4C21FD1;\n\tTue, 12 Sep 2017 13:05:04 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7D249C21FD1; Tue, 12 Sep 2017 13:05:02 +0000 (UTC)","from mail-lf0-f66.google.com (mail-lf0-f66.google.com\n\t[209.85.215.66])\n\tby lists.denx.de (Postfix) with ESMTPS id 0A12CC21FD0\n\tfor ; Tue, 12 Sep 2017 13:05:02 +0000 (UTC)","by mail-lf0-f66.google.com with SMTP id h80so5326317lfe.1\n\tfor ; Tue, 12 Sep 2017 06:05:02 -0700 (PDT)","by 10.46.29.20 with HTTP; Tue, 12 Sep 2017 06:05:00 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=5QPWAw+/PTv4FzwlZ3ppqRpPCGv9PnZB5OZAXa76Hyw=;\n\tb=HZwzrKhUb/29a0VEO2uhCRl2LLj/YGSrwa3tWU8a1U8ymQO3FVR4naJFYoaryR4yB0\n\t+alyZJYLnBW2JRPTnfXpkWjE/KoD8VqkzHBUsWOG1hinsoihSKWPqJB2pXm2nK6XRjce\n\t/qjfku+adFo3Ak2ngHW8ZXAZqg3SMPbMkrXLC1kCD73uRJQaMGDN8LTKIdJwEReZIaf5\n\t3BH2rCCs9e+a5dsTNgDoaD6ynhyQ9X5kiIKci9hu+3QZ1R2ziKVJXkxtPoAMmg2JZ/da\n\tECuNcSYHXoEDbV7xy29LEZY4n+RsvvnpBqjZDRj89sABWmAiLhWzVH0bjoX8mK/0VDJ8\n\tR2iw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=5QPWAw+/PTv4FzwlZ3ppqRpPCGv9PnZB5OZAXa76Hyw=;\n\tb=UQQPAVZz7WQT94tkvPsM4P6/gslx+ef+DU4wXVsxzFmKRitabjs/0EtXGj1gbRZk/c\n\tYplJ7teKzcvxYq1wQL3rH1Ez+3IIPYE8bXB0m165EGxIXpmMSveZIFvAEa1VJQJxg1mW\n\tHJF8OB6HFk8G9WNb1sq1QVXYaRCYgoSOF7WRbc+nUzpd7dtfh+fx8JjTrKpIIUqqaONy\n\t2xD4mWize44+b93XO9T0riHzpiq67aqscS8vfV/B6UEJ0l7EznAKkyR7Q+BvSq15TMq3\n\tsfyH4jyhXFKDP//SCoLrpPp9k8rfmCz69ivnc9CGMA8mUnDFtYBYOsYD5Z2h9gSLktFZ\n\tS+og==","X-Gm-Message-State":"AHPjjUgTUsDuTUWuGhSKwij5RZ7tLmlKlIp+b7OBEUiVXsbnhvtGn7Rs\n\taEBYIg12fMOpOpTgQNfwlMI0w5DxvA==","X-Google-Smtp-Source":"AOwi7QAaK6hyD8ZALE0kIIKbgDjaoc69rjrwx2C0lSQkwnqkJspjCSDjT5cje02peeU9+zBK81k6ilU1Eo12ktcCe7k=","X-Received":"by 10.25.41.147 with SMTP id p141mr4473706lfp.56.1505221501477; \n\tTue, 12 Sep 2017 06:05:01 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170910112149.21358-1-robdclark@gmail.com>\n\t<20170910112149.21358-10-robdclark@gmail.com>\n\t","From":"Rob Clark ","Date":"Tue, 12 Sep 2017 09:05:00 -0400","Message-ID":"","To":"Simon Glass ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ,\n\tPeter Jones ","Subject":"Re: [U-Boot] [PATCH v2 05/21] efi_loader: add device-path utils","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]