[{"id":1766997,"web_url":"http://patchwork.ozlabs.org/comment/1766997/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:29:45","subject":"Re: [U-Boot] [PATCH v3 2/9] fs/fat: introduce new director iterators","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 10 September 2017 at 05:21, Rob Clark wrote:\n> Untangle directory traversal into a simple iterator, to replace the\n> existing multi-purpose do_fat_read_at() + get_dentfromdir().\n>\n> Signed-off-by: Rob Clark \n> Reviewed-by: Łukasz Majewski \n> ---\n> fs/fat/fat.c | 356 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-\n> include/fat.h | 7 ++\n> 2 files changed, 360 insertions(+), 3 deletions(-)\n\nReviewed-by: Simon Glass \n\nBut I still think that fat_itr should not be a typedef, since this is\nsomething you are adding. I understand what you are saying about the\nexisting code, but really that should be converted at some point, as\nyou say.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"OuzF4hw8\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"YUNtEuLT\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4fX0JcFz9s0g\n\tfor ;\n\tTue, 12 Sep 2017 23:00:50 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2D615C22068; Tue, 12 Sep 2017 12:44:13 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id EA0FFC220F3;\n\tTue, 12 Sep 2017 12:44:10 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7C0CAC220E2; Tue, 12 Sep 2017 12:30:11 +0000 (UTC)","from mail-qk0-f170.google.com (mail-qk0-f170.google.com\n\t[209.85.220.170])\n\tby lists.denx.de (Postfix) with ESMTPS id B06BDC21FF2\n\tfor ; Tue, 12 Sep 2017 12:30:07 +0000 (UTC)","by mail-qk0-f170.google.com with SMTP id z143so24597889qkb.3\n\tfor ; Tue, 12 Sep 2017 05:30:07 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:29:45 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=TxiMc/fL14UkCdNpJwyd6D6rMHpF9k0WdWt/XnaIvMA=;\n\tb=OuzF4hw8Fpyz9NfmRoI7VvMDrzT8aLj2YFSX7j4fBPBfcoRQ0AzoItVNILXYhCEZsb\n\tN+ZdVPhVvMHteMM7ZZSEK2Qs9xcv5fuo5kppFQtpb4Fw4yRAjJU2ffhjzPMDWnRcemvT\n\trIDk5/GLgnlRbbFml2rDF2wYyq18u+XrnyKMOek8NgLzRWK4HVAnRTvOgkvFxyhaciKA\n\tSV7BoCIwnIFYPffAahEQHZ0wyQKHK8qB9yi4E1RyABoQZur/gzNc1d8f/H/SXfneCPDU\n\tagG5eCcGunOjA3rHLI9XDw6bfEdSODbNdQmLRMtHzD1cY+0LcgyA3B79oyDiMaUAxxSr\n\tywNw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=TxiMc/fL14UkCdNpJwyd6D6rMHpF9k0WdWt/XnaIvMA=;\n\tb=YUNtEuLT9Vq1nGQEOoPhDaRlnEmLRVOONsgEm1RncMZGE0+XvMU551Q63envJs2XU6\n\t2n1eN3SkSgmPwHefQpMbU8FEKT0ib9P1nNf4JVrvcsrlUgDrBtW9YOjgktUp4ps1pujQ\n\tjkqJyj5wRmrGF7tDLXTOUhfRaUcQmBTsvKz3Y="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=TxiMc/fL14UkCdNpJwyd6D6rMHpF9k0WdWt/XnaIvMA=;\n\tb=N2QRLGVqxesacuB89iPprq09zmiFW6GN0w7wWHsoixxNcyHIxaxZKYBxYGxoJaOUhp\n\t91IiAQFiiKbDkuNSvTk3STbIK1OqCCpLPZ1sLEW4/UYn7peXl5mEexxi1Ver5ZbGsO7K\n\tT4Tfl46xiTsTEPmIzp74me3TcpyW586qFNmGxBn70g9FYXBJyV1zBPPjWAuebCfs/KJH\n\ti+YKrnOZmMgboTmzNeN4yfo768rti4HAZZDIxnIk9XnRPnRHGNyLVk9+Y6uOFdsNhknA\n\tHU84l87gPyAaTSpLf7p+S+gROVedB0HzwhDoFvVmJb/yk6yuyCAAbaFb80De1MOkb+XQ\n\tJnmg==","X-Gm-Message-State":"AHPjjUgIRZQY45vh7Xvh1vUp0Ft4FRvt9HOFO4Aav2w5IZgn7DjgFiTw\n\tgO1MBkOhhaNhGYE7ZzGdAzfDSG7Br7u62ayQwezOcA==","X-Google-Smtp-Source":"AOwi7QBa8+muzj9rZrnxJaZwoO0k0btcM8mue6l00LtGiedwy9Ub2ljyKXP3GRY0MqXZJQo5qfYtv4xscX9nx1ET5VE=","X-Received":"by 10.55.81.215 with SMTP id f206mr18064081qkb.188.1505219406434;\n\tTue, 12 Sep 2017 05:30:06 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170910112149.21358-4-robdclark@gmail.com>","References":"<20170910112149.21358-1-robdclark@gmail.com>\n\t<20170910112149.21358-4-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:29:45 -0600","X-Google-Sender-Auth":"qp6hiWxnPzdMwMVZHb0_JUJwURM","Message-ID":"","To":"Rob Clark ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ,\n\tGenevieve Chan , Tien Fong Chee ","Subject":"Re: [U-Boot] [PATCH v3 2/9] fs/fat: introduce new director iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]