[{"id":1766614,"web_url":"http://patchwork.ozlabs.org/comment/1766614/","msgid":"<08c18921-e2ed-db59-cc4d-69854b6ced08@gmx.de>","list_archive_url":null,"date":"2017-09-11T22:55:07","subject":"Re: [U-Boot] [PATCH v2 01/21] part: move efi_guid_t","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 09/10/2017 01:21 PM, Rob Clark wrote:\n> Prep work for next patch.\n> \n> Signed-off-by: Rob Clark \n> ---\n> include/efi.h | 4 ++++\n> include/part.h | 3 ++-\n> include/part_efi.h | 4 ----\n> 3 files changed, 6 insertions(+), 5 deletions(-)\n> \n> diff --git a/include/efi.h b/include/efi.h\n> index 02b78b31b1..87b0b43f20 100644\n> --- a/include/efi.h\n> +++ b/include/efi.h\n> @@ -28,6 +28,10 @@\n> \n> struct efi_device_path;\n> \n> +typedef struct {\n> +\tu8 b[16];\n> +} efi_guid_t;\n> +\n> #define EFI_BITS_PER_LONG\tBITS_PER_LONG\n> \n> /*\n> diff --git a/include/part.h b/include/part.h\n> index 86117a7ce5..b2e820ef8a 100644\n> --- a/include/part.h\n> +++ b/include/part.h\n> @@ -280,8 +280,9 @@ struct part_driver {\n> #define U_BOOT_PART_TYPE(__name)\t\t\t\t\t\\\n> \tll_entry_declare(struct part_driver, __name, part_driver)\n> \n> -#if CONFIG_IS_ENABLED(EFI_PARTITION)\n> #include \n> +\n> +#if CONFIG_IS_ENABLED(EFI_PARTITION)\n> /* disk/part_efi.c */\n> /**\n> * write_gpt_table() - Write the GUID Partition Table to disk\n> diff --git a/include/part_efi.h b/include/part_efi.h\n> index 317c044795..31e6bc6e14 100644\n> --- a/include/part_efi.h\n> +++ b/include/part_efi.h\n> @@ -58,10 +58,6 @@\n> /* linux/include/efi.h */\n> typedef u16 efi_char16_t;\n> \n> -typedef struct {\n> -\tu8 b[16];\n> -} efi_guid_t;\n> -\n> /* based on linux/include/genhd.h */\n> struct partition {\n> \tu8 boot_ind;\t\t/* 0x80 - active */\n> \n\nThe patch extends\nhttps://lists.denx.de/pipermail/u-boot/2017-September/304970.html\n[PATCH 1/1] efi_loader: move efi_guid_t typedef to efi.h\n\nA descriptive commit message might be helpful.\n\nAcked-by: Heinrich Schuchardt ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrjvC1pnhz9s7B\n\tfor ;\n\tTue, 12 Sep 2017 08:55:33 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9196EC21E4B; Mon, 11 Sep 2017 22:55:28 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 36CD0C21EA7;\n\tMon, 11 Sep 2017 22:55:26 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 57C65C21EA7; Mon, 11 Sep 2017 22:55:24 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\tby lists.denx.de (Postfix) with ESMTPS id 063CDC21E4B\n\tfor ; Mon, 11 Sep 2017 22:55:24 +0000 (UTC)","from [192.168.8.100] ([92.40.249.251]) by mail.gmx.com (mrgmx103\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 0M9bYB-1dj3h247sV-00D1Qx;\n\tTue, 12 Sep 2017 00:55:12 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","To":"Rob Clark ","References":"<20170910112149.21358-1-robdclark@gmail.com>\n\t<20170910112149.21358-3-robdclark@gmail.com>","From":"Heinrich Schuchardt ","Message-ID":"<08c18921-e2ed-db59-cc4d-69854b6ced08@gmx.de>","Date":"Tue, 12 Sep 2017 00:55:07 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170910112149.21358-3-robdclark@gmail.com>","Content-Language":"en-US","X-Provags-ID":"V03:K0:2N7J1OTmBCTMmRWfnZA+TZuFPLojUlfQJquxPOFexk1GESfxv+e\n\tCIiXUW8b4gcpXnMTnibm8MDx3dEK3mjM/2QwKDjiM6R4vYMcowEeI4qqv/GNd02aQ1hT4NP\n\tZOjFc3uAbuYh8mJvf4+5j/MpyOwVU5SzU15UV5mnNFK8XlvxPjRW/dpM2ThYLHNbimT2w1M\n\t+R/DsikBBrKI21arTzbmg==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:iAVSpMf9ltw=:0CXwZQY+OpMtbk5Dhmja1s\n\tqJfzxJOdvt8ivBqYDBocbeyRs+PNGw5RsZtnW38Hia3QiR+oJgVAjX+anIrNtB912a6+PmSpo\n\tAXiauhM+4pf4hfaV8E4pupbdRVYZoL1x2EssE8Xxh/O4tTtNd0UwspKb78Io5DpU/NDS3Ejyy\n\tgPFBIrE1u9izi2t2m3TQfmVgnknJe6AicqeNlufUmzYs5LF9aWfrli7fFb3oPfoySsJtxR9ww\n\tNiMBzCnEPQ+qjec4hkBoxMoQnmu/X9VyvIgaQIublQ5lMNQGQuTe8by+rBpEEfAAped8+p6or\n\tjS3w0Wx+7Cog0kpJdMUsgBZGmgm+PLwDvfaj94scSkYK+cgE++OaZQxU21j87BEqdCxb9mUUG\n\tNO5Gl5nUgwX2GqrS8JjICnejlzuaCCZiwbJEoWFlxMMzxOY+dUL6I8hhpR39Qt76duzdMEYKq\n\tZVLhh+KobeL/uOWie4P8cXpLHyZVvkiAGFgMxxMNRcAvBdsDF77RNPxCwzDuvFHNLqWh5EyyK\n\tNmzrTxmzkhzHr7AXrXU7y3aki4W9y2fVr3eqA0tBTq2wSjx9NPfIw14962v/VLscG9KTNCgIu\n\tC+Z4c47S0YuhpIPb7oqhbu1NqxNa56PVHni6x9BIKgIUy8wLH02YrT6NqqFlI6cAdZt/Qaq6Q\n\tLeAurueFe4xqfGaWSXGjLl5BYOyv00Ed6MwoOjPIhYSNFkuvfyq2unLvavx6IQg8/Z4gbwILz\n\tIoVyfEmkNFtKlUUwORykXGNjPMI3w8R726txbpFB7JGsLkLBu0n+kVVqgp8dOzNObeNo5ixDH\n\tEbPYsGqyYINk5fqKTaofaRxphnvj21BHwPWeGd6bcUkF25gIdjcqgMnHDjpAtJ15hOyrSr6","Cc":"Petr Kulhavy , Alison Chaiken , \n\tU-Boot Mailing List ,\n\tSteve Rae ,\n\tMaxime Ripard ","Subject":"Re: [U-Boot] [PATCH v2 01/21] part: move efi_guid_t","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1766979,"web_url":"http://patchwork.ozlabs.org/comment/1766979/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:29:54","subject":"Re: [U-Boot] [PATCH v2 01/21] part: move efi_guid_t","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 10 September 2017 at 05:21, Rob Clark wrote:\n> Prep work for next patch.\n\nMove it where?\n\nReviewed-by: Simon Glass \n\n>\n> Signed-off-by: Rob Clark \n> ---\n> include/efi.h | 4 ++++\n> include/part.h | 3 ++-\n> include/part_efi.h | 4 ----\n> 3 files changed, 6 insertions(+), 5 deletions(-)\n>\n> diff --git a/include/efi.h b/include/efi.h\n> index 02b78b31b1..87b0b43f20 100644\n> --- a/include/efi.h\n> +++ b/include/efi.h\n> @@ -28,6 +28,10 @@\n>\n> struct efi_device_path;\n>\n> +typedef struct {\n> + u8 b[16];\n> +} efi_guid_t;\n\nPlease add a comment to this","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"ZeSjNBNr\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"hH0JoCaD\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4Xn4yMFz9t8C\n\tfor ;\n\tTue, 12 Sep 2017 22:55:52 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 34EA1C220D2; Tue, 12 Sep 2017 12:36:30 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 28093C22019;\n\tTue, 12 Sep 2017 12:36:28 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C0797C22008; Tue, 12 Sep 2017 12:30:20 +0000 (UTC)","from mail-qt0-f178.google.com (mail-qt0-f178.google.com\n\t[209.85.216.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 90F3AC21FA0\n\tfor ; Tue, 12 Sep 2017 12:30:16 +0000 (UTC)","by mail-qt0-f178.google.com with SMTP id i50so25177514qtf.0\n\tfor ; Tue, 12 Sep 2017 05:30:16 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:29:54 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=L6L2W6EvA5nvvlK50/s+7xZl7shovoAW2P53F79KfMk=;\n\tb=ZeSjNBNr1RaSwicUjPrrnybmjdzDhhJ/mEL6t9L/JaYmqk6g8kqgSOXRtMBucl2IxS\n\tifN5AR0u1JoWfchcIg9a9ZCrz76JKTOVimNIjVqFeIzO5R7u9wZJQ8hqkg2QPEZ1urY5\n\tMVOlmdxAF8Rwjav/Ff7vUUM2ZRme35IVWF3q3ANHgpkqqU8d/Ls5BjVqkpcGhPEvqxx1\n\t3OxAVsq2MiS8SXk/wXY1bRkOsFDlEvZaQ/NRYcoyMAnuVlMNs5g9+WFFAjmGhPwFjjs1\n\tWywB2k10S3uMPSZnjBRR3vdk/+xfRXm13JkNjVGm1Klh3liTcq8QtnPIfetZUAjSWTlt\n\tqWiw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=L6L2W6EvA5nvvlK50/s+7xZl7shovoAW2P53F79KfMk=;\n\tb=hH0JoCaD1PhyXwu8bQC6Qja52nvIAXb5F328n3f//8lQFogUCz4nLyZSA6K5L6sOva\n\tHcoeX7ZPyovwx3KzAx/kMvfLQCBqm9EtWt+iiBLE0ymdOx+Q2ZcSj4gw2d4Pxhu3RZBs\n\tpVu2FQrAKymFP4LaJ0EmJoXNVGDphSFYlf0Tg="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=L6L2W6EvA5nvvlK50/s+7xZl7shovoAW2P53F79KfMk=;\n\tb=lODMIKTw90xsNnqW6hekh4PrHWbsqSfW06ds6WVYdVczweFTkf07ICqpviXZJpGrK2\n\tx5/FDqr7PrjJQP3XsXlQEIM37eUiiIPJZ2us5xZUVH2adRro4Jp1XTtNO7jRqgJr/JxN\n\tirJQIrJkdBn4xCPm3Lh7YzqAv+kCpUH+ULOo72ker5ceoEb8yl/4sJz6ehU/RrXNyGdH\n\tOmN216b0KL8PL6Ap4I9DBUkxe7geRf/WRFMADF3/tf1zvX/Ha+TTdks/Z02ed+44qwRO\n\tz5YLXlU+iaBPQGZgzmeJGspysHABLY4Sa8/X4CLIhRfD/GnFr4I5Lxt3Wg3GOnk4BVmD\n\t2OTQ==","X-Gm-Message-State":"AHPjjUgTtN9gdJWqnU3sANbusm5A8I2TJWIdFa9/E5VL1jCJjdhnkLGq\n\tiKZ5EudfEUaTtF0ACtHthE9xejsrfbMRvCZmwhiOmvZW","X-Google-Smtp-Source":"AOwi7QAsf8e8TUWJqYiW/5GkoRBvyvAflGDodMuuajNB4ezYO9Jz6t5EIVznxn5JTvq4LP/F4QP0wxFaNnRFQieXgx8=","X-Received":"by 10.237.35.238 with SMTP id k43mr21522355qtc.214.1505219415247;\n\tTue, 12 Sep 2017 05:30:15 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170910112149.21358-3-robdclark@gmail.com>","References":"<20170910112149.21358-1-robdclark@gmail.com>\n\t<20170910112149.21358-3-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:29:54 -0600","X-Google-Sender-Auth":"dBKGmvK4xg8MrQhOuAPIgwx8RVU","Message-ID":"","To":"Rob Clark ","Cc":"Petr Kulhavy , Heinrich Schuchardt , \n\tAlison Chaiken ,\n\tU-Boot Mailing List ,\n\tSteve Rae ,\n\tMaxime Ripard ","Subject":"Re: [U-Boot] [PATCH v2 01/21] part: move efi_guid_t","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]