[{"id":1766972,"web_url":"http://patchwork.ozlabs.org/comment/1766972/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:29:07","subject":"Re: [U-Boot] [PATCH v3 3/9] fat/fs: convert to directory iterators","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 9 September 2017 at 11:15, Rob Clark wrote:\n> And drop a whole lot of ugly code!\n>\n> Signed-off-by: Rob Clark \n> Reviewed-by: Łukasz Majewski \n> ---\n> fs/fat/fat.c | 722 +++++++---------------------------------------------------\n> include/fat.h | 6 -\n> 2 files changed, 76 insertions(+), 652 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"VoQCopW8\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"GbZVjwHu\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4Xm3vfVz9t7r\n\tfor ;\n\tTue, 12 Sep 2017 22:55:51 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid CAAC5C220E3; Tue, 12 Sep 2017 12:33:44 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id BE60AC22031;\n\tTue, 12 Sep 2017 12:32:30 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 48051C2201A; Tue, 12 Sep 2017 12:29:36 +0000 (UTC)","from mail-qk0-f177.google.com (mail-qk0-f177.google.com\n\t[209.85.220.177])\n\tby lists.denx.de (Postfix) with ESMTPS id C6AD0C21FF6\n\tfor ; Tue, 12 Sep 2017 12:29:29 +0000 (UTC)","by mail-qk0-f177.google.com with SMTP id a128so24569781qkc.5\n\tfor ; Tue, 12 Sep 2017 05:29:29 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:29:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=CtJzveiG1XKDfSKHxtqZY6pjq6IOpgYj8NxY76NaiPk=;\n\tb=VoQCopW87A5rWQJWMyrFHPq+n2WqfOoO+HxNtqGb8gfxwfmSRzHEsSkH8C8VTVGAu7\n\tblWMN5KzXa9JUAYPoJlMwB01QX1v+LmLY0q/hBeTDjULJIUoGbCvGO77NQEMHtK0VPwK\n\t7nxtk1YzX968oC9aFcVxUWlu3tDb9koeCalfy4mcEj6JkgYsdTU/pAEY294GekS+VQww\n\t42IiIlWo1z+UhwqIYVsujspiJI+uuhuVKk49Yb+QaWa+zfxFrp6oCseDwCRDJ0mq6a5V\n\taX1zNfd2oy/jZ2fX2Df/La3qshVu4LpO9igc1g/faFsGmgXkvGfx80lGpNoxxeaMVtwt\n\tqwfg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=CtJzveiG1XKDfSKHxtqZY6pjq6IOpgYj8NxY76NaiPk=;\n\tb=GbZVjwHuqYqYZXl2gmUG1JKUVEYb7ujB91PKvwRw2Xt3gmulGFDnPzb7AeLwqafGHw\n\tTrfXiDgE9V5kcHhJi1pGyuE2/iQ1mv6eI7aCm2gQloDASjGBEKU6DRB9HLwQ1h1FDKsd\n\tvxjdyFYXsKUmr93Hk+HGljnggVj4blRBWpV/s="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=CtJzveiG1XKDfSKHxtqZY6pjq6IOpgYj8NxY76NaiPk=;\n\tb=sItz/cF+tW5VFoPPThey0Uj1ar1ZRq48b74i1K/k++JDY+JWUma5oKL7lwa4kzzgYN\n\tZtZZ5HOCJZoSr3RZDOesWG2waWHTVW6fpKjbUpXsNVS4qzyvMOl9vLT1xrHpmqvUo/lD\n\ta+Q5OP2PXJfvvpfgBhaiFz5j6LIqS/0dQfqpyynSb7a+p6dOcIiI64cgx1KugSW1uKi6\n\tSW87NZ21quJ9MTIJ5ng8z07Up9tMXp9KUp4COdLJUZLGt7eaf73V7i2JTxxScLDjDaKK\n\trcRz/uEX3UJ5qUoBXymjukaLuYkS9fcrOOfh03i3YXub2S2u8ktiXfTPEca/ERotAgRG\n\tI+xw==","X-Gm-Message-State":"AHPjjUh0a95htF4yW85+27PwQadnHVO7OedI8RA3HigZjBvavKp9X6d4\n\tIiWCfjGcjUL2zt+gwKrDrR9ON1vvhm3S5cF5PusL2g==","X-Google-Smtp-Source":"AOwi7QCbHs8GwCxFIahf8N9/6K6pb57gqD4zHSPVV1xPYQx+VlaYNcYQQWXJEotI3shn5saxuAtraFsDyIJrXgDTE10=","X-Received":"by 10.55.17.207 with SMTP id 76mr3950194qkr.178.1505219368462;\n\tTue, 12 Sep 2017 05:29:28 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170909171606.20029-4-robdclark@gmail.com>","References":"<20170909171606.20029-1-robdclark@gmail.com>\n\t<20170909171606.20029-4-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:29:07 -0600","X-Google-Sender-Auth":"0LrVPpDQ_g_Y0TmQQ01nMFBC1M8","Message-ID":"","To":"Rob Clark ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ,\n\tTien Fong Chee ","Subject":"Re: [U-Boot] [PATCH v3 3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769541,"web_url":"http://patchwork.ozlabs.org/comment/1769541/","msgid":"<20170916023206.GQ4560@bill-the-cat>","list_archive_url":null,"date":"2017-09-16T02:32:06","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Sat, Sep 09, 2017 at 01:15:54PM -0400, Rob Clark wrote:\n\n> And drop a whole lot of ugly code!\n> \n> Signed-off-by: Rob Clark \n> Reviewed-by: Łukasz Majewski \n> Reviewed-by: Simon Glass \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"AYXVWXUx\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvGcP74Yzz9s3T\n\tfor ;\n\tSat, 16 Sep 2017 12:36:37 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid BF374C21FB7; Sat, 16 Sep 2017 02:33:06 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id CA2E8C21F27;\n\tSat, 16 Sep 2017 02:32:28 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7E39BC21F77; Sat, 16 Sep 2017 02:32:10 +0000 (UTC)","from mail-yw0-f176.google.com (mail-yw0-f176.google.com\n\t[209.85.161.176])\n\tby lists.denx.de (Postfix) with ESMTPS id 10547C21E8A\n\tfor ; Sat, 16 Sep 2017 02:32:10 +0000 (UTC)","by mail-yw0-f176.google.com with SMTP id w22so2417334ywa.13\n\tfor ; Fri, 15 Sep 2017 19:32:10 -0700 (PDT)","from bill-the-cat (cpe-65-184-142-68.ec.res.rr.com.\n\t[65.184.142.68])\n\tby smtp.gmail.com with ESMTPSA id u5sm449417ywi.0.2017.09.15.19.32.08\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tFri, 15 Sep 2017 19:32:08 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=z9Wy/O4+Ah1mL2K6h1wZMsdFpgbHc2F0mqldOmUqj8c=;\n\tb=AYXVWXUxB8kJbJSfq0P5C0byXdIG1xzG96ecS+G/+CtfaI7XVpptInFFRAdMImAjLs\n\tUvs5K0Wj0dJdB9v26HvBnBvA5TV5nZELfbr+7zI+Y5eNmpxLD02H4EfH5xy4l3dftI50\n\tRT5vrJ1PyLS+PKSj8wYIyx23a+4t2SqYRexeo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=z9Wy/O4+Ah1mL2K6h1wZMsdFpgbHc2F0mqldOmUqj8c=;\n\tb=kl0lqxNTWRIUaIe7TlS9DIR/bmNbUbi7ME7P1/tkD2zyvv+d/02y/IlE+zwZgFJCF5\n\t9B03jbDGgDtaM27nCBukI0ST/9+4X9RGqiFzaTjOFMAps94H7SH84SJ6GlQ0jSGt/VX6\n\tZ4549OUsm9SGMr2omGwFmf0KEhiCV8+3pqXYVgFlvgLwG2qI1lkCRf5RpWg82QxbULfa\n\tCF3M+HTfgTY5m2xXHk8qyAgYbcn03zcGfKYmViGfNKxymY2w7rcZmwyWdGnDJChRpSB7\n\t8cAqElB8IZmwt5+RZiCjnu4pk7vv0aTlek2RfniDPLbx7WaBPYH+ZPmOLVa6yqaNORDO\n\t4Yxg==","X-Gm-Message-State":"AHPjjUhC2DkksMRAX1fmdVsnvH8+Rx3QYvJquHxbzP/veeCaPljNLP/n\n\t6Pwq2u4Z2FfYSNcq","X-Google-Smtp-Source":"AOwi7QCQ35Hgqkc5nyhGVFBlMXg/doUMd69AYN1/6VSs57OAKqv3h1RZHtKAR9Law2AU16MfYFhl6g==","X-Received":"by 10.37.31.193 with SMTP id f184mr6063089ybf.2.1505529128970;\n\tFri, 15 Sep 2017 19:32:08 -0700 (PDT)","Date":"Fri, 15 Sep 2017 22:32:06 -0400","From":"Tom Rini ","To":"Rob Clark ","Message-ID":"<20170916023206.GQ4560@bill-the-cat>","References":"<20170909171606.20029-4-robdclark@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<20170909171606.20029-4-robdclark@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"U-Boot Mailing List ,\n\tTien Fong Chee ,\n\tHeinrich Schuchardt ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============6242260869466366063==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769636,"web_url":"http://patchwork.ozlabs.org/comment/1769636/","msgid":"","list_archive_url":null,"date":"2017-09-16T20:32:24","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":67132,"url":"http://patchwork.ozlabs.org/api/people/67132/","name":"Adam Ford","email":"aford173@gmail.com"},"content":"On Fri, Sep 15, 2017 at 9:32 PM, Tom Rini wrote:\n>\n> On Sat, Sep 09, 2017 at 01:15:54PM -0400, Rob Clark wrote:\n>\n> > And drop a whole lot of ugly code!\n> >\n> > Signed-off-by: Rob Clark \n> > Reviewed-by: Łukasz Majewski \n> > Reviewed-by: Simon Glass \n>\n> Applied to u-boot/master, thanks!\n>\n\nAccording to git bisect, this patch seems to break the booting of am3517_evm\n\nIt just displays:\n\nU-Boot SPL 2017.09-00135-g8eafae2 (Sep 16 2017 - 15:23:16)\nTrying to boot from MMC1\n\nThen hangs.\n\nIt does, however the same patch boots just fine on\nomap3_logic_defconfig which is an OMAP3630/DM3730 board.\n\nda850evm_defconfig (OMAP-L138) is also booting just fine.\n\nI'm going to investigate it further to see why just 1/3 boards seems impacted.\n\nadam\n\n>\n> --\n> Tom\n>\n> _______________________________________________\n> U-Boot mailing list\n> U-Boot@lists.denx.de\n> https://lists.denx.de/listinfo/u-boot\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"f/pk69z5\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvkTz4B3Rz9sRm\n\tfor ;\n\tSun, 17 Sep 2017 06:32:39 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3919BC21D96; Sat, 16 Sep 2017 20:32:32 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B119BC21C4E;\n\tSat, 16 Sep 2017 20:32:29 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 9048DC21C4E; Sat, 16 Sep 2017 20:32:27 +0000 (UTC)","from mail-ua0-f194.google.com (mail-ua0-f194.google.com\n\t[209.85.217.194])\n\tby lists.denx.de (Postfix) with ESMTPS id 48248C21C39\n\tfor ; Sat, 16 Sep 2017 20:32:26 +0000 (UTC)","by mail-ua0-f194.google.com with SMTP id l24so1580150uaa.5\n\tfor ; Sat, 16 Sep 2017 13:32:26 -0700 (PDT)","by 10.159.59.213 with HTTP; Sat, 16 Sep 2017 13:32:24 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=KgDuoJUBUxJjqggRQOvkZT0cs/KMww+5S/WBfLreboQ=;\n\tb=f/pk69z5Nl4Ty7tg7Uh71u05QqA8LCW1YqPKc1SH6Hh3JWpGVPLVapZqk9vA0R10S1\n\tn5cXNEis1jD2ZhpsYB9wWzLS8X55sEoUkvwXo6r9LIa+QIHAt4FOF7A5mL6xX8EWVN6w\n\tjI4YOOUEmaq/tCXnPr664LJQBOOrVwM46KB2YqKg96QgjlsTWL/urlb5oN1lhvN/BuJV\n\tLz/bRwDCADgDKh3VNcmiUWgyu7Eq5+8lumG32CF5JBUpv3CPYzLwDN03bVTU3l/t26E5\n\tZXB7uJp95OXutFZkSRSgZXoJe+FCbGH2ZqvP/HwLzvUxoCtSkHpmPB6nlJky8OAe5d58\n\tJK2w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=KgDuoJUBUxJjqggRQOvkZT0cs/KMww+5S/WBfLreboQ=;\n\tb=fq12yipAFFd45XpEi7iO9vMdl2tVekMU2l5aTDvSK2faXxnR+fYugql0YdwxWKg9JA\n\tYbIBysZYqbpFieB0kkIXxViU+nMWKVSm+BqXs3ehPiQ/mJZ/b0suYTUoW3PGHrV49W94\n\t/FuBvOYWDtE6Bxt/DOcXgevY9kzn/cbfOQ1LayXBbxdsYX5uYR20PDHNnEIDiJJEIMC7\n\tlEP3zwUPH39pk7GDTXFN0qOU/V0KaRj5n9e90BwNl6CpJMdxrd9kefdNuR9y2YbIlH/l\n\tRE4MZ8j7ivIw8MK4x31ivftwtk0b04tBxtWT4vpaXLnDuOffEJudmCgNsVoWzeUT0XFF\n\t3Jcg==","X-Gm-Message-State":"AHPjjUilw5JWOtdDE95Wk+EfsjbAPTZKv1EzmX2r+Xl1vk7cplmEmswQ\n\tN1vxzGzhWkZwINdRpaJMzLN+2DaOdfRz1Ybe2rc=","X-Google-Smtp-Source":"ADKCNb6lm0rISAqh8jRZeLYOvWOrq5v8/QrARXGj4Z22CBKXlWDMbzoDeTUNolNMNUxXik+8hS//wONRiJrvfugkRtA=","X-Received":"by 10.176.71.202 with SMTP id w10mr25348291uac.79.1505593945060; \n\tSat, 16 Sep 2017 13:32:25 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170916023206.GQ4560@bill-the-cat>","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>","From":"Adam Ford ","Date":"Sat, 16 Sep 2017 15:32:24 -0500","Message-ID":"","To":"Tom Rini ","Cc":"U-Boot Mailing List ,\n\tTien Fong Chee ,\n\tHeinrich Schuchardt ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769637,"web_url":"http://patchwork.ozlabs.org/comment/1769637/","msgid":"","list_archive_url":null,"date":"2017-09-16T20:42:31","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Sat, Sep 16, 2017 at 4:32 PM, Adam Ford wrote:\n> On Fri, Sep 15, 2017 at 9:32 PM, Tom Rini wrote:\n>>\n>> On Sat, Sep 09, 2017 at 01:15:54PM -0400, Rob Clark wrote:\n>>\n>> > And drop a whole lot of ugly code!\n>> >\n>> > Signed-off-by: Rob Clark \n>> > Reviewed-by: Łukasz Majewski \n>> > Reviewed-by: Simon Glass \n>>\n>> Applied to u-boot/master, thanks!\n>>\n>\n> According to git bisect, this patch seems to break the booting of am3517_evm\n>\n> It just displays:\n>\n> U-Boot SPL 2017.09-00135-g8eafae2 (Sep 16 2017 - 15:23:16)\n> Trying to boot from MMC1\n>\n> Then hangs.\n>\n> It does, however the same patch boots just fine on\n> omap3_logic_defconfig which is an OMAP3630/DM3730 board.\n>\n> da850evm_defconfig (OMAP-L138) is also booting just fine.\n>\n> I'm going to investigate it further to see why just 1/3 boards seems impacted.\n>\n\nTom reported a similar fail.. although I am failing to reproduce it in\nsandbox w/ a copy of his partition, so maybe it is somehow hw\nspecific? If you could, debug logs w/\nhttps://hastebin.com/raw/fijazebiso applied in before/after case would\nbe useful.. maybe I could spot something from that?\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CVQ9byoq\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvkjX68Xmz9sRm\n\tfor ;\n\tSun, 17 Sep 2017 06:42:40 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9EC9AC21DA0; Sat, 16 Sep 2017 20:42:38 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A8E9AC21C39;\n\tSat, 16 Sep 2017 20:42:35 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 93FFEC21C39; Sat, 16 Sep 2017 20:42:33 +0000 (UTC)","from mail-lf0-f66.google.com (mail-lf0-f66.google.com\n\t[209.85.215.66])\n\tby lists.denx.de (Postfix) with ESMTPS id 1857AC21C26\n\tfor ; Sat, 16 Sep 2017 20:42:33 +0000 (UTC)","by mail-lf0-f66.google.com with SMTP id c8so2755377lfe.2\n\tfor ; Sat, 16 Sep 2017 13:42:33 -0700 (PDT)","by 10.46.41.75 with HTTP; Sat, 16 Sep 2017 13:42:31 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=reWu/WC5KGji5SPg/FAnrPS5tAXGSRgVl7JNYd71Jbc=;\n\tb=CVQ9byoqHUS9Eho1jhg9XTPPotqlck9ReUBlodZGiDq7IHEUPaTYTRxQyogU6goQGz\n\tvOgh3kM7Qihk6G1SymsDPZnKWmXsFn2yluh83bkw0MKvs87iVSjUYsJw686zQJIRDdgO\n\tS9Q8SGb/MZPlOC/uVt16XAcnB0lmFH8VRJjqgb+F+daoRWK7GzzTwJfP6g4nbg26r2zA\n\tOYBRdwNrRZnSKhlAXlRZ/xpb8eTRLskYQvXkv5hItxOJaa0lfThYXpoWPceG6WmY1Lum\n\tk/uFZWHQGYNUNcAh6LGLQ4nykx+PrFQpbzMGSSYpFyfZoOxMoGz9MByEGx5YJGWIWA5+\n\tLbPA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=reWu/WC5KGji5SPg/FAnrPS5tAXGSRgVl7JNYd71Jbc=;\n\tb=h+TI5vVvLI4Mdjn5s0gI+eXpW8ChbQPrEUytw8v+nVigkSaFnyQlokU9Fgab8K9bDp\n\t6QV1Mv56lsrNDTrpiNtvmO9aWrEnECQIXxU2MEWFgBCkMLGHr6fV6R/1KbGeXqYq4F2q\n\tH6eri7kssdvWiz8aU/QPGT32Cu39l9f35jU47h/f/qS/986gVKwfGW+VIx5ssZSgWhcb\n\tAaD4fWLQ0B6bUehcUma9nhw2H6sxnJ75IKM2yc0duAIxBwJuAe8Dv0Ut+Q96z7Ft9iOn\n\tfA0PkrY5+iEWn8SlVTJ/o9e481NnrB9BMAJtUuU/lcHxruAbHk/ogB00cfwzFbxecQvd\n\tuUlQ==","X-Gm-Message-State":"AHPjjUjITT4tWl6AGmmjKwZXhHvTVzLTOm+ZE23cPpP5ZXCRhf1J71+Q\n\ty4fhYAaOu5eDWNNr3Y9Gpa7vtd1Us1fMhYAs+Dg=","X-Google-Smtp-Source":"AOwi7QB8scjSyOZzJkd/6tkXkUZHz6MvbPjv8y9/PrnXD126u4a3UuSuWRgix2hF7cS0h3eYK3yv6t6PGQWi7tFlFYY=","X-Received":"by 10.46.19.26 with SMTP id 26mr11099748ljt.20.1505594552496;\n\tSat, 16 Sep 2017 13:42:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>\n\t","From":"Rob Clark ","Date":"Sat, 16 Sep 2017 16:42:31 -0400","Message-ID":"","To":"Adam Ford ","Cc":"Tom Rini , Heinrich Schuchardt , \n\tTien Fong Chee ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769692,"web_url":"http://patchwork.ozlabs.org/comment/1769692/","msgid":"","list_archive_url":null,"date":"2017-09-17T11:08:44","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":67132,"url":"http://patchwork.ozlabs.org/api/people/67132/","name":"Adam Ford","email":"aford173@gmail.com"},"content":"On Sat, Sep 16, 2017 at 3:42 PM, Rob Clark wrote:\n> On Sat, Sep 16, 2017 at 4:32 PM, Adam Ford wrote:\n>> On Fri, Sep 15, 2017 at 9:32 PM, Tom Rini wrote:\n>>>\n>>> On Sat, Sep 09, 2017 at 01:15:54PM -0400, Rob Clark wrote:\n>>>\n>>> > And drop a whole lot of ugly code!\n>>> >\n>>> > Signed-off-by: Rob Clark \n>>> > Reviewed-by: Łukasz Majewski \n>>> > Reviewed-by: Simon Glass \n>>>\n>>> Applied to u-boot/master, thanks!\n>>>\n>>\n>> According to git bisect, this patch seems to break the booting of am3517_evm\n>>\n>> It just displays:\n>>\n>> U-Boot SPL 2017.09-00135-g8eafae2 (Sep 16 2017 - 15:23:16)\n>> Trying to boot from MMC1\n>>\n>> Then hangs.\n>>\n>> It does, however the same patch boots just fine on\n>> omap3_logic_defconfig which is an OMAP3630/DM3730 board.\n>>\n>> da850evm_defconfig (OMAP-L138) is also booting just fine.\n>>\n>> I'm going to investigate it further to see why just 1/3 boards seems impacted.\n>>\n>\n> Tom reported a similar fail.. although I am failing to reproduce it in\n> sandbox w/ a copy of his partition, so maybe it is somehow hw\n> specific? If you could, debug logs w/\n> https://hastebin.com/raw/fijazebiso applied in before/after case would\n> be useful.. maybe I could spot something from that?\n>\n\nAdding the debug to master made no difference. No debug messages appeared.\nInterestingly enough, some junk appeard, and the name of U-Boot name\nwasn't correctly displayed:\n\n**Sș017.09-00178-g08cebee-dirty (Sep 17 2017 - 06:01:07)\nTrying to boot from MMC1\n\n(hang)\n\nCould there a be some memory overflow somewhere?\n\nAdding the debug to the last working commit, yielded the following:\n\nU-Boot SPL 2017.09-00134-ge71f88d-dirty (Sep 17 2017 - 06:03:28)\nTrying to boot from MMC1\nreading u-boot.img\nVFAT Support enabled\nFAT16, fat_sect: 1, fatlength: 200\nRootdir begins at cluster: 536870910, sector: 401, offset: 32200\nData begins at: 417\nSector size: 512, cluster size: 8\nFAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=d\nRootMismatch: |mlo||\nRootvfatname: |u-boot.img|\nRootName: u-boot.img, start: 0x98, size: 0x83708\nFilesize: u bytes\nu bytes\ngc - clustnum: 152, startsect: 1633\nSize: 538376, got: u\nreading u-boot.img\nVFAT Support enabled\nFAT16, fat_sect: 1, fatlength: 200\nRootdir begins at cluster: 536870910, sector: 401, offset: 32200\nData begins at: 417\nSector size: 512, cluster size: 8\nFAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=d\nRootMismatch: |mlo||\nRootvfatname: |u-boot.img|\nRootName: u-boot.img, start: 0x98, size: 0x83708\nFilesize: u bytes\nu bytes\n\nI truncated it, because after that, it seems to just be showing\nentries and offsets over and over again.\n\nadam\n> BR,\n> -R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"iIYz9K0N\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw5xB27Dsz9sBZ\n\tfor ;\n\tSun, 17 Sep 2017 21:09:00 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 9DB95C21C62; Sun, 17 Sep 2017 11:08:51 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id AE398C21C62;\n\tSun, 17 Sep 2017 11:08:48 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid CD9A7C21C62; Sun, 17 Sep 2017 11:08:47 +0000 (UTC)","from mail-vk0-f65.google.com (mail-vk0-f65.google.com\n\t[209.85.213.65])\n\tby lists.denx.de (Postfix) with ESMTPS id 38984C21C39\n\tfor ; Sun, 17 Sep 2017 11:08:47 +0000 (UTC)","by mail-vk0-f65.google.com with SMTP id j189so1551876vka.0\n\tfor ; Sun, 17 Sep 2017 04:08:47 -0700 (PDT)","by 10.159.59.213 with HTTP; Sun, 17 Sep 2017 04:08:44 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=CN+f/tNi88niNu9C1EgU2f6/YLCFu69w9zAsY5j40Ro=;\n\tb=iIYz9K0N1V9oKCWnUexWoPcCM6n40nywUYHww7BzuiSQVntKzxckr9LfQNDpXjZXGX\n\tFeQ/zShmbdySyJe9t+Y2JST5PkC5GLan89ygAc33/FfNCjqDzuPwERr2Tda+Al3lVPKY\n\tevZvcD9WEDb5Hzq8dyILtZ9QhegfJTj6NNBDgHSCjTmBkcK7fDc9J5yJTuOksGVchEyQ\n\tn55fVwfY3rlQ+LtzOixPVyZZsp2Fmc8YBOjSguOowCnHM0TNdNavFvyjrdkmL8nXSatx\n\toy0MvNA0Zri72wtR239bA5WYUs+XsycpeHCStd886LsmotJoSeIta/4eHsGYktOtqKxf\n\twylw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=CN+f/tNi88niNu9C1EgU2f6/YLCFu69w9zAsY5j40Ro=;\n\tb=Yal1ugX8LqqkoaQq+d6XWw2gFUk3PVFWdy/CxuhEU3whK/W0zsUJH6xejOiARNTScF\n\tTg7jKvDRn6wNaXgA+PoLbWsiAjdSTDPrAkd0HALWhwfI/2Yiw3P/QGDLQUMKDRdVxWJi\n\tUZzaoAbqt/7Sy7i+dLWpmMMaWyql9F56TSKYmPurqG97t+Vej899iaoKD4VZSygoFBlQ\n\tZOVwXX15t3cRea8+Ql24GlUuFnMKItsTs/OrIgSYXmD/EpR2WBoKAh37twPzVrwOqluB\n\tRIZWX2T4+Y4FGcG8s4g8caNOtzKbjT+DLEq1Blqq3mgF24Moa12VUHi67T9MoqLacbX6\n\tJkDg==","X-Gm-Message-State":"AHPjjUiPefJ0GoWw3qtWe4/ZDchodMwIuZluGlqaZzWP8qi+PLO4xgyT\n\tj2mBlMzYUpDj9vAmhOyp0S9FZynMKfXmpMNMvPU=","X-Google-Smtp-Source":"AOwi7QAyQqmifGbUwKcoltT1PH4J/LIXZQ80JMRwwbNTKY6B/12nzM4CbgEPZ+vUhrjoxtvtgtCDiwgbGbO5GQsasXU=","X-Received":"by 10.31.163.150 with SMTP id\n\tm144mr21090529vke.171.1505646525147; \n\tSun, 17 Sep 2017 04:08:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>\n\t\n\t","From":"Adam Ford ","Date":"Sun, 17 Sep 2017 06:08:44 -0500","Message-ID":"","To":"Rob Clark ","Cc":"Tom Rini , Heinrich Schuchardt , \n\tTien Fong Chee ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769696,"web_url":"http://patchwork.ozlabs.org/comment/1769696/","msgid":"","list_archive_url":null,"date":"2017-09-17T12:28:17","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Sun, Sep 17, 2017 at 7:08 AM, Adam Ford wrote:\n> On Sat, Sep 16, 2017 at 3:42 PM, Rob Clark wrote:\n>> On Sat, Sep 16, 2017 at 4:32 PM, Adam Ford wrote:\n>>> On Fri, Sep 15, 2017 at 9:32 PM, Tom Rini wrote:\n>>>>\n>>>> On Sat, Sep 09, 2017 at 01:15:54PM -0400, Rob Clark wrote:\n>>>>\n>>>> > And drop a whole lot of ugly code!\n>>>> >\n>>>> > Signed-off-by: Rob Clark \n>>>> > Reviewed-by: Łukasz Majewski \n>>>> > Reviewed-by: Simon Glass \n>>>>\n>>>> Applied to u-boot/master, thanks!\n>>>>\n>>>\n>>> According to git bisect, this patch seems to break the booting of am3517_evm\n>>>\n>>> It just displays:\n>>>\n>>> U-Boot SPL 2017.09-00135-g8eafae2 (Sep 16 2017 - 15:23:16)\n>>> Trying to boot from MMC1\n>>>\n>>> Then hangs.\n>>>\n>>> It does, however the same patch boots just fine on\n>>> omap3_logic_defconfig which is an OMAP3630/DM3730 board.\n>>>\n>>> da850evm_defconfig (OMAP-L138) is also booting just fine.\n>>>\n>>> I'm going to investigate it further to see why just 1/3 boards seems impacted.\n>>>\n>>\n>> Tom reported a similar fail.. although I am failing to reproduce it in\n>> sandbox w/ a copy of his partition, so maybe it is somehow hw\n>> specific? If you could, debug logs w/\n>> https://hastebin.com/raw/fijazebiso applied in before/after case would\n>> be useful.. maybe I could spot something from that?\n>>\n>\n> Adding the debug to master made no difference. No debug messages appeared.\n> Interestingly enough, some junk appeard, and the name of U-Boot name\n> wasn't correctly displayed:\n>\n> **Sș017.09-00178-g08cebee-dirty (Sep 17 2017 - 06:01:07)\n> Trying to boot from MMC1\n>\n> (hang)\n>\n> Could there a be some memory overflow somewhere?\n>\n> Adding the debug to the last working commit, yielded the following:\n>\n> U-Boot SPL 2017.09-00134-ge71f88d-dirty (Sep 17 2017 - 06:03:28)\n> Trying to boot from MMC1\n> reading u-boot.img\n> VFAT Support enabled\n> FAT16, fat_sect: 1, fatlength: 200\n> Rootdir begins at cluster: 536870910, sector: 401, offset: 32200\n> Data begins at: 417\n> Sector size: 512, cluster size: 8\n> FAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=d\n> RootMismatch: |mlo||\n> Rootvfatname: |u-boot.img|\n> RootName: u-boot.img, start: 0x98, size: 0x83708\n> Filesize: u bytes\n> u bytes\n> gc - clustnum: 152, startsect: 1633\n> Size: 538376, got: u\n> reading u-boot.img\n> VFAT Support enabled\n> FAT16, fat_sect: 1, fatlength: 200\n> Rootdir begins at cluster: 536870910, sector: 401, offset: 32200\n> Data begins at: 417\n> Sector size: 512, cluster size: 8\n> FAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=d\n> RootMismatch: |mlo||\n> Rootvfatname: |u-boot.img|\n> RootName: u-boot.img, start: 0x98, size: 0x83708\n> Filesize: u bytes\n> u bytes\n>\n> I truncated it, because after that, it seems to just be showing\n> entries and offsets over and over again.\n>\n\nThanks, this first part is what I was looking for.\n\nNot sure why DEBUG would make it hang on master. I don't know much\nabout spl, but is there a way you can get it to just do 'ls mmc 1:1'\ninstead of loading u-boot.img? ls should give me the same information\nabout the partition, without so many repeating entries/offsets.\nAlternately, is it possible to boot w/ old spl image but new\nu-boot.img to debug this once we get into main u-boot image??\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"HxqXKx2l\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw7jh50b3z9s81\n\tfor ;\n\tSun, 17 Sep 2017 22:29:11 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 23F1DC21DDE; Sun, 17 Sep 2017 12:29:08 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 45222C21C62;\n\tSun, 17 Sep 2017 12:28:24 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 78999C21C62; Sun, 17 Sep 2017 12:28:22 +0000 (UTC)","from mail-lf0-f44.google.com (mail-lf0-f44.google.com\n\t[209.85.215.44])\n\tby lists.denx.de (Postfix) with ESMTPS id 8211EC21C39\n\tfor ; Sun, 17 Sep 2017 12:28:18 +0000 (UTC)","by mail-lf0-f44.google.com with SMTP id u21so5709797lfk.12\n\tfor ; Sun, 17 Sep 2017 05:28:18 -0700 (PDT)","by 10.46.41.75 with HTTP; Sun, 17 Sep 2017 05:28:17 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=YZlkkR6kKqgqCLBmg2/c+PA0Kwkl77pV4cqi3CPIhv0=;\n\tb=HxqXKx2lO4iP0ZiRRZYWOVt+eevl1TIkifAgLJR0G9DS87JY5Yq9wKxgNRwyeBxU7M\n\tTTI527c1wVkUZXLfTvbO5RkdrLQIb8VrABZtuYBmGmiXGrbquaz2GTJD0wBZtCW6kJYQ\n\tdbo/D6bidW/QGesenOksH3xb68ob3zw5us76T9fYFjjlPc6DqmkhiHkWn7LusI/ZGEvE\n\tj9kSkWcWyg0QiYd2HCRyoioskreD6FktZVNz2oOiLnydBhHyWYFusbuqRCUIFa1biHhW\n\tQhg8zQOvgy1VRU7qXHz/LTaBOVKMwOKLoB0vx+oX52cy9bAR1gwPQN9UfJl0gzQSSh7S\n\tO3Xw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=YZlkkR6kKqgqCLBmg2/c+PA0Kwkl77pV4cqi3CPIhv0=;\n\tb=Ab5h+5L7XV0zTJzZ15QevpB6wqNzPfAInKUCpifhAsiUy1++q+pluhUBMFE/fqopcy\n\ty+bkCB0NQ7qZOpda0NCdQcm2E2HqfKzW8MzcoZRIrxAE0UxT3XVbpXptAbt8aF+rlEtc\n\tQOai191ZcWHQ39LLeiKZklk7aZqfwkr30zc4IymX2AqCquOzPgW1RTOSCP6986JqE0PU\n\trTKqs9E7zkrBP+0NR3WwmBs6tedU6vMdach7LtC6Tj6g4Z2u1PYxX+25K4ZXMT+V7Rmv\n\tw3U4VJwTYE1HjaqHDgb9Cp4U9BZAavER/B8qQWwdDCSfV/NbJMM3rOtFhdo2tOamRhcQ\n\tyfhw==","X-Gm-Message-State":"AHPjjUhvUdlSOPlTBUB1+gZS9dvj9EUbbPXfCbtr8RWvf0ios/rUEfIW\n\tw6bJbXZaO2+80B7+VRmwfgOz4D3jZxPrFF/utuc=","X-Google-Smtp-Source":"AOwi7QCUQv28d0vN9D9u8wSJGf8VB/xi1Ug42bZwMBdDdEowtIiSRcPFNHkmNUZvUjNI1lY5FM91/syWVLlJI3naPM4=","X-Received":"by 10.46.19.26 with SMTP id 26mr11689351ljt.20.1505651297984;\n\tSun, 17 Sep 2017 05:28:17 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>\n\t\n\t\n\t","From":"Rob Clark ","Date":"Sun, 17 Sep 2017 08:28:17 -0400","Message-ID":"","To":"Adam Ford ","Cc":"Tom Rini , Heinrich Schuchardt , \n\tTien Fong Chee ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769697,"web_url":"http://patchwork.ozlabs.org/comment/1769697/","msgid":"","list_archive_url":null,"date":"2017-09-17T12:30:58","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Sun, Sep 17, 2017 at 8:28 AM, Rob Clark wrote:\n> On Sun, Sep 17, 2017 at 7:08 AM, Adam Ford wrote:\n>> On Sat, Sep 16, 2017 at 3:42 PM, Rob Clark wrote:\n>>> On Sat, Sep 16, 2017 at 4:32 PM, Adam Ford wrote:\n>>>> On Fri, Sep 15, 2017 at 9:32 PM, Tom Rini wrote:\n>>>>>\n>>>>> On Sat, Sep 09, 2017 at 01:15:54PM -0400, Rob Clark wrote:\n>>>>>\n>>>>> > And drop a whole lot of ugly code!\n>>>>> >\n>>>>> > Signed-off-by: Rob Clark \n>>>>> > Reviewed-by: Łukasz Majewski \n>>>>> > Reviewed-by: Simon Glass \n>>>>>\n>>>>> Applied to u-boot/master, thanks!\n>>>>>\n>>>>\n>>>> According to git bisect, this patch seems to break the booting of am3517_evm\n>>>>\n>>>> It just displays:\n>>>>\n>>>> U-Boot SPL 2017.09-00135-g8eafae2 (Sep 16 2017 - 15:23:16)\n>>>> Trying to boot from MMC1\n>>>>\n>>>> Then hangs.\n>>>>\n>>>> It does, however the same patch boots just fine on\n>>>> omap3_logic_defconfig which is an OMAP3630/DM3730 board.\n>>>>\n>>>> da850evm_defconfig (OMAP-L138) is also booting just fine.\n>>>>\n>>>> I'm going to investigate it further to see why just 1/3 boards seems impacted.\n>>>>\n>>>\n>>> Tom reported a similar fail.. although I am failing to reproduce it in\n>>> sandbox w/ a copy of his partition, so maybe it is somehow hw\n>>> specific? If you could, debug logs w/\n>>> https://hastebin.com/raw/fijazebiso applied in before/after case would\n>>> be useful.. maybe I could spot something from that?\n>>>\n>>\n>> Adding the debug to master made no difference. No debug messages appeared.\n>> Interestingly enough, some junk appeard, and the name of U-Boot name\n>> wasn't correctly displayed:\n>>\n>> **Sș017.09-00178-g08cebee-dirty (Sep 17 2017 - 06:01:07)\n>> Trying to boot from MMC1\n>>\n>> (hang)\n>>\n>> Could there a be some memory overflow somewhere?\n>>\n>> Adding the debug to the last working commit, yielded the following:\n>>\n>> U-Boot SPL 2017.09-00134-ge71f88d-dirty (Sep 17 2017 - 06:03:28)\n>> Trying to boot from MMC1\n>> reading u-boot.img\n>> VFAT Support enabled\n>> FAT16, fat_sect: 1, fatlength: 200\n>> Rootdir begins at cluster: 536870910, sector: 401, offset: 32200\n>> Data begins at: 417\n>> Sector size: 512, cluster size: 8\n>> FAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=d\n>> RootMismatch: |mlo||\n>> Rootvfatname: |u-boot.img|\n>> RootName: u-boot.img, start: 0x98, size: 0x83708\n>> Filesize: u bytes\n>> u bytes\n>> gc - clustnum: 152, startsect: 1633\n>> Size: 538376, got: u\n>> reading u-boot.img\n>> VFAT Support enabled\n>> FAT16, fat_sect: 1, fatlength: 200\n>> Rootdir begins at cluster: 536870910, sector: 401, offset: 32200\n>> Data begins at: 417\n>> Sector size: 512, cluster size: 8\n>> FAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=d\n>> RootMismatch: |mlo||\n>> Rootvfatname: |u-boot.img|\n>> RootName: u-boot.img, start: 0x98, size: 0x83708\n>> Filesize: u bytes\n>> u bytes\n>>\n>> I truncated it, because after that, it seems to just be showing\n>> entries and offsets over and over again.\n>>\n>\n> Thanks, this first part is what I was looking for.\n>\n> Not sure why DEBUG would make it hang on master. I don't know much\n> about spl, but is there a way you can get it to just do 'ls mmc 1:1'\n> instead of loading u-boot.img? ls should give me the same information\n> about the partition, without so many repeating entries/offsets.\n> Alternately, is it possible to boot w/ old spl image but new\n> u-boot.img to debug this once we get into main u-boot image??\n\nI suppose another benefit if it is possible to use old spl and new\nu-boot.img is the presumably u-boot.img isn't using TINY_PRINTF so the\ndebug prints about the partition parameters would be more complete..\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"H0ncGl+U\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw7qj49nMz9s81\n\tfor ;\n\tSun, 17 Sep 2017 22:34:25 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 44E27C21D76; Sun, 17 Sep 2017 12:34:24 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 47032C21C62;\n\tSun, 17 Sep 2017 12:32:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0AB73C21D72; Sun, 17 Sep 2017 12:32:09 +0000 (UTC)","from mail-lf0-f65.google.com (mail-lf0-f65.google.com\n\t[209.85.215.65])\n\tby lists.denx.de (Postfix) with ESMTPS id EDA03C21C39\n\tfor ; Sun, 17 Sep 2017 12:30:59 +0000 (UTC)","by mail-lf0-f65.google.com with SMTP id y15so3254526lfd.0\n\tfor ; Sun, 17 Sep 2017 05:30:59 -0700 (PDT)","by 10.46.41.75 with HTTP; Sun, 17 Sep 2017 05:30:58 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=+HS57mb3VYOYNWCdqlX77UkIX5wRF/rFO7P2rAxt8QE=;\n\tb=H0ncGl+UBszhsFQLC32RtXhwtvdknFIhm7AwOjBiJA/JrT5cj8TaSwV2OsxiXXBT6D\n\txtucYE4hGx54AaJil1NRO86hGdcgTkugGN7CZz2t8wTmQAeUmzqsKulr1HRvEOu2WfJ7\n\tDCv4wO0w9KYDo6aJQT1UmE0XzusQalFY61XG/7kBfVbyxU+oL8JqbqpX3an+rODyL8e2\n\tCc7tUH+7EgPBo1BMoOnD0Pw+2WEi3MCOxB4f3HBAO8FXLnoRnE2vSb+1QJF28RQlKPsk\n\tmqXdTanNt6rso964f8gvCEnacA5HQhvN+W/rBMFguu1dXYur5uCfm3v//hmv4SA/lcWZ\n\tTTFQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=+HS57mb3VYOYNWCdqlX77UkIX5wRF/rFO7P2rAxt8QE=;\n\tb=apBtbXdw0NlG8xmnCs6QvGvDgpRZM8mnZgTdN1mYN2pYSwzJ0hIGf7fMmyvE8FP0lb\n\teBI/OjVtayJ4QS/I7FNFyVoOlOrXez6MdptlfahSvvWVvelg/3rx5pMVE9FvTCxomcNe\n\tAO8NQIb7TWHIjpb956lsEIckVHUoQHMSsP9D7m0Ng7rLfrRB581azIVBgd6weVq+v+b5\n\trqia3xSVw/trAgrUUPcz53xZe0isTD08afT8xeG8ZOjULmLOLKzS87p8SMQpa/8BEdQL\n\tip9ldJjsyCJA8kQdi2u4Nv6NaO6/G+sZnkXj/fGS7uJXjc9VhMOK1rz1x8sV7FI440/O\n\tryUg==","X-Gm-Message-State":"AHPjjUimx5KSNksJLG9o1QbiJWmxFrXJ9v/b09JPKOltliQH0b/W4PGt\n\txnoiVdXS22bNAw6PL5VgribYq8a/4wPBlcLMTWM=","X-Google-Smtp-Source":"AOwi7QDiNhtWfIDd1bPY9eDtYpLy771MHr3Vi78kpBw3j1Euh8Ce3yfDOf+fdlQHpY8FjvFP91CkTUOVq3QjEtAl1/w=","X-Received":"by 10.46.33.202 with SMTP id h71mr11745801lji.56.1505651459481; \n\tSun, 17 Sep 2017 05:30:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>\n\t\n\t\n\t\n\t","From":"Rob Clark ","Date":"Sun, 17 Sep 2017 08:30:58 -0400","Message-ID":"","To":"Adam Ford ","Cc":"Tom Rini , Heinrich Schuchardt , \n\tTien Fong Chee ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769701,"web_url":"http://patchwork.ozlabs.org/comment/1769701/","msgid":"","list_archive_url":null,"date":"2017-09-17T12:53:23","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Sun, Sep 17, 2017 at 7:08 AM, Adam Ford wrote:\n>\n> Adding the debug to master made no difference. No debug messages appeared.\n> Interestingly enough, some junk appeard, and the name of U-Boot name\n> wasn't correctly displayed:\n>\n> **Sș017.09-00178-g08cebee-dirty (Sep 17 2017 - 06:01:07)\n> Trying to boot from MMC1\n>\n> (hang)\n>\n\nhmm, one thing I noticed in doc/README.SPL:\n\n\"When building SPL with DEBUG set you may also need to set CONFIG_PANIC_HANG\nas in most cases do_reset is not defined within SPL.\"\n\nnot sure if that would help.\n\nAlso, it has a section about estimating stack usage.. not sure if this\nimplies that stack size is constrained in spl? If so, maybe that is\nrelated. The new directory iterators do move the buffer for current\nblock of dir_entry's to the stack. Reducing\nCONFIG_FS_FAT_MAX_CLUSTSIZE might help.\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"oVueRGgC\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw8Mn1Cs8z9s83\n\tfor ;\n\tSun, 17 Sep 2017 22:58:45 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E0985C21E23; Sun, 17 Sep 2017 12:58:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 84BADC21E09;\n\tSun, 17 Sep 2017 12:54:28 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 43A4CC21E26; Sun, 17 Sep 2017 12:54:25 +0000 (UTC)","from mail-lf0-f45.google.com (mail-lf0-f45.google.com\n\t[209.85.215.45])\n\tby lists.denx.de (Postfix) with ESMTPS id 33FCBC21E00\n\tfor ; Sun, 17 Sep 2017 12:53:24 +0000 (UTC)","by mail-lf0-f45.google.com with SMTP id r17so5793332lff.6\n\tfor ; Sun, 17 Sep 2017 05:53:24 -0700 (PDT)","by 10.46.41.75 with HTTP; Sun, 17 Sep 2017 05:53:23 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=UofWGVci8HUJFqlkOKMNktt5g/lecYVRmeBgExhrPUQ=;\n\tb=oVueRGgCiYVQIt2Nb4tnaQbfwTy3E/YOjvJS+4Xl8kjQE4D4upa8lBy/HmgQ1/qEmd\n\t+4Rv5tuLyo2zIrDh2QpwlmsvhBONCDwec7sEdBfecG94Byvn4wNJxtWG/TNbJ1/9gDXU\n\tUYIbDbJV1eF5Df58mvA65cY53HGmjDyII2KSjREaIwW9iRLCKRvAZMuRvKRgAxhp2b5B\n\tOUkvsH1emqOCQEomrvIDqPtcaHOnPUbsgi/S8/3whY1yfThP0EQhEuWaHISYxVlbq2bm\n\tuThFXMKchQJ+tIE8Kivhx9UjlXHvovNbh8uccChsxuYq9rKWbQzO23vwIn+qBYp4u77H\n\tk98g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=UofWGVci8HUJFqlkOKMNktt5g/lecYVRmeBgExhrPUQ=;\n\tb=pSZ1LD2skeicnP8EjJdJm7DqFCj7Ex6XFLzvMUgUg3/Pw1KDL7FTLwM+ESpGLkOn/r\n\t7BvdnH2+KY55mB0Fzbmr8wjn6HgAZL0Wtb2ElvCblvJOsFkMfRIs+0KG9W0LAtWFlKuB\n\tJgTDLWh/mGayklKWLTSFzCZ3VI6xAwY1r11RfzG1YApN9vw7ZDneHSVSrCoSxGUzTPvV\n\tbrxqO+rKM7NkC5O/x8zrAKCbxTjl0VUWTH9X1oJAM0rKayE8ao64dFpLaFwhQas48M52\n\t1DNag+GH8wsNbuT9a/Fp1ROg23Wr6mC89cqyNkGhQAgX6KtmISP66xI5wZwM31CfYcDA\n\tJbhA==","X-Gm-Message-State":"AHPjjUjahn5wFloTJJ5LHTHoB8YqcQp5JLbnceB3dw05dSs8dwkEw2CV\n\tPkVKF+zGwt0ODj4z883yR/0zQE77z393RRe3Otn/k/bV","X-Google-Smtp-Source":"AOwi7QAz19CmJ3QmOhODgOv19r0aKDlU7tWQQdOouorbv1bqlDG5MT4Sh0E9jMTBpuZ5RKt2q1i7AVhLanokoGekr4o=","X-Received":"by 10.25.23.105 with SMTP id n102mr2378832lfi.252.1505652803695; \n\tSun, 17 Sep 2017 05:53:23 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>\n\t\n\t\n\t","From":"Rob Clark ","Date":"Sun, 17 Sep 2017 08:53:23 -0400","Message-ID":"","To":"Adam Ford ","Cc":"Tom Rini , Heinrich Schuchardt , \n\tTien Fong Chee ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769706,"web_url":"http://patchwork.ozlabs.org/comment/1769706/","msgid":"<20170917132855.GG4560@bill-the-cat>","list_archive_url":null,"date":"2017-09-17T13:28:55","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Sun, Sep 17, 2017 at 08:53:23AM -0400, Rob Clark wrote:\n> On Sun, Sep 17, 2017 at 7:08 AM, Adam Ford wrote:\n> >\n> > Adding the debug to master made no difference. No debug messages appeared.\n> > Interestingly enough, some junk appeard, and the name of U-Boot name\n> > wasn't correctly displayed:\n> >\n> > **Sș017.09-00178-g08cebee-dirty (Sep 17 2017 - 06:01:07)\n> > Trying to boot from MMC1\n> >\n> > (hang)\n> >\n> \n> hmm, one thing I noticed in doc/README.SPL:\n> \n> \"When building SPL with DEBUG set you may also need to set CONFIG_PANIC_HANG\n> as in most cases do_reset is not defined within SPL.\"\n> \n> not sure if that would help.\n> \n> Also, it has a section about estimating stack usage.. not sure if this\n> implies that stack size is constrained in spl? If so, maybe that is\n> related. The new directory iterators do move the buffer for current\n> block of dir_entry's to the stack. Reducing\n> CONFIG_FS_FAT_MAX_CLUSTSIZE might help.\n\nYes, in SPL we don't require stack being in SDRAM and unless SPL_STACK_R\nis set we have a very limited stack available. And that looks to be the\ncommon thread between functional and non-functional platforms. In the\ncase of what Adam and I both have, we could move to SPL_STACK_R easily\nenough. What needs to be done next 'tho would be to see if making\nSPL_FAT_SUPPORT depend on SPL_STACK_R, migrating the various TI\nplatforms (and possibly others) that could butdon't use SPL_STACK_R, and\nseeing if we have platforms that have now lost FAT support.\n\nOr, how hard would it be to make that code not use the stack so much?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"osgt4CbN\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw93f0rlkz9s81\n\tfor ;\n\tSun, 17 Sep 2017 23:29:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid BEF83C21E26; Sun, 17 Sep 2017 13:29:48 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B79D9C21CB3;\n\tSun, 17 Sep 2017 13:29:00 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C5534C21CB3; Sun, 17 Sep 2017 13:28:59 +0000 (UTC)","from mail-yw0-f177.google.com (mail-yw0-f177.google.com\n\t[209.85.161.177])\n\tby lists.denx.de (Postfix) with ESMTPS id 4B7BFC21C62\n\tfor ; Sun, 17 Sep 2017 13:28:59 +0000 (UTC)","by mail-yw0-f177.google.com with SMTP id w22so3712734ywa.13\n\tfor ; Sun, 17 Sep 2017 06:28:59 -0700 (PDT)","from bill-the-cat (cpe-65-184-142-68.ec.res.rr.com.\n\t[65.184.142.68]) by smtp.gmail.com with ESMTPSA id\n\tw142sm2063022ywa.90.2017.09.17.06.28.56\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tSun, 17 Sep 2017 06:28:57 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=q0nQ5rPzLZ+C5AqbqMlMjEIq5LhkOmxtTM58xc5PaXc=;\n\tb=osgt4CbNWN3SUhBTndMSG82pRWWk9X6vAJ6tiNXa49okx9rc3hYtTcg9s2It/my80Q\n\tW6NWgzCJrdlD38sOvNatpGgtXbi8DH48xHNtaHclgxQybOxCmV67UaZATg4iuUZWA7Jf\n\tTmoFQt9/2XLNVa1fmUZ5bNrDv3M18ccR4MBkY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=q0nQ5rPzLZ+C5AqbqMlMjEIq5LhkOmxtTM58xc5PaXc=;\n\tb=RP9CO1P/241ADxAx6C2l6ncRpzVhddO83NL3+SS4Vl9I5pYqvbyh9vfNoIAHMAaXow\n\t6ZKbhy5jacr4SSmpfIPX5n8Hzh639nPeoG9np04uUl153kzCgO6z/bmtbm23xMBYWtw9\n\t4C/oS6GUoK6+ed04TyVCAQ+v6mqmggl4aQ4bZ47e+1FQIsZt8ycZD5mPCwh/L7g9Pnig\n\t2WHoaFR44kFarPHT7oWXtfTe4CutIj7A9Mg/KmLW5y6WwS617MY+rCp/S3FXBXI4eYq+\n\tzw217p0w5VPuOcvXoEd41vakTWqU3eVIhdzobNlTr53a+j2KskyElQ2EZa/cI7KOLNxk\n\tWZug==","X-Gm-Message-State":"AHPjjUhTIaRR22tnE9Fus2dib6WYfA1BxFWMQ9kKk8qKjMP9vOLyd+Mf\n\t72BgMvIF7ztTQJ9l","X-Google-Smtp-Source":"ADKCNb47T+sMj5dvVMGKT05xtBopMbbP4vScgBbv8xQdNAudAW25r9U7T70L2pkrMERQJIucEKRkjQ==","X-Received":"by 10.129.120.6 with SMTP id t6mr25594825ywc.160.1505654937869; \n\tSun, 17 Sep 2017 06:28:57 -0700 (PDT)","Date":"Sun, 17 Sep 2017 09:28:55 -0400","From":"Tom Rini ","To":"Rob Clark ","Message-ID":"<20170917132855.GG4560@bill-the-cat>","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>\n\t\n\t\n\t\n\t","MIME-Version":"1.0","In-Reply-To":"","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"U-Boot Mailing List ,\n\tTien Fong Chee ,\n\tHeinrich Schuchardt ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============2477673921328950475==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769711,"web_url":"http://patchwork.ozlabs.org/comment/1769711/","msgid":"","list_archive_url":null,"date":"2017-09-17T13:42:15","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":67132,"url":"http://patchwork.ozlabs.org/api/people/67132/","name":"Adam Ford","email":"aford173@gmail.com"},"content":"On Sun, Sep 17, 2017 at 7:53 AM, Rob Clark wrote:\n> On Sun, Sep 17, 2017 at 7:08 AM, Adam Ford wrote:\n>>\n>> Adding the debug to master made no difference. No debug messages appeared.\n>> Interestingly enough, some junk appeard, and the name of U-Boot name\n>> wasn't correctly displayed:\n>>\n>> **Sș017.09-00178-g08cebee-dirty (Sep 17 2017 - 06:01:07)\n>> Trying to boot from MMC1\n>>\n>> (hang)\n>>\n>\n\nWith the TINY_PRINTF disabled (except in SPL), the log looks better:\n\nTrying to boot from MMC1\nreading u-boot.img\nVFAT Support enabled\nFAT16, fat_sect: 1, fatlength: 200\nRootdir begins at cluster: 536870910, sector: 401, offset: 32200\nData begins at: 417\nSector size: 512, cluster size: 8\nFAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=16\nRootMismatch: |mlo||\nRootvfatname: |u-boot.img|\nRootName: u-boot.img, start: 0x12, size: 0x83708\nFilesize: 538376 bytes\n64 bytes\ngc - clustnum: 18, startsect: 561\nSize: 538376, got: 64\nreading u-boot.img\nVFAT Support enabled\nFAT16, fat_sect: 1, fatlength: 200\nRootdir begins at cluster: 536870910, sector: 401, offset: 32200\nData begins at: 417\nSector size: 512, cluster size: 8\nFAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=16\nRootMismatch: |mlo||\nRootvfatname: |u-boot.img|\nRootName: u-boot.img, start: 0x12, size: 0x83708\nFilesize: 538376 bytes\n\n\n\n> hmm, one thing I noticed in doc/README.SPL:\n>\n> \"When building SPL with DEBUG set you may also need to set CONFIG_PANIC_HANG\n> as in most cases do_reset is not defined within SPL.\"\n>\n> not sure if that would help.\n>\n\nI did try your experiment with keeping the working SPL and using the\nnewer u-boot.img file and that worked, so I am guessing it's probably\nrelated to tight memory in SPL.\nI looked up the mapping in doc/SPL/README.omap3 and it shows:\n\n0x40200800 - 0x4020BBFF: Area for SPL text, data and rodata\n0x4020E000 - 0x4020FFFC: Area for the SPL stack.\n0x80000000 - 0x8007FFFF: Area for the SPL BSS.\n0x80100000: CONFIG_SYS_TEXT_BASE of U-Boot\n0x80208000 - 0x80307FFF: malloc() pool available to SPL.\n\nFor this board, CONFIG_SYS_SPL_MALLOC_SIZE is set to 0x100000\n\nI don't know if any of this is helpful information to you or not.\n\n> Also, it has a section about estimating stack usage.. not sure if this\n> implies that stack size is constrained in spl? If so, maybe that is\n> related. The new directory iterators do move the buffer for current\n> block of dir_entry's to the stack. Reducing\n> CONFIG_FS_FAT_MAX_CLUSTSIZE might help.\n\nAny recommendations on how small this can go and still operate\nreliably? I don't want to just arbitrarily choose something.\n\n>\n> BR,\n> -R\n\nadam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"iWipZd0M\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw9Wh2NVbz9s83\n\tfor ;\n\tSun, 17 Sep 2017 23:50:40 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid EB76AC21DCE; Sun, 17 Sep 2017 13:50:38 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B6DA5C21E3D;\n\tSun, 17 Sep 2017 13:43:25 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 6E87FC21E3D; Sun, 17 Sep 2017 13:43:24 +0000 (UTC)","from mail-ua0-f194.google.com (mail-ua0-f194.google.com\n\t[209.85.217.194])\n\tby lists.denx.de (Postfix) with ESMTPS id A8003C21CB3\n\tfor ; Sun, 17 Sep 2017 13:42:17 +0000 (UTC)","by mail-ua0-f194.google.com with SMTP id g47so1886488uad.2\n\tfor ; Sun, 17 Sep 2017 06:42:17 -0700 (PDT)","by 10.159.59.213 with HTTP; Sun, 17 Sep 2017 06:42:15 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=GT5iQEXWaNRhEpf5eGo9+taFYf/6gEss6yxDnqedUmg=;\n\tb=iWipZd0M+L33pOfc2tUarAgQEGqG2Q24hhLJubFnudTsndqoNr5fz+WC3i3HM9vQ37\n\t5wHGRagCkJFO557BTJ8IY9peC8lQG3xQWBr9Nma6n0+g3nc+WYkbqpuI9hOjjtfIvSux\n\ttRqIzdD514zuA8SXLe2NxFfVOnNfha9Q87Sd/nG+rHYrGaYDyfd4og8Rbuit7p5TsB9k\n\tdb9nxPyNKgEknge4a2U0gdvVz6BiCriq0C/OAKIeBDrxLTediMktA2RR2TsbHgUWCTee\n\tuexF5VaABMoKF5fx6PIm2sJhumk8+HE1rOgDRwSfMd5LDChXTEr84lY+poh1k3KQJg8G\n\tndMw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=GT5iQEXWaNRhEpf5eGo9+taFYf/6gEss6yxDnqedUmg=;\n\tb=fiy5bCKAqcWw/RmAxZ+K5eJ2jujo7DIhgwbogaVDR5Ii0F/sujJmRcs5jcdJ+SEzfM\n\tJb8QCq7zULF/YKbszmEC71tfRm6BNIF49b7HxQRvhHujHBBVA9wPap2UP7MGYQbJHJN6\n\tvVlNP0bdi8NpYb56lss8+Z470d8otVa/jaRu3rVacjgL/e1+d0H0vlpl5MUi8RlWz9mn\n\tj0HGa9APtXK1NkJvEwAcwzlJbpoCvC+pjLu+oVGAaB+2MhtUyFEOUbCP7/hH9XuJhidq\n\tTg8VSeq6CHlCrQ2Eeov2fSIUOSKAMAXG20rtJtQvX7eEM1kW1M9j68cQuSuLISo+m8ot\n\tUWbA==","X-Gm-Message-State":"AHPjjUgSjxiSpxYGcplnfaPfE6rBQ5Bfcp/Zqsco+InzJ9f3qpwdynRi\n\tNR+qgh+S3H7VGzOIeQZB46dVvabjGaNTyj6vZWw=","X-Google-Smtp-Source":"ADKCNb62uw6QKR2L0rBaQLHGB2IH0lCQqbb9/KjZzSc1zJV6I4LP+YrxGuuv0r9FOp+H4/K92ZsJ8hsvx/XyZ3WmSfI=","X-Received":"by 10.176.20.169 with SMTP id d38mr27063114uae.184.1505655736204;\n\tSun, 17 Sep 2017 06:42:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>\n\t\n\t\n\t\n\t","From":"Adam Ford ","Date":"Sun, 17 Sep 2017 08:42:15 -0500","Message-ID":"","To":"Rob Clark ","Cc":"Tom Rini , Heinrich Schuchardt , \n\tTien Fong Chee ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769713,"web_url":"http://patchwork.ozlabs.org/comment/1769713/","msgid":"","list_archive_url":null,"date":"2017-09-17T13:50:22","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Sun, Sep 17, 2017 at 9:42 AM, Adam Ford wrote:\n> On Sun, Sep 17, 2017 at 7:53 AM, Rob Clark wrote:\n>> On Sun, Sep 17, 2017 at 7:08 AM, Adam Ford wrote:\n>>>\n>>> Adding the debug to master made no difference. No debug messages appeared.\n>>> Interestingly enough, some junk appeard, and the name of U-Boot name\n>>> wasn't correctly displayed:\n>>>\n>>> **Sș017.09-00178-g08cebee-dirty (Sep 17 2017 - 06:01:07)\n>>> Trying to boot from MMC1\n>>>\n>>> (hang)\n>>>\n>>\n>\n> With the TINY_PRINTF disabled (except in SPL), the log looks better:\n>\n> Trying to boot from MMC1\n> reading u-boot.img\n> VFAT Support enabled\n> FAT16, fat_sect: 1, fatlength: 200\n> Rootdir begins at cluster: 536870910, sector: 401, offset: 32200\n> Data begins at: 417\n> Sector size: 512, cluster size: 8\n> FAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=16\n> RootMismatch: |mlo||\n> Rootvfatname: |u-boot.img|\n> RootName: u-boot.img, start: 0x12, size: 0x83708\n> Filesize: 538376 bytes\n> 64 bytes\n> gc - clustnum: 18, startsect: 561\n> Size: 538376, got: 64\n> reading u-boot.img\n> VFAT Support enabled\n> FAT16, fat_sect: 1, fatlength: 200\n> Rootdir begins at cluster: 536870910, sector: 401, offset: 32200\n> Data begins at: 417\n> Sector size: 512, cluster size: 8\n> FAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=16\n> RootMismatch: |mlo||\n> Rootvfatname: |u-boot.img|\n> RootName: u-boot.img, start: 0x12, size: 0x83708\n> Filesize: 538376 bytes\n>\n>\n>\n>> hmm, one thing I noticed in doc/README.SPL:\n>>\n>> \"When building SPL with DEBUG set you may also need to set CONFIG_PANIC_HANG\n>> as in most cases do_reset is not defined within SPL.\"\n>>\n>> not sure if that would help.\n>>\n>\n> I did try your experiment with keeping the working SPL and using the\n> newer u-boot.img file and that worked, so I am guessing it's probably\n> related to tight memory in SPL.\n> I looked up the mapping in doc/SPL/README.omap3 and it shows:\n>\n> 0x40200800 - 0x4020BBFF: Area for SPL text, data and rodata\n> 0x4020E000 - 0x4020FFFC: Area for the SPL stack.\n> 0x80000000 - 0x8007FFFF: Area for the SPL BSS.\n> 0x80100000: CONFIG_SYS_TEXT_BASE of U-Boot\n> 0x80208000 - 0x80307FFF: malloc() pool available to SPL.\n>\n> For this board, CONFIG_SYS_SPL_MALLOC_SIZE is set to 0x100000\n>\n> I don't know if any of this is helpful information to you or not.\n\nI think we narrowed it down to stack usage.. Tom tested the \"please\ntest\" patch I just sent and it works for him.\n\nIf reducing SPL_MALLOC_SIZE increases available stack size, that might\nalso work. But I think for next release we can just go with my patch\nthat moves itrblock off the stack.\n\n>> Also, it has a section about estimating stack usage.. not sure if this\n>> implies that stack size is constrained in spl? If so, maybe that is\n>> related. The new directory iterators do move the buffer for current\n>> block of dir_entry's to the stack. Reducing\n>> CONFIG_FS_FAT_MAX_CLUSTSIZE might help.\n>\n> Any recommendations on how small this can go and still operate\n> reliably? I don't want to just arbitrarily choose something.\n\n\nSector size: 512, cluster size: 8\nFAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=16\n\nSo I think 512 * 8 = 4096 would work for your filesys.. what I'm not\nentirely sure is what range of sector sizes and cluster sizes are\npossible. 64k seems *way* too much. Maybe in the end I should switch\nto malloc() so we can allocate just what is needed.\n\nI'll give it some thought for my next batch of fs/fat work.. but\nsuggestions welcome.\n\nBR,\n-R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"skV0hixe\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw9m13Rdxz9s83\n\tfor ;\n\tMon, 18 Sep 2017 00:01:21 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 43524C21E64; Sun, 17 Sep 2017 14:01:20 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 7E4DCC21E3D;\n\tSun, 17 Sep 2017 13:51:30 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5F86AC21E45; Sun, 17 Sep 2017 13:51:29 +0000 (UTC)","from mail-lf0-f46.google.com (mail-lf0-f46.google.com\n\t[209.85.215.46])\n\tby lists.denx.de (Postfix) with ESMTPS id 14EBCC21E40\n\tfor ; Sun, 17 Sep 2017 13:50:24 +0000 (UTC)","by mail-lf0-f46.google.com with SMTP id c80so5825551lfh.0\n\tfor ; Sun, 17 Sep 2017 06:50:24 -0700 (PDT)","by 10.46.41.75 with HTTP; Sun, 17 Sep 2017 06:50:22 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=7H6IxCdRWz8c3x7sswMevywUDaJJGWlsYKzMrj2l9oQ=;\n\tb=skV0hixeZpA4dwDIbqSNFUzSQpukXsEAyYQ/CE/TYgeyXkrEvz0NnS3p1pD3aQY99A\n\tmJ3NPnqv13Yn13sFRqVWmVjJNQToGpKHAkn0S0OJNEwFS4fRitWer5UwUymnocGjRTNW\n\tRQrwO/JVVfqOYtt9suGZEiRwNvU2F1QH/BVnnpzJWGIuI/v5QikrEY1thrSxco4PYkNQ\n\tArycAWyn3mcqmqmeKok5Di5LysMqMGSU15ki1vHnXnILjvoUJTakPmUbl83EzIGzE1/A\n\tNO7qXe3BOxxwwXy/dSaTiO0C7wM09va/Zo6abUx41nZw52PgnXgeY1iN6h3crFDsurBu\n\t8R/g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=7H6IxCdRWz8c3x7sswMevywUDaJJGWlsYKzMrj2l9oQ=;\n\tb=cqUPrB7od19c8+dQJewCmNoecfDcRv4OAzNimxfjGua42gC5h3KlhfIMvUWNx3EDwh\n\twkKzXZaru3Xkn3BM+9rvWewzvXn16OemV+Gq5pw5RFlw9Ig2Xha7/0mlvwEA9flFjkpa\n\t5AD59jzYxxaGvOgZTJVa6b8PDInXA2k3FVmBky92yvMhLF2bUtXVlpC8jxf805hXKOn7\n\tqZuxvkn/P5GUGen7K6K5atzo1fl4qOCrp/LlFM7KGb6FIVTyrtgAI2GnIYx1Et1hxCK+\n\tvWU9RHfW/tyrdz4oMJehHhrjpVDs89ipJttvp9bYtruWqglkJ9XvM+je+i1lKJXt8L1m\n\tzZSw==","X-Gm-Message-State":"AHPjjUhj9hQFUJapoSPIao++P8SmC6OJGv3twdrLadrb542QPdP9QYim\n\t8AeuvZe0NtnTI8r8a/+cx5UXh4PTj/UDuAInG/0=","X-Google-Smtp-Source":"AOwi7QCz/dvCM49Ik1W7nOMVFaSPwkHpWq2wzu3a4UZGg9NeZrCHqQ+4+paGeOUoI/vefE0pQjSdwdEi7qmZM0UqnCE=","X-Received":"by 10.25.43.80 with SMTP id r77mr2475960lfr.130.1505656223457;\n\tSun, 17 Sep 2017 06:50:23 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>\n\t\n\t\n\t\n\t\n\t","From":"Rob Clark ","Date":"Sun, 17 Sep 2017 09:50:22 -0400","Message-ID":"","To":"Adam Ford ","Cc":"Tom Rini , Heinrich Schuchardt , \n\tTien Fong Chee ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769715,"web_url":"http://patchwork.ozlabs.org/comment/1769715/","msgid":"","list_archive_url":null,"date":"2017-09-17T13:52:02","subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","submitter":{"id":67132,"url":"http://patchwork.ozlabs.org/api/people/67132/","name":"Adam Ford","email":"aford173@gmail.com"},"content":"On Sun, Sep 17, 2017 at 8:50 AM, Rob Clark wrote:\n> On Sun, Sep 17, 2017 at 9:42 AM, Adam Ford wrote:\n>> On Sun, Sep 17, 2017 at 7:53 AM, Rob Clark wrote:\n>>> On Sun, Sep 17, 2017 at 7:08 AM, Adam Ford wrote:\n>>>>\n>>>> Adding the debug to master made no difference. No debug messages appeared.\n>>>> Interestingly enough, some junk appeard, and the name of U-Boot name\n>>>> wasn't correctly displayed:\n>>>>\n>>>> **Sș017.09-00178-g08cebee-dirty (Sep 17 2017 - 06:01:07)\n>>>> Trying to boot from MMC1\n>>>>\n>>>> (hang)\n>>>>\n>>>\n>>\n>> With the TINY_PRINTF disabled (except in SPL), the log looks better:\n>>\n>> Trying to boot from MMC1\n>> reading u-boot.img\n>> VFAT Support enabled\n>> FAT16, fat_sect: 1, fatlength: 200\n>> Rootdir begins at cluster: 536870910, sector: 401, offset: 32200\n>> Data begins at: 417\n>> Sector size: 512, cluster size: 8\n>> FAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=16\n>> RootMismatch: |mlo||\n>> Rootvfatname: |u-boot.img|\n>> RootName: u-boot.img, start: 0x12, size: 0x83708\n>> Filesize: 538376 bytes\n>> 64 bytes\n>> gc - clustnum: 18, startsect: 561\n>> Size: 538376, got: 64\n>> reading u-boot.img\n>> VFAT Support enabled\n>> FAT16, fat_sect: 1, fatlength: 200\n>> Rootdir begins at cluster: 536870910, sector: 401, offset: 32200\n>> Data begins at: 417\n>> Sector size: 512, cluster size: 8\n>> FAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=16\n>> RootMismatch: |mlo||\n>> Rootvfatname: |u-boot.img|\n>> RootName: u-boot.img, start: 0x12, size: 0x83708\n>> Filesize: 538376 bytes\n>>\n>>\n>>\n>>> hmm, one thing I noticed in doc/README.SPL:\n>>>\n>>> \"When building SPL with DEBUG set you may also need to set CONFIG_PANIC_HANG\n>>> as in most cases do_reset is not defined within SPL.\"\n>>>\n>>> not sure if that would help.\n>>>\n>>\n>> I did try your experiment with keeping the working SPL and using the\n>> newer u-boot.img file and that worked, so I am guessing it's probably\n>> related to tight memory in SPL.\n>> I looked up the mapping in doc/SPL/README.omap3 and it shows:\n>>\n>> 0x40200800 - 0x4020BBFF: Area for SPL text, data and rodata\n>> 0x4020E000 - 0x4020FFFC: Area for the SPL stack.\n>> 0x80000000 - 0x8007FFFF: Area for the SPL BSS.\n>> 0x80100000: CONFIG_SYS_TEXT_BASE of U-Boot\n>> 0x80208000 - 0x80307FFF: malloc() pool available to SPL.\n>>\n>> For this board, CONFIG_SYS_SPL_MALLOC_SIZE is set to 0x100000\n>>\n>> I don't know if any of this is helpful information to you or not.\n>\n> I think we narrowed it down to stack usage.. Tom tested the \"please\n> test\" patch I just sent and it works for him.\n>\n> If reducing SPL_MALLOC_SIZE increases available stack size, that might\n> also work. But I think for next release we can just go with my patch\n> that moves itrblock off the stack.\n>\n>>> Also, it has a section about estimating stack usage.. not sure if this\n>>> implies that stack size is constrained in spl? If so, maybe that is\n>>> related. The new directory iterators do move the buffer for current\n>>> block of dir_entry's to the stack. Reducing\n>>> CONFIG_FS_FAT_MAX_CLUSTSIZE might help.\n>>\n>> Any recommendations on how small this can go and still operate\n>> reliably? I don't want to just arbitrarily choose something.\n>\n>\n> Sector size: 512, cluster size: 8\n> FAT read(sect=401, cnt:2), clust_size=8, DIRENTSPERBLOCK=16\n>\n> So I think 512 * 8 = 4096 would work for your filesys.. what I'm not\n> entirely sure is what range of sector sizes and cluster sizes are\n> possible. 64k seems *way* too much. Maybe in the end I should switch\n> to malloc() so we can allocate just what is needed.\n>\n> I'll give it some thought for my next batch of fs/fat work.. but\n> suggestions welcome.\n>\n\nWhen I wrote that, I didn't see either Tom's comments or you updated\npatch yet, but you can go ahead and add my tested-by because I'm\nsatisfied with that.\n\nadam\n> BR,\n> -R","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"M9VZlRaO\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwB0r2jC5z9s83\n\tfor ;\n\tMon, 18 Sep 2017 00:12:27 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid D568DC21E52; Sun, 17 Sep 2017 14:12:24 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A84D0C21CB3;\n\tSun, 17 Sep 2017 13:53:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid C9D04C21CB3; Sun, 17 Sep 2017 13:53:09 +0000 (UTC)","from mail-ua0-f193.google.com (mail-ua0-f193.google.com\n\t[209.85.217.193])\n\tby lists.denx.de (Postfix) with ESMTPS id C9325C21C62\n\tfor ; Sun, 17 Sep 2017 13:52:03 +0000 (UTC)","by mail-ua0-f193.google.com with SMTP id k23so1882295uaf.3\n\tfor ; Sun, 17 Sep 2017 06:52:03 -0700 (PDT)","by 10.159.59.213 with HTTP; Sun, 17 Sep 2017 06:52:02 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=jpMkbKLhno/yGSbrK42CDVdbtNnenGpdCQkVBWtqZgQ=;\n\tb=M9VZlRaOfEz3I33CWw5fcdLI43cPCx6/845XlDCUutT6jYICck+AS+xWIWL1xd3o1H\n\t4YzotBiH8fhRU2mvcrvgne3W4lnNswcqsi1ExWMJ9zowQzFID61G+FrpmYq+U4DthLGG\n\tYVHGe7UVkZylEsBB6lYD+nXaNvbp5UZ+vB2QCza15cl9Kykd2+b46J7s0e9IvQArskb+\n\tf0h6JGYb/qOSAW1mA29s/2o98sIWaXXW0LNc8rScEUKTi4vlrwpjA+7mEoC/0YPrwqtp\n\txYbW+yrH92oShcIG95+OdyPygpZ+JyB5Ab/oKjcthVnNF2YhqM7rViJPYniTLGHKr6Le\n\t3vuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=jpMkbKLhno/yGSbrK42CDVdbtNnenGpdCQkVBWtqZgQ=;\n\tb=RiDoHHcJgBZiY9eWNvi4gZ4CBPcubLjMPBEjTDgmV+N8zhUYWTDLcNZuhTOZdHPvna\n\tWaKhSDgfB/q5+rapA9JERF1h9EQBEd9WZ4jMsgBitb77ANfJekSpbUxd5TGBp3gjWpRB\n\tVNw4Q3Jh1WN7WNwlbwZr1YvHnfdviniJ0MwW99eQgMyKScUpjk32+tnowCZShhpNYE7Y\n\t+wltFKZeeqdmUgQ5UFs+wSAKHbPet0DOePOOVz90gLEb46VOe56w9NxtaFsgGZr59uKG\n\tGtv4+wD1HBZtoL7AlvIWz+S5RU/5OQYz0RZ0yXTsepnjEuJqCd9fhO9yLrvirlIy5qEH\n\tV3nQ==","X-Gm-Message-State":"AHPjjUikn+6Mpeue4h5HtJSEZUrkHbNQBt1SzJU9QAwe9eS3zpezcaxA\n\t+mJZM14xlgIEzY1eNoKFiEYBpYAlJT5nqaomVpE=","X-Google-Smtp-Source":"AOwi7QDjFIlhv5YUO1+sQT7ldWH7tggrdP92KJ2wiFJXeG6BZnSoVJYnjqnBTXQ1ysc1CZz9MjNkVfoFItS2FGdp7Ok=","X-Received":"by 10.176.22.109 with SMTP id l42mr27939877uae.196.1505656322631;\n\tSun, 17 Sep 2017 06:52:02 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170909171606.20029-4-robdclark@gmail.com>\n\t<20170916023206.GQ4560@bill-the-cat>\n\t\n\t\n\t\n\t\n\t\n\t","From":"Adam Ford ","Date":"Sun, 17 Sep 2017 08:52:02 -0500","Message-ID":"","To":"Rob Clark ","Cc":"Tom Rini , Heinrich Schuchardt , \n\tTien Fong Chee ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t3/9] fat/fs: convert to directory iterators","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]