[{"id":1766987,"web_url":"http://patchwork.ozlabs.org/comment/1766987/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:29:11","subject":"Re: [U-Boot] [PATCH v3 4/9] fs: add fs_readdir()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 9 September 2017 at 11:15, Rob Clark wrote:\n> Needed to support efi file protocol. The fallback.efi loader wants\n> to be able to read the contents of the /EFI directory to find an OS\n> to boot.\n>\n> Modelled after POSIX opendir()/readdir()/closedir(). Unlike the other\n> fs APIs, this is stateful (ie. state is held in the FS_DIR \"directory\n> stream\"), to avoid re-traversing of the directory structure at each\n> step. The directory stream must be released with closedir() when it\n> is no longer needed.\n>\n> Signed-off-by: Rob Clark \n> Reviewed-by: Łukasz Majewski \n> ---\n> disk/part.c | 31 ++++++++++-------\n> fs/fs.c | 104 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> include/fs.h | 67 +++++++++++++++++++++++++++++++++++++\n> include/part.h | 9 +++++\n> 4 files changed, 199 insertions(+), 12 deletions(-)\n\nI do think it is useful to see a change log on each patch.\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"IGXrpqgC\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"CWjYIfuq\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4YC4Nm5z9s7M\n\tfor ;\n\tTue, 12 Sep 2017 22:56:15 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 495F6C21FD0; Tue, 12 Sep 2017 12:45:33 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1597CC220A8;\n\tTue, 12 Sep 2017 12:45:30 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 16AD1C220FB; Tue, 12 Sep 2017 12:29:39 +0000 (UTC)","from mail-qk0-f178.google.com (mail-qk0-f178.google.com\n\t[209.85.220.178])\n\tby lists.denx.de (Postfix) with ESMTPS id D4572C22001\n\tfor ; Tue, 12 Sep 2017 12:29:33 +0000 (UTC)","by mail-qk0-f178.google.com with SMTP id a128so24570153qkc.5\n\tfor ; Tue, 12 Sep 2017 05:29:33 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:29:11 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=h1K8rJL23/R/JaWAoN55qKNHbDAvky5INOiJzbkvv0k=;\n\tb=IGXrpqgC9lyts2CxGdExRC8IRFilA+dPznlpW9YnHbBcCC+L+DBSXPq2dKucz6zGmV\n\tGfeM9TlRrRPlfnSjlXOxS2uaVQ5gAWxCIJH+HSc4FXv5JN/HlUrU7gYOojO7Kw1yC2LF\n\tVsJT4/wrmyyvT4O1soG+Rrd386fNgbX+8FQul/s88ODaRFB4kSSi/f681oRmFt4RPuIU\n\tSuZl7JI+AgvYCpmRoIMJoagS4d2a0LpuSZaRLYH3CS5ztHE7uqXcD5LS+CMcBFvfhjnU\n\tmubbYcI0cHUQaPWeJQJHQyXABcgvtq1XhLJ7Tm9Ou6pHqBZLm6i7DK9VB2vp/CuAlg71\n\tcbpQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=h1K8rJL23/R/JaWAoN55qKNHbDAvky5INOiJzbkvv0k=;\n\tb=CWjYIfuqKwOvgTIyNmkWBjjj6+g5Cj0EcohSPKM41KIsHjsGG8itW/sJQmjFWuY5R4\n\tA2JIn5r+jNMpcrM1R5aSvjC/yR8xH2HLdSrA9Drtq0tdBuVtfqBjX6Li6sAOdv6/d7v2\n\tef19vHjTm6a6swnsrttVmSIBEy8PJWTT+5EmI="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=h1K8rJL23/R/JaWAoN55qKNHbDAvky5INOiJzbkvv0k=;\n\tb=MdHJ1AMbQcrzdYsmoqbI3PUKlukhy3I+HTWYUyTkf1FM8cxSZoRuH+BbXPL7pLlCW9\n\tWCgD5c8+TMO5xr4qTVS7P6+lky1pPxDUwKCCLfz9ItE0AcxpRydBcLxJ4D89VSH3n5+C\n\t5jBswia/mmdS+QEGfR7HQKM/ljKAHmRUWeGVQ6YYxk5y4yIeWg4EQer6o14rCPzh4Y9J\n\tPbwhYdGDcs/VqWOI3pfr4DfhTWle8jNrlweiyKIfNjmm/Ht/m0dop/AxrPj9o4nRr8Jd\n\tAw5UuAcn1cpTfk8MsqcEPJ7yhZm9AByzZELekDvOaGuu0YiDQFl9QS0DIx24cgGOimDk\n\tD3Mg==","X-Gm-Message-State":"AHPjjUhnUSzu41MKwKGRK80RUZ4s0YNk1apqmOtx1m1qqfcaxya1eutN\n\tF6IYrZxGk5gDb8rfotZuzwCQ4rcws9i6R0HfusOVCg==","X-Google-Smtp-Source":"AOwi7QC9ns0s/LOoqYulFSxfNAWUI5/jhCWvm3cBdp9RNgK8rmvJ1wJYGNm9HW7MLStt75Cpzg90ia2PI8gWFBGNPBI=","X-Received":"by 10.233.216.135 with SMTP id\n\tu129mr1007909qkf.302.1505219372427; \n\tTue, 12 Sep 2017 05:29:32 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170909171606.20029-5-robdclark@gmail.com>","References":"<20170909171606.20029-1-robdclark@gmail.com>\n\t<20170909171606.20029-5-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:29:11 -0600","X-Google-Sender-Auth":"DCV-zr4Mb0iW0Wj2XHLbV9VpGNI","Message-ID":"","To":"Rob Clark ","Cc":"Petr Kulhavy , Heinrich Schuchardt , \n\tZhikang Zhang ,\n\tAlison Chaiken ,\n\tU-Boot Mailing List ,\n\tSteve Rae ,\n\tMaxime Ripard ","Subject":"Re: [U-Boot] [PATCH v3 4/9] fs: add fs_readdir()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769542,"web_url":"http://patchwork.ozlabs.org/comment/1769542/","msgid":"<20170916023211.GR4560@bill-the-cat>","list_archive_url":null,"date":"2017-09-16T02:32:11","subject":"Re: [U-Boot] [U-Boot,v3,4/9] fs: add fs_readdir()","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Sat, Sep 09, 2017 at 01:15:55PM -0400, Rob Clark wrote:\n\n> Needed to support efi file protocol. The fallback.efi loader wants\n> to be able to read the contents of the /EFI directory to find an OS\n> to boot.\n> \n> Modelled after POSIX opendir()/readdir()/closedir(). Unlike the other\n> fs APIs, this is stateful (ie. state is held in the FS_DIR \"directory\n> stream\"), to avoid re-traversing of the directory structure at each\n> step. The directory stream must be released with closedir() when it\n> is no longer needed.\n> \n> Signed-off-by: Rob Clark \n> Reviewed-by: Łukasz Majewski \n> Reviewed-by: Simon Glass \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"oY1PBrMg\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvGcz4shXz9s3T\n\tfor ;\n\tSat, 16 Sep 2017 12:37:07 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 6A523C21FB7; Sat, 16 Sep 2017 02:33:23 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9B942C21F5C;\n\tSat, 16 Sep 2017 02:32:48 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid BCF63C21C2B; Sat, 16 Sep 2017 02:32:19 +0000 (UTC)","from mail-yw0-f171.google.com (mail-yw0-f171.google.com\n\t[209.85.161.171])\n\tby lists.denx.de (Postfix) with ESMTPS id 0717EC21DDD\n\tfor ; Sat, 16 Sep 2017 02:32:15 +0000 (UTC)","by mail-yw0-f171.google.com with SMTP id u11so1827962ywh.7\n\tfor ; Fri, 15 Sep 2017 19:32:14 -0700 (PDT)","from bill-the-cat (cpe-65-184-142-68.ec.res.rr.com.\n\t[65.184.142.68]) by smtp.gmail.com with ESMTPSA id\n\tk129sm870946ywd.76.2017.09.15.19.32.12\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tFri, 15 Sep 2017 19:32:13 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=fEzRc3rdYmIHkGaoD1gWwyKmyvoYpMG0Q5m12U3mK0E=;\n\tb=oY1PBrMgWVF2ke3THrJV9piKNawCua8FZgYz6Q2gxF+N9n5od+EmpmbduFZ2Jx660p\n\tVX4zDDmPVSDvCv6vnR6s1VfavHV+QVzedYV3wivXnHSS0nRm9+U8MEsTzMMS9xCv5nY+\n\tqMrD7kTPGCs3C7UdxwA0Q/+9uJbJCTTICa99Y=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=fEzRc3rdYmIHkGaoD1gWwyKmyvoYpMG0Q5m12U3mK0E=;\n\tb=eUifRb8+rDQtQLjqmsFqtR57dxBXv7Hc/yj2gyS16g1gkWKUAFhgE173A4cUlYSaOT\n\tdKX7/y9g8FjMrAQeVZFel5xeKmjlFvSvQSp3IkRuzNjHs88ZaRLgCIa2s17685T20fqE\n\tr+npDrXUHcWpOZPwhdWkSYMSegPPm5ZlpCrKZJlb0zUf8SHt8C00zOoP9bNNaubrLLMo\n\tPI9RX/q3zHGid2YkvfsQlF53tVFqunmHDSlrVBN4VXRx7/RHRgSutydJBuvmPfkCWGbF\n\trulsrY/s7E3qww/fMVo27mOIxS+VJDcktt1V9LwwreyMdft9/6y4Zze5RbJVWAi3IuL+\n\tKLsQ==","X-Gm-Message-State":"AHPjjUgz7zgVJzNha4gseAzkijm9ADd/R4QSyQiPEcBSuE0Fgd8sAvD9\n\tpi33wZmf97LjwT3N","X-Google-Smtp-Source":"AOwi7QDmJPkBt7QnkGaPFOVZrSowgPcizwqIyqC9ZeDf9ofyDA38uAQBa+nS4wTxccBqTTVO87vIoQ==","X-Received":"by 10.37.58.3 with SMTP id h3mr22500605yba.61.1505529133871;\n\tFri, 15 Sep 2017 19:32:13 -0700 (PDT)","Date":"Fri, 15 Sep 2017 22:32:11 -0400","From":"Tom Rini ","To":"Rob Clark ","Message-ID":"<20170916023211.GR4560@bill-the-cat>","References":"<20170909171606.20029-5-robdclark@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<20170909171606.20029-5-robdclark@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"Petr Kulhavy , Heinrich Schuchardt , \n\tZhikang Zhang ,\n\tAlison Chaiken ,\n\tU-Boot Mailing List ,\n\tSteve Rae ,\n\tMaxime Ripard ","Subject":"Re: [U-Boot] [U-Boot,v3,4/9] fs: add fs_readdir()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1451169911090822725==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]