[{"id":1766978,"web_url":"http://patchwork.ozlabs.org/comment/1766978/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:29:15","subject":"Re: [U-Boot] [PATCH v3 5/9] fs/fat: implement\n\topendir/readdir/closedir","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 9 September 2017 at 11:15, Rob Clark wrote:\n> Implement the readdir interface using the directory iterators.\n>\n> Signed-off-by: Rob Clark \n> Reviewed-by: Łukasz Majewski \n> ---\n> fs/fat/fat.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 61 insertions(+)\n\nReviewed-by: Simon Glass \n\nBut I still feel unconvinced that you need to add the typedef.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"Zk5VwJA0\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"f9j5n9V1\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4Xn49Vxz9t8B\n\tfor ;\n\tTue, 12 Sep 2017 22:55:52 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E7897C22081; Tue, 12 Sep 2017 12:33:11 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B90ADC21FBD;\n\tTue, 12 Sep 2017 12:31:44 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 875F4C21FFE; Tue, 12 Sep 2017 12:29:42 +0000 (UTC)","from mail-qk0-f178.google.com (mail-qk0-f178.google.com\n\t[209.85.220.178])\n\tby lists.denx.de (Postfix) with ESMTPS id 9826CC21FA0\n\tfor ; Tue, 12 Sep 2017 12:29:38 +0000 (UTC)","by mail-qk0-f178.google.com with SMTP id a128so24570597qkc.5\n\tfor ; Tue, 12 Sep 2017 05:29:38 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:29:15 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=3Rg/m8f2D+OFcg+uFQDD2nivuUkpqavmbNTtxZurDNg=;\n\tb=Zk5VwJA04uAySE5EFCnqw6oPrLJOTP8DQxi0z+or+OifKMCQcHXPDaso8bM5X+AqO7\n\tPbRa1QsGhp1qEI2ThX3FdhCWARdr0Zm50onkRSQy3kOikLRd/uEsuiqRx3MvalLK4Ndu\n\tul1fA6HEawOvRI54EHt9OQGR/I3CK7YggQh6wfIKzhDfIsj3s4B5DU2ElVcq3a9CMyPR\n\tU+P+9W0531GSOtUTW2XJWlvgQOyOYM7Fwzzn2iLKP8eIUPVXguYt5Lq9zoo0Qty0BT+7\n\tQ0pscCfm9Smp1oaGWURC/0TOw4rw2NiXwTnRjHGmarAoaWwR98HhXayvQbegH2WhLoJJ\n\tVikA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-transfer-encoding;\n\tbh=3Rg/m8f2D+OFcg+uFQDD2nivuUkpqavmbNTtxZurDNg=;\n\tb=f9j5n9V1gwo0lvorv1ZNFA8R6PeHo6+8bO+w2R9XN+cA3YLOZRw27/0K5xo6TaTwq9\n\tvNyC7DChnDgM+ONxTk/hbnAIRPSCwElz6NrILdUWJuZ65l+zV8vBr8uWHMm98hBMPHzt\n\t+Nju4cred9ienuAN3Dze9GJLNkUZut0WkKeKg="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=3Rg/m8f2D+OFcg+uFQDD2nivuUkpqavmbNTtxZurDNg=;\n\tb=XMPpHZBsk0hqUx7wE5bsf1gaN890QSS9xW0X7t0JDfLhCtxtbEOTaxAdFRSO4ekDTU\n\thc6vzlvlKmaCTjg2y1DY9ltZIY7TCEsqlQGpK1dj120oItCSohbWYyMx4LwGAsnDQHrS\n\tsxWSJZmOEF51WLKi0+JMGK4x2ZhYejkWOlUXaApGilpxT0rkZNC1L+blLZQ7MkLWHNr2\n\tNJ370Xj5nY6AYFAx9mAeoqUxCsvmEYUc0biLto2NC8F/ZjtTkkGltnU05vN1021vhe1i\n\tD4u8DjCY5hpvwt+xF/RHey41NwMNEH1aujC5EXZY8beycreZOOOAOZ4Ue9hvhSoSS9Rm\n\tcKLA==","X-Gm-Message-State":"AHPjjUgSQb+8tIvyU1lDC2wc/gqr1JiiFbP9cpzvSSz5MI2aCEP79Gx3\n\tCMP4eZfHQDaQKKAiUUvAHbG1Aq7Q9niHJftStBl7RQ==","X-Google-Smtp-Source":"AOwi7QBrBxt13CWMgwqzHLlFD1dj1lWVV6ktRAG2A2tamZRshqD9PIrn2pAk2A88u4bfbmQM/DMv3vIQp4CFjIBGZaE=","X-Received":"by 10.55.146.198 with SMTP id\n\tu189mr18759429qkd.317.1505219376650; \n\tTue, 12 Sep 2017 05:29:36 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170909171606.20029-6-robdclark@gmail.com>","References":"<20170909171606.20029-1-robdclark@gmail.com>\n\t<20170909171606.20029-6-robdclark@gmail.com>","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:29:15 -0600","X-Google-Sender-Auth":"FsIhW-9wTcMUzmrXzY40mDpymxk","Message-ID":"","To":"Rob Clark ","Cc":"Heinrich Schuchardt ,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v3 5/9] fs/fat: implement\n\topendir/readdir/closedir","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769548,"web_url":"http://patchwork.ozlabs.org/comment/1769548/","msgid":"<20170916023215.GS4560@bill-the-cat>","list_archive_url":null,"date":"2017-09-16T02:32:15","subject":"Re: [U-Boot] [U-Boot, v3,\n\t5/9] fs/fat: implement opendir/readdir/closedir","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Sat, Sep 09, 2017 at 01:15:56PM -0400, Rob Clark wrote:\n\n> Implement the readdir interface using the directory iterators.\n> \n> Signed-off-by: Rob Clark \n> Reviewed-by: Łukasz Majewski \n> Reviewed-by: Simon Glass \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"jdP5t9Lc\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvGhG1f4kz9s3T\n\tfor ;\n\tSat, 16 Sep 2017 12:39:58 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid ECABDC2200E; Sat, 16 Sep 2017 02:34:12 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 81949C21EE0;\n\tSat, 16 Sep 2017 02:33:32 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1C1EEC21EF4; Sat, 16 Sep 2017 02:32:23 +0000 (UTC)","from mail-yw0-f180.google.com (mail-yw0-f180.google.com\n\t[209.85.161.180])\n\tby lists.denx.de (Postfix) with ESMTPS id 423A6C21F63\n\tfor ; Sat, 16 Sep 2017 02:32:19 +0000 (UTC)","by mail-yw0-f180.google.com with SMTP id o143so2424718ywd.12\n\tfor ; Fri, 15 Sep 2017 19:32:19 -0700 (PDT)","from bill-the-cat (cpe-65-184-142-68.ec.res.rr.com.\n\t[65.184.142.68]) by smtp.gmail.com with ESMTPSA id\n\tj7sm870887ywf.75.2017.09.15.19.32.17\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tFri, 15 Sep 2017 19:32:17 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=KTTFoDs/clAQGpK+8Ylkmn7CkXwRgrbAc1X6FA1ByEU=;\n\tb=jdP5t9LcDM0u4wEQQC85ObtAZBJoo+j8F+VQL99aZgZn8SclNuT7ka9ZwGWh9peob0\n\tjMZ9Ir7buYmgafHlYAQM9y4+kjepMVzZQH8wkRYmhhup/4lfYY99HSipo1qMV1M+CJIN\n\t3vynOrcB584tBUZnAwbZ3DcrYMvU5p+szPm1s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=KTTFoDs/clAQGpK+8Ylkmn7CkXwRgrbAc1X6FA1ByEU=;\n\tb=drobGc+qPFjLlKxodr92KVeJvf1GPW5dEk98b7/ZIwQvIPQyfUdxpjz4b1SPaASyfo\n\t7+4fUAUtI8AseuhriTfN+FBmgcXQJrF82AFWoKm8zmAwl7KhondOvJc9f2lwNjoipT3d\n\tb0DaAlYwm1TX8KVsRLHkMcI1w7BVeM4KJ+o2w+R01A+IG2mogqnMrZqFmtDOq0Km2OSe\n\takBYbWExtIUc0fUvO0xFIZ813TGGrsRdYEgaPSGrJlivkS9oCg1IAj53ta4C6EWGt+2k\n\tTYc9uQXfrRgNCi5hFLBdvjy4091fwQJeK8KlorLsO9+Fl7jjTjCtCdmFUA/4VIlDjVee\n\t7XLg==","X-Gm-Message-State":"AHPjjUgaTq55hDPlkizx1+YsUboZqwU0Q3tbvzUqm9OP6EqSBegU0Rhj\n\tEFETnfSiwbyknzh5uuhHhA==","X-Google-Smtp-Source":"ADKCNb7c/dla9zDj13NEmDx/1lvRNBkjXOFFHePbLjHuHS1JgeNKVQ7XuMnO7CaGo57klHOInpDNpg==","X-Received":"by 10.37.220.14 with SMTP id y14mr18786592ybe.121.1505529138145; \n\tFri, 15 Sep 2017 19:32:18 -0700 (PDT)","Date":"Fri, 15 Sep 2017 22:32:15 -0400","From":"Tom Rini ","To":"Rob Clark ","Message-ID":"<20170916023215.GS4560@bill-the-cat>","References":"<20170909171606.20029-6-robdclark@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<20170909171606.20029-6-robdclark@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"U-Boot Mailing List ,\n\tHeinrich Schuchardt ","Subject":"Re: [U-Boot] [U-Boot, v3,\n\t5/9] fs/fat: implement opendir/readdir/closedir","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============4478604846676478937==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]