[{"id":1766029,"web_url":"http://patchwork.ozlabs.org/comment/1766029/","msgid":"","list_archive_url":null,"date":"2017-09-11T01:57:09","subject":"Re: [U-Boot] [PATCH v2 1/5] kbuild: Enable -fshort-wchar","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"2017-09-09 19:47 GMT+09:00 Rob Clark :\n> EFI_LOADER really wants UTF-16 strings (ie. %ls and L\"string\" are 16bit\n> chars instead of 32bit chars). But rather than enabling -fshort-wchar\n> conditionally if EFI_LOADER is enabled, it was deemed preferrable to\n> globally switch.\n>\n> Signed-off-by: Rob Clark \n> ---\n> Makefile | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/Makefile b/Makefile\n> index 5bb3b09115..d635de12ab 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -360,6 +360,7 @@ KBUILD_CPPFLAGS := -D__KERNEL__ -D__UBOOT__\n> KBUILD_CFLAGS := -Wall -Wstrict-prototypes \\\n> -Wno-format-security \\\n> -fno-builtin -ffreestanding\n> +KBUILD_CFLAGS += -fshort-wchar\n> KBUILD_AFLAGS := -D__ASSEMBLY__\n>\n> # Read UBOOTRELEASE from include/config/uboot.release (if it exists)\n> --\n\n\nRecently, Linux also switched to the global -fshort-wchar\nand I think it makes more sense than giving it conditionally.\n\n\nAcked-by: Masahiro Yamada ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"RK56QQZc\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrB0M3n2Jz9s7g\n\tfor ;\n\tMon, 11 Sep 2017 11:58:11 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 288A3C21DD7; Mon, 11 Sep 2017 01:58:06 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 5DA25C21C4C;\n\tMon, 11 Sep 2017 01:58:04 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid EC7EFC21C4C; Mon, 11 Sep 2017 01:58:02 +0000 (UTC)","from conssluserg-04.nifty.com (conssluserg-04.nifty.com\n\t[210.131.2.83]) by lists.denx.de (Postfix) with ESMTPS id A2B7CC21C41\n\tfor ; Mon, 11 Sep 2017 01:58:01 +0000 (UTC)","from mail-yw0-f180.google.com (mail-yw0-f180.google.com\n\t[209.85.161.180]) (authenticated)\n\tby conssluserg-04.nifty.com with ESMTP id v8B1voMg004229\n\tfor ; Mon, 11 Sep 2017 10:57:51 +0900","by mail-yw0-f180.google.com with SMTP id s62so18758085ywg.0\n\tfor ; Sun, 10 Sep 2017 18:57:51 -0700 (PDT)","by 10.37.164.225 with HTTP; Sun, 10 Sep 2017 18:57:09 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com v8B1voMg004229","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1505095071;\n\tbh=9jb3Ft4wFzxJMCKBnZUptg3FbXhp7oB4d0KI//wcRYM=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=RK56QQZcNMKdiIU7e21lErKvBDS/vLIyPpjQV2/cbKYBX04fgWxIXeDIUsSHO5a8w\n\tI+aFbGK+BzC2tR6ENvAhalwUkM6DryEhVz2V69CboT+JFx3mCosFvB2Ke99476c3ZA\n\tCtT4J+5FSRTG0iRCppJbKRdDJJ4yBWJNh7JqWpeb9wDlf+jgD8vhNcsvOkm1Spus7D\n\tdCCQrqDMneLD1nlqPaK8myU+dftV61mhtll1pM/I9rwEFQkqCGqZ+NlY0vAVPS+vLM\n\tFkBw8MtbiJP3JzKfaS08DKAuoqKOsCO466oUwz5zylnLOGtoK65I+UoNz+6S24IjeU\n\t+kVuirvTyJRXQ==","X-Nifty-SrcIP":"[209.85.161.180]","X-Gm-Message-State":"AHPjjUjtJY5aTcqvO7DwTOyeCxsOPZwiuMFp28mw4UijWPByL0g2xLkN\n\tfKoKNrXlz6l7vdbewiKu1nk25DELzw==","X-Google-Smtp-Source":"ADKCNb7NRpGFdqCXrob/O8bEZLaozowZ8kdqfQtNb7r/bO9BV1FDctTPuAoQgnsE5SWLO5pM7G8Msd9wIeRCouSkvqE=","X-Received":"by 10.37.80.213 with SMTP id e204mr8261868ybb.215.1505095070372; \n\tSun, 10 Sep 2017 18:57:50 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170909104746.5948-2-robdclark@gmail.com>","References":"<20170909104746.5948-1-robdclark@gmail.com>\n\t<20170909104746.5948-2-robdclark@gmail.com>","From":"Masahiro Yamada ","Date":"Mon, 11 Sep 2017 10:57:09 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Rob Clark ","Cc":"U-Boot Mailing List ,\n\tAndre Przywara , \"Cooper Jr.,\n\tFranklin\" , Heinrich Schuchardt ","Subject":"Re: [U-Boot] [PATCH v2 1/5] kbuild: Enable -fshort-wchar","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767473,"web_url":"http://patchwork.ozlabs.org/comment/1767473/","msgid":"<20170913022830.GH4474@bill-the-cat>","list_archive_url":null,"date":"2017-09-13T02:28:30","subject":"Re: [U-Boot] [U-Boot,v2,1/5] kbuild: Enable -fshort-wchar","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Sat, Sep 09, 2017 at 06:47:39AM -0400, Rob Clark wrote:\n\n> EFI_LOADER really wants UTF-16 strings (ie. %ls and L\"string\" are 16bit\n> chars instead of 32bit chars). But rather than enabling -fshort-wchar\n> conditionally if EFI_LOADER is enabled, it was deemed preferrable to\n> globally switch.\n> \n> Signed-off-by: Rob Clark \n> Acked-by: Masahiro Yamada \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"Uuoud9a5\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsQh74NvZz9sPt\n\tfor ;\n\tWed, 13 Sep 2017 12:33:27 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3D035C2236F; Wed, 13 Sep 2017 02:30:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A1D11C22337;\n\tWed, 13 Sep 2017 02:29:41 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D6579C22360; Wed, 13 Sep 2017 02:28:37 +0000 (UTC)","from mail-yw0-f181.google.com (mail-yw0-f181.google.com\n\t[209.85.161.181])\n\tby lists.denx.de (Postfix) with ESMTPS id 4CDFFC22369\n\tfor ; Wed, 13 Sep 2017 02:28:33 +0000 (UTC)","by mail-yw0-f181.google.com with SMTP id r85so32103924ywg.1\n\tfor ; Tue, 12 Sep 2017 19:28:33 -0700 (PDT)","from bill-the-cat ([2606:a000:140b:dc:202f:e2cf:a300:56c])\n\tby smtp.gmail.com with ESMTPSA id\n\to64sm4381644ywe.15.2017.09.12.19.28.31\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tTue, 12 Sep 2017 19:28:31 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=L/3SuXhuN7CoZVV6r+1tnokFtdbvd0k3OwSFN5sj518=;\n\tb=Uuoud9a5aaER3tMR5lIDwQoRMcUgrjBIitiQnky68fYF/TgP1UKofGBEKjf4JuT1Yn\n\t6za0BcSbn3HGbt0AkeO4SOdIceVe1XYqkXBxmG8Rg5xkfDI8i1YNX+aZjV6NdaXujgga\n\tV7dkyfLpxG2PG338KzWRGwaknustUKmmDO3zk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=L/3SuXhuN7CoZVV6r+1tnokFtdbvd0k3OwSFN5sj518=;\n\tb=sUzuBQipuruGuP01YpDMze5q+33Cy5Jx1X7MSngcJecHgFh8R6YzfesmrfkARrY10/\n\tivv5yh6e83mqdPf4xV8Pr7Lb+EvCOGiA0cpAP0d7CiDLUEPtdSCna5A5ML3ESfe+lzoO\n\tzUjVuguLT7jv8DX2vMHbd5H1jU5qxeT3GBmByCC9k+sPWOM36IXGnxETP6pJk6aWwxsR\n\tqTiUqna3479VPP//A9umjqi5d4aXTEGl/es0YV45CoJ17BEhj5em+G/6jO5izUNcsvUw\n\tdwiSlrZmAF7bxAu7z9rK69rDFhaokJYMt6I1myPL8/d7nkhXDsAk1zTPLKteoJRliTtL\n\tVg7g==","X-Gm-Message-State":"AHPjjUiys+waRu3mhGSkVwi9iWGTzcYhvRfMrDMoYyG9NtGUq/nbVxtr\n\t4Wp6FVh1xBURV34p","X-Google-Smtp-Source":"ADKCNb4dzutS9bIJfU2MN1Q+77o0jF013tlcsg9HYJ30OLb4pVpUbGiW1lfKXfrjVZdL/seFtEaN3g==","X-Received":"by 10.129.131.129 with SMTP id\n\tt123mr15033835ywf.139.1505269712273; \n\tTue, 12 Sep 2017 19:28:32 -0700 (PDT)","Date":"Tue, 12 Sep 2017 22:28:30 -0400","From":"Tom Rini ","To":"Rob Clark ","Message-ID":"<20170913022830.GH4474@bill-the-cat>","References":"<20170909104746.5948-2-robdclark@gmail.com>","MIME-Version":"1.0","In-Reply-To":"<20170909104746.5948-2-robdclark@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"U-Boot Mailing List ,\n\tAndre Przywara , \"Cooper Jr.,\n\tFranklin\" , Heinrich Schuchardt ","Subject":"Re: [U-Boot] [U-Boot,v2,1/5] kbuild: Enable -fshort-wchar","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============8406554004371198669==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]