[{"id":1783230,"web_url":"http://patchwork.ozlabs.org/comment/1783230/","msgid":"<20171009203333.GC67463@gmail.com>","list_archive_url":null,"date":"2017-10-09T20:33:33","subject":"Re: [PATCH v3] fscrypt: add a documentation file for\n\tfilesystem-level encryption","submitter":{"id":65202,"url":"http://patchwork.ozlabs.org/api/people/65202/","name":"Eric Biggers","email":"ebiggers3@gmail.com"},"content":"On Fri, Sep 08, 2017 at 05:15:12PM -0700, Eric Biggers wrote:\n> From: Eric Biggers <ebiggers@google.com>\n> \n> Perhaps long overdue, add a documentation file for filesystem-level\n> encryption, a.k.a. fscrypt or fs/crypto/, to the Documentation\n> directory.  The new file is based loosely on the latest version of the\n> \"EXT4 Encryption Design Document (public version)\" Google Doc, but with\n> many improvements made, including:\n> \n> - Reflect the reality that it is not specific to ext4 anymore.\n> - More thoroughly document the design and user-visible API/behavior.\n> - Replace outdated information, such as the outdated explanation of how\n>   encrypted filenames are hashed for indexed directories and how\n>   encrypted filenames are presented to userspace without the key.\n>   (This was changed just before release.)\n> \n> For now the focus is on the design and user-visible API/behavior, not on\n> how to add encryption support to a filesystem --- since the internal API\n> is still pretty messy and any standalone documentation for it would\n> become outdated as things get refactored over time.\n> \n> Reviewed-by: Michael Halcrow <mhalcrow@google.com>\n\nTed, are you interested in taking this through the fscrypt tree for v4.15?\n\nEric","headers":{"Return-Path":"<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"JN5jg1js\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tnr+hYtP\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y9sRH5WDnz9t5Q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 10 Oct 2017 07:34:19 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1ekZ-00025P-VZ; Mon, 09 Oct 2017 20:34:08 +0000","from mail-pf0-x232.google.com ([2607:f8b0:400e:c00::232])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e1ekR-0008Tt-BH\n\tfor linux-mtd@lists.infradead.org; Mon, 09 Oct 2017 20:34:06 +0000","by mail-pf0-x232.google.com with SMTP id 17so6564801pfn.12\n\tfor <linux-mtd@lists.infradead.org>;\n\tMon, 09 Oct 2017 13:33:35 -0700 (PDT)","from gmail.com ([2620:15c:17:3:8806:6b61:e969:44a1])\n\tby smtp.gmail.com with ESMTPSA id\n\tu8sm15934865pgp.17.2017.10.09.13.33.34\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tMon, 09 Oct 2017 13:33:34 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=nPFFo6I+T7/k92q2xZfJwmXV83O59mQucA4yqZS5ekY=;\n\tb=JN5jg1js7QA9Z/\n\tkNAbxFVdH64g3jAJdSCwB3kNq/RU+B0vgcLu036jqs5kDxPwnHrmMsS0PTtjfTZbKYd3R1KFPpHhF\n\tvXcMHbfrntEVPdPzdv/GshSPVDlcosGoFHBOn+INhjLsoYZcgvRRhIKCil2/efj3TPf4k5DFAspfZ\n\tRPHLn9Msaw2CgI/kK3APg1OtS+DduuewNzKvRYwVcVTGZ00O2ly55qLcJQwVPoWVTFaN6vG8OSjjF\n\tjwEzJI/M+qPTfhqSdUUr34CCcpfTByteObTxCj/Cs9k7T1D8SZHplvfDwvdfGtkmSXBYCfi1okuUv\n\tPIq3qxwdh7D0fwbk43FA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=7rBzss3HZn/EgBX724YOxPb/XA+oot1zDH/XvuFS88M=;\n\tb=tnr+hYtPhPXrICr5KXXkmER6mJT/OxSpH2osJQsaZqSBYZd6v3brJY3dbC0D5wDSB/\n\t7Fq8Xs77QW/MJswbR0QZq+0X4TQuyW+b0GU2DFfE8RnqXKjyzHgPQx0ceTKQcuLV5dAi\n\ttALMqa/Dwtx2Wpn/kgdrvO4hSpVGon3Yug0UyI9XAauUyg73mwX6Y/9AZEleWHGN/5qg\n\t+MefSl8wUYz1f2r+DZQjizfB5zAC/HeUCevwZvJEHNOrKlyOXItIHzebFml/4itc8JCK\n\t/i7c9aPgmUo0Ue2JxCOVq4B24lb/QI3Ug17CV3yjZU950PbZDGJ4YBpv1HNtnKWa5WFZ\n\t68aA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=7rBzss3HZn/EgBX724YOxPb/XA+oot1zDH/XvuFS88M=;\n\tb=p0mmK4pWWUgYbkBRj0vJ27XLhzXB0FA7VXJ2T7F7JZLN1R9agxS1XAVipNjX2tSM2Z\n\tOMR1Hy1SOoT8ZUUvQwHKeej1U9G0wMEPuvKebGnSOFvVYvtmzj50ZBC3JPuZ6rhjkFN2\n\tTU5dpe0rEMFLaVgPM53RfDqvHDBOy6Bguv36Jp+bpo9MAHt9EbbtxzqcEmxkuCgQtBRG\n\tmrnstQ1QfBs2r5PlcGFzhpHsGt3kd/jx6PymwiEHBJ1HWgocSb/qKZVXRngs8xDwZbh/\n\t0ZfyQ7imKZHm6ctnSNAaeLXBtmQ3He2nwij89Mtm7BKYIxMiIF+Aqd5nsSB3VWQyQZcD\n\tWJJg==","X-Gm-Message-State":"AMCzsaVQxuw3gpQ36cbh4Qx+mOhemFrjp1ffXVjRiqSJ3GLCjWYcaj+T\n\tchjeUsilp3CLh8kGD/VOyjc=","X-Google-Smtp-Source":"AOwi7QDFH9UXdekJKqTVEvjX8CGcNpCetfOmxmqF9DVPKMvU/Hkq7r1jjeB56g68QpACoLE83brrrw==","X-Received":"by 10.101.74.4 with SMTP id s4mr10021870pgq.259.1507581215203;\n\tMon, 09 Oct 2017 13:33:35 -0700 (PDT)","Date":"Mon, 9 Oct 2017 13:33:33 -0700","From":"Eric Biggers <ebiggers3@gmail.com>","To":"Theodore Ts'o <tytso@mit.edu>, linux-fscrypt@vger.kernel.org","Subject":"Re: [PATCH v3] fscrypt: add a documentation file for\n\tfilesystem-level encryption","Message-ID":"<20171009203333.GC67463@gmail.com>","References":"<20170909001512.72431-1-ebiggers3@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170909001512.72431-1-ebiggers3@gmail.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171009_133404_890480_52CD14D3 ","X-CRM114-Status":"GOOD (  13.84  )","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.8 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:232 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (ebiggers3[at]gmail.com)\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (ebiggers3[at]gmail.com)\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-mtd/>","List-Post":"<mailto:linux-mtd@lists.infradead.org>","List-Help":"<mailto:linux-mtd-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>","Cc":"Eric Biggers <ebiggers@google.com>, linux-doc@vger.kernel.org,\n\tlinux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org,\n\tlinux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1795429,"web_url":"http://patchwork.ozlabs.org/comment/1795429/","msgid":"<20171029102406.hc6zzeepgbntwesx@thunk.org>","list_archive_url":null,"date":"2017-10-29T10:24:06","subject":"Re: [PATCH v3] fscrypt: add a documentation file for\n\tfilesystem-level encryption","submitter":{"id":350,"url":"http://patchwork.ozlabs.org/api/people/350/","name":"Theodore Tso","email":"tytso@mit.edu"},"content":"On Fri, Sep 08, 2017 at 05:15:12PM -0700, Eric Biggers wrote:\n> From: Eric Biggers <ebiggers@google.com>\n> \n> Perhaps long overdue, add a documentation file for filesystem-level\n> encryption, a.k.a. fscrypt or fs/crypto/, to the Documentation\n> directory.  The new file is based loosely on the latest version of the\n> \"EXT4 Encryption Design Document (public version)\" Google Doc, but with\n> many improvements made, including:\n> \n> - Reflect the reality that it is not specific to ext4 anymore.\n> - More thoroughly document the design and user-visible API/behavior.\n> - Replace outdated information, such as the outdated explanation of how\n>   encrypted filenames are hashed for indexed directories and how\n>   encrypted filenames are presented to userspace without the key.\n>   (This was changed just before release.)\n> \n> For now the focus is on the design and user-visible API/behavior, not on\n> how to add encryption support to a filesystem --- since the internal API\n> is still pretty messy and any standalone documentation for it would\n> become outdated as things get refactored over time.\n> \n> Reviewed-by: Michael Halcrow <mhalcrow@google.com>\n> Signed-off-by: Eric Biggers <ebiggers@google.com>\n\nApplied, thanks.\n\n\t\t\t\t\t- Ted","headers":{"Return-Path":"<linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ONXfZzGd\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=thunk.org header.i=@thunk.org\n\theader.b=\"neR+GWqg\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yPtzK4pFrz9t1t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 29 Oct 2017 21:25:17 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e8kmI-0008HU-Gi; Sun, 29 Oct 2017 10:25:14 +0000","from imap.thunk.org ([2600:3c02::f03c:91ff:fe96:be03])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e8kld-0008Bm-Nf\n\tfor linux-mtd@lists.infradead.org; Sun, 29 Oct 2017 10:24:35 +0000","from root (helo=callcc.thunk.org)\n\tby imap.thunk.org with local-esmtp (Exim 4.89)\n\t(envelope-from <tytso@thunk.org>)\n\tid 1e8klE-0006jA-Vm; Sun, 29 Oct 2017 10:24:09 +0000","by callcc.thunk.org (Postfix, from userid 15806)\n\tid F41B0C02021; Sun, 29 Oct 2017 06:24:06 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=NH+3q0aGSXJTtmcdQtrMl3XsDYw13/f6LF0cfmqamLI=;\n\tb=ONXfZzGdrpOhhu\n\tawKqgtrHgsDsmYB5m3cT2GokqSemZPnInvQJH2L05TGSygQcBTWh2Ij+i7/7GnojybslMUC2F3/DG\n\tStrreB8lfreBudsfCIrnQfr6c1p3Uq+Z2uEJOtA1G3Zos//HLK/XOGfh268FnX+REkOUhY7/L0dln\n\t7kwv47bLflfnpdXxBxDl5sfFLyu+1w2cro0iKLRjVyOEi9Zp79AyzjoP3WYxqu0EvoEMOIbZ9EuFA\n\tukcaOhn08f+yGkA9t4WMkMt02Th10/KC0RCp3zYgcQVip01qNBUH4btt/E7x3ngrH6KEVxLtG0zO/\n\tvg7KH+7BP8xq2LifdV/Q==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org;\n\ts=ef5046eb;\n\th=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:\n\tSubject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=FhLgn33IGdeRDd4U162+XVQbY4FWlGsvoxL04sIfYVE=;\n\tb=neR+GWqgcc+TOezpvL4anhFTXE\n\tuXoCBJD3P1QFU0qEPfLQuGuKWyO8ssduP+qS8G11ysWkgzuJEwjQByCDQytP8FDINwXn2jXq5t8X8\n\tfrlWNMj+kdvIT2PrVaX8QNlJn1jmGbWv/vbqSx+VroZQMsE7lUnZoe+CRq7rIHr/ucos=;"],"Date":"Sun, 29 Oct 2017 06:24:06 -0400","From":"Theodore Ts'o <tytso@mit.edu>","To":"Eric Biggers <ebiggers3@gmail.com>","Subject":"Re: [PATCH v3] fscrypt: add a documentation file for\n\tfilesystem-level encryption","Message-ID":"<20171029102406.hc6zzeepgbntwesx@thunk.org>","References":"<20170909001512.72431-1-ebiggers3@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170909001512.72431-1-ebiggers3@gmail.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","X-SA-Exim-Connect-IP":"<locally generated>","X-SA-Exim-Mail-From":"tytso@thunk.org","X-SA-Exim-Scanned":"No (on imap.thunk.org); SAEximRunCond expanded to false","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171029_032433_838879_707C3BAF ","X-CRM114-Status":"GOOD (  12.55  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-mtd/>","List-Post":"<mailto:linux-mtd@lists.infradead.org>","List-Help":"<mailto:linux-mtd-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-mtd>,\n\t<mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>","Cc":"linux-doc@vger.kernel.org, Eric Biggers <ebiggers@google.com>,\n\tlinux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org,\n\tlinux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,\n\tlinux-ext4@vger.kernel.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" <linux-mtd-bounces@lists.infradead.org>","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]