[{"id":1765821,"web_url":"http://patchwork.ozlabs.org/comment/1765821/","msgid":"","list_archive_url":null,"date":"2017-09-09T16:24:31","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":23500,"url":"http://patchwork.ozlabs.org/api/people/23500/","name":"Roopa Prabhu","email":"roopa@cumulusnetworks.com"},"content":"On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:\n> Signed-off-by: Roman Mashak \n> ---\n> bridge/link.c | 16 +++++++++++++---\n> 1 file changed, 13 insertions(+), 3 deletions(-)\n>\n> diff --git a/bridge/link.c b/bridge/link.c\n> index 60200f1..9e4206f 100644\n> --- a/bridge/link.c\n> +++ b/bridge/link.c\n> @@ -461,9 +461,19 @@ static int brlink_show(int argc, char **argv)\n> }\n> }\n>\n> - if (rtnl_wilddump_request(&rth, PF_BRIDGE, RTM_GETLINK) < 0) {\n> - perror(\"Cannon send dump request\");\n> - exit(1);\n> + if (show_details) {\n> + if (rtnl_wilddump_req_filter(&rth, PF_BRIDGE, RTM_GETLINK,\n> + (compress_vlans ?\n> + RTEXT_FILTER_BRVLAN_COMPRESSED :\n> + RTEXT_FILTER_BRVLAN)) < 0) {\n> + perror(\"Cannon send dump request\");\n> + exit(1);\n> + }\n\nvlan information is already available with `bridge vlan show`. any\nspecific reason why you want it in\nthe link dump output ?\n\nThe problem is this might just make the link dump larger and also add\ntoo much clutter into the regular link dump output. iproute2 detailed\ndump is already a bit hard to interpret. And without compression by\ndefault, vlan info can just take over the link dump output. It will be\nhard to look for other link attributes after that :). We deploy with\nthousands of vlans and without compression even bridge vlan default\noutput is already hard to interpret.\n\nCan you please paste a sample default detailed output with your patch\nwith a few hundred vlans ?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"eejPMqEg\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqKK358FQz9t16\n\tfor ;\n\tSun, 10 Sep 2017 02:24:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1757615AbdIIQYd (ORCPT );\n\tSat, 9 Sep 2017 12:24:33 -0400","from mail-oi0-f49.google.com ([209.85.218.49]:34070 \"EHLO\n\tmail-oi0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1757555AbdIIQYc (ORCPT\n\t); Sat, 9 Sep 2017 12:24:32 -0400","by mail-oi0-f49.google.com with SMTP id l74so24187348oih.1\n\tfor ; Sat, 09 Sep 2017 09:24:32 -0700 (PDT)","by 10.157.15.221 with HTTP; Sat, 9 Sep 2017 09:24:31 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=jgwEIOEpLLPRRlmqF6qCc3p5aHRZsqFZeEW2vF1A2/Q=;\n\tb=eejPMqEgOHhsiwYXIYtExGRHNcDnhgm5+I12CPJPDSvjB2/WfgpzxeT/+f0//HKNir\n\tg2va7VGGwnNxBSKX/dtPViCSXL7C7KSg13BkwzVnn77dY90eVwDygwYnNuY3dhzPByFw\n\taDy/xYypzW8gHhK6UU/orvw0oXGhMxRGraFh8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=jgwEIOEpLLPRRlmqF6qCc3p5aHRZsqFZeEW2vF1A2/Q=;\n\tb=ujYVdaGcdYisOVNrGZJooaQSp0gdsbukYdpUH20qvuUj/LMi2xkO/HlhcR6CxMEN1K\n\tc/A3NmyRmibmhg+exLJgmXmbv5rxaSRa6d2e39vSZ9OJXXc3UAB0bBONABS9QMjPahw+\n\tQdnudE0R+ThcKd/CVjW+vnYiaorXaR56yTLw4zBnSDanhvLu08eXv2Fy6uPTiuKrZj4k\n\to3WrQ7LGd6cjF4B5iDKUdPyHzeZoXa42c+n28OKwZMyhg57/+ZWg4XmvENeF/LJWhehF\n\trfFDNOgRzaxKvZWrhrnzUf2JMkSmkEErOiVVG2QSFC1EMDWiabdD+c7K7W3Hp/uz52zy\n\tg25g==","X-Gm-Message-State":"AHPjjUhVKo2M5Zws9/+g7jw7FmDTFCb76dd1pBZxxCdzW6eBPmlndEAK\n\teLcWcxz2aiWbqUfFi8U7yrKmw9fw3qe4","X-Google-Smtp-Source":"AOwi7QAcMGDBhXETVInYwmZ0SLasnHS9DiOr4xg30tj/SASA0xMaycC5HEMT30J3y+8UBUGRfa/8SXzuHnv1FQjpKE4=","X-Received":"by 10.202.73.65 with SMTP id w62mr6836695oia.159.1504974271849; \n\tSat, 09 Sep 2017 09:24:31 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504907543-14394-4-git-send-email-mrv@mojatatu.com>","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>","From":"Roopa Prabhu ","Date":"Sat, 9 Sep 2017 09:24:31 -0700","Message-ID":"","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","To":"Roman Mashak ","Cc":"\"stephen@networkplumber.org\" ,\n\t\"netdev@vger.kernel.org\" ,\n\tJamal Hadi Salim ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765829,"web_url":"http://patchwork.ozlabs.org/comment/1765829/","msgid":"<5706e1ba-6b85-4f32-a858-b5d87b17eb51@mojatatu.com>","list_archive_url":null,"date":"2017-09-09T17:23:19","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":9380,"url":"http://patchwork.ozlabs.org/api/people/9380/","name":"Jamal Hadi Salim","email":"jhs@mojatatu.com"},"content":"On 17-09-09 12:24 PM, Roopa Prabhu wrote:\n> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:\n>> Signed-off-by: Roman Mashak \n>> ---\n>> bridge/link.c | 16 +++++++++++++---\n>> 1 file changed, 13 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/bridge/link.c b/bridge/link.c\n>> index 60200f1..9e4206f 100644\n>> --- a/bridge/link.c\n>> +++ b/bridge/link.c\n>> @@ -461,9 +461,19 @@ static int brlink_show(int argc, char **argv)\n>> }\n>> }\n>>\n>> - if (rtnl_wilddump_request(&rth, PF_BRIDGE, RTM_GETLINK) < 0) {\n>> - perror(\"Cannon send dump request\");\n>> - exit(1);\n>> + if (show_details) {\n>> + if (rtnl_wilddump_req_filter(&rth, PF_BRIDGE, RTM_GETLINK,\n>> + (compress_vlans ?\n>> + RTEXT_FILTER_BRVLAN_COMPRESSED :\n>> + RTEXT_FILTER_BRVLAN)) < 0) {\n>> + perror(\"Cannon send dump request\");\n>> + exit(1);\n>> + }\n> \n> vlan information is already available with `bridge vlan show`. any\n> specific reason why you want it in\n> the link dump output ?\n> \n >\n> The problem is this might just make the link dump larger and also add\n> too much clutter into the regular link dump output. iproute2 detailed\n> dump is already a bit hard to interpret. And without compression by\n> default, vlan info can just take over the link dump output. It will be\n> hard to look for other link attributes after that :). We deploy with\n> thousands of vlans and without compression even bridge vlan default\n> output is already hard to interpret.\n>\n\nAgree we should be turning on this stuff by default. i.e default stays\ncompressed; otherwise it a huge dump.\n\nHaving said that there is a lot of mess with this stuff.\nThe bridge link events _already send this IFLA_AF_SPCE info_\nso not much choice there but to print it.\nAt minimal we need that part because unfortunately there is no\nvlanfilter event in existence which will send us summaries of just\nvlans added to a port i.e both use XXXLINK.\nIn general, the XXXLINK interface with these master devices (bridge,\nbond etc) continues to get messy. Recently started seeing events with\ndevices claiming to be of KIND_slave etc on the bridge and bond devices;\nyet at the same time my wireless card events are also showing up on the\nbridge link even though it is not enslaved there..\n\ncheers,\njamal\n\n> Can you please paste a sample default detailed output with your patch\n> with a few hundred vlans ?\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"AJAjEo7o\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqLd73yZGz9t16\n\tfor ;\n\tSun, 10 Sep 2017 03:23:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751897AbdIIRX3 (ORCPT );\n\tSat, 9 Sep 2017 13:23:29 -0400","from mail-it0-f65.google.com ([209.85.214.65]:35325 \"EHLO\n\tmail-it0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750939AbdIIRX2 (ORCPT\n\t); Sat, 9 Sep 2017 13:23:28 -0400","by mail-it0-f65.google.com with SMTP id b76so2399879itb.2\n\tfor ; Sat, 09 Sep 2017 10:23:27 -0700 (PDT)","from [192.168.1.120] (135-23-93-187.cpe.pppoe.ca. [135.23.93.187])\n\tby smtp.googlemail.com with ESMTPSA id\n\th84sm2347545iod.72.2017.09.09.10.23.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 09 Sep 2017 10:23:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=l5Mc7H4iamy5d4H7XtVFlEq3ALvi0g3hqgJ6KKJFQMY=;\n\tb=AJAjEo7oxhFbJ9e6ygaVQvb71Sos/OL9a85jDC7i6prOZtXBp/9A9sEQH63EIBA9hp\n\t+hmkMwxbIS6uiQz28AakBh2p9kN9FC9EWMSpDHf2egLhUuj5JxCBQtxsEsBD9sjwFaAc\n\tuqgRFsie13SduQCBmVgP7dsq9/zihcpQb723SDPZKTLxOHYOdBox2CLAiPfXq8pXwPcE\n\tyesLvFV/klrnx5HN/SbDdUZ5DzoZsbiNxuzqAK3xJntS5jApqlCgtfc3kH5KWO2trUCg\n\tGitLHaPBJru3bs3jlsJLEnzRY3qtmGOlq7voBnCN/Oug4LPBHqlxZhihPXFbx8beH3EX\n\t3UMg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=l5Mc7H4iamy5d4H7XtVFlEq3ALvi0g3hqgJ6KKJFQMY=;\n\tb=aUNSY8MdgR4Z/axat46IXjkWhtAWNscQ9J81iH2Q7kIsblShaeJ0eThKsj10nx2cUe\n\tksalk+YcPfMnXH5UPHft2ennCpSYGPvTWsG0A4HOROdbVQ/O+LbRVtsSHIbUOcFxtQUg\n\tkfXUh6xZ8Vb1LCEAa0nT+lnGgh28wzNCjO+vdRuUAZtMzqkCAwLk2WjhvFOhNXM1N3uf\n\t+nsEOQFEabiPOAkhl9Xjgm/fwufUKfMm7a3sB+ochSoL/TcGp80Vd87Yr4VPkAu885GZ\n\tXqwCpCg/zS/1iBKGIvoY90VZj33YIEhU8QzsnCiZsyzi9Cc1g1N/2SaSDxRNx5H/jtdg\n\ta3QQ==","X-Gm-Message-State":"AHPjjUjQ88OTeohLTWF27r1CGH3n4aC9xhD6LEv1trQ6wbW0bLeM3wmN\n\t/38CbCr11Y3pHpVe8pUDzGsc6zYP","X-Google-Smtp-Source":"ADKCNb45V6Id2eYtrdCE6pUI9Qy/47GIBdcJ+GWimD9zMWLn1nXx5AY0OcgxO6MI578KpYxmwWwB6A==","X-Received":"by 10.36.238.133 with SMTP id b127mr5810572iti.109.1504977807227;\n\tSat, 09 Sep 2017 10:23:27 -0700 (PDT)","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","To":"Roopa Prabhu , Roman Mashak ","Cc":"\"stephen@networkplumber.org\" ,\n\t\"netdev@vger.kernel.org\" ","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>\n\t","From":"Jamal Hadi Salim ","Message-ID":"<5706e1ba-6b85-4f32-a858-b5d87b17eb51@mojatatu.com>","Date":"Sat, 9 Sep 2017 13:23:19 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765832,"web_url":"http://patchwork.ozlabs.org/comment/1765832/","msgid":"<1bde7c3e-1571-a2a2-3308-b42906fbb3d2@cumulusnetworks.com>","list_archive_url":null,"date":"2017-09-09T18:15:24","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 09/09/17 20:23, Jamal Hadi Salim wrote:\n> On 17-09-09 12:24 PM, Roopa Prabhu wrote:\n>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:\n>>> Signed-off-by: Roman Mashak \n>>> ---\n>>> bridge/link.c | 16 +++++++++++++---\n>>> 1 file changed, 13 insertions(+), 3 deletions(-)\n>>>\n>>> diff --git a/bridge/link.c b/bridge/link.c\n>>> index 60200f1..9e4206f 100644\n>>> --- a/bridge/link.c\n>>> +++ b/bridge/link.c\n>>> @@ -461,9 +461,19 @@ static int brlink_show(int argc, char **argv)\n>>> }\n>>> }\n>>>\n>>> - if (rtnl_wilddump_request(&rth, PF_BRIDGE, RTM_GETLINK) < 0) {\n>>> - perror(\"Cannon send dump request\");\n>>> - exit(1);\n>>> + if (show_details) {\n>>> + if (rtnl_wilddump_req_filter(&rth, PF_BRIDGE, RTM_GETLINK,\n>>> + (compress_vlans ?\n>>> + RTEXT_FILTER_BRVLAN_COMPRESSED :\n>>> + RTEXT_FILTER_BRVLAN)) < 0) {\n>>> + perror(\"Cannon send dump request\");\n>>> + exit(1);\n>>> + }\n>>\n>> vlan information is already available with `bridge vlan show`. any\n>> specific reason why you want it in\n>> the link dump output ?\n>>\n>>\n>> The problem is this might just make the link dump larger and also add\n>> too much clutter into the regular link dump output. iproute2 detailed\n>> dump is already a bit hard to interpret. And without compression by\n>> default, vlan info can just take over the link dump output. It will be\n>> hard to look for other link attributes after that :). We deploy with\n>> thousands of vlans and without compression even bridge vlan default\n>> output is already hard to interpret.\n>>\n> \n> Agree we should be turning on this stuff by default. i.e default stays\n> compressed; otherwise it a huge dump.\n\nI think this should be dumped with the getlink request only on some additional\nflag. The getlink does not include these by default.\n\n> \n> Having said that there is a lot of mess with this stuff.\n> The bridge link events _already send this IFLA_AF_SPCE info_\n> so not much choice there but to print it.\n\nRight, on NEWLINK per port notification you'll get the compressed vlan info.\n\n> At minimal we need that part because unfortunately there is no\n> vlanfilter event in existence which will send us summaries of just\n> vlans added to a port i.e both use XXXLINK.\n\nBut let's either add a new flag or use -compressvlans to print it when monitoring/showing\nlink otherwise people who are monitoring only the port flags will start getting lists\nwith vlans. Even compressed these can still be quite long and confusing, especially\nwhen monitoring.\n\n> In general, the XXXLINK interface with these master devices (bridge,\n> bond etc) continues to get messy. Recently started seeing events with\n> devices claiming to be of KIND_slave etc on the bridge and bond devices;\n> yet at the same time my wireless card events are also showing up on the\n> bridge link even though it is not enslaved there..\n> \n> cheers,\n> jamal\n> \n>> Can you please paste a sample default detailed output with your patch\n>> with a few hundred vlans ?\n>>\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"BFWg7PlE\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqMn00wD6z9t39\n\tfor ;\n\tSun, 10 Sep 2017 04:15:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753515AbdIISP3 (ORCPT );\n\tSat, 9 Sep 2017 14:15:29 -0400","from mail-wm0-f45.google.com ([74.125.82.45]:46044 \"EHLO\n\tmail-wm0-f45.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751384AbdIISP2 (ORCPT\n\t); Sat, 9 Sep 2017 14:15:28 -0400","by mail-wm0-f45.google.com with SMTP id f199so18883759wme.0\n\tfor ; Sat, 09 Sep 2017 11:15:27 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\tm25sm811821edj.17.2017.09.09.11.15.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 09 Sep 2017 11:15:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=O6WUqw56gB7333CZjyoza0jIQG7WGeci/oxdylkJw70=;\n\tb=BFWg7PlEYRExBwIcep/stNBuIMzSvD9Bvxi44yD8e7k4yt/rSNSEN1UOYHJ5kqztVy\n\t6VKkXBGTKc6+agM5edeqWWJCXNVl6HO6XIFQlY1f2mtUBj7TXpDkLRuzjWW7vlamestm\n\teK7GqIw+Nep+Laxd9JKtDFruBFgnEw1r1gmN0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=O6WUqw56gB7333CZjyoza0jIQG7WGeci/oxdylkJw70=;\n\tb=imW+NGP5ouARfAUBVBzDlZ7q5oib/TAu9oM9b+RpUfNWmeNTnoh8p7NqrqugMgZHqn\n\tY2BIPefpLqq4aLTPDZkuqL2jKwxw03CGwjHkZLydcqs0LJsi1LM6iAtvTkOQaDTqEGf8\n\tfkKbjU7CGOMgFrxSWClJ6RJmVIF77Q14VwviS/6OuXTdzdA+gyN+gHY2rzcdyYJpPJsX\n\t6erWsBubSSovti6lsBa9UX6uQYYUv4zFVpOi56/ySv6/nHH96LjDNg8l3BmJuyo0xqO4\n\t8hICN6QMd401YMuW0hRJdcnWWAojbguuzlypwJH1oF9oECuHoD+/c0qaKFVDbKb2KulC\n\tcLtw==","X-Gm-Message-State":"AHPjjUjycSdxo14D3bWH3EW5kGIs+UmNJmyRg1tlg22N+x1HljdKsgcK\n\tfeMUk9T6RcGAK3knXUQ=","X-Google-Smtp-Source":"ADKCNb56h1ngRhgnag7VR2t/qB3CsRifRYZOdi96j2kiHSLNHIqtm5TzDZXGPTRGJ2eKscw+EPtGSg==","X-Received":"by 10.80.151.143 with SMTP id e15mr406655edb.135.1504980926347; \n\tSat, 09 Sep 2017 11:15:26 -0700 (PDT)","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","To":"Jamal Hadi Salim ,\n\tRoopa Prabhu , Roman Mashak ","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>\n\t\n\t<5706e1ba-6b85-4f32-a858-b5d87b17eb51@mojatatu.com>","Cc":"\"stephen@networkplumber.org\" ,\n\t\"netdev@vger.kernel.org\" ","From":"Nikolay Aleksandrov ","Message-ID":"<1bde7c3e-1571-a2a2-3308-b42906fbb3d2@cumulusnetworks.com>","Date":"Sat, 9 Sep 2017 21:15:24 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"<5706e1ba-6b85-4f32-a858-b5d87b17eb51@mojatatu.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765902,"web_url":"http://patchwork.ozlabs.org/comment/1765902/","msgid":"","list_archive_url":null,"date":"2017-09-10T05:26:02","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":23500,"url":"http://patchwork.ozlabs.org/api/people/23500/","name":"Roopa Prabhu","email":"roopa@cumulusnetworks.com"},"content":"On Sat, Sep 9, 2017 at 10:23 AM, Jamal Hadi Salim wrote:\n> On 17-09-09 12:24 PM, Roopa Prabhu wrote:\n>>\n>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:\n>>>\n>>> Signed-off-by: Roman Mashak \n>>> ---\n>>> bridge/link.c | 16 +++++++++++++---\n>>> 1 file changed, 13 insertions(+), 3 deletions(-)\n>>>\n>>> diff --git a/bridge/link.c b/bridge/link.c\n>>> index 60200f1..9e4206f 100644\n>>> --- a/bridge/link.c\n>>> +++ b/bridge/link.c\n>>> @@ -461,9 +461,19 @@ static int brlink_show(int argc, char **argv)\n>>> }\n>>> }\n>>>\n>>> - if (rtnl_wilddump_request(&rth, PF_BRIDGE, RTM_GETLINK) < 0) {\n>>> - perror(\"Cannon send dump request\");\n>>> - exit(1);\n>>> + if (show_details) {\n>>> + if (rtnl_wilddump_req_filter(&rth, PF_BRIDGE,\n>>> RTM_GETLINK,\n>>> + (compress_vlans ?\n>>> +\n>>> RTEXT_FILTER_BRVLAN_COMPRESSED :\n>>> + RTEXT_FILTER_BRVLAN)) < 0)\n>>> {\n>>> + perror(\"Cannon send dump request\");\n>>> + exit(1);\n>>> + }\n>>\n>>\n>> vlan information is already available with `bridge vlan show`. any\n>> specific reason why you want it in\n>> the link dump output ?\n>>\n>>\n>>\n>> The problem is this might just make the link dump larger and also add\n>> too much clutter into the regular link dump output. iproute2 detailed\n>> dump is already a bit hard to interpret. And without compression by\n>> default, vlan info can just take over the link dump output. It will be\n>> hard to look for other link attributes after that :). We deploy with\n>> thousands of vlans and without compression even bridge vlan default\n>> output is already hard to interpret.\n>>\n>\n> Agree we should be turning on this stuff by default. i.e default stays\n> compressed; otherwise it a huge dump.\n>\n> Having said that there is a lot of mess with this stuff.\n> The bridge link events _already send this IFLA_AF_SPCE info_\n> so not much choice there but to print it.\n> At minimal we need that part because unfortunately there is no\n> vlanfilter event in existence which will send us summaries of just\n> vlans added to a port i.e both use XXXLINK.\n> In general, the XXXLINK interface with these master devices (bridge,\n> bond etc) continues to get messy. Recently started seeing events with\n> devices claiming to be of KIND_slave etc on the bridge and bond devices;\n\nyes, its a bit messy and redundant.\n\n> yet at the same time my wireless card events are also showing up on the\n> bridge link even though it is not enslaved there..\n\nthat is strange. It should not.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"TyRFlxUW\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqfg10ys2z9sDB\n\tfor ;\n\tSun, 10 Sep 2017 15:26:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750941AbdIJF0E (ORCPT );\n\tSun, 10 Sep 2017 01:26:04 -0400","from mail-oi0-f51.google.com ([209.85.218.51]:33041 \"EHLO\n\tmail-oi0-f51.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750877AbdIJF0D (ORCPT\n\t); Sun, 10 Sep 2017 01:26:03 -0400","by mail-oi0-f51.google.com with SMTP id r20so32234893oie.0\n\tfor ; Sat, 09 Sep 2017 22:26:03 -0700 (PDT)","by 10.157.15.221 with HTTP; Sat, 9 Sep 2017 22:26:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=L1jlH7QGsc/v9KlICSAWQ17dth4YsJaW/QAXwF2PVLE=;\n\tb=TyRFlxUWVB0ZRFeOAIRqfsuQHTNo5UoyAMOot0TfXTmMCGA8ipFe6ArylwyYBJJvqN\n\thkBgj8d/t8IRl47QmR/3Q6vaQl8KXfb/UImUZqRoMVuu1BElJZSXeXh80NZyuOUcD2jv\n\tko/46jrup4MDUIJ1E/ac/I93epLm5eE6KsoF0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=L1jlH7QGsc/v9KlICSAWQ17dth4YsJaW/QAXwF2PVLE=;\n\tb=qzVUPVyGBYhv9zVV4Y3WTrnLEgND+m5kcU/xSjjLX9paOjTHMZ1Ovy3KjCDE+bsoYg\n\t6UOs6NkVlP6YsrOyI1SinBdumkEsbOulGC5WpLTu0jpH2ywSVYW0IwzbOyLrXxHVieAW\n\tDBHo2r+wZFF1+tOB2/3+tGabb+Czg0w1VWCif6XY/71MbSCR6g+xwU5SoEUYhqz5swX4\n\tKosMhxB78V2DgU2jZlsMwYe3qCK7NoQhgO3wiUHO5wVt52QDzi6cpIvkIR84/iqHv+ie\n\tVRFIRLEjsTODbHiBLtHkgqVh07g+9fIT25L24a7ZkR+sr1afcI7+JxmPY4vAWMiRdWXr\n\tQL/A==","X-Gm-Message-State":"AHPjjUgOuLmFMlAI7ilUAMjQKLxiODaTHdrY7zxHtno7y0LGAAxc/8fh\n\tbtdymbqIkmYMDet6yUrbI7Ch14O8xtH3","X-Google-Smtp-Source":"AOwi7QAXHDCovzsQkXPuywXFeR5rgdHxAA+rCfB2U2uPSwuglD3OdKEZLIaRAdvfZWJ27Ptuh7JtMLtIPCAdp/LUUVk=","X-Received":"by 10.202.207.72 with SMTP id f69mr8428362oig.87.1505021162888; \n\tSat, 09 Sep 2017 22:26:02 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<5706e1ba-6b85-4f32-a858-b5d87b17eb51@mojatatu.com>","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>\n\t\n\t<5706e1ba-6b85-4f32-a858-b5d87b17eb51@mojatatu.com>","From":"Roopa Prabhu ","Date":"Sat, 9 Sep 2017 22:26:02 -0700","Message-ID":"","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","To":"Jamal Hadi Salim ","Cc":"Roman Mashak ,\n\t\"stephen@networkplumber.org\" ,\n\t\"netdev@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765904,"web_url":"http://patchwork.ozlabs.org/comment/1765904/","msgid":"","list_archive_url":null,"date":"2017-09-10T05:28:00","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":23500,"url":"http://patchwork.ozlabs.org/api/people/23500/","name":"Roopa Prabhu","email":"roopa@cumulusnetworks.com"},"content":"On Sat, Sep 9, 2017 at 11:15 AM, Nikolay Aleksandrov\n wrote:\n> On 09/09/17 20:23, Jamal Hadi Salim wrote:\n>> On 17-09-09 12:24 PM, Roopa Prabhu wrote:\n>>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:\n>>>> Signed-off-by: Roman Mashak \n>>>> ---\n>\n\n[snip]\n\n>>>\n>>> vlan information is already available with `bridge vlan show`. any\n>>> specific reason why you want it in\n>>> the link dump output ?\n>>>\n>>>\n>>> The problem is this might just make the link dump larger and also add\n>>> too much clutter into the regular link dump output. iproute2 detailed\n>>> dump is already a bit hard to interpret. And without compression by\n>>> default, vlan info can just take over the link dump output. It will be\n>>> hard to look for other link attributes after that :). We deploy with\n>>> thousands of vlans and without compression even bridge vlan default\n>>> output is already hard to interpret.\n>>>\n>>\n>> Agree we should be turning on this stuff by default. i.e default stays\n>> compressed; otherwise it a huge dump.\n>\n> I think this should be dumped with the getlink request only on some additional\n> flag. The getlink does not include these by default.\n>\n>>\n>> Having said that there is a lot of mess with this stuff.\n>> The bridge link events _already send this IFLA_AF_SPCE info_\n>> so not much choice there but to print it.\n>\n> Right, on NEWLINK per port notification you'll get the compressed vlan info.\n>\n>> At minimal we need that part because unfortunately there is no\n>> vlanfilter event in existence which will send us summaries of just\n>> vlans added to a port i.e both use XXXLINK.\n>\n> But let's either add a new flag or use -compressvlans to print it when monitoring/showing\n> link otherwise people who are monitoring only the port flags will start getting lists\n> with vlans. Even compressed these can still be quite long and confusing, especially\n> when monitoring.\n\nyes agree. It will add too much clutter to the monitor output too.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"CbDwauGb\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqfj96LlCz9sDB\n\tfor ;\n\tSun, 10 Sep 2017 15:28:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750980AbdIJF2C (ORCPT );\n\tSun, 10 Sep 2017 01:28:02 -0400","from mail-oi0-f49.google.com ([209.85.218.49]:34491 \"EHLO\n\tmail-oi0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750807AbdIJF2B (ORCPT\n\t); Sun, 10 Sep 2017 01:28:01 -0400","by mail-oi0-f49.google.com with SMTP id l74so27964006oih.1\n\tfor ; Sat, 09 Sep 2017 22:28:01 -0700 (PDT)","by 10.157.15.221 with HTTP; Sat, 9 Sep 2017 22:28:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=NiInci8OH6kMPFU2MJ6VieaKZeVp+cJregVBFdj4+4g=;\n\tb=CbDwauGbS1cxuY8MaSbZuxTPpOLcwEndE0Q2G8EkS8Aug+QRrsxAvoLMlGpbnZerzy\n\tWDnvAH+aMxpo1f7npPsda1WiAVS2UanXjLKTN1QvNPCBf3fB+gYStTvIcCAPO7ut8GS6\n\tTaOlNJIE8pygGyIeA9XheJmTn89b40pCe61Gg=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=NiInci8OH6kMPFU2MJ6VieaKZeVp+cJregVBFdj4+4g=;\n\tb=jqv/I5f8K4YeKrSjrHZ8SQEfJof/v1B/AhYy+CFEjEzXu7S+pTPcE/3JvWfIZH8/2A\n\t9Oy52OwUBvUhlWl561Z4S8rDgImMdq/ZlXkacxks7lfHpPGKdmaAUF3eJv2s7J1lWVQB\n\t2nNl/IgYG66BIyc725y2eNeP4sSz58fkXtQ19hVjY6clrSZPxvMki/sTy1QNxk6d5otC\n\thBMkBCF7Zm/DDOUx66EhGis7bJx4VvIF5wPKXmItjCAXsXJh/HGXkieAYu60mlQCzbHh\n\tnQD7Rb6W+j/XgFfNaiyLJCleLOy/wfR7ksrQ5onkQ2WPJnYpvrrT4eWcnM3pxcZJwyvC\n\tG3uw==","X-Gm-Message-State":"AHPjjUga8YvMMEM3mRBB3ihE50UpAxeamZFRajSccUyr/8LigBzk2SB8\n\tujcFYWXFI8UCtEBf3EkkkJaeycnuGuxp","X-Google-Smtp-Source":"AOwi7QA++SR4KAUVv+AfQf7zuJhVtugMNV35Ul12m7W4/oE4BBGIOwLPppoA/nhAspCExw0948PSfuuj60DPZMVrdYA=","X-Received":"by 10.202.240.86 with SMTP id o83mr4707745oih.295.1505021280724; \n\tSat, 09 Sep 2017 22:28:00 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1bde7c3e-1571-a2a2-3308-b42906fbb3d2@cumulusnetworks.com>","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>\n\t\n\t<5706e1ba-6b85-4f32-a858-b5d87b17eb51@mojatatu.com>\n\t<1bde7c3e-1571-a2a2-3308-b42906fbb3d2@cumulusnetworks.com>","From":"Roopa Prabhu ","Date":"Sat, 9 Sep 2017 22:28:00 -0700","Message-ID":"","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","To":"Nikolay Aleksandrov ","Cc":"Jamal Hadi Salim , Roman Mashak ,\n\t\"stephen@networkplumber.org\" ,\n\t\"netdev@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765930,"web_url":"http://patchwork.ozlabs.org/comment/1765930/","msgid":"","list_archive_url":null,"date":"2017-09-10T10:24:53","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 09/09/17 20:23, Jamal Hadi Salim wrote:\n> On 17-09-09 12:24 PM, Roopa Prabhu wrote:\n>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:\n[snip]\n> \n> Agree we should be turning on this stuff by default. i.e default stays\n> compressed; otherwise it a huge dump.\n> \n> Having said that there is a lot of mess with this stuff.\n> The bridge link events _already send this IFLA_AF_SPCE info_\n> so not much choice there but to print it.\n> At minimal we need that part because unfortunately there is no\n> vlanfilter event in existence which will send us summaries of just\n> vlans added to a port i.e both use XXXLINK.\n> In general, the XXXLINK interface with these master devices (bridge,\n> bond etc) continues to get messy. Recently started seeing events with\n> devices claiming to be of KIND_slave etc on the bridge and bond devices;\n> yet at the same time my wireless card events are also showing up on the\n> bridge link even though it is not enslaved there..\n\nOut of curiousity about this one, do you see the wifi card when doing bridge monitor ?\nOr are you specifically watching AF_BRIDGE events, because bridge monitor link also can\ninclude AF_UNSPEC ?\n\n> \n> cheers,\n> jamal\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"Z+HEN7vK\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqnK35Hkkz9sBZ\n\tfor ;\n\tSun, 10 Sep 2017 20:26:15 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751351AbdIJKY6 (ORCPT );\n\tSun, 10 Sep 2017 06:24:58 -0400","from mail-wm0-f41.google.com ([74.125.82.41]:46121 \"EHLO\n\tmail-wm0-f41.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750709AbdIJKY5 (ORCPT\n\t); Sun, 10 Sep 2017 06:24:57 -0400","by mail-wm0-f41.google.com with SMTP id i189so23287168wmf.1\n\tfor ; Sun, 10 Sep 2017 03:24:56 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\ty8sm779082edb.86.2017.09.10.03.24.53\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 10 Sep 2017 03:24:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=xGEwghsJmZ3EXl0V+gMr72/bdy6UyeHMXps2QQ92gW4=;\n\tb=Z+HEN7vK4NCb133x3EbQI5G75n46VnF0Iab/e/MYndFa6CRaZojv/lnFmNBjaxv36n\n\td0rw+MHia7JzLf4jDct+t0GkYHlnDKbPjGvy1oKH0h6bUmKiy9pFwCM1i08/36A8q94P\n\t8H7OISfIJbY82IsajRdIoMMZtqKvGbs8lNHiw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=xGEwghsJmZ3EXl0V+gMr72/bdy6UyeHMXps2QQ92gW4=;\n\tb=uS3MpdQCtOpdPQKp/+RoM6alRR7RzXgh1ummGd6Krq/eEN78eLC+zVfvkbR+/xWAMu\n\t8/ISDP88qrgJ9YP11cNVRUn6vBlPPHh4ej/nLzqd700VSuidE1Yv9J10gcTe/Di9KA0K\n\tNUoQyljU/NAPwKUPMZpxCO7tZGUvCDqVZkx4l1R+Xl73KHr/NQQzA392XxZNJen5uAQV\n\tnD78GgKjlz2an3V/YV54zaFASfBmYLyj1g9EIzyD3pfSzI/mApJUiR2gWQW8/MNUZ9nB\n\tgDwQ++Ud5J14l67tcpnRYG/8qLqqfWPVxXmbpe8WKEvRxtigr4uFGTe6l1WYWuEGQiXf\n\t0UBw==","X-Gm-Message-State":"AHPjjUg0Vz2KZn0qFYJgdgF8TEOVMzOb4NVwv0fRtVWKLmcNFHCDosZL\n\tnvsqBQwAlFT9ro819g8=","X-Google-Smtp-Source":"ADKCNb7LF2SV2LuM58EZSmGqnQHj/JsxpaEbeqkEYYOVy3YNttmENlj/Y0Zj4pJg38rQI2xZwt2MJA==","X-Received":"by 10.80.139.246 with SMTP id n51mr5409569edn.244.1505039095831; \n\tSun, 10 Sep 2017 03:24:55 -0700 (PDT)","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","To":"Jamal Hadi Salim ,\n\tRoopa Prabhu , Roman Mashak ","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>\n\t\n\t<5706e1ba-6b85-4f32-a858-b5d87b17eb51@mojatatu.com>","Cc":"\"stephen@networkplumber.org\" ,\n\t\"netdev@vger.kernel.org\" ","From":"Nikolay Aleksandrov ","Message-ID":"","Date":"Sun, 10 Sep 2017 13:24:53 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"<5706e1ba-6b85-4f32-a858-b5d87b17eb51@mojatatu.com>","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765944,"web_url":"http://patchwork.ozlabs.org/comment/1765944/","msgid":"<85y3pmr7wn.fsf@mojatatu.com>","list_archive_url":null,"date":"2017-09-10T13:38:00","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":70341,"url":"http://patchwork.ozlabs.org/api/people/70341/","name":"Roman Mashak","email":"mrv@mojatatu.com"},"content":"Roopa Prabhu writes:\n\n> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:\n>> Signed-off-by: Roman Mashak \n>> ---\n>> bridge/link.c | 16 +++++++++++++---\n>> 1 file changed, 13 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/bridge/link.c b/bridge/link.c\n>> index 60200f1..9e4206f 100644\n>> --- a/bridge/link.c\n>> +++ b/bridge/link.c\n>> @@ -461,9 +461,19 @@ static int brlink_show(int argc, char **argv)\n>> }\n>> }\n>>\n>> - if (rtnl_wilddump_request(&rth, PF_BRIDGE, RTM_GETLINK) < 0) {\n>> - perror(\"Cannon send dump request\");\n>> - exit(1);\n>> + if (show_details) {\n>> + if (rtnl_wilddump_req_filter(&rth, PF_BRIDGE, RTM_GETLINK,\n>> + (compress_vlans ?\n>> + RTEXT_FILTER_BRVLAN_COMPRESSED :\n>> + RTEXT_FILTER_BRVLAN)) < 0) {\n>> + perror(\"Cannon send dump request\");\n>> + exit(1);\n>> + }\n>\n> vlan information is already available with `bridge vlan show`. any\n> specific reason why you want it in\n> the link dump output ?\n\nSince VLAN info is already in link messages, there is no other option but\ndump it in monitor or \"bridge link show\". Yes, the output may be lengthy\nand hard to digest for a human, that is why I put it under \"show_details\"\nkludge - if one is requesting details, he/she should be prepared for\nlarge volumes of data to be shown :)\n\nAs Nikolay suggested, it'll make sense to request compressed\noutput by default, this will be addresses in v2 patch.\n\n[...]","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"zE+ew5zg\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqsZw48Vgz9s8J\n\tfor ;\n\tSun, 10 Sep 2017 23:38:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751482AbdIJNi2 (ORCPT );\n\tSun, 10 Sep 2017 09:38:28 -0400","from mail-io0-f193.google.com ([209.85.223.193]:38160 \"EHLO\n\tmail-io0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750853AbdIJNi1 (ORCPT\n\t); Sun, 10 Sep 2017 09:38:27 -0400","by mail-io0-f193.google.com with SMTP id j141so2111149ioj.5\n\tfor ; Sun, 10 Sep 2017 06:38:27 -0700 (PDT)","from sevai (23-233-26-181.cpe.pppoe.ca. [23.233.26.181])\n\tby smtp.gmail.com with ESMTPSA id\n\tg133sm3050104iof.41.2017.09.10.06.38.25\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tSun, 10 Sep 2017 06:38:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:references:date:in-reply-to:message-id\n\t:user-agent:mime-version;\n\tbh=BQn45dLlrxBJOi2LjWKIYMBFpabH3GZEKyuRnDDgs7Y=;\n\tb=zE+ew5zghuOk3tv5+31uV8EIJ82xoMjPBW8gpmUOjHsIvYJ2F0mpLG1mEbFKhJbZgg\n\tomDT3qMeTQxMIlbm7BzG6izLZ6wHZIPvEi4HXqfG9gTc7W2r2ai/plU5s31B1p0ljfD8\n\tUUEnkxUIcDk5d2nvgfDrC5YkeDQq1Z3JwcbE922X5Eckqfw8Vqa/jR3TUQBJOfWxw8Bf\n\tlgFwitVnqM2G2re0sVOPT+IgXJZehD4CsnU7blIdF1Mg6/07KzKoqh5iEtLTPd1TlmqW\n\tWG82raJuW+ZqQh9DBnwIyxLOx8aLq1a3vibG/5sY+w3UhkR17X5igkxl6hBEEarXH2r3\n\tVGrg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:user-agent:mime-version;\n\tbh=BQn45dLlrxBJOi2LjWKIYMBFpabH3GZEKyuRnDDgs7Y=;\n\tb=RehzJQGavyQI9/NGLWyhQ4ba093uo1GKvKly1l0eirQmui2Gay/389TNbNoV1IXVib\n\tzh3o691xCmpgfIXwD02WhCnI3qputj7Euwt4GGyDA3wleUXw3snEo6AoO7DrJUjC2Tl/\n\tne/6YzcQJzizvxW92CluMiZrKSIv2LkjnkdX0nG5JgphR/bKyi2dtbdXGrF05JkIFLEf\n\teCXvPJPNOyHghXu3UhqtFOEdfhicinNnK6dZlZCn4bEAbHmksBR5NIXNuozjDnk9zA6m\n\tqictblOKnT6YhxzRAMOAaIcL+RFmTxwf5dmD2xYpM6FDpW5tFplabnr8OVV16Hju+BSm\n\t2SjA==","X-Gm-Message-State":"AHPjjUgAGbX6hOsGJ2Cwkw0v6keiTcggKBMBXpAgz8RPUZnBwKtBuJKF\n\tZeHW+MalKvziYgBb","X-Google-Smtp-Source":"AOwi7QAy6zyDvN/SPZxItCHoYrsmEjVOtW+hZFT17WrKX1WUsrte+p5KMhL5nvdZeFyfFEdERgjYXQ==","X-Received":"by 10.107.10.77 with SMTP id u74mr11704087ioi.243.1505050707127; \n\tSun, 10 Sep 2017 06:38:27 -0700 (PDT)","From":"Roman Mashak ","To":"Roopa Prabhu ","Cc":"\"stephen\\@networkplumber.org\" ,\n\t\"netdev\\@vger.kernel.org\" ,\n\tJamal Hadi Salim ","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>\n\t","Date":"Sun, 10 Sep 2017 09:38:00 -0400","In-Reply-To":"\n\t(Roopa Prabhu's message of \"Sat, 9 Sep 2017 09:24:31 -0700\")","Message-ID":"<85y3pmr7wn.fsf@mojatatu.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765947,"web_url":"http://patchwork.ozlabs.org/comment/1765947/","msgid":"<93aaf641-5063-e5d2-799c-718c85ca60a5@cumulusnetworks.com>","list_archive_url":null,"date":"2017-09-10T14:21:48","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 10/09/17 16:38, Roman Mashak wrote:\n> Roopa Prabhu writes:\n> \n>> On Fri, Sep 8, 2017 at 2:52 PM, Roman Mashak wrote:\n>>> Signed-off-by: Roman Mashak \n>>> ---\n>>> bridge/link.c | 16 +++++++++++++---\n>>> 1 file changed, 13 insertions(+), 3 deletions(-)\n>>>\n>>> diff --git a/bridge/link.c b/bridge/link.c\n>>> index 60200f1..9e4206f 100644\n>>> --- a/bridge/link.c\n>>> +++ b/bridge/link.c\n>>> @@ -461,9 +461,19 @@ static int brlink_show(int argc, char **argv)\n>>> }\n>>> }\n>>>\n>>> - if (rtnl_wilddump_request(&rth, PF_BRIDGE, RTM_GETLINK) < 0) {\n>>> - perror(\"Cannon send dump request\");\n>>> - exit(1);\n>>> + if (show_details) {\n>>> + if (rtnl_wilddump_req_filter(&rth, PF_BRIDGE, RTM_GETLINK,\n>>> + (compress_vlans ?\n>>> + RTEXT_FILTER_BRVLAN_COMPRESSED :\n>>> + RTEXT_FILTER_BRVLAN)) < 0) {\n>>> + perror(\"Cannon send dump request\");\n>>> + exit(1);\n>>> + }\n>>\n>> vlan information is already available with `bridge vlan show`. any\n>> specific reason why you want it in\n>> the link dump output ?\n> \n> Since VLAN info is already in link messages, there is no other option but\n> dump it in monitor or \"bridge link show\". Yes, the output may be lengthy\n\nTo make sure there's no misunderstanding - on GETLINK the vlan info is _not_\ndumped by default (not compressed or otherwise).\nIt is only dumped compressed on port notifications, that is why I suggested to\nuse the already present flag (-compressvlans, -c) in order to include that info\nwhen monitoring or dumping link info, so people watching for the port flags\n(show_details) would not suddenly start getting a lot more and it makes sense\nto dump it only on specific request.\n\n> and hard to digest for a human, that is why I put it under \"show_details\"\n> kludge - if one is requesting details, he/she should be prepared for\n> large volumes of data to be shown :)\n> \n> As Nikolay suggested, it'll make sense to request compressed\n> output by default, this will be addresses in v2 patch.\n> \n> [...]\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"fSPu4sXX\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqtY92jLCz9sCZ\n\tfor ;\n\tMon, 11 Sep 2017 00:21:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751704AbdIJOVx (ORCPT );\n\tSun, 10 Sep 2017 10:21:53 -0400","from mail-wm0-f53.google.com ([74.125.82.53]:43994 \"EHLO\n\tmail-wm0-f53.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751615AbdIJOVv (ORCPT\n\t); Sun, 10 Sep 2017 10:21:51 -0400","by mail-wm0-f53.google.com with SMTP id a137so2469988wma.0\n\tfor ; Sun, 10 Sep 2017 07:21:50 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\tr39sm4337283edr.95.2017.09.10.07.21.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 10 Sep 2017 07:21:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=3ttQ6w7HfpY36GKd5i6J6siJwl6xGS1B6+abJvHHcz8=;\n\tb=fSPu4sXXV+/vPIU7lswXifVTynltC3yDmhjzSkt7tL2xB4ABV/vWHgf+vCODdcJgVC\n\tYCGWYVpFe5CVK9mvqTtdEPIZyNKuuQowlbYEBDRj6B6bY5r68/CGscoaVO8sajLKWY2/\n\t3flj+O1PJwlF+TT00C9uPhlMCscdqKH266GSk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=3ttQ6w7HfpY36GKd5i6J6siJwl6xGS1B6+abJvHHcz8=;\n\tb=WimIJVUPrzX/YMmcOeEDsMcYpoJMInAi4/eTUaZR8IBtJ9RN0lpxIpBAom2ACVsMWa\n\tvbGNEwRCuE/VUUJ7lCt+OS/dUVYS0QHEVdQmHofxR9dKlIX+8CKWsyCtblYSxpBM1vax\n\tE6O1n/hMe/8vymxR4UFJA/xHF9fOipttIuxWdU30ZBpOYDQKVmyCDhS1VhIrtpvxiPDg\n\tS+5/f8Cuz24a8AcFAgbFSqd3jbBl0xrBVlxOCi5a3DvSUI3mh93jcz2/vcquzky7c0ip\n\tJnE4o4GqXc3zNPZsrIoNk/nbrEHVdoDVJFrUweDtSRPJOcAOt1M+y9iQ3355EEUZYjlY\n\t12fQ==","X-Gm-Message-State":"AHPjjUjH41qfOXy8gHOHrduRnivTAPhhjNzfeCZZffT8nIEJUtbCkOBM\n\tsPm/sMXck4QSNVKh","X-Google-Smtp-Source":"ADKCNb5IrPUd3xe/ClA4KQV/No0Tf7O6AyRjyvufb99f/GAOnHuokGzhA7pLb8RqX7ni3Thz+8VB5A==","X-Received":"by 10.80.181.39 with SMTP id y36mr1484491edd.227.1505053310120; \n\tSun, 10 Sep 2017 07:21:50 -0700 (PDT)","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","To":"Roman Mashak , Roopa Prabhu ","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>\n\t\n\t<85y3pmr7wn.fsf@mojatatu.com>","Cc":"\"stephen@networkplumber.org\" ,\n\t\"netdev@vger.kernel.org\" ,\n\tJamal Hadi Salim ","From":"Nikolay Aleksandrov ","X-Enigmail-Draft-Status":"N1110","Message-ID":"<93aaf641-5063-e5d2-799c-718c85ca60a5@cumulusnetworks.com>","Date":"Sun, 10 Sep 2017 17:21:48 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"<85y3pmr7wn.fsf@mojatatu.com>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765987,"web_url":"http://patchwork.ozlabs.org/comment/1765987/","msgid":"<85poayquwo.fsf@mojatatu.com>","list_archive_url":null,"date":"2017-09-10T18:18:47","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":70341,"url":"http://patchwork.ozlabs.org/api/people/70341/","name":"Roman Mashak","email":"mrv@mojatatu.com"},"content":"Nikolay Aleksandrov writes:\n\n> On 10/09/17 16:38, Roman Mashak wrote:\n\n[...]\n\n>> Since VLAN info is already in link messages, there is no other option but\n>> dump it in monitor or \"bridge link show\". Yes, the output may be lengthy\n>\n> To make sure there's no misunderstanding - on GETLINK the vlan info is _not_\n> dumped by default (not compressed or otherwise).\n\nYes, I understand it, I was referring to link events in the previous\ncomment. However, why not to report compressed vlans for GETLINK by\ndefault if show_details is true, this would be consistent with events monitor.\n\nIt seems to be more clear and intuitive from the user's perspective, the\nsame set of command line options for \\monitor' or 'show' commands.\n\n> It is only dumped compressed on port notifications, that is why I suggested to\n> use the already present flag (-compressvlans, -c) in order to include that info\n> when monitoring or dumping link info, so people watching for the port flags\n> (show_details) would not suddenly start getting a lot more and it makes sense\n> to dump it only on specific request.\n>\n>> and hard to digest for a human, that is why I put it under \"show_details\"\n>> kludge - if one is requesting details, he/she should be prepared for\n>> large volumes of data to be shown :)\n>> \n>> As Nikolay suggested, it'll make sense to request compressed\n>> output by default, this will be addresses in v2 patch.\n>> \n>> [...]\n>>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=mojatatu-com.20150623.gappssmtp.com\n\theader.i=@mojatatu-com.20150623.gappssmtp.com\n\theader.b=\"eq9Ibuuy\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xqzpc5Z7Fz9s7m\n\tfor ;\n\tMon, 11 Sep 2017 04:19:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751732AbdIJSTA (ORCPT );\n\tSun, 10 Sep 2017 14:19:00 -0400","from mail-it0-f45.google.com ([209.85.214.45]:45678 \"EHLO\n\tmail-it0-f45.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750789AbdIJSS7 (ORCPT\n\t); Sun, 10 Sep 2017 14:18:59 -0400","by mail-it0-f45.google.com with SMTP id v19so9821992ite.0\n\tfor ; Sun, 10 Sep 2017 11:18:59 -0700 (PDT)","from sevai (23-233-26-181.cpe.pppoe.ca. [23.233.26.181])\n\tby smtp.gmail.com with ESMTPSA id\n\ti125sm3633141itf.1.2017.09.10.11.18.57\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tSun, 10 Sep 2017 11:18:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mojatatu-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:references:date:in-reply-to:message-id\n\t:user-agent:mime-version;\n\tbh=ymFrP/2SgnX2EQRAyM0lfiNK+Wjpt37YAko74NombRE=;\n\tb=eq9IbuuyuR6fgG293I1vm13gjeirqdkUYPOoFHfWZHsIFq721ka9OutIVjnDysKYpR\n\teVZc2qgLaw612/7CVnGxu7C3JC1Zjiu2M6iH9IE9h8Z14WKIJ6ArStwlVAL0vqOZKeMn\n\tCRf00OdcbKp1IPeFkCe7eCskc1E7uby/cdmw/N6g+6/UMUdQfX/NHZiYdIK1BIDVRybj\n\tFlT+LGTu7m5dALv+Z2gVDn07E37ubeYQc9yP0sNm5VtTBnOqVdsG8ZWQbDsVzBS+Ojh5\n\tBubB+U1L+bMeTLtXjgUgYr+ZaXwDec3CUIZ+uLQo8vVgPk4u0IRfMV4pfPOW2dwzl60q\n\tggeg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to\n\t:message-id:user-agent:mime-version;\n\tbh=ymFrP/2SgnX2EQRAyM0lfiNK+Wjpt37YAko74NombRE=;\n\tb=nkCJwyl7l8yh6zDczG3v071gZA7FWejQUmTgM1+6c5ndcrsQHVw0As7DRsQcnx8ud0\n\tU9VdpJlnrb68/XKaW63zzJuXOo9MgrNVWS1hhE23XwO+tIx9G+TwjzL7AI0zAe/cjIGE\n\tNwjHHt/gQiau6b4FLUBFCL59unXY1Hy7k/Vz3CKxt0T7z0ocVbBAHk91P1HXW5pf8Bpk\n\tZKLkMuAb6KbtbrIf3NWlpuRxeSrsBZgdDk9nNBYOHh4u5ZZ3o1eRP60dwv0n1XH9oUKv\n\tUYquVHxZlEocRkmlKPLZyKAmcslRUfj8hURKPfu1R9FFRFvdmAWicuy8oMT9ceXH9YzZ\n\txbNQ==","X-Gm-Message-State":"AHPjjUhoOWbFWX5tft5fxAbuljkg3HldhCrQmvxtZMB3wIN/MxbSgqi9\n\tEam9JlcyW14oP1IvLRgsxwSbbQ==","X-Google-Smtp-Source":"ADKCNb6j8I13mIaYP3haewe8dfYWBttNfuz31JeheNuW91R7BBoMnkLv980A+GicBCeNwZXslh8Azg==","X-Received":"by 10.36.170.15 with SMTP id b15mr11021712itf.107.1505067538839; \n\tSun, 10 Sep 2017 11:18:58 -0700 (PDT)","From":"Roman Mashak ","To":"Nikolay Aleksandrov ","Cc":"Roopa Prabhu ,\n\t\"stephen\\@networkplumber.org\" ,\n\t\"netdev\\@vger.kernel.org\" ,\n\tJamal Hadi Salim ","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>\n\t\n\t<85y3pmr7wn.fsf@mojatatu.com>\n\t<93aaf641-5063-e5d2-799c-718c85ca60a5@cumulusnetworks.com>","Date":"Sun, 10 Sep 2017 14:18:47 -0400","In-Reply-To":"<93aaf641-5063-e5d2-799c-718c85ca60a5@cumulusnetworks.com>\n\t(Nikolay Aleksandrov's message of \"Sun, 10 Sep 2017 17:21:48 +0300\")","Message-ID":"<85poayquwo.fsf@mojatatu.com>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765989,"web_url":"http://patchwork.ozlabs.org/comment/1765989/","msgid":"<5eec2834-c54f-0cc9-e5f7-a38cce6ebee1@cumulusnetworks.com>","list_archive_url":null,"date":"2017-09-10T18:36:23","subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","submitter":{"id":66448,"url":"http://patchwork.ozlabs.org/api/people/66448/","name":"Nikolay Aleksandrov","email":"nikolay@cumulusnetworks.com"},"content":"On 10/09/17 21:18, Roman Mashak wrote:\n> Nikolay Aleksandrov writes:\n> \n>> On 10/09/17 16:38, Roman Mashak wrote:\n> \n> [...]\n> \n>>> Since VLAN info is already in link messages, there is no other option but\n>>> dump it in monitor or \"bridge link show\". Yes, the output may be lengthy\n>>\n>> To make sure there's no misunderstanding - on GETLINK the vlan info is _not_\n>> dumped by default (not compressed or otherwise).\n> \n> Yes, I understand it, I was referring to link events in the previous\n> comment. However, why not to report compressed vlans for GETLINK by\n> default if show_details is true, this would be consistent with events monitor.\n> \n\nSo my point is to only print the compressed vlans when the -c flag is present on\nboth occasions. I don't have any strong feeling about this, my only concern is that\npeople using -d with monitor will start suddenly seeing a lot more than they expect.\nThe -c (which already exists) will give them the option to skip it. Also the getlink\nwith lots of vlans and ports will grow by default if there's no way to remove the\nvlan dumps (be it compressed or not).\n\nIn general I'd prefer to have only one way to do things, e.g. in this particular\ncase I'd advise people to use bridge vlan show, but I get it that monitor doesn't\nshow them anywhere. Maybe all of this should go under bridge monitor vlan or\nbridge -compressvlans monitor link. Anyway, if other people are fine with extending\nthe 'show_details' only, then I won't stay in the way.\n\n> It seems to be more clear and intuitive from the user's perspective, the\n> same set of command line options for \\monitor' or 'show' commands.\n> \n\nThat I completely agree with. :-)\n\n>> It is only dumped compressed on port notifications, that is why I suggested to\n>> use the already present flag (-compressvlans, -c) in order to include that info\n>> when monitoring or dumping link info, so people watching for the port flags\n>> (show_details) would not suddenly start getting a lot more and it makes sense\n>> to dump it only on specific request.\n>>\n>>> and hard to digest for a human, that is why I put it under \"show_details\"\n>>> kludge - if one is requesting details, he/she should be prepared for\n>>> large volumes of data to be shown :)\n>>>\n>>> As Nikolay suggested, it'll make sense to request compressed\n>>> output by default, this will be addresses in v2 patch.\n>>>\n>>> [...]\n>>>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=cumulusnetworks.com\n\theader.i=@cumulusnetworks.com header.b=\"EimwHYxJ\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xr0Bl4tqhz9sxR\n\tfor ;\n\tMon, 11 Sep 2017 04:36:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751479AbdIJSg1 (ORCPT );\n\tSun, 10 Sep 2017 14:36:27 -0400","from mail-wm0-f50.google.com ([74.125.82.50]:45147 \"EHLO\n\tmail-wm0-f50.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750966AbdIJSg0 (ORCPT\n\t); Sun, 10 Sep 2017 14:36:26 -0400","by mail-wm0-f50.google.com with SMTP id f199so26765938wme.0\n\tfor ; Sun, 10 Sep 2017 11:36:25 -0700 (PDT)","from [192.168.0.103] (46-10-142-144.ip.btc-net.bg. [46.10.142.144])\n\tby smtp.googlemail.com with ESMTPSA id\n\tp14sm3324874edj.21.2017.09.10.11.36.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 10 Sep 2017 11:36:23 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cumulusnetworks.com; s=google;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=4mtyEHywPAaHFB9OWXn57mN3Wb9Os01BifY/TAErNAg=;\n\tb=EimwHYxJerm7aZzjJcSqC7CRLeFAvNd91zGA2Uy4B+MnSKrsmwQ4hVnkqLL7olX0ja\n\tN0f5gdCe2h2tcTrSoCWNS6ST9s0hMZjjjNyaHeHczXjuy17b9pC5jx80RxrcF6dcy0/W\n\tYC1u3F6TKQltj5/eITcek1kCiL5CYmMvXrc40=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=4mtyEHywPAaHFB9OWXn57mN3Wb9Os01BifY/TAErNAg=;\n\tb=M888BICTo+CnC8CixMsj+NHMZaekxHPSjrwuqtvf5NDCa8GUs/PCA/h5uhgGEA1VIq\n\tVAK2d+rMWa0xPGF0OV6zCNZNo9E3LBoV+h0HDYRwEZfiz0XVdyYDBps58Wh8bFiqXsVx\n\tcVnGyKgKhO3vcZZ1JAkCd86154n/G+3j4MAZwAdpdiIkTJ/tIzjPXA7vdRuKBRx2ZSU0\n\tGcK6yu9+DJxmbFQ0qpF3N10UMKWp+xmcF8Pfogk0oDwUQsq6au1ri6VPK68M7RPw33F+\n\t5YmNVzI3WTNZ3dpOFngGKysD3wMxgRMqVJFptH0MqFOPTYf6fs6moP5dZM76JUw5vjU1\n\tTE2Q==","X-Gm-Message-State":"AHPjjUjvk60svPI8ASxV+dObeOhp5CO9twTE5/KkMKyHVHkZYQSfEaYO\n\t89mAzNFjQgaRRn3O4k4=","X-Google-Smtp-Source":"ADKCNb4zWNanoasqlilXoMSY9UvVBQ+mz/g4O1/uVzpOQZU4AtD8o/rpLiSwax3T62Jyve68rVFRnA==","X-Received":"by 10.80.224.201 with SMTP id j9mr7543279edl.216.1505068585087; \n\tSun, 10 Sep 2017 11:36:25 -0700 (PDT)","Subject":"Re: [PATCH iproute2 3/3] bridge: request vlans along with link\n\tinformation","To":"Roman Mashak ","References":"<1504907543-14394-1-git-send-email-mrv@mojatatu.com>\n\t<1504907543-14394-4-git-send-email-mrv@mojatatu.com>\n\t\n\t<85y3pmr7wn.fsf@mojatatu.com>\n\t<93aaf641-5063-e5d2-799c-718c85ca60a5@cumulusnetworks.com>\n\t<85poayquwo.fsf@mojatatu.com>","Cc":"Roopa Prabhu ,\n\t\"stephen@networkplumber.org\" ,\n\t\"netdev@vger.kernel.org\" ,\n\tJamal Hadi Salim ","From":"Nikolay Aleksandrov ","X-Enigmail-Draft-Status":"N1110","Message-ID":"<5eec2834-c54f-0cc9-e5f7-a38cce6ebee1@cumulusnetworks.com>","Date":"Sun, 10 Sep 2017 21:36:23 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tIcedove/45.6.0","MIME-Version":"1.0","In-Reply-To":"<85poayquwo.fsf@mojatatu.com>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]