[{"id":1765641,"web_url":"http://patchwork.ozlabs.org/comment/1765641/","msgid":"<893ece6d-ac19-fd3e-aee2-f5032d2d13d8@fb.com>","list_archive_url":null,"date":"2017-09-08T22:40:47","subject":"Re: [net PATCH 3/3] bpf: devmap, use cond_resched instead of\n\tcpu_relax","submitter":{"id":68234,"url":"http://patchwork.ozlabs.org/api/people/68234/","name":"Alexei Starovoitov","email":"ast@fb.com"},"content":"On 9/8/17 2:01 PM, John Fastabend wrote:\n> Be a bit more friendly about waiting for flush bits to complete.\n> Replace the cpu_relax() with a cond_resched().\n>\n> Suggested-by: Daniel Borkmann \n> Acked-by: Daniel Borkmann \n> Signed-off-by: John Fastabend \n\nunlike patch 1 and 2, this one could have waited till net-next opens,\nbut I don't mind now. lgtm\nAcked-by: Alexei Starovoitov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=fb.com header.i=@fb.com header.b=\"L4mBbtJJ\";\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com\n\theader.b=\"ORsywCLQ\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpsk70TPNz9sRV\n\tfor ;\n\tSat, 9 Sep 2017 08:41:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1757082AbdIHWlQ (ORCPT );\n\tFri, 8 Sep 2017 18:41:16 -0400","from mx0a-00082601.pphosted.com ([67.231.145.42]:43136 \"EHLO\n\tmx0a-00082601.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1752952AbdIHWlO (ORCPT\n\t); Fri, 8 Sep 2017 18:41:14 -0400","from pps.filterd (m0044010.ppops.net [127.0.0.1])\n\tby mx0a-00082601.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv88Mdw5E024438; Fri, 8 Sep 2017 15:40:59 -0700","from maileast.thefacebook.com ([199.201.65.23])\n\tby mx0a-00082601.pphosted.com with ESMTP id 2cv2jar915-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tFri, 08 Sep 2017 15:40:59 -0700","from NAM03-DM3-obe.outbound.protection.outlook.com (192.168.183.28)\n\tby o365-in.thefacebook.com (192.168.177.27) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 8 Sep 2017 18:40:58 -0400","from [IPv6:2620:10d:c081:1130::10d2] (2620:10d:c090:180::1:72d0) by\n\tDM3PR15MB0972.namprd15.prod.outlook.com (2603:10b6:0:10::26) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12;\n\tFri, 8 Sep 2017 22:40:55 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com;\n\th=subject : to : references\n\t: cc : from : message-id : date : mime-version : in-reply-to :\n\tcontent-type : content-transfer-encoding; s=facebook;\n\tbh=8+dKCLS9l7gGezfsESNgKrrycURp8oR/DANupEOtc9A=;\n\tb=L4mBbtJJu/juoZA+mtS7J4hmrGKPwv9+L90uSmCHxwQtojlqasJxsrtjT9INzPlw7J8z\n\tng28w55vD92ZHxnCUpdKFSErA9lYdNi7J0AD1TRQWGnuE9r3wP7aTR9Kj/jl7vgQ1Bih\n\tmw0frX+umKQaC2IeDv2rvaBX22yQo/1HrBI= ","v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; \n\ts=selector1-fb-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version; \n\tbh=8+dKCLS9l7gGezfsESNgKrrycURp8oR/DANupEOtc9A=;\n\tb=ORsywCLQLqT8q24AeZMHDITpkB0OXq8ns7WKz4XCBLxwAJBB1hj9jwmtTUEsabufr5Jqr1sPmV58R5sxgAavbtD+lC/auNGRJc4Q5G5ZOvDlKU66oBiywA9TfWiSr0/Y7AIMIZDaQmnfA7jxlXFkQcDamxOMbIreRk6ZtVT0X0Q="],"Subject":"Re: [net PATCH 3/3] bpf: devmap, use cond_resched instead of\n\tcpu_relax","To":"John Fastabend , ","References":"<150490397545.11590.1409723973253492363.stgit@john-XPS-13-9360>\n\t<150490447017.11590.17727368565733920857.stgit@john-XPS-13-9360>","CC":", ","From":"Alexei Starovoitov ","Message-ID":"<893ece6d-ac19-fd3e-aee2-f5032d2d13d8@fb.com>","Date":"Fri, 8 Sep 2017 15:40:47 -0700","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)\n\tGecko/20100101 Thunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<150490447017.11590.17727368565733920857.stgit@john-XPS-13-9360>","Content-Type":"text/plain; charset=\"utf-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[2620:10d:c090:180::1:72d0]","X-ClientProxiedBy":"BN6PR04CA0055.namprd04.prod.outlook.com\n\t(2603:10b6:405:3b::44) To DM3PR15MB0972.namprd15.prod.outlook.com\n\t(2603:10b6:0:10::26)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"03c90ae1-133c-4022-a019-08d4f70aabba","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DM3PR15MB0972; ","X-Microsoft-Exchange-Diagnostics":["1; DM3PR15MB0972;\n\t3:3iovM+sONPPqIdkrYvWxd6bf3FCPLPtSU44Ol/l5OS+s0ucWcQJPfGHKekbRhKBr769KLQOk2+nAJbf6lDV1EgiiDPVYX7BfKD1gXe+4LN/3sJIUj/+0aMiSgU3xr5pdl39CIbg9sPg3dmjQze/hlGPb1O0MVOW7qggG0SddNiVtlowG4pWzSYhNYFT2HnDRAtn8jUeX2tpl7YMaV6oHOtMm+ILaEIZhwedZx6wmJGKOAthf0liV6BnlB9AqF5Lk;\n\t25:8AiBAwRlx9Z2D9H7ifWlJ3SFEjpmgVLIQOI0w+bB9u2cXlbkyvZVff980UX8nqw8EI3QkL9AIuwzdMkTAnReS6GheUSm7HLWGBOHAKbIBPMs4sY3qEk4UUgThop/A88Og6U4rTyAHYXhWAy3d9Y7h5O24SDV1xQD7u+1h1a6npkjCmJS9J1pJZVyj4vJhrdUWxDTd3bVJMqhuhW6KespayuyDDJ75S1kysEDGZkTI+tgsDoNpfeoFMJaAgzdC9nKoQxCmAXGwHLAdVjNXvG9LlwIX0mw7m77WdomCiK81yRsMgp1maN8VPlzVIAQkechi5zhYX4bc2y5lkVpl6o/4w==;\n\t31:+kLF8+qSSZyJx4DdPr2NTNHskN4j9pfgUcAqsGKhiaKBQozncITl3yN2TGP96EKK3sth5oG1ay3T+Pex4HL2u9xguj59JggCyrHdGEWG+gf+kHrf2/wYhQLSwtWMVqhBE7pNk7aWJawj2a5ckaJMuocoYUdFNXDVSjPX/V8PcTwy0PKHIbjbQ9wJjdffpOVTN9r37J4sB35FgOo+V1T6oOWcoXA2bwqIXOk7Eo2puKE=","1; DM3PR15MB0972;\n\t20:zjp4G6t9JW8lzZZCP38Tf3jBDeddHhbrBrHoLlpXKnkL/UGHKjkofxgnizAGNc9chPRqmCoXer58arVktIXPJtkFC2UP/GuUMkRFBiQlkjwUpCEz5zre4dxcqmJjKOC0qGPVZTkHg3POJflGlSotx0O9uHYJn5Pgd3rGkSR66T5pfvFw2hMjHiQWOemwFowX14j/DDTIfdyHaXQSxLIgJBPwPTWFEkHQ+GWPYnMtGyO9i6aOqxjX57P5rBB8bYcrbfgKzDz4Q81Dv4Cr3dhN1UunuASgitGUtGoY70G2ama4SnHg+LbI6xBkih27weu/GpYXTnzjWJY/a97gknV3p3Ux0/14wJbeSh5YY2cIT/blC9I7MsoUM/LFQ16w//ahG3cBWY7ODbhSsnq17Hhp6jczM61goB3eNvABLEkzPj1vbOACz+/yJVLtdE3SvRI8iiLxPb7PZwAUtVhRzEd0CpflNcJmYdfy1IzyXLPSjcmwdw6z9+pYBN2cROr6K5YO;\n\t4:pyajDbAnbkWDtm+Z/qC4mvrZQ2POfGKnrqZO+h+MNxnOo6FpvGaGE+gCstNov28Vg/2S2RRWoTx6+lZ9cDb79pfFTkams3J6QA/x6YKQEKAwQ4TrludWNy0/GC/KQL/hvzHLpXO7gnH2T/HWVx/tS7GGhF4Yp+LohXpKhUGo+YyTsJfg5jjD1xCKoIy5GuFS0n6Fsydd57s4aEtdklojIzqTlleEq6Ixq/nxZtlwXiiwv2Rj6UymTF0OGsNhNYG02w/pakDKPGNIXCTyz2G6QQbzNJZfA+UI54htbA+4uYc=","=?utf-8?q?1=3BDM3PR15MB0972=3B23=3AodTo?=\n\t=?utf-8?q?lk7bUpHN1j3Pt+7dgdBnv7o75Qy9WsXxd34RdGvEjU85A58mKTpocH7T?=\n\t=?utf-8?q?Voe8EaRpI5jGliIdk915HNiNyM/LVUSDMsfgrQEs1Uq3DV/6C4nYXGxe?=\n\t=?utf-8?q?zDzFCMmHBWhBtecQkFrHJJWiz5QWQPC0aj6sRO69dFDonSfkUVOyRahI?=\n\t=?utf-8?q?DFqE7JfAb52O5cJtTa1YMAh9Tkatrvq0aJQ65YLJGvhyCJilTKvf4YGy?=\n\t=?utf-8?q?PNpQWvA6lGrwM/MU1KN/JH2x9A8aLWpJW4utqaubM3Bes3KmDDVnGPjc?=\n\t=?utf-8?q?T5KQAGBNz2nEeWuQrEOaZE3k7jqKCTPy1V8uqRuHXKjZ1MkosRN1vPrJ?=\n\t=?utf-8?q?fU3ZQMxDGAfo78fK+NjqMUt+42xOBRxZ2N6ccdb3Rv458ynfcIOnR8y9?=\n\t=?utf-8?q?YO8qrBeR//22D1PTOtjTrT5Xg+J86abL9cMZLFlKeEXa9nPNIQBxzc5I?=\n\t=?utf-8?q?DptVdTaQuiSmAwDgKyk2v+PFPqhy6+K8nFbvne7bO6sLAIMSLuDKyEIN?=\n\t=?utf-8?q?c36qHYgoSLISj1HUS1lTaDAl5a+bvsquMBgr7CO3fVWW/sZ15xQsqQxh?=\n\t=?utf-8?q?cps/bTYe8H4FKqx+18uM61GeQTePIMWkGiNnpo07NMjPHr6KAFCyZkOd?=\n\t=?utf-8?q?DO3NdALOeHC1UnK7hfMGlCrUpGplZ16gkkyqR9i6py1w98afyvBh3TCr?=\n\t=?utf-8?q?8rojoi6zursyE1QpKpX+kLNhk6ucTkEo8Fz+H2YqC5rAAvgg65Zg2xZe?=\n\t=?utf-8?q?cxzPH9UW0CRKMu8e5AVnaenP6kjvL6SwZ3XNgg5ral1Mm61N1V2/Fwr4?=\n\t=?utf-8?q?jq252ngOqpDs41TQq6DHCWkCiR6BzLOG9o8RBEgtFB5MAEhYE+uFUK1h?=\n\t=?utf-8?q?pGgn/4cgCgM1EN9MmWRbrt5Vq9SLRLiC02/mfVnNuEz0Hybn23sa7vzM?=\n\t=?utf-8?q?BwO+twhqG6yh+cWPrIxy5WlttY4mTc5UZBPP4o5UzMVS2n8CQMm3WwJF?=\n\t=?utf-8?q?KAb0Q8fp7OdHD0SiOHjlVt/mbvyq4utg3I8D3Ox+let4kvSjXuaTVPFJ?=\n\t=?utf-8?q?CO91Fj03JE1ElWu7an2z0b+l4LXD6IzNUDisJ3cX9RIlBoAp1CfkJGRZ?=\n\t=?utf-8?q?hfQBq79mJOeyokRLwSGsZ+s+B6xRFXmOaNF4hRGlxmjL+nvLLYtI0Gsl?=\n\t=?utf-8?q?WM4mhmXRTXgWyluX6Z1V26C2GmTDzaPX99Ebn6jh3fQTRRJ8cmXK3bvN?=\n\t=?utf-8?q?dJYIg8helcyPrDvxdEkQMsNCPvWUT+PFfRwcbKLKbTKmAWZveSCHI6xW?=\n\t=?utf-8?q?pj6YH8kH4YXl9o6FdKx8P74HqxP3T8KqM6bC/PZ9D+EX?=","1; DM3PR15MB0972;\n\t6:cfsRDhshADpPdg2E9ag+XdHLB9uk+28ldJyA0vCrS2e8ZEZNrWnV7NkKC4x3tCcx4uAxlyO+kTrGvVlj3SW0mof7avSH3qsO+rHYYsnofPNhHKe0ZnqVqQieR3rRNkC9kiXH0R9Df22a+Os/0GEZP9PDCnKtNVw0HsKvTxGBsM3+kiAlULmUxDkuW66nD1sgVQtagzrLsluUIsJpZHD5DaoTMbqyO5cm4CQtFso1Fzi7HyRUYsdrLk5GVKN7x4D4ftoJyiRLCti2XlH+PZe0PRS2Wmnt8ieppU+JZR0B+nScwXRpYxPmxpjQiiKrOJPNQfX75dNwonSMRPd03egDNA==;\n\t5:q1HTvI3gwdwjc5rbtJxKEsv6OACaMxgqm/0KRJXFiB2pC7X+Hw51KHr37bEdDNfnmK4l1FQf5NVjAQP4U+lkqvoMndE9xpRrmyvq0SqLhKSY+jXFBPtmGf5LRIgYnJ/AIhy3P+u/n0sZm/kXNJj4oQ==;\n\t24:dcKo3XqeF67ifL/i5fGapLuZNR7/cGubvqwjviTYKJv99vlQbojj9mu8FfAthYBYQspUMeFUPeB1TWf1RSmuxZjO82WeBsAGxbWSWhEXMtk=;\n\t7:r1jNq20/nZY4rNaPTQZvBCxxhtPBkrl9i6ZnV2tqtQXdoVrijcJE461HOwN6UOKbJrq7NxgobiR2JSIQC44UeGLmJbhKWchJ/kGP5poKrH2y3guDh3fUClpXZfv++6Y7pnt5fCxLWyAzY9IdqmEfpqdJdB73V59LWhi8SCxdOzBhUHps7GH9ZoI8H0ZwG9gZhONkb9uox8LXqF8/9MZYN5KUL6uvRO+j8lJFtxzXJI4=","1; DM3PR15MB0972;\n\t20:78tZyydd3hpGOKpC2b8Osez08g3tVI07sbWz9AnAYIRjrRGV40ksqM6mZM/S9o/O/gUE+pPB5MmvWOUuKWkvx+XioJE5lAO41kQwIE5JC9bOK593n0ktUy8Yi2O+HXCh8rMF8WExPQ5DhoY02+dxFNrVfMdak5b7da8lGNxOLGs="],"X-MS-TrafficTypeDiagnostic":"DM3PR15MB0972:","X-Exchange-Antispam-Report-Test":"UriScan:(788757137089);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DM3PR15MB0972; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DM3PR15MB0972; ","X-Forefront-PRVS":"04244E0DC5","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(6009001)(199003)(24454002)(377454003)(189002)(65956001)(76176999)(50466002)(50986999)(54356999)(106356001)(7736002)(2950100002)(229853002)(105586002)(65806001)(6666003)(47776003)(31686004)(478600001)(6486002)(64126003)(81156014)(8676002)(81166006)(305945005)(65826007)(8936002)(33646002)(101416001)(5660300001)(2906002)(6116002)(36756003)(189998001)(1706002)(53546010)(83506001)(97736004)(4001350100001)(25786009)(42186005)(23676002)(68736007)(110136004)(53936002)(6246003)(4326008)(31696002)(230700001)(86362001)(39060400002)(42262002);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:DM3PR15MB0972;\n\tH:[IPv6:2620:10d:c081:1130::10d2]; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: fb.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"08 Sep 2017 22:40:55.9262\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"8ae927fe-1255-47a7-a2af-5f3a069daaa2","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DM3PR15MB0972","X-OriginatorOrg":"fb.com","X-Proofpoint-Spam-Reason":"safe","X-FB-Internal":"Safe","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-08_14:, , signatures=0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]