[{"id":1765640,"web_url":"http://patchwork.ozlabs.org/comment/1765640/","msgid":"<4876e2ef-b093-cfb6-c1fd-c7f44ff891bb@fb.com>","list_archive_url":null,"date":"2017-09-08T22:38:47","subject":"Re: [net PATCH 2/3] bpf: add support for sockmap detach programs","submitter":{"id":68234,"url":"http://patchwork.ozlabs.org/api/people/68234/","name":"Alexei Starovoitov","email":"ast@fb.com"},"content":"On 9/8/17 2:00 PM, John Fastabend wrote:\n> The bpf map sockmap supports adding programs via attach commands. This\n> patch adds the detach command to keep the API symmetric and allow\n> users to remove previously added programs. Otherwise the user would\n> have to delete the map and re-add it to get in this state.\n>\n> This also adds a series of additional tests to capture detach operation\n> and also attaching/detaching invalid prog types.\n>\n> API note: socks will run (or not run) programs depending on the state\n> of the map at the time the sock is added. We do not for example walk\n> the map and remove programs from previously attached socks.\n>\n> Acked-by: Daniel Borkmann \n> Signed-off-by: John Fastabend \n\nNice clean patch. Thx\nAcked-by: Alexei Starovoitov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=fb.com header.i=@fb.com header.b=\"E04553ZQ\";\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com\n\theader.b=\"jJQW7UeU\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpsgk4vDfz9sRV\n\tfor ;\n\tSat, 9 Sep 2017 08:39:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932400AbdIHWjM (ORCPT );\n\tFri, 8 Sep 2017 18:39:12 -0400","from mx0a-00082601.pphosted.com ([67.231.145.42]:55731 \"EHLO\n\tmx0a-00082601.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753026AbdIHWjL (ORCPT\n\t); Fri, 8 Sep 2017 18:39:11 -0400","from pps.filterd (m0044012.ppops.net [127.0.0.1])\n\tby mx0a-00082601.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv88MYcgf010907; Fri, 8 Sep 2017 15:38:55 -0700","from mail.thefacebook.com ([199.201.64.23])\n\tby mx0a-00082601.pphosted.com with ESMTP id 2cuyrvrv0g-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tFri, 08 Sep 2017 15:38:54 -0700","from PRN-CHUB02.TheFacebook.com (2620:10d:c081:35::11) by\n\tPRN-CHUB11.TheFacebook.com (2620:10d:c081:35::20) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 8 Sep 2017 15:38:53 -0700","from NAM02-CY1-obe.outbound.protection.outlook.com (192.168.54.28)\n\tby o365-in.thefacebook.com (192.168.16.12) with Microsoft SMTP\n\tServer (TLS) id 14.3.319.2; Fri, 8 Sep 2017 15:38:51 -0700","from [IPv6:2620:10d:c081:1130::10d2] (2620:10d:c090:180::1:72d0) by\n\tSN2PR15MB0976.namprd15.prod.outlook.com (2603:10b6:804:20::26) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10;\n\tFri, 8 Sep 2017 22:38:50 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com;\n\th=subject : to : references\n\t: cc : from : message-id : date : mime-version : in-reply-to :\n\tcontent-type : content-transfer-encoding; s=facebook;\n\tbh=MUtdo5lcuhJNqY96FP4jkTYxXbmqTU2HcjvzljHP1b0=;\n\tb=E04553ZQ7FIesPWVXBNEzzzC0F7y8v2FO46B7SjqctCqBFGAgryZmXWVWOgbJI5g4AZo\n\tNzkJCR2uXmh4tsjgMVtS9OIYPH+ERkrxKMc7MSm+sx2TEx3+uTBjccV/4VmLS71yUaAd\n\tidMuGW2TMu/1wYTHFRjp59WxLG8hmGU20hw= ","v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; \n\ts=selector1-fb-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version; \n\tbh=MUtdo5lcuhJNqY96FP4jkTYxXbmqTU2HcjvzljHP1b0=;\n\tb=jJQW7UeUITZqRX9QrMUoLmomwl76rLxUeAVBQ4fK7GlothzRSczsJz4O8lrNaw6O6iNOKr8fbbIYaKQn3ss1QydBVx3fPhf/WnN1CMiaOI/fo+tfkFVj4TiYiebW1ZK2h/mu0F45tZW0vosBOA2nghabHlLDmEud168H5MIDYvM="],"Subject":"Re: [net PATCH 2/3] bpf: add support for sockmap detach programs","To":"John Fastabend , ","References":"<150490397545.11590.1409723973253492363.stgit@john-XPS-13-9360>\n\t<150490444956.11590.4733752227675213913.stgit@john-XPS-13-9360>","CC":", ","From":"Alexei Starovoitov ","Message-ID":"<4876e2ef-b093-cfb6-c1fd-c7f44ff891bb@fb.com>","Date":"Fri, 8 Sep 2017 15:38:47 -0700","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)\n\tGecko/20100101 Thunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<150490444956.11590.4733752227675213913.stgit@john-XPS-13-9360>","Content-Type":"text/plain; charset=\"utf-8\"; format=flowed","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[2620:10d:c090:180::1:72d0]","X-ClientProxiedBy":"CY4PR13CA0037.namprd13.prod.outlook.com\n\t(2603:10b6:903:99::23) To SN2PR15MB0976.namprd15.prod.outlook.com\n\t(2603:10b6:804:20::26)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"bca74fd5-9105-4978-e793-08d4f70a60c7","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:SN2PR15MB0976; ","X-Microsoft-Exchange-Diagnostics":["1; SN2PR15MB0976;\n\t3:fXwBY9Fos4LyJ/ThNnS6m5+yLyb5DUmTq+PUP0/yXz9PUKwFIuau9nWS6BjhBIvA9AEkDDj6yw+V+gwWQEnweAHSgno/Wq1bd1hvCbExT4HbcbsUCGjyBYHlyaZR6JXqBZeOzyApPPsivuKwr9rQ9209K8bmvQU7baz8XuTg/nMf+uc0MAjGjSuzIxT370/se7gaK/YDWp9LBRT/5OpSRmnljnSfLj4bYS4txusmh85LZwTqRXxLnRmI9ZidEPlV;\n\t25:GSs8QWmQXTqyO79045H+MnraEmkKtpUkI+SymCR4++2IGplRl1qR6VAEMKzQmi90fUZA5tloy10An3CPG65Xc1IpQmrafDYSdLpOeBxxEBd9OF8NSxIB2jyn/rttot67WBeghqP7eZ1ADKvqevu9g3lm6lwhV4eildj/1U0wevOh9PGmsQIzxbRB1HVcBf6DGpGINNRg+ohDTQV2yBhH/9jCApvGefmtxXty2ntfV/ybgZjqv5cNMKNXZY0gbAEqMrXFS+lH1QJ5Re1/cEAQd9/kiQMyOI18sSgx9tktUxIxlXrMpblDYrtMjpzFBT32+zC/pTNUSZADZKf/B2pY6g==;\n\t31:cNYEpshy4NcFOvS0jrD6olkUmap1k3scycflNMOZRjYuHMhx3FDN9OhIzzk0mnD8WmMVqVKo/M3vdMgVd1K5BcIac9srGai4tPzedwSWI4ecqPRYJf0ZGJm5vbkCQkAHPe52gIqWbtDkHyREqdVZ7cgk4nasB3EflkqJSfqgBuMx7KMDcCtdKFqALlwGXa56LNobDCeLEvXwXmWqaxbSHrCzoMtQ/1XubbAW7ts2PIY=","1; SN2PR15MB0976;\n\t20:qAklwGrnmerRz7Zlwf2jLBu4BoEvzAJCby8jdFuJn6fV6u8qPlTplh70W/yiQIwdNMrsAIeqhqDwW+hCItoW9jCsVxQabUTQIfBtNUd+Y+azEq5wMkqHs3hd+BTSU/ntnV9F0qUFlADTj7iTvpm5UsmDGZxCOg3vC5LbKEi0CHq5ChnLzEA33GQ0C0cZEoyFYUscXDsPr5lx1S7tZLGyme+u6sRUadT7piB67iD0MtsatCGAS/IdkHy5Bn9N9btK0rXnYgLc9RwjG6kWUa9CJhg0QC3HTATfKPiTCBipPuVda1xsKNyiyXXEzpxN8yM7PzkF36UA382ZpVQMbHU7oHtf/L/5UYXoC5wK0ujVRUDepVo6ELKUZU1M/FR0KFQ+9V4w47yfLhP1eIyQDtwXb6YEW/tmv3j7YUfA4hvjOwm21bAHy+3RnbwoTfOwJFI30iIuFBe8GIfLQ3ElBpmB2/m/pCFoBRxc4RAXrfXGtrOP1rdxQ3vd5Wz45NVP3NTZ;\n\t4:zHhJUrbFHKWfmvbELFnauWsJ7KRSoALZBGPD2FT+qgUHgMaEoM2ZGUXD0Tz+XCUdgziXI7qus0Z1Qhsn0SyDy0RkHq1AoCKgLfuR3BD8ViFDpes0QLEg2u8cNw9fsNjJxOjJ+5hz4kSsgSjEFWbvLN1SJrn+3FLdpJ+bb8owNsb7SVFJDDFhobDAZ6zQieMjt4kENS1PLk1YfxOJNjfdxMvddWGzE2ZTFYs8Ppmdr3kEl1JvlfnMg5hILh5uqNzB","=?utf-8?q?1=3BSN2PR15MB0976=3B23=3AAByX?=\n\t=?utf-8?q?mBUpbWOvsPHFWqUbXie0OigtjsFeglPCSg8EGwEmEUkp1PQsEedOwCxr?=\n\t=?utf-8?q?mD0a0IAiC3VcXm8p8oGMKvnGeOeGuoa901sFDN7iWgfO+0fXGtC/Unkf?=\n\t=?utf-8?q?il73ckL1qI4I8w8oaheMeOP086fy//Q+T4lqf0F9XILgL+al0djPVxNW?=\n\t=?utf-8?q?ND7xKfxN2HOOI2F0oaG5fXUDbBCwQ1mMSnKK+EXkt5f+j5Im5tfecmuU?=\n\t=?utf-8?q?7FMHwLwpEZsRH7LK0TyKoCleV3ObuVTJ4AhmZCqbB8skXOhuTIY4aIYU?=\n\t=?utf-8?q?Re1fQnDQV1hkaM5nDBMxZYlezcIPwOTGo+h5DDYSuzkkWr1SLBIO4dC4?=\n\t=?utf-8?q?VMkvXEahCgbc9mIYg2jaiwzixwC3svFr+5AqoS3sVPq0m+ZbQa1rMbz1?=\n\t=?utf-8?q?fCvss9dL3dUgvhia5pWX2MbphAxN4Aa5CTEMdC2SoO/SpeP/Xn5QGwxd?=\n\t=?utf-8?q?NpBnoqiRFhYOfW81lam1Ueze/Gvo3/Acls/L2SS+rGlVhKWNmqCNwoVj?=\n\t=?utf-8?q?SJJRIuCNFQR45W/0z8cvAotIAvABd2r5K4hL0QdgWAVYJLas8rfe9uCZ?=\n\t=?utf-8?q?TIolvVSWktfr4dacx6gttWypzyS7xMfbY1eAbmMemAqha5Jpckk08ZZ8?=\n\t=?utf-8?q?KYq1F+y3gSxJw8lUzGV8P2IC/uMeVgnTSbz9OLMzKIDKV3an4zy0hjCO?=\n\t=?utf-8?q?oBqJQRCHjNOPPqiYwd3/BoxlBsjd2LsImedbafLvjeTGhiFkuApQtmXY?=\n\t=?utf-8?q?Ro0qEOxrgvBkZXzeNVxUIR/u2gOfR6r3cgEJeUvzbuyBHxwN2mxPUnPi?=\n\t=?utf-8?q?pSUaDUbzrafA3oCGFT5aElu9S1Jut2WSygGcsSgx7TJATdYr3cH7Kugl?=\n\t=?utf-8?q?uVsMcOhT1IS/RfUsjzUfvQctFW3ODqzgHpvQWou7h33UF6Pqw3UIutC/?=\n\t=?utf-8?q?UUAn/lYyHNXq7Tk+Ok//MkQuIa68wPsCwMHJ9vnomEKp0wXOjjVQtQ6W?=\n\t=?utf-8?q?E8vQDlZV/1WeI3MvUoB/xtNgBRdhlEe8kS6BVGr9CBpzTi3JtYfmJMby?=\n\t=?utf-8?q?/FzeBQmm8vgIVQGroZCTG+znoF5N1bbh3Ab3Sg9WmCFvP5YdOxr+89xZ?=\n\t=?utf-8?q?y5NbAwXw7r5n8Du/rFpVVSzloI3BTxFXiXCFs/f6Pt084EGU9Jzh/uQG?=\n\t=?utf-8?q?OwUAXMTgnrQP/ol2391o84Ti4MdsIkiMudtAI12+nwpJcOtHnP93O5yw?=\n\t=?utf-8?q?qwZvYIBOJsVQF+tXQrCCMWg9gmV1koKqTeQtIgLDosyi56YRMwK0h/uM?=\n\t=?utf-8?q?6Ja9TnDtI0QE5UJyOnE6uCrVUjwtsDWk9hLy0Pv6Ta4Q0LX2TTKi14bF?=\n\t=?utf-8?q?dMD2xijLDQ=3D=3D?=","1; SN2PR15MB0976;\n\t6:mz9c7ykO8Zr4vxKMAHlg1dgUSjpg5XbyEJGSxy8ZdkJG/PbXe9IkrNqqsAsLaV80ASGTnGkLbsA19SgI0uKELgLlsM1N5+hclAGyQH/4cVQYm+rYreJa5I7AaN1985k/TdeR5lwhT4/C3VCgrdOcl613g/Wklaj/CR1REqNPx2FjuoVp6hfX2JDkCC/jqOKKVwcWG8lGeQVWo4x3Us+H/V6UDzg1x33H/DKekQNf+UhE/TeHLGbHLRYSZqBqf/XE1zaoAuoqly7M2qcBX7AjmJWKiVnX2g9Ylm04Vkfr/3uiuoBy5sReSmXXnLhv7wx5lZWMDJa1pufiQEUb/ysHbw==;\n\t5:nnxoqOGuXQu+oLDJZ+Kdlr9T20LHpYwiqEaaFR7vaRheLmR8mBHCPxtStolHOiTjWLBh2O66l2YsD1cuGY7fbNFczrXZKyzevV+ATnGDsVfmTsoZUEUNavJwtNplxaQHrKcmdZJUbmQFXTqu6ke9Fg==;\n\t24:EEohuOtiKJDRp5X2APqc8beRoWoABzgvdaLXSlMrak324h7/zyfihufHkoudEu7lV63srrmBQ6X4JxMVa//jji2YIX1SGsgZ9WDd9tLAj4U=;\n\t7:MuMi8rZ9JjsAUlO/KuCGt06eEka/xNHyRcbA+UwtETB+SfXh5AQeUq3A6jOCL6sw6o6oKC+5OZOBrcIbg3tt4AxV7ejWdLZbFIeYXr4UXCut8nL05s1y9VmtWUzj/0hV2ntfB9yFU17E/snw8k45V/K7B9xa0umIAFUBKSOIxIF7KWgarLTQzbVNcwETdNBA8YHyrUmcAn984PqgUey4ANSf65IB4dr7rYraQJH9IoA=","1; SN2PR15MB0976;\n\t20:mZjrYpSNqY1xtvBnMJipf0vC/EFtiNcPBHpq9yfXyZHZjPyUQfuTIllQuVAKov+TbkviAhHT4+zOGzQ2xa7suAzmzh4yLyWp1WzMzWpg41Irdn65/7gYYW/uJ1GbFdrbxI+O/AXKn5hc/zQNA6SBnp+HTVE9WQK5kaU45IdVdpc="],"X-MS-TrafficTypeDiagnostic":"SN2PR15MB0976:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6041248)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:SN2PR15MB0976; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:SN2PR15MB0976; ","X-Forefront-PRVS":"04244E0DC5","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10019020)(6009001)(377454003)(189002)(199003)(24454002)(6666003)(50466002)(65826007)(1706002)(64126003)(47776003)(4326008)(68736007)(5660300001)(25786009)(229853002)(2906002)(86362001)(189998001)(36756003)(4001350100001)(83506001)(31696002)(305945005)(7736002)(53936002)(101416001)(6246003)(110136004)(39060400002)(8676002)(81156014)(53546010)(81166006)(76176999)(54356999)(50986999)(6116002)(478600001)(5890100001)(97736004)(23676002)(33646002)(2950100002)(106356001)(230700001)(31686004)(42186005)(6486002)(65806001)(105586002)(8936002)(65956001)(42262002);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:SN2PR15MB0976;\n\tH:[IPv6:2620:10d:c081:1130::10d2]; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: fb.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"08 Sep 2017 22:38:50.1216\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"8ae927fe-1255-47a7-a2af-5f3a069daaa2","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SN2PR15MB0976","X-OriginatorOrg":"fb.com","X-Proofpoint-Spam-Reason":"safe","X-FB-Internal":"Safe","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-08_14:, , signatures=0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]