[{"id":1770474,"web_url":"http://patchwork.ozlabs.org/comment/1770474/","msgid":"","list_archive_url":null,"date":"2017-09-18T20:33:15","subject":"Re: [PATCH] omap2: hsmmc: fix logic to call either omap_hsmmc_init\n\tor omap_hsmmc_late_init but not both","submitter":{"id":42442,"url":"http://patchwork.ozlabs.org/api/people/42442/","name":"H. Nikolaus Schaller","email":"hns@goldelico.com"},"content":"Hi Tony,\nis still there on 4.14-rc1.\n\nBR,\nNikolaus\n\n> Am 08.09.2017 um 21:15 schrieb H. Nikolaus Schaller :\n> \n> With 4.13 kernel I get this boot message:\n> \n> [ 1.051727] ------------[ cut here ]------------\n> [ 1.051818] WARNING: CPU: 0 PID: 1 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x54/0x74\n> [ 1.051849] sysfs: cannot create duplicate filename '/devices/platform/omap_hsmmc.2'\n> [ 1.051879] Modules linked in:\n> [ 1.051971] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.13.0-letux+ #1360\n> [ 1.052001] Hardware name: Generic OMAP3 (Flattened Device Tree)\n> [ 1.052062] [] (unwind_backtrace) from [] (show_stack+0x10/0x14)\n> [ 1.052124] [] (show_stack) from [] (dump_stack+0x98/0xd0)\n> [ 1.052185] [] (dump_stack) from [] (__warn+0xd0/0x100)\n> [ 1.052215] [] (__warn) from [] (warn_slowpath_fmt+0x34/0x44)\n> [ 1.052276] [] (warn_slowpath_fmt) from [] (sysfs_warn_dup+0x54/0x74)\n> [ 1.052337] [] (sysfs_warn_dup) from [] (sysfs_create_dir_ns+0x74/0x84)\n> [ 1.052398] [] (sysfs_create_dir_ns) from [] (kobject_add_internal+0xd0/0x294)\n> [ 1.052429] [] (kobject_add_internal) from [] (kobject_add+0x6c/0x8c)\n> [ 1.052490] [] (kobject_add) from [] (device_add+0xe4/0x510)\n> [ 1.052551] [] (device_add) from [] (platform_device_add+0x130/0x1c0)\n> [ 1.052612] [] (platform_device_add) from [] (omap_hsmmc_late_init+0x3c/0x60)\n> [ 1.052673] [] (omap_hsmmc_late_init) from [] (omap3_pandora_legacy_init+0x24/0xb4)\n> [ 1.052734] [] (omap3_pandora_legacy_init) from [] (pdata_quirks_check+0x30/0x3c)\n> [ 1.052795] [] (pdata_quirks_check) from [] (omap_generic_init+0xc/0x18)\n> [ 1.052856] [] (omap_generic_init) from [] (customize_machine+0x1c/0x28)\n> [ 1.052917] [] (customize_machine) from [] (do_one_initcall+0xa8/0x150)\n> [ 1.052947] [] (do_one_initcall) from [] (kernel_init_freeable+0x110/0x1d4)\n> [ 1.053009] [] (kernel_init_freeable) from [] (kernel_init+0x8/0x10c)\n> [ 1.053070] [] (kernel_init) from [] (ret_from_fork+0x14/0x24)\n> [ 1.055023] ---[ end trace 44e490b09ac4ab88 ]---\n> \n> This can be traced down to the calls of\n> \n> \tomap_hsmmc_init(pandora_mmc3);\n> \tomap_hsmmc_late_init(pandora_mmc3);\n> \n> in omap3_pandora_legacy_init().\n> \n> It turns out that both funcions disagree how to decide if the other one was alredy called.\n> \n> Signed-off-by: H. Nikolaus Schaller \n> ---\n> arch/arm/mach-omap2/hsmmc.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c\n> index 5b614388d72f..6d28aa20a7d3 100644\n> --- a/arch/arm/mach-omap2/hsmmc.c\n> +++ b/arch/arm/mach-omap2/hsmmc.c\n> @@ -58,10 +58,10 @@ void omap_hsmmc_late_init(struct omap2_hsmmc_info *c)\n> \tstruct platform_device *pdev;\n> \tint res;\n> \n> -\tif (omap_hsmmc_done != 1)\n> +\tif (omap_hsmmc_done)\n> \t\treturn;\n> \n> -\tomap_hsmmc_done++;\n> +\tomap_hsmmc_done = 1;\n> \n> \tfor (; c->mmc; c++) {\n> \t\tpdev = c->pdev;\n> -- \n> 2.12.2\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"KaqmklQR\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=goldelico.com header.i=@goldelico.com\n\theader.b=\"GhrKoZuF\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwyRF4JhYz9s78\n\tfor ;\n\tTue, 19 Sep 2017 06:34:31 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1du2kN-0007Un-Sm; Mon, 18 Sep 2017 20:34:27 +0000","from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::11])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1du2kG-0007Ou-S9 for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 20:34:25 +0000","from [192.168.2.107] (p57AE0010.dip0.t-ipconnect.de [87.174.0.16])\n\tby smtp.strato.de (RZmta 41.4 DYNA|AUTH)\n\twith ESMTPSA id Z0862bt8IKXFC10\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with\n\t521 ECDH\n\tbits, eq. 15360 bits RSA)) (Client did not present a certificate);\n\tMon, 18 Sep 2017 22:33:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Date:\n\tIn-Reply-To:From:Mime-Version:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=0CRBoLI6d/5Y99cXoWIFEbSWL4arCp/vAb+ls3s4aoE=;\n\tb=KaqmklQRuw0gQi\n\twX1xONzoSQu2d0WCvjFX3jcTmHoaisJhTZLlbi2H8gMpNO+YapSk/ttHrpQyhw6f+MvEII9fbeIYx\n\twSEt1xi9qc6thFGOEun/qT2dnZ0STWkNh2nhMaWFSvo4uyrPWGSscA4dNRmLAa6GvV+Oeotmkx+Fs\n\tc5G6Rbq90OMdP54xiD1DWZw1+FfZORe7Ep1usDpSdtmqQh83zrSzKQDD7vo/VCc5nmV+ZHjVYWJnA\n\t5z3QjnciQmTpyT0USzzY+WE8SnRK00HJHDeHZ0JGF8Xa4Pu3IBMkJHSOnNLp5Uye3Cv3ty4epCNxe\n\t+T3z26t8hgnc31tj8Uww==;","v=1; a=rsa-sha256; c=relaxed/relaxed; t=1505766826;\n\ts=domk; d=goldelico.com;\n\th=To:References:Content-Transfer-Encoding:Cc:Date:In-Reply-To:From:\n\tContent-Type:Mime-Version:Subject;\n\tbh=UMJWRIWp5U0v7h92wOQhwJlGHlw/9SNmTqkmMIxOazw=;\n\tb=GhrKoZuFjRh4zLd/LsEQLQHNMVAN9DL4H1RF3dDMz82eEe4urm38iRQqVLpb0nf65Z\n\tvwQMC9sYxu20kGKxyOL3kjg4EwE0XwtTbKoNPx0GdEzhAFRFGf0F5kzFOA/92F9ILXEE\n\tH9hc9wX7+ZVNAUjgPmN1HcJu2mFcS24RZKlZw="],"X-RZG-AUTH":":JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mSAGQ+qKID4oI1eB","X-RZG-CLASS-ID":"mo00","Subject":"Re: [PATCH] omap2: hsmmc: fix logic to call either omap_hsmmc_init\n\tor omap_hsmmc_late_init but not both","Mime-Version":"1.0 (Mac OS X Mail 9.3 \\(3124\\))","From":"\"H. Nikolaus Schaller\" ","In-Reply-To":"","Date":"Mon, 18 Sep 2017 22:33:15 +0200","Message-Id":"","References":"","To":"Tony Lindgren ","X-Mailer":"Apple Mail (2.3124)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_133421_103271_ABF9649A ","X-CRM114-Status":"GOOD ( 14.47 )","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2a01:238:20a:202:5300:0:0:11 listed in] [list.dnswl.org]\n\t-0.0 SPF_HELO_PASS SPF: HELO matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Discussions about the Letux Kernel ,\n\tlinux-omap ,\n\tlinux-kernel ,\n\tlinux-arm-kernel ,\n\tRussell King ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1771240,"web_url":"http://patchwork.ozlabs.org/comment/1771240/","msgid":"<20170919174702.GC5024@atomide.com>","list_archive_url":null,"date":"2017-09-19T17:47:02","subject":"Re: [PATCH] omap2: hsmmc: fix logic to call either omap_hsmmc_init\n\tor omap_hsmmc_late_init but not both","submitter":{"id":365,"url":"http://patchwork.ozlabs.org/api/people/365/","name":"Tony Lindgren","email":"tony@atomide.com"},"content":"* H. Nikolaus Schaller [170918 13:34]:\n> Hi Tony,\n> is still there on 4.14-rc1.\n\nApplying into omap-for-v4.14/fixes thanks.\n\nTony","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"W36fdEJc\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxVh46j2Tz9rvt\n\tfor ;\n\tWed, 20 Sep 2017 03:47:32 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duMcL-0005It-GD; Tue, 19 Sep 2017 17:47:29 +0000","from muru.com ([72.249.23.125])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duMcI-0005Ga-2a for linux-arm-kernel@lists.infradead.org;\n\tTue, 19 Sep 2017 17:47:27 +0000","from atomide.com (localhost [127.0.0.1])\n\tby muru.com (Postfix) with ESMTPS id F10F28207;\n\tTue, 19 Sep 2017 17:47:50 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=mj5c1pokEN6V/+7EvYkPfgOxcf8Po5OG2xW8qRMLtWY=;\n\tb=W36fdEJc6r1zkX\n\tuzlpfwvI4mdAHbZ3pEoMP2GC0k6rg2ulmgeyWiJ9/9HDuKNsFyc0bIrp3v9NO69MLWasMCJ77myKf\n\tvEqBJoSqjDT8wiTS8yMfzLn6CgXD+SqnZ/22URzRFIkxvHOeQvJJCyGbG+H4lOIHlZYtLFr5TnCBP\n\tKznC/KNMkkbaX70fRRUElx1X3Ou+ob4bXaXolRzKxkfu4BJdwXG/eUwb+/FSjM9pb9Fr5oV1kjntC\n\tFNqp5pn8yUZt22EvrS6RJzbMvLHsaxbXkSvKHKWwpnJ+VcbuN+l8GkkMPG2AyUGbOOL0w75xYw+uO\n\teR88uD2uI58gKJY6WSgA==;","Date":"Tue, 19 Sep 2017 10:47:02 -0700","From":"Tony Lindgren ","To":"\"H. Nikolaus Schaller\" ","Subject":"Re: [PATCH] omap2: hsmmc: fix logic to call either omap_hsmmc_init\n\tor omap_hsmmc_late_init but not both","Message-ID":"<20170919174702.GC5024@atomide.com>","References":"\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_104726_177642_90800677 ","X-CRM114-Status":"UNSURE ( 5.46 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Discussions about the Letux Kernel ,\n\tlinux-omap ,\n\tlinux-kernel ,\n\tlinux-arm-kernel ,\n\tRussell King ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]