[{"id":1766372,"web_url":"http://patchwork.ozlabs.org/comment/1766372/","msgid":"","list_archive_url":null,"date":"2017-09-11T15:56:20","subject":"Re: [ovs-dev] [PATCH] ovn-nbctl: fix validation logic for acl-del\n\tcommand","submitter":{"id":71978,"url":"http://patchwork.ozlabs.org/api/people/71978/","name":"Mark Michelson","email":"mmichels@redhat.com"},"content":"On Fri, Sep 8, 2017 at 1:57 PM Han Zhou wrote:\n\n> The command error message is misleading, e.g.:\n>\n> $ ovn-nbctl acl-del ls1 100 'outport==\"lsp1\" && ip4'\n> ovn-nbctl: cannot specify priority without match\n>\n> $ ovn-nbctl acl-del ls1 to-lport 'outport==\"lsp1\" && ip4'\n> ovn-nbctl: cannot specify priority without match\n>\n> This patch fixes the problem.\n> $\n> $ ovn-nbctl acl-del ls1 100 'outport==\"lsp1\" && ip4'\n\n\n> Signed-off-by: Han Zhou \n>\nAcked-by: Mark Michelson \n\n> ---\n> ovn/utilities/ovn-nbctl.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c\n> index 46ede4e..8e5c1a4 100644\n> --- a/ovn/utilities/ovn-nbctl.c\n> +++ b/ovn/utilities/ovn-nbctl.c\n> @@ -1469,10 +1469,6 @@ nbctl_acl_del(struct ctl_context *ctx)\n> const struct nbrec_logical_switch *ls;\n> ls = ls_by_name_or_uuid(ctx, ctx->argv[1], true);\n>\n> - if (ctx->argc != 2 && ctx->argc != 3 && ctx->argc != 5) {\n> - ctl_fatal(\"cannot specify priority without match\");\n> - }\n> -\n> if (ctx->argc == 2) {\n> /* If direction, priority, and match are not specified, delete\n> * all ACLs. */\n> @@ -1503,6 +1499,10 @@ nbctl_acl_del(struct ctl_context *ctx)\n>\n> int64_t priority = parse_priority(ctx->argv[3]);\n>\n> + if (ctx->argc == 4) {\n> + ctl_fatal(\"cannot specify priority without match\");\n> + }\n> +\n> /* Remove the matching rule. */\n> for (size_t i = 0; i < ls->n_acls; i++) {\n> struct nbrec_acl *acl = ls->acls[i];\n> --\n> 2.1.0\n>\n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrXbm17cHz9s1h\n\tfor ;\n\tTue, 12 Sep 2017 01:56:35 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id B94F8AB7;\n\tMon, 11 Sep 2017 15:56:32 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 00E3BA88\n\tfor ; Mon, 11 Sep 2017 15:56:32 +0000 (UTC)","from mail-it0-f49.google.com (mail-it0-f49.google.com\n\t[209.85.214.49])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7AF3BA4\n\tfor ; Mon, 11 Sep 2017 15:56:31 +0000 (UTC)","by mail-it0-f49.google.com with SMTP id 6so15929719itl.1\n\tfor ; Mon, 11 Sep 2017 08:56:31 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to;\n\tbh=rpiPi1flC5WDOWb1sSXBG+9UtIiDlAej84HmVaG+Tlw=;\n\tb=pTFvauM2OrHSEoW+4rwoBD2Doyzo/wHy/EvbFlKKbFFTTT2U6DdNx2NYt4GD0lideq\n\taWpijlnEEL1OeWqfI4FV/ou0FwcZv075LU48EsfydIpUfdn2ida2HdEKgKSjIGuIuH1O\n\t/6zSZ4JyzAOHY+lfhpxB8j1ECG7uB+4bWgIXm2AF8yX4ALKCgBR8vS3/N/Jws9SRkE8b\n\tkgaLcOfU2GM05rEswVasiu7eCfa2J9Raq7Y1dtdrYGD2KSrWcEihv2lMBaIV8fUzYFWk\n\tFB6HxL+eGkjdMSjofzaYTScrzedmGqnIibDLtg+FbKZhJsb7FPRQUbcqc7zba+fLG7DK\n\ta6Mw==","X-Gm-Message-State":"AHPjjUhOac6VSLyqt9Pc+5j0TVknmK4cWlJrs+jA6tKDZhQHM8pGaH88\n\teWg8q9zAZfDJwtTBWcv8P78jQxDbQw7+vj40QLEQNQ==","X-Google-Smtp-Source":"ADKCNb4XpfYfxERHL2LemLC91TmZrdYAcpT+sX2glhMwPUXJEJRHdkAYyP9uVxe6PI/iPrFOsQlYRJZHm+jvcCwHSfs=","X-Received":"by 10.36.185.9 with SMTP id w9mr15066839ite.75.1505145390866;\n\tMon, 11 Sep 2017 08:56:30 -0700 (PDT)","MIME-Version":"1.0","References":"<1504896980-37224-1-git-send-email-zhouhan@gmail.com>","In-Reply-To":"<1504896980-37224-1-git-send-email-zhouhan@gmail.com>","From":"Mark Michelson ","Date":"Mon, 11 Sep 2017 15:56:20 +0000","Message-ID":"","To":"Han Zhou , dev@openvswitch.org","X-Spam-Status":"No, score=0.5 required=5.0 tests=HTML_MESSAGE,\n\tRCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","X-Content-Filtered-By":"Mailman/MimeDel 2.1.12","Subject":"Re: [ovs-dev] [PATCH] ovn-nbctl: fix validation logic for acl-del\n\tcommand","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766423,"web_url":"http://patchwork.ozlabs.org/comment/1766423/","msgid":"<107A2A03-0D0C-4C22-87DF-600A58B5BD6D@ovn.org>","list_archive_url":null,"date":"2017-09-11T17:45:51","subject":"Re: [ovs-dev] [PATCH] ovn-nbctl: fix validation logic for acl-del\n\tcommand","submitter":{"id":67602,"url":"http://patchwork.ozlabs.org/api/people/67602/","name":"Justin Pettit","email":"jpettit@ovn.org"},"content":"> On Sep 8, 2017, at 11:56 AM, Han Zhou wrote:\n> \n> The command error message is misleading, e.g.:\n> \n> $ ovn-nbctl acl-del ls1 100 'outport==\"lsp1\" && ip4'\n> ovn-nbctl: cannot specify priority without match\n> \n> $ ovn-nbctl acl-del ls1 to-lport 'outport==\"lsp1\" && ip4'\n> ovn-nbctl: cannot specify priority without match\n> \n> This patch fixes the problem.\n> $\n> $ ovn-nbctl acl-del ls1 100 'outport==\"lsp1\" && ip4'\n> \n> Signed-off-by: Han Zhou \n\nThanks. I pushed this to master.\n\n--Justin","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrb1z3pHMz9s81\n\tfor ;\n\tTue, 12 Sep 2017 03:45:58 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 5BE69A74;\n\tMon, 11 Sep 2017 17:45:56 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id CC3728DC\n\tfor ; Mon, 11 Sep 2017 17:45:54 +0000 (UTC)","from mail-pf0-f177.google.com (mail-pf0-f177.google.com\n\t[209.85.192.177])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 75732E0\n\tfor ; Mon, 11 Sep 2017 17:45:54 +0000 (UTC)","by mail-pf0-f177.google.com with SMTP id q76so1392065pfq.2\n\tfor ; Mon, 11 Sep 2017 10:45:54 -0700 (PDT)","from [10.0.1.5] ([98.234.50.139]) by smtp.gmail.com with ESMTPSA id\n\ty16sm18261203pge.92.2017.09.11.10.45.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 10:45:52 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc\n\t:content-transfer-encoding:message-id:references:to;\n\tbh=2OZCqFm1YuR87+1VyqjWrRfuscY5J2Tgh4JWJN4Nk5c=;\n\tb=HZkScskhFEeBGoeBqTR+dowpacjBIeGDROvyeR6eRNtr590UcmA8qQZaHtQpUu2Bda\n\t2CB62YuFptpu9VHs5hAhNLvVBMRhecX8fdC+ft29WNyydzv1xTqFwskDGx9DGTfA4IUU\n\tl5Fb+twOqFzRUa/5oDebPNDm15qcCY+A3DaUwBft3T79O2HOnZmSBMjBWNwArXLdWMNV\n\tQLqGfGhNDuFwVyrKR4mbCR1m62sAfcqfxutbwC3K/X15SJjZopqFR3+Rn5zDBEviN+O0\n\t1t/Hn4JI89/l6nu2bG+2+nd1K99faD3P7LjKMrQ2vgXkOeE6tUkFsV6UtSpMMUz0AAKf\n\tY9eg==","X-Gm-Message-State":"AHPjjUj2mpXwzHfJlMKqZChd5ZP96gjSBI8OidmmngdUZlYbtHxBdwx7\n\t6pUXCIrheVnRvA==","X-Google-Smtp-Source":"ADKCNb7WtUMZreJgPZX9sb0oN7OuyOehHhP+S+Sv+49h6bHNIhrOF/ih7Lr7iKW+T7b9u59unLzsLg==","X-Received":"by 10.84.232.72 with SMTP id f8mr14355276pln.269.1505151953903; \n\tMon, 11 Sep 2017 10:45:53 -0700 (PDT)","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"Justin Pettit ","In-Reply-To":"<1504896980-37224-1-git-send-email-zhouhan@gmail.com>","Date":"Mon, 11 Sep 2017 10:45:51 -0700","Message-Id":"<107A2A03-0D0C-4C22-87DF-600A58B5BD6D@ovn.org>","References":"<1504896980-37224-1-git-send-email-zhouhan@gmail.com>","To":"Han Zhou ","X-Mailer":"Apple Mail (2.3273)","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] ovn-nbctl: fix validation logic for acl-del\n\tcommand","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1766431,"web_url":"http://patchwork.ozlabs.org/comment/1766431/","msgid":"","list_archive_url":null,"date":"2017-09-11T17:57:19","subject":"Re: [ovs-dev] [PATCH] ovn-nbctl: fix validation logic for acl-del\n\tcommand","submitter":{"id":67602,"url":"http://patchwork.ozlabs.org/api/people/67602/","name":"Justin Pettit","email":"jpettit@ovn.org"},"content":"> On Sep 11, 2017, at 8:56 AM, Mark Michelson wrote:\n> \n> On Fri, Sep 8, 2017 at 1:57 PM Han Zhou wrote:\n> \n>> The command error message is misleading, e.g.:\n>> \n>> $ ovn-nbctl acl-del ls1 100 'outport==\"lsp1\" && ip4'\n>> ovn-nbctl: cannot specify priority without match\n>> \n>> $ ovn-nbctl acl-del ls1 to-lport 'outport==\"lsp1\" && ip4'\n>> ovn-nbctl: cannot specify priority without match\n>> \n>> This patch fixes the problem.\n>> $\n>> $ ovn-nbctl acl-del ls1 100 'outport==\"lsp1\" && ip4'\n> \n> \n>> Signed-off-by: Han Zhou \n>> \n> Acked-by: Mark Michelson \n\nI missed your acked-by before I pushed it. Sorry about that, Mark!\n\n--Justin","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrbSj6Mpqz9s83\n\tfor ;\n\tTue, 12 Sep 2017 04:05:41 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 4D137BC8;\n\tMon, 11 Sep 2017 17:57:23 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 491F1B8C\n\tfor ; Mon, 11 Sep 2017 17:57:22 +0000 (UTC)","from mail-pf0-f193.google.com (mail-pf0-f193.google.com\n\t[209.85.192.193])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 0630A180\n\tfor ; Mon, 11 Sep 2017 17:57:21 +0000 (UTC)","by mail-pf0-f193.google.com with SMTP id h4so5200908pfk.0\n\tfor ; Mon, 11 Sep 2017 10:57:21 -0700 (PDT)","from [10.0.1.5] ([98.234.50.139]) by smtp.gmail.com with ESMTPSA id\n\tl85sm18062108pfb.176.2017.09.11.10.57.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 10:57:20 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc\n\t:content-transfer-encoding:message-id:references:to;\n\tbh=+3npYY1n0wLl82aVg0c+VCGuUb+C5cKGjm5pt4fQJDg=;\n\tb=UDOeC0d+gTYOvG82U4X7HeMjZLEpwh4oCYueWYQ6q+4Nhu/UOpV52N8DCLdwBTGJlT\n\temYE39DHGSkSDeRcp3yS+B+yNF/PnuUCz9MP6iyE1gzBfeSSTcqNYQiiVaP1RqxyP04p\n\toJuYNv7ZhAYJWbvZoyhhH45u70N4qwvW7WdZx7D+obcqNcXGORusdfiGBZJfQ7Ytqvy1\n\tPZFU9Z3hkrWo32XMuwpiPWfe1hEsqk8fe63EOeKF9j9EoSsDJg5x543Cn/PBt2LKI9/i\n\tr/stHFOaauOsKyH6SyPhwUFsKrR8y0uD0TEexlLnBLrNTSP3Cs+OEteoJ1Kv8FfLPX/w\n\txXqg==","X-Gm-Message-State":"AHPjjUgvZ+pLmKZAUe/HXvK327Zn6UwWwaAv4WevOKYko2M9/jv3TLJc\n\teOoFNXYlW7WhVw==","X-Google-Smtp-Source":"ADKCNb4NzH8JZ7ULabeYOy6QHPPQPJJze1a12crOQ+6mZy6DeulIBXV81eFqin8aLuF71C/0+oWBXw==","X-Received":"by 10.84.129.226 with SMTP id b89mr14143000plb.193.1505152641625;\n\tMon, 11 Sep 2017 10:57:21 -0700 (PDT)","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"Justin Pettit ","In-Reply-To":"","Date":"Mon, 11 Sep 2017 10:57:19 -0700","Message-Id":"","References":"<1504896980-37224-1-git-send-email-zhouhan@gmail.com>\n\t","To":"Mark Michelson ","X-Mailer":"Apple Mail (2.3273)","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] ovn-nbctl: fix validation logic for acl-del\n\tcommand","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]