[{"id":1769329,"web_url":"http://patchwork.ozlabs.org/comment/1769329/","msgid":"<06a479bd-946a-2888-faa4-38b3c3d0cef2@gmail.com>","list_archive_url":null,"date":"2017-09-15T17:42:34","subject":"Re: [ovs-dev] [PATCH 13/13] ofproto-dpif-xlate: Fix dead assignment\n\treported by clang.","submitter":{"id":69140,"url":"http://patchwork.ozlabs.org/api/people/69140/","name":"Gregory Rose","email":"gvrose8192@gmail.com"},"content":"On 09/08/2017 10:59 AM, Bhanuprakash Bodireddy wrote:\n> Clang reports that value stored in to ac_offset is never read in the\n> function.\n> \n> Signed-off-by: Bhanuprakash Bodireddy \n> ---\n> ofproto/ofproto-dpif-xlate.c | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c\n> index 9e1f837..5d83666 100644\n> --- a/ofproto/ofproto-dpif-xlate.c\n> +++ b/ofproto/ofproto-dpif-xlate.c\n> @@ -5370,7 +5370,6 @@ compose_clone(struct xlate_ctx *ctx, const struct ofpact_nest *oc)\n> if (ctx->xbridge->support.clone) { /* Use clone action */\n> /* Use clone action as datapath clone. */\n> offset = nl_msg_start_nested(ctx->odp_actions, OVS_ACTION_ATTR_CLONE);\n> - ac_offset = ctx->odp_actions->size;\n> do_xlate_actions(oc->actions, oc_actions_len, ctx);\n> nl_msg_end_non_empty_nested(ctx->odp_actions, offset);\n> goto dp_clone_done;\n> \n\nNot in this section of code anyway.\n\nLooks good.\n\nReviewed-by: Greg Rose ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UbbVbinG\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv2mK1b0Fz9s7c\n\tfor ;\n\tSat, 16 Sep 2017 03:42:41 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id ABB97AF4;\n\tFri, 15 Sep 2017 17:42:39 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id EAA9AABC\n\tfor ; Fri, 15 Sep 2017 17:42:37 +0000 (UTC)","from mail-pg0-f54.google.com (mail-pg0-f54.google.com\n\t[74.125.83.54])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 86BF43D8\n\tfor ; Fri, 15 Sep 2017 17:42:37 +0000 (UTC)","by mail-pg0-f54.google.com with SMTP id c137so1898255pga.11\n\tfor ; Fri, 15 Sep 2017 10:42:37 -0700 (PDT)","from gizo.bigblue.kilchis.com (67-5-132-83.ptld.qwest.net.\n\t[67.5.132.83]) by smtp.gmail.com with ESMTPSA id\n\tb68sm3478991pfk.23.2017.09.15.10.42.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 10:42:35 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=Km2cbeaKpC7D6Zu6c2w95uCFxRifFclhL5VtdhJfc8M=;\n\tb=UbbVbinG+0L1CcAJb49LwomHSYmr0uJieHuzYv9xBB72/mT3VpzPgW5kOTMj8IJDHq\n\tKcQWMs92AirU613+PDj++gcSk3bWi8vxGXpMn9xxSJX8uIZxk0iDcWptvaiRUnfdazKb\n\tn11rlNuqcr9z9QBtfyxWe8OeXDUBvylKFdBJh+twtqYfBrhL/W3/lToQyJHQbmdfuamC\n\tGOzHzDveRkTjnvhnFZ8p7U4w+OtAapqme1lhNfVN/l3ffGHRpqtQsrcd6DLxm3H56X8n\n\tejCL8Hrv2HnpGgTkiNIZXbfHIlEW/FQlldjtaV6JtM33DGp3eFqsbq1S8M8bZu9EYfPb\n\tZzLA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=Km2cbeaKpC7D6Zu6c2w95uCFxRifFclhL5VtdhJfc8M=;\n\tb=Q+EDE9dX0JfHQJjO6/7eFjidZM3RSd+Mfhp5yDKw83rpPA+sPzrLtTrOH4Gvbd66wD\n\t9+EG4nOvWc0VxN6JjtbRMO4vFq8FGBt9fNzMuYvf4GjtZaRAn9bLuEyteha31NgC6uua\n\tj6qCk7lWgKtYtnBOW2mHsMPh/572xcWcxCrwn3b2lckxwEbgi7jU5AkpgruBVFc4z2gi\n\tJAJdtiH/8DKjMTYFn5PKEKx9NPBvQJvJA0beQ4gRA/mEyxj1eJWA6tOp3wjXJbqL9zAQ\n\t8TihkA+Z2i+eh7gsgPWNi8GZeYesjkB6JpPcO6kuuzgevqK/k6H0shP4mIhmGaqsI+GS\n\tujpw==","X-Gm-Message-State":"AHPjjUhm1Ynk+cU4UlMOykZ965dm/vTy3LS3b2KxSCYcyLKMqv5jRXKR\n\t12r1tc/h9w2YhKXkC1I=","X-Google-Smtp-Source":"ADKCNb4XvTtd2jRPx6C3qksblExEjA3WDc+dc3PtzwAMNzuZ/uBbwvU7YtIIEVok+JB9ef1Xs1/hLA==","X-Received":"by 10.84.252.130 with SMTP id y2mr27463153pll.68.1505497356675; \n\tFri, 15 Sep 2017 10:42:36 -0700 (PDT)","To":"Bhanuprakash Bodireddy ,\n\tdev@openvswitch.org","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-14-git-send-email-bhanuprakash.bodireddy@intel.com>","From":"Greg Rose ","Message-ID":"<06a479bd-946a-2888-faa4-38b3c3d0cef2@gmail.com>","Date":"Fri, 15 Sep 2017 10:42:34 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"<1504893565-110166-14-git-send-email-bhanuprakash.bodireddy@intel.com>","Content-Language":"en-US","X-Spam-Status":"No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 13/13] ofproto-dpif-xlate: Fix dead assignment\n\treported by clang.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1798881,"web_url":"http://patchwork.ozlabs.org/comment/1798881/","msgid":"<20171103200917.GJ27530@ovn.org>","list_archive_url":null,"date":"2017-11-03T20:09:17","subject":"Re: [ovs-dev] [PATCH 13/13] ofproto-dpif-xlate: Fix dead assignment\n\treported by clang.","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Fri, Sep 08, 2017 at 06:59:25PM +0100, Bhanuprakash Bodireddy wrote:\n> Clang reports that value stored in to ac_offset is never read in the\n> function.\n> \n> Signed-off-by: Bhanuprakash Bodireddy \n\nIt looks like this has been obsoleted by later patches.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yTCkK0cp3z9sNV\n\tfor ;\n\tSat, 4 Nov 2017 07:10:33 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 712F2D93;\n\tFri, 3 Nov 2017 20:09:25 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id BAC6ED86\n\tfor ; Fri, 3 Nov 2017 20:09:23 +0000 (UTC)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 5E8B0550\n\tfor ; Fri, 3 Nov 2017 20:09:23 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id DA8D0FB87E;\n\tFri, 3 Nov 2017 21:09:20 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Fri, 3 Nov 2017 13:09:17 -0700","From":"Ben Pfaff ","To":"Bhanuprakash Bodireddy ","Message-ID":"<20171103200917.GJ27530@ovn.org>","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-14-git-send-email-bhanuprakash.bodireddy@intel.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504893565-110166-14-git-send-email-bhanuprakash.bodireddy@intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH 13/13] ofproto-dpif-xlate: Fix dead assignment\n\treported by clang.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]