[{"id":1798873,"web_url":"http://patchwork.ozlabs.org/comment/1798873/","msgid":"<20171103200456.GE27530@ovn.org>","list_archive_url":null,"date":"2017-11-03T20:04:56","subject":"Re: [ovs-dev] [PATCH 11/13] ofproto: Reorder elements in\n\tofproto_bundle_settings structure.","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Fri, Sep 08, 2017 at 06:59:23PM +0100, Bhanuprakash Bodireddy wrote:\n> By reordering elements in ofproto_bundle_settings structure, sum holes\n> and pad bytes can be reduced.\n> \n> Before: structure size: 96, sum holes: 13, pad bytes: 7, cachelines:2\n> After : structure size: 80, sum holes: 4, pad bytes: 0, cachelines:2\n> \n> Signed-off-by: Bhanuprakash Bodireddy \n> ---\n> ofproto/ofproto.h | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/ofproto/ofproto.h b/ofproto/ofproto.h\n> index 9e35327..2a7c1f3 100644\n> --- a/ofproto/ofproto.h\n> +++ b/ofproto/ofproto.h\n> @@ -403,18 +403,17 @@ struct ofproto_bundle_settings {\n> size_t n_slaves;\n> \n> enum port_vlan_mode vlan_mode; /* Selects mode for vlan and trunks */\n> + bool protected; /* Protected port mode */\n> + bool use_priority_tags; /* Use 802.1p tag for frames in VLAN 0? */\n> uint16_t qinq_ethtype;\n> int vlan; /* VLAN VID, except for PORT_VLAN_TRUNK. */\n> unsigned long *trunks; /* vlan_bitmap, except for PORT_VLAN_ACCESS. */\n> unsigned long *cvlans;\n> - bool use_priority_tags; /* Use 802.1p tag for frames in VLAN 0? */\n> \n> struct bond_settings *bond; /* Must be nonnull iff if n_slaves > 1. */\n> \n> struct lacp_settings *lacp; /* Nonnull to enable LACP. */\n> struct lacp_slave_settings *lacp_slaves; /* Array of n_slaves elements. */\n> -\n> - bool protected; /* Protected port mode */\n> };\n\nI'm planning to skip this one for the same reason as the previous patches.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yTCc20tn5z9sBW\n\tfor ;\n\tSat, 4 Nov 2017 07:05:06 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id EC1E6D62;\n\tFri, 3 Nov 2017 20:05:03 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id E9CE18F5\n\tfor ; Fri, 3 Nov 2017 20:05:02 +0000 (UTC)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id DAD4054F\n\tfor ; Fri, 3 Nov 2017 20:05:01 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 98A0E41C07F;\n\tFri, 3 Nov 2017 21:04:59 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Fri, 3 Nov 2017 13:04:56 -0700","From":"Ben Pfaff ","To":"Bhanuprakash Bodireddy ","Message-ID":"<20171103200456.GE27530@ovn.org>","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-12-git-send-email-bhanuprakash.bodireddy@intel.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504893565-110166-12-git-send-email-bhanuprakash.bodireddy@intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH 11/13] ofproto: Reorder elements in\n\tofproto_bundle_settings structure.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]