[{"id":1798872,"web_url":"http://patchwork.ozlabs.org/comment/1798872/","msgid":"<20171103200404.GD27530@ovn.org>","list_archive_url":null,"date":"2017-11-03T20:04:04","subject":"Re: [ovs-dev] [PATCH 10/13] ofproto: Reorder elements in\n\tofproto_ipfix_flow_exporter_options structure.","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Fri, Sep 08, 2017 at 06:59:22PM +0100, Bhanuprakash Bodireddy wrote:\n> By reordering elements in ofproto_ipfix_flow_exporter_options structure,\n> sum holes can be reduced significantly.\n> \n> Before: structure size: 64, sum holes: 11, cachelines:1\n> After : structure size: 56, sum holes: 3, cachelines:1\n> \n> Signed-off-by: Bhanuprakash Bodireddy \n> ---\n> ofproto/ofproto.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/ofproto/ofproto.h b/ofproto/ofproto.h\n> index 1e48e19..9e35327 100644\n> --- a/ofproto/ofproto.h\n> +++ b/ofproto/ofproto.h\n> @@ -87,10 +87,10 @@ struct ofproto_ipfix_bridge_exporter_options {\n> \n> struct ofproto_ipfix_flow_exporter_options {\n> uint32_t collector_set_id;\n> + bool enable_tunnel_sampling;\n> struct sset targets;\n> uint32_t cache_active_timeout;\n> uint32_t cache_max_flows;\n> - bool enable_tunnel_sampling;\n> char *virtual_obs_id;\n> };\n\nThis is another case where performance isn't important and I think that\nthe current ordering is clearer, so I'll skip this one.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yTCb13pDLz9sBW\n\tfor ;\n\tSat, 4 Nov 2017 07:04:13 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id D8122D59;\n\tFri, 3 Nov 2017 20:04:11 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 1006B8F5\n\tfor ; Fri, 3 Nov 2017 20:04:11 +0000 (UTC)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9867654D\n\tfor ; Fri, 3 Nov 2017 20:04:10 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 1DB43C5A46;\n\tFri, 3 Nov 2017 21:04:06 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Fri, 3 Nov 2017 13:04:04 -0700","From":"Ben Pfaff ","To":"Bhanuprakash Bodireddy ","Message-ID":"<20171103200404.GD27530@ovn.org>","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-11-git-send-email-bhanuprakash.bodireddy@intel.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504893565-110166-11-git-send-email-bhanuprakash.bodireddy@intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH 10/13] ofproto: Reorder elements in\n\tofproto_ipfix_flow_exporter_options structure.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]