[{"id":1769319,"web_url":"http://patchwork.ozlabs.org/comment/1769319/","msgid":"<7dc99933-5183-b187-8787-81a7c2bb3112@gmail.com>","list_archive_url":null,"date":"2017-09-15T17:27:58","subject":"Re: [ovs-dev] [PATCH 02/13] netdev-dummy: Reorder elements in\n\tdummy_packet_stream structure.","submitter":{"id":69140,"url":"http://patchwork.ozlabs.org/api/people/69140/","name":"Gregory Rose","email":"gvrose8192@gmail.com"},"content":"On 09/08/2017 10:59 AM, Bhanuprakash Bodireddy wrote:\n> By reordering elements in dummy_packet_stream structure, sum holes\n\nDo you mean \"the sum of the holes\" can be reduced or do you mean \"some holes\"\ncan be reduced?\n\nSame question through several of the other patches where you use the same\nlanguage.\n\nThanks,\n\n- Greg\n\n> can be reduced, thus saving a cache line.\n> \n> Before: structure size: 784, sum holes: 56, cachelines:13\n> After : structure size: 768, sum holes: 40, cachelines:12\n> \n> Signed-off-by: Bhanuprakash Bodireddy \n> ---\n> lib/netdev-dummy.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c\n> index f731af1..d888c40 100644\n> --- a/lib/netdev-dummy.c\n> +++ b/lib/netdev-dummy.c\n> @@ -50,8 +50,8 @@ struct reconnect;\n> \n> struct dummy_packet_stream {\n> struct stream *stream;\n> - struct dp_packet rxbuf;\n> struct ovs_list txq;\n> + struct dp_packet rxbuf;\n> };\n> \n> enum dummy_packet_conn_type {\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"gdI8dvSC\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv2RV1sR3z9sNc\n\tfor ;\n\tSat, 16 Sep 2017 03:28:05 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id AE342ABB;\n\tFri, 15 Sep 2017 17:28:03 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id C9C73A64\n\tfor ; Fri, 15 Sep 2017 17:28:02 +0000 (UTC)","from mail-pf0-f194.google.com (mail-pf0-f194.google.com\n\t[209.85.192.194])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7268C3CB\n\tfor ; Fri, 15 Sep 2017 17:28:02 +0000 (UTC)","by mail-pf0-f194.google.com with SMTP id q76so1508953pfq.5\n\tfor ; Fri, 15 Sep 2017 10:28:02 -0700 (PDT)","from gizo.bigblue.kilchis.com (67-5-132-83.ptld.qwest.net.\n\t[67.5.132.83]) by smtp.gmail.com with ESMTPSA id\n\tc185sm3335373pfb.57.2017.09.15.10.27.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 15 Sep 2017 10:28:00 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=/0Oo3lyY6+1qx+MmGM6pb1j6JcWl/RSkQjjesNs9nqw=;\n\tb=gdI8dvSCyyVDkuhTQG3Htxs2twHVlmh+T1rtCqdwiiUIV0hHTXzYkpz/QI2lZb8Xt/\n\tdgfFNG7mifFBrru7OlTqwnTf7ufPIrYK3bXpeDJwo3WsiFAbpZMtjOHXoT8dFGF4VcNW\n\tjLPmUdl8Li/ldwf/9d0oXK3ZlS4xWlcX1EjIl1s9OcWkPOk1rfwPB/Ye20xUawm0+coY\n\tpR09pHUDzFoPCIo9xbKdjXTX3J6CmWkVaqNdUaQFChMpo/Bhr1ttKB6n1TbZRq1FCXd6\n\trOwDDRu/sQA0FW733O9YvBrinuDNqgMfwsu6QnQvUNkfQOSNLPw/kPJTEj7EBj4ungcT\n\tMprA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=/0Oo3lyY6+1qx+MmGM6pb1j6JcWl/RSkQjjesNs9nqw=;\n\tb=EP9IlOPPt0M4TOfxAAqMwvd7Yq7MxD+b6YweD0rh+jJGpksLU1179oGiQL62VhqFl/\n\tHy1RGkTkOSbYOHQ92ChJ0sdv7Udf8yHfVl5De8hhfGKnX2b8jYidvYEGjlqgXLiuRJxo\n\twt6KI/Hzr4r3ADBjrNj864riz4ncXwFPjUeyzMFFZSQKB0UHjiuMQJ3hA9K9Jreirh0h\n\tiRGB1eKshI6cSyHSXd2o2lw/hiPxIM53B7lRC5faEgKZzhYL3mUkvt71p4KOE2T2PIH9\n\tHnFzF5RrYF4bUaRrgROKeFuGb8UcK0u8pilKUBz4QtYnazDDRRvkaizhI7sPIFOIsBY4\n\tP7Ig==","X-Gm-Message-State":"AHPjjUikjg+0fp+ZMa9CJNJvzWU1C4lhCpFWL4NprKiq/SbnUGWD03d3\n\tGbD0jSLLuwlIVtIyQ7c=","X-Google-Smtp-Source":"ADKCNb5K54VI9iJiAXRaFvGhX65NKcTuap//kD+aul8gVEO143StIqEyeQKnzRlKjORtpSQi/1ZCMQ==","X-Received":"by 10.98.216.202 with SMTP id\n\te193mr25658201pfg.344.1505496481264; \n\tFri, 15 Sep 2017 10:28:01 -0700 (PDT)","To":"Bhanuprakash Bodireddy ,\n\tdev@openvswitch.org","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-3-git-send-email-bhanuprakash.bodireddy@intel.com>","From":"Greg Rose ","Message-ID":"<7dc99933-5183-b187-8787-81a7c2bb3112@gmail.com>","Date":"Fri, 15 Sep 2017 10:27:58 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"<1504893565-110166-3-git-send-email-bhanuprakash.bodireddy@intel.com>","Content-Language":"en-US","X-Spam-Status":"No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, \n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 02/13] netdev-dummy: Reorder elements in\n\tdummy_packet_stream structure.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1769895,"web_url":"http://patchwork.ozlabs.org/comment/1769895/","msgid":"<7EE4206A5F421D4FBA0A4623185DE2BD3750F0AA@IRSMSX104.ger.corp.intel.com>","list_archive_url":null,"date":"2017-09-18T06:49:22","subject":"Re: [ovs-dev] [PATCH 02/13] netdev-dummy: Reorder elements in\n\tdummy_packet_stream structure.","submitter":{"id":68557,"url":"http://patchwork.ozlabs.org/api/people/68557/","name":"Bodireddy, Bhanuprakash","email":"bhanuprakash.bodireddy@intel.com"},"content":"Hi greg,\n\n>On 09/08/2017 10:59 AM, Bhanuprakash Bodireddy wrote:\n>> By reordering elements in dummy_packet_stream structure, sum holes\n>\n>Do you mean \"the sum of the holes\" can be reduced or do you mean \"some\n>holes\"\n>can be reduced?\n\nIn this patch series \"sum of the holes\" means, the sum/total of all the hole bytes in the\nrespective structure. For example 'dummy_packet_stream' structure members are aligned below way.\nThis structure has one hole comprising of 56 bytes.\n\nstruct dummy_packet_stream {\n struct stream * stream; /* 0 8 */\n ====> 56 bytes holes. \n struct dp_packet rxbuf; /* 64 704 */ \n struct ovs_list txq; /* 768 16 */\n};\n\nWith the proposed change in this patch, the new alignment is as below \n\nstruct dummy_packet_stream {\n struct stream * stream; /* 0 8 */\n struct ovs_list txq; /* 8 16 */\n ====> 40 bytes hole\n struct dp_packet rxbuf; /* 64 704 */\n};\n\nFor all the patches, the information is added in to the commit log that shows\nthe improvement with the proposed changes. As claimed, sum holes(bytes) are\n reduced from 56 to 40 in case of this patch.\n\n>> Before: structure size: 784, sum holes: 56, cachelines:13\n>> After : structure size: 768, sum holes: 40, cachelines:12\n\n>\n>Same question through several of the other patches where you use the same\n>language.\n\nIn few structures there are multiple holes and 'sum holes' adds hole bytes of multiple holes\nIn those cases. \n\n- Bhanuprakash.\n\n>\n>> can be reduced, thus saving a cache line.\n>>\n>> Before: structure size: 784, sum holes: 56, cachelines:13 After :\n>> structure size: 768, sum holes: 40, cachelines:12\n>>\n>> Signed-off-by: Bhanuprakash Bodireddy\n>> \n>> ---\n>> lib/netdev-dummy.c | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index\n>> f731af1..d888c40 100644\n>> --- a/lib/netdev-dummy.c\n>> +++ b/lib/netdev-dummy.c\n>> @@ -50,8 +50,8 @@ struct reconnect;\n>>\n>> struct dummy_packet_stream {\n>> struct stream *stream;\n>> - struct dp_packet rxbuf;\n>> struct ovs_list txq;\n>> + struct dp_packet rxbuf;\n>> };\n>>\n>> enum dummy_packet_conn_type {\n>>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwc7K0QhYz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 16:49:31 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 55477A80;\n\tMon, 18 Sep 2017 06:49:27 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 52AB49B9\n\tfor ; Mon, 18 Sep 2017 06:49:26 +0000 (UTC)","from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id C00BAD3\n\tfor ; Mon, 18 Sep 2017 06:49:25 +0000 (UTC)","from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Sep 2017 23:49:25 -0700","from irsmsx101.ger.corp.intel.com ([163.33.3.153])\n\tby orsmga004.jf.intel.com with ESMTP; 17 Sep 2017 23:49:24 -0700","from irsmsx104.ger.corp.intel.com ([169.254.5.248]) by\n\tIRSMSX101.ger.corp.intel.com ([169.254.1.22]) with mapi id\n\t14.03.0319.002; Mon, 18 Sep 2017 07:49:23 +0100"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,411,1500966000\"; d=\"scan'208\";a=\"129718373\"","From":"\"Bodireddy, Bhanuprakash\" ","To":"Greg Rose , \"dev@openvswitch.org\"\n\t","Thread-Topic":"[ovs-dev] [PATCH 02/13] netdev-dummy: Reorder elements in\n\tdummy_packet_stream structure.","Thread-Index":"AQHTLkgFipGFmxoeREKUQBM5WH6VbqK6MMhA","Date":"Mon, 18 Sep 2017 06:49:22 +0000","Message-ID":"<7EE4206A5F421D4FBA0A4623185DE2BD3750F0AA@IRSMSX104.ger.corp.intel.com>","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-3-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<7dc99933-5183-b187-8787-81a7c2bb3112@gmail.com>","In-Reply-To":"<7dc99933-5183-b187-8787-81a7c2bb3112@gmail.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[163.33.239.181]","MIME-Version":"1.0","X-Spam-Status":"No, score=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,\n\tRP_MATCHES_RCVD autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH 02/13] netdev-dummy: Reorder elements in\n\tdummy_packet_stream structure.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1798863,"web_url":"http://patchwork.ozlabs.org/comment/1798863/","msgid":"<20171103195255.GA27530@ovn.org>","list_archive_url":null,"date":"2017-11-03T19:52:55","subject":"Re: [ovs-dev] [PATCH 02/13] netdev-dummy: Reorder elements in\n\tdummy_packet_stream structure.","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Fri, Sep 08, 2017 at 06:59:14PM +0100, Bhanuprakash Bodireddy wrote:\n> By reordering elements in dummy_packet_stream structure, sum holes\n> can be reduced, thus saving a cache line.\n> \n> Before: structure size: 784, sum holes: 56, cachelines:13\n> After : structure size: 768, sum holes: 40, cachelines:12\n> \n> Signed-off-by: Bhanuprakash Bodireddy \n\nI wouldn't normally bother optimizing code that is used only for\ntesting, but the reduction in cache lines is nice, so I applied this.\nThank you!","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yTCL83F62z9sBW\n\tfor ;\n\tSat, 4 Nov 2017 06:53:04 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id F37DBD3A;\n\tFri, 3 Nov 2017 19:53:02 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id C3F5FD3A\n\tfor ; Fri, 3 Nov 2017 19:53:01 +0000 (UTC)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 540C54F4\n\tfor ; Fri, 3 Nov 2017 19:53:01 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id CB620A80C1;\n\tFri, 3 Nov 2017 20:52:58 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Fri, 3 Nov 2017 12:52:55 -0700","From":"Ben Pfaff ","To":"Bhanuprakash Bodireddy ","Message-ID":"<20171103195255.GA27530@ovn.org>","References":"<1504893565-110166-1-git-send-email-bhanuprakash.bodireddy@intel.com>\n\t<1504893565-110166-3-git-send-email-bhanuprakash.bodireddy@intel.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504893565-110166-3-git-send-email-bhanuprakash.bodireddy@intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH 02/13] netdev-dummy: Reorder elements in\n\tdummy_packet_stream structure.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]