[{"id":1766947,"web_url":"http://patchwork.ozlabs.org/comment/1766947/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:28:03","subject":"Re: [U-Boot] [PATCH 04/13] usb: gadget: usb_ether: Move the\n\tinterfaces to Kconfig","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Maxime,\n\nOn 8 September 2017 at 11:34, Maxime Ripard\n wrote:\n> We need to select an interface for the usb_ether gadget, and they haven't\n> been converted to Kconfig yet. Add a choice to make sure we have an option\n> selected, and convert all the users.\n>\n> Signed-off-by: Maxime Ripard \n> ---\n> configs/gwventana_emmc_defconfig | 1 +\n> configs/gwventana_gw5904_defconfig | 1 +\n> configs/gwventana_nand_defconfig | 1 +\n> configs/mx6qsabrelite_defconfig | 1 +\n> configs/nitrogen6dl2g_defconfig | 1 +\n> configs/nitrogen6dl_defconfig | 1 +\n> configs/nitrogen6q2g_defconfig | 1 +\n> configs/nitrogen6q_defconfig | 1 +\n> configs/nitrogen6s1g_defconfig | 1 +\n> configs/nitrogen6s_defconfig | 1 +\n> configs/novena_defconfig | 1 +\n> configs/sansa_fuze_plus_defconfig | 1 +\n> configs/warp7_defconfig | 1 +\n> configs/warp7_secure_defconfig | 1 +\n> configs/xfi3_defconfig | 1 +\n> drivers/usb/gadget/Kconfig | 12 ++++++++++++\n> include/configs/am335x_evm.h | 4 ----\n> include/configs/am3517_evm.h | 4 ----\n> include/configs/baltos.h | 4 ----\n> include/configs/gw_ventana.h | 1 -\n> include/configs/ma5d4evk.h | 1 -\n> include/configs/nitrogen6x.h | 1 -\n> include/configs/novena.h | 1 -\n> include/configs/pcm051.h | 4 ----\n> include/configs/sama5d2_ptc.h | 1 -\n> include/configs/sansa_fuze_plus.h | 1 -\n> include/configs/siemens-am33x-common.h | 4 ----\n> include/configs/vinco.h | 1 -\n> include/configs/warp7.h | 2 --\n> include/configs/xfi3.h | 1 -\n> scripts/config_whitelist.txt | 2 --\n> 31 files changed, 27 insertions(+), 32 deletions(-)\n\n[..]\n\n> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig\n> index 4f29beba1c52..878495fd5d03 100644\n> --- a/drivers/usb/gadget/Kconfig\n> +++ b/drivers/usb/gadget/Kconfig\n> @@ -129,6 +129,18 @@ config USB_ETHER\n>\n> if USB_ETHER\n>\n> +choice\n> + prompt \"USB Ethernet Gadget Model\"\n> + default USB_ETH_RNDIS\n> +\n> +config USB_ETH_CDC\n> + bool \"CDC-Ethernet model\"\n> +\n> +config USB_ETH_RNDIS\n> + bool \"RNDIS model\"\n> +\n> +endchoice\n> +\n\nPlease add help for these including spelling out the acronyms.\n\n- Simon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"HkBoJDp7\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"jYOoY28F\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs43S41q7z9t6D\n\tfor ;\n\tTue, 12 Sep 2017 22:32:47 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 50BBEC22001; Tue, 12 Sep 2017 12:29:38 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2F5FBC21FE6;\n\tTue, 12 Sep 2017 12:29:11 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 456B8C21FE8; Tue, 12 Sep 2017 12:28:29 +0000 (UTC)","from mail-qt0-f172.google.com (mail-qt0-f172.google.com\n\t[209.85.216.172])\n\tby lists.denx.de (Postfix) with ESMTPS id 917C2C21C40\n\tfor ; Tue, 12 Sep 2017 12:28:25 +0000 (UTC)","by mail-qt0-f172.google.com with SMTP id s18so23252936qta.3\n\tfor ; Tue, 12 Sep 2017 05:28:25 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:28:03 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=KmoL1Uvt0/W3ceOy0+cs0qRZFYL/2Yub1yDExwyVPjI=;\n\tb=HkBoJDp7m4IHcoUvWTpsSLGhk5WfeDnHp/WOiVKNjTWsccsRAK0Is6GA06vn3iFKY0\n\tg7S7WCZcqXnAiCMZMsxztwF3pRXhk3DgaIUJ07n9k+Fs63kVVfpeOPbWkyZjVQQtXFKu\n\tfx/2YFvoCPoeGPwrnSF9iQOdCuOYvPvrw0zR/JkeGYxtR4KXwfFEMH/MKUp3XkTW+Cy/\n\tQFaB05BYVRh+OmA4h2Gja7xROrp0lis+EemTboeFX0KZY140kezkzODFZA/Q1V0vApQZ\n\t+1vqWflM0guZiTtY1i8QJr0qMserSgi29ssaogIhTeEUF41Y2B4ONG/kBOXIlgwmT74w\n\tjUdw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=KmoL1Uvt0/W3ceOy0+cs0qRZFYL/2Yub1yDExwyVPjI=;\n\tb=jYOoY28FRr/RkKz7CoHpYuineL/8XfHiFz8oxqc92LgWhMAyU4Np1+fwxUn3+r6nOn\n\t23VF0Bvynk4KNM+ag90f5dZ0PGGO434iAxGGJ+olqYq6JbKVjanxvaRGxp4JhIGYXQC0\n\tiykczarNgX7w4KsXC7YRV0wVdF1qBu7tk+P2I="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=KmoL1Uvt0/W3ceOy0+cs0qRZFYL/2Yub1yDExwyVPjI=;\n\tb=VFfUARqiEDr9ng3og/fBW/huQrXnv5oTVcm8+vCTER/Frn4QGL8h7jLUdSP6dC74xc\n\tDmXuJvYv1sZd+0cdsq9oNNRkhSw6l5fsaTekpCi7P/h3Vk/+qoBkkX2lg+TWuhroPN8t\n\tlNrGQ1RRPw0RWeWBRTZ2MxqunDttrOluBZ51HMC1MKUVZ3Qugxvm/MouxAkxEKfYdO9+\n\tHyq5o24vc1zFHldp2sywhJUrjA9utxZAHTvIlL95rqRQpKR2I0A79tKkd+VXSdKFs2PO\n\tUMqRZS9EhLHftCSvnZ4+6qcg3D0+sI8+mlLpFYYgwvqIyvXMp2sQrIbZB6Wz4VcD7UKB\n\t+R7g==","X-Gm-Message-State":"AHPjjUjEK8BZp64yovW76VJG+SFDdw5VqBNTpRatADg2SmblWp20qQzc\n\tOcvHZrrPSEZZV8SkrcgDjUVIuPGX1uw4JjmjHDCRBQ==","X-Google-Smtp-Source":"AOwi7QDPCaBFZ67KqhxLIb3bj3oDD11voJy55yrJjOaOV3L1O2XiVUE2zwp9Ka83sUl2QEuUCBVfJ4z7A/GHPX6loiY=","X-Received":"by 10.200.52.241 with SMTP id x46mr12796937qtb.38.1505219304273; \n\tTue, 12 Sep 2017 05:28:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"\n\t","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:28:03 -0600","X-Google-Sender-Auth":"IjW4QqXoAb8XBm2fzF6ezVZrUDI","Message-ID":"","To":"Maxime Ripard ","Cc":"Thomas Petazzoni ,\n\tTom Rini , Marek Vasut ,\n\tU-Boot Mailing List ,\n\tJagan Teki ","Subject":"Re: [U-Boot] [PATCH 04/13] usb: gadget: usb_ether: Move the\n\tinterfaces to Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]