[{"id":1767013,"web_url":"http://patchwork.ozlabs.org/comment/1767013/","msgid":"","list_archive_url":null,"date":"2017-09-12T12:27:55","subject":"Re: [U-Boot] [PATCH 03/13] usb: gadget: Convert USB_ETHER to Kconfig","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Maxime,\n\nOn 8 September 2017 at 11:34, Maxime Ripard\n wrote:\n> The USB Ethernet gadget option has not yet been moved to Kconfig, let's\n> deal with that.\n>\n> Signed-off-by: Maxime Ripard \n> ---\n> configs/am335x_baltos_defconfig | 1 +\n> configs/am335x_boneblack_defconfig | 1 +\n> configs/am335x_boneblack_vboot_defconfig | 1 +\n> configs/am335x_evm_defconfig | 1 +\n> configs/am335x_evm_nor_defconfig | 1 +\n> configs/am335x_evm_norboot_defconfig | 1 +\n> configs/am335x_evm_spiboot_defconfig | 1 +\n> configs/am335x_evm_usbspl_defconfig | 1 +\n> configs/am335x_hs_evm_defconfig | 1 +\n> configs/draco_defconfig | 1 +\n> configs/etamin_defconfig | 1 +\n> configs/gwventana_emmc_defconfig | 1 +\n> configs/gwventana_gw5904_defconfig | 1 +\n> configs/gwventana_nand_defconfig | 1 +\n> configs/ma5d4evk_defconfig | 1 +\n> configs/mx6qsabrelite_defconfig | 1 +\n> configs/nitrogen6dl2g_defconfig | 1 +\n> configs/nitrogen6dl_defconfig | 1 +\n> configs/nitrogen6q2g_defconfig | 1 +\n> configs/nitrogen6q_defconfig | 1 +\n> configs/nitrogen6s1g_defconfig | 1 +\n> configs/nitrogen6s_defconfig | 1 +\n> configs/novena_defconfig | 1 +\n> configs/omap3_beagle_defconfig | 1 +\n> configs/omap3_evm_defconfig | 1 +\n> configs/omap3_logic_defconfig | 1 +\n> configs/pcm051_rev1_defconfig | 1 +\n> configs/pcm051_rev3_defconfig | 1 +\n> configs/pxm2_defconfig | 1 +\n> configs/rastaban_defconfig | 1 +\n> configs/rut_defconfig | 1 +\n> configs/sama5d2_ptc_nandflash_defconfig | 1 +\n> configs/sama5d2_ptc_spiflash_defconfig | 1 +\n> configs/sansa_fuze_plus_defconfig | 1 +\n> configs/thuban_defconfig | 1 +\n> configs/vinco_defconfig | 1 +\n> configs/warp7_defconfig | 1 +\n> configs/warp7_secure_defconfig | 1 +\n> configs/xfi3_defconfig | 1 +\n> drivers/usb/gadget/Kconfig | 10 ++++++++++\n> include/configs/am335x_evm.h | 1 -\n> include/configs/am3517_evm.h | 1 -\n> include/configs/baltos.h | 1 -\n> include/configs/gw_ventana.h | 1 -\n> include/configs/h2200.h | 1 -\n> include/configs/ma5d4evk.h | 1 -\n> include/configs/nitrogen6x.h | 1 -\n> include/configs/novena.h | 1 -\n> include/configs/omap3_beagle.h | 1 -\n> include/configs/omap3_evm.h | 1 -\n> include/configs/omap3_logic.h | 1 -\n> include/configs/pcm051.h | 1 -\n> include/configs/sama5d2_ptc.h | 1 -\n> include/configs/sansa_fuze_plus.h | 1 -\n> include/configs/siemens-am33x-common.h | 1 -\n> include/configs/tao3530.h | 1 -\n> include/configs/vinco.h | 1 -\n> include/configs/warp7.h | 1 -\n> include/configs/xfi3.h | 1 -\n> scripts/config_whitelist.txt | 1 -\n> 60 files changed, 49 insertions(+), 20 deletions(-)\n\n[..]\n\n> --- a/drivers/usb/gadget/Kconfig\n> +++ b/drivers/usb/gadget/Kconfig\n> @@ -121,6 +121,14 @@ config G_DNL_PRODUCT_NUM\n>\n> endif # USB_GADGET_DOWNLOAD\n>\n> +config USB_ETHER\n> + bool \"USB Ethernet Gadget\"\n> + help\n> + Creates an Ethernet network card through an USB peripheral\n> + controller.\n\n'a USB'\n\nI think 'device' is better than 'card'?\n\nCan you expand this help a bit?\n\n- what it is used for\n- pointer to docs on how to use it\n- how it interacts with host-mode USB\n\nRegrads,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"NTNzIQUR\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"SczH9VBf\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xs4mC75WRz9s5L\n\tfor ;\n\tTue, 12 Sep 2017 23:05:47 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 24B4FC220F4; Tue, 12 Sep 2017 12:29:54 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A2C37C21FF5;\n\tTue, 12 Sep 2017 12:29:35 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D1BFCC21FF4; Tue, 12 Sep 2017 12:28:18 +0000 (UTC)","from mail-qt0-f182.google.com (mail-qt0-f182.google.com\n\t[209.85.216.182])\n\tby lists.denx.de (Postfix) with ESMTPS id 6F095C21FD1\n\tfor ; Tue, 12 Sep 2017 12:28:18 +0000 (UTC)","by mail-qt0-f182.google.com with SMTP id m35so25121714qte.1\n\tfor ; Tue, 12 Sep 2017 05:28:18 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 12 Sep 2017 05:27:55 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=U3EkLejf5NoJ6/+Gfrs4684Dxbg1u+julUaOvPX5sok=;\n\tb=NTNzIQUR+43PmKlK9FvNUW0q9W6AdY3h9Lx4mKQf/sbo8TqarPQjBWz9L63wXMUc3C\n\tOqpmUkzYzafCHKHaWy75H37w0qJzxsCpKYhUlL/KPbCeraOvhToG6HYQpeh8mOiTYdou\n\t3XaAmf4Ckz9QmR8aHhxKV+z8m8AXXlDJdAuYhXN31Hs/jLvVENk8DNcJeM31wx3d5MY/\n\teKjfWVCYt1I1SXCvmlaveogn4DLWsY+/uIvEMNdo9xcFu/ZxLcdvkDZfgetn6RlvREpL\n\t2U/Vi3Crm8AhoC4z3nUfN7DsAB9Tr/j0GdAADWXuspzE1IcP+zxlVQgxA/ntyYMy23BO\n\tgEkQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=U3EkLejf5NoJ6/+Gfrs4684Dxbg1u+julUaOvPX5sok=;\n\tb=SczH9VBfmL7kg0JVzbG/kUK0BsxbRK/oesjukX8N+p4lULMgAP/VGsZgZYyv+yoehb\n\tBhf0CImKzMnZ2GYkDH9wsz1hwPjQoVFcz87LDsRIddDucggBfIr/T1IUjtuXybRe2zvw\n\tePIZYT7iRGUySbc/9ywMFeBdQUpeU1as+xmAU="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=U3EkLejf5NoJ6/+Gfrs4684Dxbg1u+julUaOvPX5sok=;\n\tb=LK8dYS5HBKypzU3TVHCms1fIuBX6whBJ+DzIiOboOrXMmrAHVhwTGAYUwFk215iX7P\n\tp54gT/wXgZrxaI1cwOac//JqGzwMVJNP4mlSxRaObgy9HoBPAfbljgrYvk5dGInpJNdQ\n\t0y+4ymrEkg5KHvYhZe8jVQqDgqb5uJDTJAD3kMn6vSJKj57uc2I07slqAx2juKqwt0Nj\n\t0oNZccxQddMnVWVhxnihAlX/RbGtaqf0Cr9idnRAgJ+9aWv0/8iKjidcuFJLR3DMHT5W\n\tuBNVgb+pGgbBhv2DrCTflRIsdIx8m5/McttOy5WNJb9HIs2N6oZer2fApe8qwx/1oR8Y\n\tHfPg==","X-Gm-Message-State":"AHPjjUjwrZEQE7N1hTJbZlg55u0d9/+WVo4Q3dZU0hDIC1Xi+aHYCHaE\n\tA8QTzusU+yEEjuQINxr3qPPdFIp3thYFKvfR/MBwjg==","X-Google-Smtp-Source":"AOwi7QDb4AKEtPHsnKXKHB2uemCO+hC0IlhgWWDUsydTIwDifzHP7Jkjv29aSCID6nw0252SAbHdrB/uXxqTusm1b98=","X-Received":"by 10.237.35.238 with SMTP id k43mr21513941qtc.214.1505219296865;\n\tTue, 12 Sep 2017 05:28:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"\n\t","From":"Simon Glass ","Date":"Tue, 12 Sep 2017 06:27:55 -0600","X-Google-Sender-Auth":"2rYUqRi5pXX_7bOEWNduuFM11CY","Message-ID":"","To":"Maxime Ripard ","Cc":"Thomas Petazzoni ,\n\tTom Rini , Marek Vasut ,\n\tU-Boot Mailing List ,\n\tJagan Teki ","Subject":"Re: [U-Boot] [PATCH 03/13] usb: gadget: Convert USB_ETHER to Kconfig","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]