[{"id":1768238,"web_url":"http://patchwork.ozlabs.org/comment/1768238/","msgid":"<08f47a9b-b6f0-d35c-7d64-fe3a8b6b1989@redhat.com>","list_archive_url":null,"date":"2017-09-13T23:14:48","subject":"Re: [Qemu-devel] [PATCH v4 3/3] Test for full Backup","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/08/2017 12:41 PM, Ishani Chugh wrote:\n> This patch is the test for full backup implementation in Backup tool.\n> The test employs two basic substests:\n> 1) Backing up an empty guest and comparing it with base image.\n> 2) Writing a pattern to the guest, creating backup and comparing\n> with the base image.\n> \n> Signed-off-by: Ishani Chugh \n> ---\n> tests/qemu-iotests/191 | 86 ++++++++++++++++++++++++++++++++++++++++++++++\n> tests/qemu-iotests/191.out | 35 +++++++++++++++++++\n> tests/qemu-iotests/group | 1 +\n> 3 files changed, 122 insertions(+)\n> create mode 100755 tests/qemu-iotests/191\n> create mode 100644 tests/qemu-iotests/191.out\n> \n> diff --git a/tests/qemu-iotests/191 b/tests/qemu-iotests/191\n> new file mode 100755\n> index 0000000..16988d8\n> --- /dev/null\n> +++ b/tests/qemu-iotests/191\n> @@ -0,0 +1,86 @@\n> +#!/bin/bash\n> +#\n> +# Test full backup functionality of qemu-backup tool\n> +#\n> +# Copyright (C) 2017 Ishani Chugh \n> +#\n> +# This program is free software; you can redistribute it and/or modify\n> +# it under the terms of the GNU General Public License as published by\n> +# the Free Software Foundation; either version 2 of the License, or\n> +# (at your option) any later version.\n> +#\n> +# This program is distributed in the hope that it will be useful,\n> +# but WITHOUT ANY WARRANTY; without even the implied warranty of\n> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n> +# GNU General Public License for more details.\n> +#\n> +# You should have received a copy of the GNU General Public License\n> +# along with this program. If not, see .\n> +#\n> +\n> +# creator\n> +owner=chugh.ishani@research.iiit.ac.in\n> +\n> +seq=`basename $0`\n> +echo \"QA output created by $seq\"\n> +\n> +here=`pwd`\n> +status=1\t# failure is the default!\n> +\n> +\n> +# get standard environment, filters and checks\n> +. ./common.rc\n> +. ./common.filter\n> +. ./common.qemu\n> +\n> +_supported_fmt generic\n> +_supported_proto generic\n> +_supported_os Linux\n> +\n> +_cleanup()\n> +{\n> + rm -f \"$TEST_DIR\"/virtio0\n> + rm -f \"$CONFIG_FILE\"\n> +}\n> +trap \"_cleanup; exit \\$status\" 0 1 2 3 15\n> +\n> +CONFIG_FILE=\"$TEST_DIR\"/backup-config\n> +SOCKET=unix:\"$TEST_DIR\"/backup_socket\n> +size=128M\n> +\n> +_make_test_img \"$size\"\n> +export QEMU_BACKUP_CONFIG=\"$CONFIG_FILE\"\n> +qemu_comm_method=\"monitor\"\n> +echo\n> +_launch_qemu -drive if=virtio,file=\"$TEST_IMG\" -qmp \"$SOCKET\",server,nowait\n\nQEMU launch invocation is missing the format= parameter. This test fails\nwith the -raw format because of this.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsyF71f2rz9t2f\n\tfor ;\n\tThu, 14 Sep 2017 09:15:21 +1000 (AEST)","from localhost ([::1]:44974 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsGsI-0000Qk-Fv\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 19:15:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56132)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsGrz-0000Q9-FT\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 19:15:00 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsGrw-0003a1-8m\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 19:14:59 -0400","from mx1.redhat.com ([209.132.183.28]:48816)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsGrv-0003ZL-W5\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 19:14:56 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C9EC05AFED;\n\tWed, 13 Sep 2017 23:14:54 +0000 (UTC)","from [10.18.17.231] (dhcp-17-231.bos.redhat.com [10.18.17.231])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8FEDB17CCF;\n\tWed, 13 Sep 2017 23:14:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C9EC05AFED","To":"Ishani Chugh , qemu-devel@nongnu.org","References":"<1504888905-22396-1-git-send-email-chugh.ishani@research.iiit.ac.in>\n\t<1504888905-22396-4-git-send-email-chugh.ishani@research.iiit.ac.in>","From":"John Snow ","Message-ID":"<08f47a9b-b6f0-d35c-7d64-fe3a8b6b1989@redhat.com>","Date":"Wed, 13 Sep 2017 19:14:48 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504888905-22396-4-git-send-email-chugh.ishani@research.iiit.ac.in>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tWed, 13 Sep 2017 23:14:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 3/3] Test for full Backup","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"famz@redhat.com, stefanha@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]