[{"id":1767851,"web_url":"http://patchwork.ozlabs.org/comment/1767851/","msgid":"<b0c7e816-4a7c-609d-2bc7-281fc6ca751d@microchip.com>","list_archive_url":null,"date":"2017-09-13T12:29:35","subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 08/09/2017 at 17:35, Romain Izard wrote:\n> From: Romain Izard <romain.izard@mobile-devices.fr>\n> \n> Save and restore the System Clock and Programmable Clock register for\n> the backup use case.\n\n\"System Clock\" seems to be handled in another patch.\n\n> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>\n> ---\n>  drivers/clk/at91/pmc.c | 5 +++++\n>  1 file changed, 5 insertions(+)\n> \n> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n> index 07dc2861ad3f..5421b03553ec 100644\n> --- a/drivers/clk/at91/pmc.c\n> +++ b/drivers/clk/at91/pmc.c\n> @@ -66,6 +66,7 @@ static struct\n>  \tu32 pcr[PMC_MAX_IDS];\n>  \tu32 audio_pll0;\n>  \tu32 audio_pll1;\n> +\tu32 pckr[3];\n\nSome products have different numbers of PCK (only 2 on at91sam9x5 for\ninstance)...\n\n>  } pmc_cache;\n>  \n>  void pmc_register_id(u8 id)\n> @@ -103,6 +104,8 @@ static int pmc_suspend(void)\n>  \t\tregmap_read(pmcreg, AT91_PMC_PCR,\n>  \t\t\t    &pmc_cache.pcr[registered_ids[i]]);\n>  \t}\n> +\tfor (i = 0; i < 3; i++)\n\nAnd it might be a good practice to have this constant value in a #define.\nWe have \"#define PROG_ID_MAX  7\" defined in\ndrivers/clk/at91/clk-programmable.c.\n\nRegards,\n\n\n> +\t\tregmap_read(pmcreg, AT91_PMC_PCKR(i), &pmc_cache.pckr[i]);\n>  \n>  \treturn 0;\n>  }\n> @@ -143,6 +146,8 @@ static void pmc_resume(void)\n>  \t\t\t     pmc_cache.pcr[registered_ids[i]] |\n>  \t\t\t     AT91_PMC_PCR_CMD);\n>  \t}\n> +\tfor (i = 0; i < 3; i++)\n> +\t\tregmap_write(pmcreg, AT91_PMC_PCKR(i), pmc_cache.pckr[i]);\n>  \n>  \tif (pmc_cache.uckr & AT91_PMC_UPLLEN)\n>  \t\tmask |= AT91_PMC_LOCKU;\n>","headers":{"Return-Path":"<linux-pwm-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsgwB34BKz9sNr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 22:29:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752391AbdIMM3b (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 08:29:31 -0400","from esa2.microchip.iphmx.com ([68.232.149.84]:63295 \"EHLO\n\tesa2.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752371AbdIMM31 (ORCPT\n\t<rfc822; linux-pwm@vger.kernel.org>); Wed, 13 Sep 2017 08:29:27 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa2.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t13 Sep 2017 05:28:29 -0700","from [10.159.245.112] (10.10.76.4) by chn-sv-exch07.mchp-main.com\n\t(10.10.76.108) with Microsoft SMTP Server id 14.3.352.0;\n\tWed, 13 Sep 2017 05:28:28 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,387,1500966000\"; d=\"scan'208\";a=\"6957384\"","Subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","To":"Romain Izard <romain.izard.pro@gmail.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tMichael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@codeaurora.org>,\n\tLudovic Desroches <ludovic.desroches@microchip.com>,\n\tJonathan Cameron <jic23@kernel.org>, Wenyou Yang <wenyou.yang@atmel.com>,\n\tJosh Wu <rainyfeeling@outlook.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>,\n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tRichard Genoud <richard.genoud@gmail.com>,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tAlan Stern <stern@rowland.harvard.edu>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>","CC":"<linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,\n\t<linux-iio@vger.kernel.org>, <linux-mtd@lists.infradead.org>,\n\t<linux-pwm@vger.kernel.org>, <linux-serial@vger.kernel.org>,\n\t<linux-usb@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,\n\tRomain Izard <romain.izard@mobile-devices.fr>","References":"<20170908153604.28383-1-romain.izard.pro@gmail.com>\n\t<20170908153604.28383-4-romain.izard.pro@gmail.com>","From":"Nicolas Ferre <nicolas.ferre@microchip.com>","Organization":"microchip","Message-ID":"<b0c7e816-4a7c-609d-2bc7-281fc6ca751d@microchip.com>","Date":"Wed, 13 Sep 2017 14:29:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170908153604.28383-4-romain.izard.pro@gmail.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-pwm.vger.kernel.org>","X-Mailing-List":"linux-pwm@vger.kernel.org"}},{"id":1768029,"web_url":"http://patchwork.ozlabs.org/comment/1768029/","msgid":"<20170913170310.grfv7j5xvh7chjdo@piout.net>","list_archive_url":null,"date":"2017-09-13T17:03:10","subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote:\n> On 08/09/2017 at 17:35, Romain Izard wrote:\n> > From: Romain Izard <romain.izard@mobile-devices.fr>\n> > \n> > Save and restore the System Clock and Programmable Clock register for\n> > the backup use case.\n> \n> \"System Clock\" seems to be handled in another patch.\n> \n> > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>\n> > ---\n> >  drivers/clk/at91/pmc.c | 5 +++++\n> >  1 file changed, 5 insertions(+)\n> > \n> > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n> > index 07dc2861ad3f..5421b03553ec 100644\n> > --- a/drivers/clk/at91/pmc.c\n> > +++ b/drivers/clk/at91/pmc.c\n> > @@ -66,6 +66,7 @@ static struct\n> >  \tu32 pcr[PMC_MAX_IDS];\n> >  \tu32 audio_pll0;\n> >  \tu32 audio_pll1;\n> > +\tu32 pckr[3];\n> \n> Some products have different numbers of PCK (only 2 on at91sam9x5 for\n> instance)...\n> \n\nMy opinion is that it will be time to change that when multiple SoCs\nwill need to save their registers.","headers":{"Return-Path":"<linux-pwm-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsp0D3yrvz9rxl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 03:03:40 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751546AbdIMRDZ (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tWed, 13 Sep 2017 13:03:25 -0400","from mail.free-electrons.com ([62.4.15.54]:50351 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751458AbdIMRDT (ORCPT\n\t<rfc822; linux-pwm@vger.kernel.org>); Wed, 13 Sep 2017 13:03:19 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 5F2012097F; Wed, 13 Sep 2017 19:03:17 +0200 (CEST)","from localhost (unknown [12.145.98.253])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id ADA03208E5;\n\tWed, 13 Sep 2017 19:03:16 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 13 Sep 2017 19:03:10 +0200","From":"Alexandre Belloni <alexandre.belloni@free-electrons.com>","To":"Nicolas Ferre <nicolas.ferre@microchip.com>","Cc":"Romain Izard <romain.izard.pro@gmail.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tMichael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@codeaurora.org>,\n\tLudovic Desroches <ludovic.desroches@microchip.com>,\n\tJonathan Cameron <jic23@kernel.org>, Wenyou Yang <wenyou.yang@atmel.com>,\n\tJosh Wu <rainyfeeling@outlook.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>,\n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tRichard Genoud <richard.genoud@gmail.com>,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tAlan Stern <stern@rowland.harvard.edu>,\n\tlinux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-iio@vger.kernel.org, linux-mtd@lists.infradead.org,\n\tlinux-pwm@vger.kernel.org, linux-serial@vger.kernel.org,\n\tlinux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tRomain Izard <romain.izard@mobile-devices.fr>","Subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","Message-ID":"<20170913170310.grfv7j5xvh7chjdo@piout.net>","References":"<20170908153604.28383-1-romain.izard.pro@gmail.com>\n\t<20170908153604.28383-4-romain.izard.pro@gmail.com>\n\t<b0c7e816-4a7c-609d-2bc7-281fc6ca751d@microchip.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<b0c7e816-4a7c-609d-2bc7-281fc6ca751d@microchip.com>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-pwm.vger.kernel.org>","X-Mailing-List":"linux-pwm@vger.kernel.org"}},{"id":1768380,"web_url":"http://patchwork.ozlabs.org/comment/1768380/","msgid":"<CAGkQfmOZBi4tzUSEAD7J+w_v+pZ_yFgPRBaYaLnW-ptFZO0rvg@mail.gmail.com>","list_archive_url":null,"date":"2017-09-14T07:41:36","subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for\n\tprogrammable clocks","submitter":{"id":68075,"url":"http://patchwork.ozlabs.org/api/people/68075/","name":"romain izard","email":"romain.izard@mobile-devices.fr"},"content":"2017-09-13 19:03 GMT+02:00 Alexandre Belloni\n<alexandre.belloni@free-electrons.com>:\n> On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote:\n>> On 08/09/2017 at 17:35, Romain Izard wrote:\n>> > From: Romain Izard <romain.izard@mobile-devices.fr>\n>> >\n>> > Save and restore the System Clock and Programmable Clock register for\n>> > the backup use case.\n>>\n>> \"System Clock\" seems to be handled in another patch.\n>>\n>> > Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>\n>> > ---\n>> >  drivers/clk/at91/pmc.c | 5 +++++\n>> >  1 file changed, 5 insertions(+)\n>> >\n>> > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n>> > index 07dc2861ad3f..5421b03553ec 100644\n>> > --- a/drivers/clk/at91/pmc.c\n>> > +++ b/drivers/clk/at91/pmc.c\n>> > @@ -66,6 +66,7 @@ static struct\n>> >     u32 pcr[PMC_MAX_IDS];\n>> >     u32 audio_pll0;\n>> >     u32 audio_pll1;\n>> > +   u32 pckr[3];\n>>\n>> Some products have different numbers of PCK (only 2 on at91sam9x5 for\n>> instance)...\n>>\n>\n> My opinion is that it will be time to change that when multiple SoCs will\n> need to save their registers.\n>\nFor the next version, I'll add a #define. But as this code requires a\ndevice tree node with the compatible string \"atmel,sama5d2-pmc\", I believe\nthat we can ignore other chips for now.","headers":{"Return-Path":"<linux-pwm-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=mobile-devices.fr header.i=@mobile-devices.fr\n\theader.b=\"LH7b/oAY\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xt9Tm0vtBz9t1t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 17:42:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751457AbdINHmC (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 14 Sep 2017 03:42:02 -0400","from mail-qk0-f175.google.com ([209.85.220.175]:45202 \"EHLO\n\tmail-qk0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751423AbdINHl6 (ORCPT\n\t<rfc822; linux-pwm@vger.kernel.org>); Thu, 14 Sep 2017 03:41:58 -0400","by mail-qk0-f175.google.com with SMTP id r141so5594372qke.2\n\tfor <linux-pwm@vger.kernel.org>; Thu, 14 Sep 2017 00:41:57 -0700 (PDT)","by 10.200.48.120 with HTTP; Thu, 14 Sep 2017 00:41:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mobile-devices.fr; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=/Wc0vcmET/0h2/TKJGTNBbso0HlS14Zu/QRlgRJXRFQ=;\n\tb=LH7b/oAYJIyKyo/uEesi8SgQh4W2dyUmj9Q1R6DKMh3d8PykskDuNRgCHURcpuFd8e\n\tev1MF0HjWAE58GEEMC6uLi7rZc1RxOn2vIq09C2RqBeffOntXMyZ92FrJugiozIfQx9q\n\ts6HrIoCwbBcEUzsOvGySjfglunyE2k8qI2gLA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=/Wc0vcmET/0h2/TKJGTNBbso0HlS14Zu/QRlgRJXRFQ=;\n\tb=MGjohny63/u5LMirVe9XxkKlS199Hw6DuYO2unIP3x7hXviRMpxi1egD7M+uVP9+oy\n\tniDtlKqQsK2GCN6JbEjvWXHRrDvkQneGUzE8S4l5+md40k6e195zturgkAa0njgoUbMI\n\t21oIOSq7nanKpHGyJw8dBbh0V4WQWGSJE5w0gHyT/pONSZ2437mDQcmwMI+G/pEeYCQr\n\t569aon0/5xRv54VvHN2GFtu3oElaKk9yLDk9cx7SsS4Jm4QXEjlGiCssNY2lkd0C7dKd\n\tKEaKkB1OGxbVZHbYVMfRD8jS4r0xXcyKzmYItA7a+1BjvBZNkomhZtKvLgiBU/v1lbrn\n\tlLRA==","X-Gm-Message-State":"AHPjjUjfqGG8XvoQN3vfsyjnzQBJVo01yzB5FgHDR0F8gq5rOyJmAo+F\n\tahwARdKSYYNcqO+hk4MabbeCy9ip9DNAZZ4E+6a3Cg==","X-Google-Smtp-Source":"AOwi7QCUXmUyt6U89S40Nv6vV2FMp8ARJHIqO3z5xB0fcd1vPIZKbzD32hQOLnvnbO2R5J1wMo0LksYbnUtw9tviKSk=","X-Received":"by 10.55.154.4 with SMTP id c4mr1460213qke.131.1505374917344;\n\tThu, 14 Sep 2017 00:41:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170913170310.grfv7j5xvh7chjdo@piout.net>","References":"<20170908153604.28383-1-romain.izard.pro@gmail.com>\n\t<20170908153604.28383-4-romain.izard.pro@gmail.com>\n\t<b0c7e816-4a7c-609d-2bc7-281fc6ca751d@microchip.com>\n\t<20170913170310.grfv7j5xvh7chjdo@piout.net>","From":"romain izard <romain.izard@mobile-devices.fr>","Date":"Thu, 14 Sep 2017 09:41:36 +0200","Message-ID":"<CAGkQfmOZBi4tzUSEAD7J+w_v+pZ_yFgPRBaYaLnW-ptFZO0rvg@mail.gmail.com>","Subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for\n\tprogrammable clocks","To":"Alexandre Belloni <alexandre.belloni@free-electrons.com>","Cc":"Nicolas Ferre <nicolas.ferre@microchip.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tMichael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@codeaurora.org>,\n\tLudovic Desroches <ludovic.desroches@microchip.com>,\n\tJonathan Cameron <jic23@kernel.org>, Wenyou Yang <wenyou.yang@atmel.com>,\n\tJosh Wu <rainyfeeling@outlook.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>,\n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tRichard Genoud <richard.genoud@gmail.com>,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tAlan Stern <stern@rowland.harvard.edu>,\n\tlinux-clk@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,\n\tlinux-iio@vger.kernel.org, linux-mtd <linux-mtd@lists.infradead.org>,\n\tlinux-pwm@vger.kernel.org, linux-serial@vger.kernel.org,\n\tlinux-usb@vger.kernel.org,\n\tlinux-arm-kernel <linux-arm-kernel@lists.infradead.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-pwm.vger.kernel.org>","X-Mailing-List":"linux-pwm@vger.kernel.org"}},{"id":1768466,"web_url":"http://patchwork.ozlabs.org/comment/1768466/","msgid":"<dc318434-cf3e-6cb9-2072-7b8ec45aed97@microchip.com>","list_archive_url":null,"date":"2017-09-14T09:38:45","subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 14/09/2017 at 09:41, romain izard wrote:\n> 2017-09-13 19:03 GMT+02:00 Alexandre Belloni\n> <alexandre.belloni@free-electrons.com>:\n>> On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote:\n>>> On 08/09/2017 at 17:35, Romain Izard wrote:\n>>>> From: Romain Izard <romain.izard@mobile-devices.fr>\n>>>>\n>>>> Save and restore the System Clock and Programmable Clock register for\n>>>> the backup use case.\n>>>\n>>> \"System Clock\" seems to be handled in another patch.\n>>>\n>>>> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>\n>>>> ---\n>>>>  drivers/clk/at91/pmc.c | 5 +++++\n>>>>  1 file changed, 5 insertions(+)\n>>>>\n>>>> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n>>>> index 07dc2861ad3f..5421b03553ec 100644\n>>>> --- a/drivers/clk/at91/pmc.c\n>>>> +++ b/drivers/clk/at91/pmc.c\n>>>> @@ -66,6 +66,7 @@ static struct\n>>>>     u32 pcr[PMC_MAX_IDS];\n>>>>     u32 audio_pll0;\n>>>>     u32 audio_pll1;\n>>>> +   u32 pckr[3];\n>>>\n>>> Some products have different numbers of PCK (only 2 on at91sam9x5 for\n>>> instance)...\n>>>\n>>\n>> My opinion is that it will be time to change that when multiple SoCs will\n>> need to save their registers.\n>>\n> For the next version, I'll add a #define. But as this code requires a\n> device tree node with the compatible string \"atmel,sama5d2-pmc\", I believe\n> that we can ignore other chips for now.\n\nFair enough, let's go for this.\n\nBye,","headers":{"Return-Path":"<linux-pwm-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pwm-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtD4331dFz9s06\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 19:38:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751673AbdINJi0 (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tThu, 14 Sep 2017 05:38:26 -0400","from esa5.microchip.iphmx.com ([216.71.150.166]:34753 \"EHLO\n\tesa5.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751638AbdINJiY (ORCPT\n\t<rfc822; linux-pwm@vger.kernel.org>); Thu, 14 Sep 2017 05:38:24 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t14 Sep 2017 02:37:39 -0700","from [10.159.245.112] (10.10.76.4) by chn-sv-exch06.mchp-main.com\n\t(10.10.76.107) with Microsoft SMTP Server id 14.3.352.0;\n\tThu, 14 Sep 2017 02:37:37 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,392,1500966000\"; d=\"scan'208\";a=\"4701090\"","Subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","To":"romain izard <romain.izard@mobile-devices.fr>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>","CC":"Boris Brezillon <boris.brezillon@free-electrons.com>,\n\tMichael Turquette <mturquette@baylibre.com>,\n\tStephen Boyd <sboyd@codeaurora.org>,\n\tLudovic Desroches <ludovic.desroches@microchip.com>,\n\tJonathan Cameron <jic23@kernel.org>, Wenyou Yang <wenyou.yang@atmel.com>,\n\tJosh Wu <rainyfeeling@outlook.com>,\n\tDavid Woodhouse <dwmw2@infradead.org>,\n\tBrian Norris <computersforpeace@gmail.com>,\n\tMarek Vasut <marek.vasut@gmail.com>,\n\tCyrille Pitchen <cyrille.pitchen@wedev4u.fr>,\n\tThierry Reding <thierry.reding@gmail.com>,\n\tRichard Genoud <richard.genoud@gmail.com>,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tAlan Stern <stern@rowland.harvard.edu>,\n\t<linux-clk@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,\n\t<linux-iio@vger.kernel.org>, linux-mtd <linux-mtd@lists.infradead.org>,\n\t<linux-pwm@vger.kernel.org>, <linux-serial@vger.kernel.org>,\n\t<linux-usb@vger.kernel.org>,\n\tlinux-arm-kernel <linux-arm-kernel@lists.infradead.org>","References":"<20170908153604.28383-1-romain.izard.pro@gmail.com>\n\t<20170908153604.28383-4-romain.izard.pro@gmail.com>\n\t<b0c7e816-4a7c-609d-2bc7-281fc6ca751d@microchip.com>\n\t<20170913170310.grfv7j5xvh7chjdo@piout.net>\n\t<CAGkQfmOZBi4tzUSEAD7J+w_v+pZ_yFgPRBaYaLnW-ptFZO0rvg@mail.gmail.com>","From":"Nicolas Ferre <nicolas.ferre@microchip.com>","Organization":"microchip","Message-ID":"<dc318434-cf3e-6cb9-2072-7b8ec45aed97@microchip.com>","Date":"Thu, 14 Sep 2017 11:38:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<CAGkQfmOZBi4tzUSEAD7J+w_v+pZ_yFgPRBaYaLnW-ptFZO0rvg@mail.gmail.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-pwm-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-pwm.vger.kernel.org>","X-Mailing-List":"linux-pwm@vger.kernel.org"}}]