[{"id":1767849,"web_url":"http://patchwork.ozlabs.org/comment/1767849/","msgid":"","list_archive_url":null,"date":"2017-09-13T12:29:35","subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 08/09/2017 at 17:35, Romain Izard wrote:\n> From: Romain Izard \n> \n> Save and restore the System Clock and Programmable Clock register for\n> the backup use case.\n\n\"System Clock\" seems to be handled in another patch.\n\n> Signed-off-by: Romain Izard \n> ---\n> drivers/clk/at91/pmc.c | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n> index 07dc2861ad3f..5421b03553ec 100644\n> --- a/drivers/clk/at91/pmc.c\n> +++ b/drivers/clk/at91/pmc.c\n> @@ -66,6 +66,7 @@ static struct\n> \tu32 pcr[PMC_MAX_IDS];\n> \tu32 audio_pll0;\n> \tu32 audio_pll1;\n> +\tu32 pckr[3];\n\nSome products have different numbers of PCK (only 2 on at91sam9x5 for\ninstance)...\n\n> } pmc_cache;\n> \n> void pmc_register_id(u8 id)\n> @@ -103,6 +104,8 @@ static int pmc_suspend(void)\n> \t\tregmap_read(pmcreg, AT91_PMC_PCR,\n> \t\t\t &pmc_cache.pcr[registered_ids[i]]);\n> \t}\n> +\tfor (i = 0; i < 3; i++)\n\nAnd it might be a good practice to have this constant value in a #define.\nWe have \"#define PROG_ID_MAX 7\" defined in\ndrivers/clk/at91/clk-programmable.c.\n\nRegards,\n\n\n> +\t\tregmap_read(pmcreg, AT91_PMC_PCKR(i), &pmc_cache.pckr[i]);\n> \n> \treturn 0;\n> }\n> @@ -143,6 +146,8 @@ static void pmc_resume(void)\n> \t\t\t pmc_cache.pcr[registered_ids[i]] |\n> \t\t\t AT91_PMC_PCR_CMD);\n> \t}\n> +\tfor (i = 0; i < 3; i++)\n> +\t\tregmap_write(pmcreg, AT91_PMC_PCKR(i), pmc_cache.pckr[i]);\n> \n> \tif (pmc_cache.uckr & AT91_PMC_UPLLEN)\n> \t\tmask |= AT91_PMC_LOCKU;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"QxV4y8RU\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsgvb67k0z9sPk\n\tfor ;\n\tWed, 13 Sep 2017 22:29:15 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds6mv-0001YP-2O; Wed, 13 Sep 2017 12:29:05 +0000","from esa2.microchip.iphmx.com ([68.232.149.84])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds6ms-0001VV-9K; Wed, 13 Sep 2017 12:29:03 +0000","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa2.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t13 Sep 2017 05:28:29 -0700","from [10.159.245.112] (10.10.76.4) by chn-sv-exch07.mchp-main.com\n\t(10.10.76.108) with Microsoft SMTP Server id 14.3.352.0;\n\tWed, 13 Sep 2017 05:28:28 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=JipSl1UJL4Zxzc4AcKYuabhpy9NApFtzn7ycM0tkR1U=;\n\tb=QxV4y8RU6txgy1\n\tI3EZ52dWiQcNq6GnQLWkhCIb3y8FzdDgIssmOvKAwylhHiIzQHxPtIiKDhBAcnF+jFYWmwRsLIEWY\n\tLMXaMCc1Kb2XUbl2/F8zxrTuEL0gMg+OHIau/t92M87Foq0wWg3ikUj9urYaYkrrC3d07t+MkVReB\n\tzN9b0n8lkI9aaWLmaf1gxExwMyaRUANlq1y63GVYiGo1KYSFjTy0lY+ffHKFGsbpLSVlzHudjpcRb\n\tJHRAMhYnV/xNzj4MfinnLXvgapDGygzDKAhQicZk29uY/pBunaCQbn8+rppyuabR2iSWQYYX1W6B7\n\tp87BxT8wm9L15967wNWQ==;","X-IronPort-AV":"E=Sophos;i=\"5.42,387,1500966000\"; d=\"scan'208\";a=\"6957384\"","Subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","To":"Romain Izard , Boris Brezillon\n\t, Michael Turquette\n\t, Stephen Boyd , Ludovic\n\tDesroches , Jonathan Cameron\n\t, Wenyou Yang , Josh Wu\n\t, David Woodhouse , Brian\n\tNorris ,\n\tMarek Vasut , \n\tCyrille Pitchen , Thierry Reding\n\t, Richard Genoud ,\n\tGreg Kroah-Hartman , Alan Stern\n\t, Alexandre Belloni\n\t","References":"<20170908153604.28383-1-romain.izard.pro@gmail.com>\n\t<20170908153604.28383-4-romain.izard.pro@gmail.com>","From":"Nicolas Ferre ","Organization":"microchip","Message-ID":"","Date":"Wed, 13 Sep 2017 14:29:35 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170908153604.28383-4-romain.izard.pro@gmail.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170913_052902_409021_E9CC2F8D ","X-CRM114-Status":"GOOD ( 12.33 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [68.232.149.84 listed in list.dnswl.org]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-mtd@lists.infradead.org, linux-serial@vger.kernel.org,\n\tRomain Izard ,\n\tlinux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1768031,"web_url":"http://patchwork.ozlabs.org/comment/1768031/","msgid":"<20170913170310.grfv7j5xvh7chjdo@piout.net>","list_archive_url":null,"date":"2017-09-13T17:03:10","subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote:\n> On 08/09/2017 at 17:35, Romain Izard wrote:\n> > From: Romain Izard \n> > \n> > Save and restore the System Clock and Programmable Clock register for\n> > the backup use case.\n> \n> \"System Clock\" seems to be handled in another patch.\n> \n> > Signed-off-by: Romain Izard \n> > ---\n> > drivers/clk/at91/pmc.c | 5 +++++\n> > 1 file changed, 5 insertions(+)\n> > \n> > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n> > index 07dc2861ad3f..5421b03553ec 100644\n> > --- a/drivers/clk/at91/pmc.c\n> > +++ b/drivers/clk/at91/pmc.c\n> > @@ -66,6 +66,7 @@ static struct\n> > \tu32 pcr[PMC_MAX_IDS];\n> > \tu32 audio_pll0;\n> > \tu32 audio_pll1;\n> > +\tu32 pckr[3];\n> \n> Some products have different numbers of PCK (only 2 on at91sam9x5 for\n> instance)...\n> \n\nMy opinion is that it will be time to change that when multiple SoCs\nwill need to save their registers.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"FquTK9t5\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsp1S2HNPz9s9Y\n\tfor ;\n\tThu, 14 Sep 2017 03:04:44 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsB5O-00026q-Oe; Wed, 13 Sep 2017 17:04:26 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsB4e-0001pJ-Pi; Wed, 13 Sep 2017 17:03:43 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 5F2012097F; Wed, 13 Sep 2017 19:03:17 +0200 (CEST)","from localhost (unknown [12.145.98.253])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id ADA03208E5;\n\tWed, 13 Sep 2017 19:03:16 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=5pb+RikDU2kAXk97c5R0OVG3FgRu9bEpFvv1xSQtWTM=;\n\tb=FquTK9t5VIwP+O\n\tI/cJvq0Ub47KcSmj2a5a93mb76hkRI2RrBLefjIYL2Eq08GCCFgwLXn9GL93sDAHwDYK4cXsAW5TB\n\tfGce58GydIerbm+NqzMH67eIC5eGMNeGHkANjfuu2UIXMb/BUqYOpddZuWUtFhC4mfX32zfTmCrH9\n\tKPbTc/KHYrJBLBkX2EJ+WYCOjxTiPpTFbezVa6anS7oAlFjZZVBbuEBfBiWtBAy4RbTXL6+zjvPIf\n\tQwvZPJkhmgzL4nwsFBUW7yZTCeobJH7VkVKly9G1ne77nvjPGsJT35Rmm45r1yj3txFfaqX/DTmrm\n\tX3t0pcuFwSUzyMcw7MsQ==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 13 Sep 2017 19:03:10 +0200","From":"Alexandre Belloni ","To":"Nicolas Ferre ","Subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","Message-ID":"<20170913170310.grfv7j5xvh7chjdo@piout.net>","References":"<20170908153604.28383-1-romain.izard.pro@gmail.com>\n\t<20170908153604.28383-4-romain.izard.pro@gmail.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170609 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170913_100341_002211_4A2858C2 ","X-CRM114-Status":"GOOD ( 13.76 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-iio@vger.kernel.org, Michael Turquette , \n\tThierry Reding , linux-mtd@lists.infradead.org,\n\tRomain Izard , linux-clk@vger.kernel.org, \n\tBoris Brezillon ,\n\tJosh Wu , Marek Vasut , \n\tLudovic Desroches ,\n\tAlan Stern , linux-serial@vger.kernel.org, \n\tRomain Izard ,\n\tlinux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tlinux-usb@vger.kernel.org, \n\tStephen Boyd , linux-kernel@vger.kernel.org,\n\tWenyou Yang ,\n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tJonathan Cameron ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1768390,"web_url":"http://patchwork.ozlabs.org/comment/1768390/","msgid":"","list_archive_url":null,"date":"2017-09-14T07:41:36","subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","submitter":{"id":68075,"url":"http://patchwork.ozlabs.org/api/people/68075/","name":"romain izard","email":"romain.izard@mobile-devices.fr"},"content":"2017-09-13 19:03 GMT+02:00 Alexandre Belloni\n:\n> On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote:\n>> On 08/09/2017 at 17:35, Romain Izard wrote:\n>> > From: Romain Izard \n>> >\n>> > Save and restore the System Clock and Programmable Clock register for\n>> > the backup use case.\n>>\n>> \"System Clock\" seems to be handled in another patch.\n>>\n>> > Signed-off-by: Romain Izard \n>> > ---\n>> > drivers/clk/at91/pmc.c | 5 +++++\n>> > 1 file changed, 5 insertions(+)\n>> >\n>> > diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n>> > index 07dc2861ad3f..5421b03553ec 100644\n>> > --- a/drivers/clk/at91/pmc.c\n>> > +++ b/drivers/clk/at91/pmc.c\n>> > @@ -66,6 +66,7 @@ static struct\n>> > u32 pcr[PMC_MAX_IDS];\n>> > u32 audio_pll0;\n>> > u32 audio_pll1;\n>> > + u32 pckr[3];\n>>\n>> Some products have different numbers of PCK (only 2 on at91sam9x5 for\n>> instance)...\n>>\n>\n> My opinion is that it will be time to change that when multiple SoCs will\n> need to save their registers.\n>\nFor the next version, I'll add a #define. But as this code requires a\ndevice tree node with the compatible string \"atmel,sama5d2-pmc\", I believe\nthat we can ignore other chips for now.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"cbEVMTlS\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tsecure) header.d=mobile-devices.fr header.i=@mobile-devices.fr\n\theader.b=\"LH7b/oAY\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xt9nS4D52z9sRm\n\tfor ;\n\tThu, 14 Sep 2017 17:55:40 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsOzO-0003Ic-Ck; Thu, 14 Sep 2017 07:55:10 +0000","from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsOmx-0005Jm-CC\n\tfor linux-mtd@lists.infradead.org; Thu, 14 Sep 2017 07:42:24 +0000","by mail-qk0-x22a.google.com with SMTP id r141so5594369qke.2\n\tfor ;\n\tThu, 14 Sep 2017 00:41:58 -0700 (PDT)","by 10.200.48.120 with HTTP; Thu, 14 Sep 2017 00:41:36 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=zgOfrNyQhq9zRHpqI4oDcgiXplTuYnor/LWZKt5Go4g=;\n\tb=cbEVMTlSZljRg5\n\tjQxZs5XqzZW2jfTc0YCW0iKu6/G5SAhf17rny/5oatVyAN1DbzQxR6IeCXFFB+1G7W46nmDZIXVVi\n\t1MvxWz7oY95iMHehWayIoHRP5OLZ5O+0E+/UiAQXNlF2pYcqR9AZXcdAc9FNuuaNnVik7w5chUarN\n\tuASCcxqrZNcARQjX20pBNaXoKeKEvQ3MeNgNZBx7EFmYhVGOnYcXvrd1xLclMsda8A7sf60YkSZuy\n\tIgWVjIC0gzOFgjJ/NJ/rd+++QC7NOWpjIV4I+c8D/yirdLsFF7Rt03vXVLtUga5ghElFda7hb+HK9\n\tfytuobc/FQLTZJfWiE7w==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mobile-devices.fr; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=/Wc0vcmET/0h2/TKJGTNBbso0HlS14Zu/QRlgRJXRFQ=;\n\tb=LH7b/oAYJIyKyo/uEesi8SgQh4W2dyUmj9Q1R6DKMh3d8PykskDuNRgCHURcpuFd8e\n\tev1MF0HjWAE58GEEMC6uLi7rZc1RxOn2vIq09C2RqBeffOntXMyZ92FrJugiozIfQx9q\n\ts6HrIoCwbBcEUzsOvGySjfglunyE2k8qI2gLA="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=/Wc0vcmET/0h2/TKJGTNBbso0HlS14Zu/QRlgRJXRFQ=;\n\tb=bMPzZYS5LjkAFfkCRantP6pM3QQw5cacCl5/cnF3BqWw2q2AkTMr70NFv9H9HWTPPD\n\t6mxTSBnlyAs2beKPyZBQA81A4SWPuXkX/StQacgwD8UfzAfh7Fp1c2SLgQgINRRwkNW7\n\ty2PgtaSEfdTS/82vAF3RcGN7myxIOHMS6PQPwH22LoyHDWyAS9xjt4d35FP9qXiM8K1N\n\tDgeTrs/MSRGe/JYmy9lDU5ahvbEfsTlyhrX5c/S+5XYwDgcM4BgVJmRqcmHBm0FLUjnx\n\tWz9+67YbsMVsf3b4e1scu6NHRYqJAFcNrfA0XwxW+Fh41xmduh5NtDH4LPmXW3kexAL9\n\tKRMQ==","X-Gm-Message-State":"AHPjjUi+/xeq81KT+HN9xvZAix8kdS8x9I3MyfnFkJQRUjMylltv42t7\n\tlxKQjgRDEQCPHv9EShLvXRlf0hYC6Ngqc6wlOA5N1g==","X-Google-Smtp-Source":"AOwi7QCUXmUyt6U89S40Nv6vV2FMp8ARJHIqO3z5xB0fcd1vPIZKbzD32hQOLnvnbO2R5J1wMo0LksYbnUtw9tviKSk=","X-Received":"by 10.55.154.4 with SMTP id c4mr1460213qke.131.1505374917344;\n\tThu, 14 Sep 2017 00:41:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170913170310.grfv7j5xvh7chjdo@piout.net>","References":"<20170908153604.28383-1-romain.izard.pro@gmail.com>\n\t<20170908153604.28383-4-romain.izard.pro@gmail.com>\n\t\n\t<20170913170310.grfv7j5xvh7chjdo@piout.net>","From":"romain izard ","Date":"Thu, 14 Sep 2017 09:41:36 +0200","Message-ID":"","Subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","To":"Alexandre Belloni ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170914_004219_643854_E2536A57 ","X-CRM114-Status":"GOOD ( 13.78 )","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2607:f8b0:400d:c09:0:0:0:22a listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-iio@vger.kernel.org, Michael Turquette , \n\tNicolas Ferre ,\n\tThierry Reding ,\n\tlinux-mtd , linux-clk@vger.kernel.org, \n\tBoris Brezillon ,\n\tJosh Wu , Marek Vasut , \n\tLudovic Desroches ,\n\tAlan Stern , linux-serial@vger.kernel.org, \n\tlinux-pwm@vger.kernel.org,\n\tlinux-arm-kernel ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tlinux-usb@vger.kernel.org, Stephen Boyd ,\n\tLKML , \n\tWenyou Yang ,\n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tJonathan Cameron ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1768465,"web_url":"http://patchwork.ozlabs.org/comment/1768465/","msgid":"","list_archive_url":null,"date":"2017-09-14T09:38:45","subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","submitter":{"id":71036,"url":"http://patchwork.ozlabs.org/api/people/71036/","name":"Nicolas Ferre","email":"nicolas.ferre@microchip.com"},"content":"On 14/09/2017 at 09:41, romain izard wrote:\n> 2017-09-13 19:03 GMT+02:00 Alexandre Belloni\n> :\n>> On 13/09/2017 at 14:29:35 +0200, Nicolas Ferre wrote:\n>>> On 08/09/2017 at 17:35, Romain Izard wrote:\n>>>> From: Romain Izard \n>>>>\n>>>> Save and restore the System Clock and Programmable Clock register for\n>>>> the backup use case.\n>>>\n>>> \"System Clock\" seems to be handled in another patch.\n>>>\n>>>> Signed-off-by: Romain Izard \n>>>> ---\n>>>> drivers/clk/at91/pmc.c | 5 +++++\n>>>> 1 file changed, 5 insertions(+)\n>>>>\n>>>> diff --git a/drivers/clk/at91/pmc.c b/drivers/clk/at91/pmc.c\n>>>> index 07dc2861ad3f..5421b03553ec 100644\n>>>> --- a/drivers/clk/at91/pmc.c\n>>>> +++ b/drivers/clk/at91/pmc.c\n>>>> @@ -66,6 +66,7 @@ static struct\n>>>> u32 pcr[PMC_MAX_IDS];\n>>>> u32 audio_pll0;\n>>>> u32 audio_pll1;\n>>>> + u32 pckr[3];\n>>>\n>>> Some products have different numbers of PCK (only 2 on at91sam9x5 for\n>>> instance)...\n>>>\n>>\n>> My opinion is that it will be time to change that when multiple SoCs will\n>> need to save their registers.\n>>\n> For the next version, I'll add a #define. But as this code requires a\n> device tree node with the compatible string \"atmel,sama5d2-pmc\", I believe\n> that we can ignore other chips for now.\n\nFair enough, let's go for this.\n\nBye,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"db8BfRdE\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtD3p6VXjz9s06\n\tfor ;\n\tThu, 14 Sep 2017 19:38:14 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsQb3-0000bs-GP; Thu, 14 Sep 2017 09:38:09 +0000","from esa5.microchip.iphmx.com ([216.71.150.166])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsQau-0000XB-ON; Thu, 14 Sep 2017 09:38:08 +0000","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t14 Sep 2017 02:37:39 -0700","from [10.159.245.112] (10.10.76.4) by chn-sv-exch06.mchp-main.com\n\t(10.10.76.107) with Microsoft SMTP Server id 14.3.352.0;\n\tThu, 14 Sep 2017 02:37:37 -0700"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=oOJ4NQsuK2VQ4LMZ3MLu9DAfMgnMrXQLTqiHAKRyPVI=;\n\tb=db8BfRdEsUoUHo\n\thKX1f4aeElMhSEqikiaI0vTuuB8kb6uj5EMVp6Eoa5KdBANz3pr08YOTdqfVAgXbXAZwJFGb4K/Lm\n\tM99QKR1AGOBFmkXrhKidRBXd/CkjjFjIwUsI8M0d9rLR1l40MR0HDVYYD4I3WdCpFmoEJgLBSehbO\n\t7dAKg36W8KVVK0L94k21tdA6pU9V6SOC+gO+thytuiVOwXDAgQFcIgjfeXwERws+XRFVKg41I66pA\n\tvhNKQz/UTOg9nxhQiKQg49PZ2fHQalilXtmJl2nvWVgWFw2FNuClEVCfisbLo8Y2tM8BSMbE/3Rfa\n\tdhRcShb15DnjdIUxv7bA==;","X-IronPort-AV":"E=Sophos;i=\"5.42,392,1500966000\"; d=\"scan'208\";a=\"4701090\"","Subject":"Re: [PATCH v1 03/10] clk: at91: pmc: Support backup for programmable\n\tclocks","To":"romain izard , Alexandre Belloni\n\t","References":"<20170908153604.28383-1-romain.izard.pro@gmail.com>\n\t<20170908153604.28383-4-romain.izard.pro@gmail.com>\n\t\n\t<20170913170310.grfv7j5xvh7chjdo@piout.net>\n\t","From":"Nicolas Ferre ","Organization":"microchip","Message-ID":"","Date":"Thu, 14 Sep 2017 11:38:45 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170914_023800_848687_419BB747 ","X-CRM114-Status":"GOOD ( 10.62 )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [216.71.150.166 listed in list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-iio@vger.kernel.org, Michael Turquette , \n\tThierry Reding ,\n\tlinux-mtd , linux-clk@vger.kernel.org, \n\tBoris Brezillon ,\n\tJosh Wu , Marek Vasut , \n\tLudovic Desroches ,\n\tAlan Stern , linux-serial@vger.kernel.org, \n\tlinux-pwm@vger.kernel.org,\n\tlinux-arm-kernel ,\n\tRichard Genoud ,\n\tGreg Kroah-Hartman ,\n\tlinux-usb@vger.kernel.org, Stephen Boyd ,\n\tLKML , \n\tWenyou Yang ,\n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ,\n\tJonathan Cameron ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]