[{"id":1765546,"web_url":"http://patchwork.ozlabs.org/comment/1765546/","msgid":"<f5ce1047-eb37-151a-c7b7-9b47b70789f7@hartkopp.net>","list_archive_url":null,"date":"2017-09-08T17:46:13","subject":"Re: [PATCH] can: check for null sk before deferencing it via the\n\tcall to sock_net","submitter":{"id":1450,"url":"http://patchwork.ozlabs.org/api/people/1450/","name":"Oliver Hartkopp","email":"socketcan@hartkopp.net"},"content":"On 09/08/2017 05:02 PM, Colin King wrote:\n> From: Colin Ian King <colin.king@canonical.com>\n> \n> The assignment of net via call sock_net will dereference sk. This\n> is performed before a sanity null check on sk, so there could be\n> a potential null dereference on the sock_net call if sk is null.\n> Fix this by assigning net after the sk null check. Also replace\n> the sk == NULL with the more usual !sk idiom.\n> \n> Detected by CoverityScan CID#1431862 (\"Dereference before null check\")\n> \n> Fixes: 384317ef4187 (\"can: network namespace support for CAN_BCM protocol\")\n> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n\nAcked-by: Oliver Hartkopp <socketcan@hartkopp.net>\n\n\nThanks Collin!\n\n> ---\n>   net/can/bcm.c | 5 +++--\n>   1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/net/can/bcm.c b/net/can/bcm.c\n> index 47a8748d953a..a3791674b8ce 100644\n> --- a/net/can/bcm.c\n> +++ b/net/can/bcm.c\n> @@ -1493,13 +1493,14 @@ static int bcm_init(struct sock *sk)\n>   static int bcm_release(struct socket *sock)\n>   {\n>   \tstruct sock *sk = sock->sk;\n> -\tstruct net *net = sock_net(sk);\n> +\tstruct net *net;\n>   \tstruct bcm_sock *bo;\n>   \tstruct bcm_op *op, *next;\n>   \n> -\tif (sk == NULL)\n> +\tif (!sk)\n>   \t\treturn 0;\n>   \n> +\tnet = sock_net(sk);\n>   \tbo = bcm_sk(sk);\n>   \n>   \t/* remove bcm_ops, timer, rx_unregister(), etc. */\n>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=hartkopp.net header.i=@hartkopp.net\n\theader.b=\"ptoWY699\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xplB76Sj1z9sBW\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  9 Sep 2017 03:46:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756808AbdIHRq2 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 8 Sep 2017 13:46:28 -0400","from mo4-p00-ob.smtp.rzone.de ([81.169.146.219]:32806 \"EHLO\n\tmo4-p00-ob.smtp.rzone.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756770AbdIHRqZ (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 8 Sep 2017 13:46:25 -0400","from [192.168.40.200] (p4FF2E9F1.dip0.t-ipconnect.de\n\t[79.242.233.241]) by smtp.strato.de (RZmta 41.4 DYNA|AUTH)\n\twith ESMTPSA id Y0a1b6t88HkIfdf\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve\n\tsecp521r1 with 521 ECDH bits, eq. 15360 bits RSA))\n\t(Client did not present a certificate);\n\tFri, 8 Sep 2017 19:46:18 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; t=1504892783;\n\ts=domk; d=hartkopp.net;\n\th=Content-Transfer-Encoding:Content-Language:Content-Type:In-Reply-To:\n\tMIME-Version:Date:From:References:Cc:To:Subject;\n\tbh=OfV5Nb6LYn26zyGAST5xk4Yl3ypLfNQdS8c9ohxqynI=;\n\tb=ptoWY699/S4iVt9AvunNXV7HkaQrtCd7fXDBg8Dx//5PcKa1vKiz6eJGJsA8YeDcIJ\n\t9GaUgjA22xzpTHf23YUoQ/DQRt5P/U0ur5zZtoeUNny0+mcyEHmOMdMcIk6lXm21LlQN\n\tWouDSZHCDyDQuBKvz1PvUwDAq2dsB9h9XAY2E=","X-RZG-AUTH":":P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrT1q0ngWNsKR9DbcDvsfbZ70J0gsQNRtvkOg==","X-RZG-CLASS-ID":"mo00","Subject":"Re: [PATCH] can: check for null sk before deferencing it via the\n\tcall to sock_net","To":"Colin King <colin.king@canonical.com>,\n\tMarc Kleine-Budde <mkl@pengutronix.de>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tlinux-can@vger.kernel.org, netdev@vger.kernel.org","Cc":"kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20170908150235.2931-1-colin.king@canonical.com>","From":"Oliver Hartkopp <socketcan@hartkopp.net>","Message-ID":"<f5ce1047-eb37-151a-c7b7-9b47b70789f7@hartkopp.net>","Date":"Fri, 8 Sep 2017 19:46:13 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170908150235.2931-1-colin.king@canonical.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1787567,"web_url":"http://patchwork.ozlabs.org/comment/1787567/","msgid":"<CA+5PVA7fJfZmN-XLuqARGkWL6eY54HaRAj19K_Und3K7vAVfpg@mail.gmail.com>","list_archive_url":null,"date":"2017-10-16T16:37:07","subject":"Re: [PATCH] can: check for null sk before deferencing it via the\n\tcall to sock_net","submitter":{"id":48088,"url":"http://patchwork.ozlabs.org/api/people/48088/","name":"Josh Boyer","email":"jwboyer@fedoraproject.org"},"content":"On Fri, Sep 8, 2017 at 1:46 PM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:\n>\n>\n> On 09/08/2017 05:02 PM, Colin King wrote:\n>>\n>> From: Colin Ian King <colin.king@canonical.com>\n>>\n>> The assignment of net via call sock_net will dereference sk. This\n>> is performed before a sanity null check on sk, so there could be\n>> a potential null dereference on the sock_net call if sk is null.\n>> Fix this by assigning net after the sk null check. Also replace\n>> the sk == NULL with the more usual !sk idiom.\n>>\n>> Detected by CoverityScan CID#1431862 (\"Dereference before null check\")\n>>\n>> Fixes: 384317ef4187 (\"can: network namespace support for CAN_BCM\n>> protocol\")\n>> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n>\n>\n> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>\n\nI don't see this one queued up in the net or net-next trees.  Did it\nfall through the cracks or did it get queued up elsewhere?  Seems like\nit's a good candidate to get into 4.14?\n\njosh\n\n>\n>\n> Thanks Collin!\n>\n>\n>> ---\n>>   net/can/bcm.c | 5 +++--\n>>   1 file changed, 3 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/net/can/bcm.c b/net/can/bcm.c\n>> index 47a8748d953a..a3791674b8ce 100644\n>> --- a/net/can/bcm.c\n>> +++ b/net/can/bcm.c\n>> @@ -1493,13 +1493,14 @@ static int bcm_init(struct sock *sk)\n>>   static int bcm_release(struct socket *sock)\n>>   {\n>>         struct sock *sk = sock->sk;\n>> -       struct net *net = sock_net(sk);\n>> +       struct net *net;\n>>         struct bcm_sock *bo;\n>>         struct bcm_op *op, *next;\n>>   -     if (sk == NULL)\n>> +       if (!sk)\n>>                 return 0;\n>>   +     net = sock_net(sk);\n>>         bo = bcm_sk(sk);\n>>         /* remove bcm_ops, timer, rx_unregister(), etc. */\n>>\n>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"e6rjdpxv\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yG3rj2bWTz9s06\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 17 Oct 2017 03:37:25 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755974AbdJPQhM (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 16 Oct 2017 12:37:12 -0400","from mail-qk0-f196.google.com ([209.85.220.196]:52494 \"EHLO\n\tmail-qk0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755340AbdJPQhJ (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 16 Oct 2017 12:37:09 -0400","by mail-qk0-f196.google.com with SMTP id b15so13585983qkg.9;\n\tMon, 16 Oct 2017 09:37:08 -0700 (PDT)","by 10.200.8.25 with HTTP; Mon, 16 Oct 2017 09:37:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=c6mr+l+iajLUICuFcl8Mstih3AIiJFPG5Rr0lv6Jjfs=;\n\tb=e6rjdpxvt62GbHUOVM5gnPt1W2HOmE29uwx+Giufo36bLkqem3choCy4stuJMmqVdk\n\tABodnhRGiYqGwnuJuennwtg97B7XoHQ/p3H0f+CcnjzNWaSdzmb9e9jony8oAi6xdfZ7\n\tkyF2CZV+0SC0R0TQGvteMUD8lpJyIfaB80h0NxH6vxmldr3yKaPdkfeyj6l6+S8AA2Xk\n\tud6lDtoeoFowUMIg+7m4Na/ZGeMG61bSmXoJ5itaq9Z0ckRMpHo9oEE0TPVpjxEQ7+lY\n\tcW1EF7sdBpeb8CQe45NPALCtV9cmOyAPMIDjKcwmCv7TiuuOwajSg5kTp/wxd3do6jSV\n\t4Swg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=c6mr+l+iajLUICuFcl8Mstih3AIiJFPG5Rr0lv6Jjfs=;\n\tb=gwXcc9sHEt70jxaAaPTQB8fSh6Mqi5ynJMMOVcUKR/l9VvjK7folocbG0LBmOd4Xdt\n\tsro9CbNgHfEo5y6THVTAcUFgH5E1u89t4JliL8/oCl8oHWqf1d0tuBJVUgRk2Pp9vux2\n\tZCnS9l39Q2iH3Yv56hcHwCC770c84qHhpcsWhiLI3hRbXyFUI5AuQzgVbGu3G4qMyBH0\n\t8B7ZytPIbj//4phmXMDgGnIXDckXEfHTlS9ungWRqRjodYnMNoEihEYifc1PQvho5Jxb\n\tV22pfm/KLUXpPwhkHzp1v/2zTQPMwvx/vVKa4Si3QmiQQc62ZpmKb06ZvkK6QyOVvetw\n\t5dBg==","X-Gm-Message-State":"AMCzsaUvrdcA+qudUJwFJSL0vc16Rjvk934yXIlvMWNuc8snEYwYRGIa\n\tzAHVpPEwR4KAUoznNISY59Z5uzqPq6cTNNWLZaHxLw==","X-Google-Smtp-Source":"ABhQp+Q6Zcwk9fau9cmaa9tHYg/5NkPevwLFqfkNclr/vCZvZSlXVo4QgUlq1faH2VvqWxvhUcFlv7X16Onekjou7l0=","X-Received":"by 10.55.115.130 with SMTP id o124mr14622138qkc.83.1508171828127;\n\tMon, 16 Oct 2017 09:37:08 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<f5ce1047-eb37-151a-c7b7-9b47b70789f7@hartkopp.net>","References":"<20170908150235.2931-1-colin.king@canonical.com>\n\t<f5ce1047-eb37-151a-c7b7-9b47b70789f7@hartkopp.net>","From":"Josh Boyer <jwboyer@fedoraproject.org>","Date":"Mon, 16 Oct 2017 12:37:07 -0400","X-Google-Sender-Auth":"5eAbiN_VkVX7sG8FsXG1XW30oCo","Message-ID":"<CA+5PVA7fJfZmN-XLuqARGkWL6eY54HaRAj19K_Und3K7vAVfpg@mail.gmail.com>","Subject":"Re: [PATCH] can: check for null sk before deferencing it via the\n\tcall to sock_net","To":"Oliver Hartkopp <socketcan@hartkopp.net>","Cc":"Colin King <colin.king@canonical.com>,\n\tMarc Kleine-Budde <mkl@pengutronix.de>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tlinux-can@vger.kernel.org, netdev <netdev@vger.kernel.org>,\n\tkernel-janitors@vger.kernel.org,\n\t\"Linux-Kernel@Vger. Kernel. Org\" <linux-kernel@vger.kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1787616,"web_url":"http://patchwork.ozlabs.org/comment/1787616/","msgid":"<c50ebff0-233c-7dcf-1b80-19ac0369803a@hartkopp.net>","list_archive_url":null,"date":"2017-10-16T17:32:25","subject":"Re: [PATCH] can: check for null sk before deferencing it via the\n\tcall to sock_net","submitter":{"id":1450,"url":"http://patchwork.ozlabs.org/api/people/1450/","name":"Oliver Hartkopp","email":"socketcan@hartkopp.net"},"content":"On 10/16/2017 06:37 PM, Josh Boyer wrote:\n> On Fri, Sep 8, 2017 at 1:46 PM, Oliver Hartkopp <socketcan@hartkopp.net> wrote:\n>>\n>>\n>> On 09/08/2017 05:02 PM, Colin King wrote:\n>>>\n>>> From: Colin Ian King <colin.king@canonical.com>\n>>>\n>>> The assignment of net via call sock_net will dereference sk. This\n>>> is performed before a sanity null check on sk, so there could be\n>>> a potential null dereference on the sock_net call if sk is null.\n>>> Fix this by assigning net after the sk null check. Also replace\n>>> the sk == NULL with the more usual !sk idiom.\n>>>\n>>> Detected by CoverityScan CID#1431862 (\"Dereference before null check\")\n>>>\n>>> Fixes: 384317ef4187 (\"can: network namespace support for CAN_BCM\n>>> protocol\")\n>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n>>\n>>\n>> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>\n> \n> I don't see this one queued up in the net or net-next trees.  Did it\n> fall through the cracks or did it get queued up elsewhere?  Seems like\n> it's a good candidate to get into 4.14?\n\nIt definitely is!\n\nMarc is our responsible guy for CAN related upstreams - but he seems to \nbe busy as I already poked him here:\n\nhttps://marc.info/?l=linux-can&m=150771819505097&w=2\n\nIf he doesn't send a pull request by beginning of next week, I would ask \nDave to grab these patches - to get them into 4.14.\n\nBest regards,\nOliver","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yG54f09nbz9t3Z\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 17 Oct 2017 04:32:50 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753894AbdJPRcr (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 16 Oct 2017 13:32:47 -0400","from mo4-p00-ob.smtp.rzone.de ([81.169.146.218]:10172 \"EHLO\n\tmo4-p00-ob.smtp.rzone.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753392AbdJPRcr (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Mon, 16 Oct 2017 13:32:47 -0400","from [192.168.1.200] (p4FF2F3AF.dip0.t-ipconnect.de\n\t[79.242.243.175]) by smtp.strato.de (RZmta 42.6 DYNA|AUTH)\n\twith ESMTPSA id z0b778t9GHWW4MN\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve\n\tsecp521r1 with 521 ECDH bits, eq. 15360 bits RSA))\n\t(Client did not present a certificate);\n\tMon, 16 Oct 2017 19:32:32 +0200 (CEST)"],"X-RZG-AUTH":":P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrDxb8mjG14FZxedJy6qgO1rXnMaV+PPADNDZE4Se9B","X-RZG-CLASS-ID":"mo00","Subject":"Re: [PATCH] can: check for null sk before deferencing it via the\n\tcall to sock_net","To":"Josh Boyer <jwboyer@fedoraproject.org>","Cc":"Colin King <colin.king@canonical.com>,\n\tMarc Kleine-Budde <mkl@pengutronix.de>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tlinux-can@vger.kernel.org, netdev <netdev@vger.kernel.org>,\n\tkernel-janitors@vger.kernel.org,\n\t\"Linux-Kernel@Vger. Kernel. Org\" <linux-kernel@vger.kernel.org>","References":"<20170908150235.2931-1-colin.king@canonical.com>\n\t<f5ce1047-eb37-151a-c7b7-9b47b70789f7@hartkopp.net>\n\t<CA+5PVA7fJfZmN-XLuqARGkWL6eY54HaRAj19K_Und3K7vAVfpg@mail.gmail.com>","From":"Oliver Hartkopp <socketcan@hartkopp.net>","Message-ID":"<c50ebff0-233c-7dcf-1b80-19ac0369803a@hartkopp.net>","Date":"Mon, 16 Oct 2017 19:32:25 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<CA+5PVA7fJfZmN-XLuqARGkWL6eY54HaRAj19K_Und3K7vAVfpg@mail.gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1788211,"web_url":"http://patchwork.ozlabs.org/comment/1788211/","msgid":"<8fdd94bd-da4e-784e-3832-6c1bb5e1f432@pengutronix.de>","list_archive_url":null,"date":"2017-10-17T05:49:58","subject":"Re: [PATCH] can: check for null sk before deferencing it via the\n\tcall to sock_net","submitter":{"id":2822,"url":"http://patchwork.ozlabs.org/api/people/2822/","name":"Marc Kleine-Budde","email":"mkl@pengutronix.de"},"content":"On 09/08/2017 05:02 PM, Colin King wrote:\n> From: Colin Ian King <colin.king@canonical.com>\n> \n> The assignment of net via call sock_net will dereference sk. This\n> is performed before a sanity null check on sk, so there could be\n> a potential null dereference on the sock_net call if sk is null.\n> Fix this by assigning net after the sk null check. Also replace\n> the sk == NULL with the more usual !sk idiom.\n> \n> Detected by CoverityScan CID#1431862 (\"Dereference before null check\")\n> \n> Fixes: 384317ef4187 (\"can: network namespace support for CAN_BCM protocol\")\n> Signed-off-by: Colin Ian King <colin.king@canonical.com>\n\nApplied to can.\n\nTnx,\nMarc","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGWcx0BqGz9s7m\n\tfor <patchwork-incoming@ozlabs.org>;\n\tTue, 17 Oct 2017 21:28:49 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1761131AbdJQK2r (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tTue, 17 Oct 2017 06:28:47 -0400","from metis.ext.4.pengutronix.de ([92.198.50.35]:59845 \"EHLO\n\tmetis.ext.4.pengutronix.de\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1761104AbdJQK2h (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Tue, 17 Oct 2017 06:28:37 -0400","from gallifrey.ext.pengutronix.de\n\t([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org)\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2)\n\t(envelope-from <mkl@pengutronix.de>)\n\tid 1e4P6u-0005q7-7z; Tue, 17 Oct 2017 12:28:32 +0200","from [IPv6:2001:67c:670:202:8155:6f80:7c13:cb21] (unknown\n\t[IPv6:2001:67c:670:202:8155:6f80:7c13:cb21])\n\t(using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256\n\tbits)) (Client CN \"mkl@blackshift.org\",\n\tIssuer \"StartCom Class 1 Client CA\" (not verified))\n\t(Authenticated sender: mkl@blackshift.org)\n\tby smtp.blackshift.org (Postfix) with ESMTPSA id B56772708F8;\n\tTue, 17 Oct 2017 10:28:27 +0000 (UTC)"],"Subject":"Re: [PATCH] can: check for null sk before deferencing it via the\n\tcall to sock_net","To":"Colin King <colin.king@canonical.com>,\n\tOliver Hartkopp <socketcan@hartkopp.net>,\n\t\"David S . Miller\" <davem@davemloft.net>,\n\tlinux-can@vger.kernel.org, netdev@vger.kernel.org","Cc":"kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20170908150235.2931-1-colin.king@canonical.com>","From":"Marc Kleine-Budde <mkl@pengutronix.de>","Message-ID":"<8fdd94bd-da4e-784e-3832-6c1bb5e1f432@pengutronix.de>","Date":"Tue, 17 Oct 2017 07:49:58 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170908150235.2931-1-colin.king@canonical.com>","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"kLkPTC453FQOl0tOSLf9lQ8J0w18CI4wj\"","X-SA-Exim-Connect-IP":"2001:67c:670:201:5054:ff:fe8d:eefb","X-SA-Exim-Mail-From":"mkl@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"netdev@vger.kernel.org","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]