[{"id":1765521,"web_url":"http://patchwork.ozlabs.org/comment/1765521/","msgid":"<633f5a2d-a333-5c78-1e0c-3af2a4c896f9@linaro.org>","list_archive_url":null,"date":"2017-09-08T16:58:43","subject":"Re: [Qemu-devel] [PATCH 1/1] AArch64: Fix single stepping of ERET\n\tinstruction","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/08/2017 04:02 AM, Jaroslaw Pelczar wrote:\n> Previously when single stepping through ERET instruction via GDB\n> would result in debugger entering the \"next\" PC after ERET instruction.\n> When debugging in kernel mode, this will also cause unintended behavior,\n> because debugger will try to access memory from EL0 point of view.\n> \n> Signed-off-by: Jaroslaw Pelczar \n> ---\n> target/arm/translate-a64.c | 1 +\n> 1 file changed, 1 insertion(+)\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"G6uRquyg\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpk7V1m6Bz9s7h\n\tfor ;\n\tSat, 9 Sep 2017 02:59:17 +1000 (AEST)","from localhost ([::1]:46499 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqMcb-0007iP-9G\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 12:59:13 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52340)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqMcE-0007i4-NL\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 12:58:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqMcB-0006ps-Oh\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 12:58:50 -0400","from mail-pg0-x22a.google.com ([2607:f8b0:400e:c05::22a]:33459)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqMcB-0006pZ-IA\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 12:58:47 -0400","by mail-pg0-x22a.google.com with SMTP id t3so5797581pgt.0\n\tfor ; Fri, 08 Sep 2017 09:58:47 -0700 (PDT)","from bigtime.twiddle.net (97-126-108-236.tukw.qwest.net.\n\t[97.126.108.236]) by smtp.gmail.com with ESMTPSA id\n\tv8sm3719461pgs.9.2017.09.08.09.58.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 09:58:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=JuRrKduGsTrQ9nvEQO7m5T/MVsADGK7MYb5Gx1XVwjQ=;\n\tb=G6uRquygYbIWdABWUwjVkAgxvW4nOoMuToE2tKnMhDwxxra8wms+QBNF3Wj9eAm3/A\n\trQAcaO71dcuW3rJPJf31pIvqLmaklV+3I4mVBDps3BbsUXGsCkWlerMsYjr1KNvhHeIU\n\tWCfbZ+olBY97c2LgXNHYQuPDaaNJ3kesRpznk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=JuRrKduGsTrQ9nvEQO7m5T/MVsADGK7MYb5Gx1XVwjQ=;\n\tb=D4XtKdym9vsTBm7IKaFoyYR0ujpwToTmCa0eCawwN3KVvkYB0OevTbjqQNEJSunPdH\n\txuSs5kP731AHnfMDdpmUix6vbr6NYtUahNdd/tZmtKgADZuzrkmM+LAn9dadWuJCm6mc\n\td9hC83GC8P9JwQB2mvDrc8awbfJoN7Y9PXzVjPbWCZYTcYT7v0o3WNkyQ/QNR4AKkOrh\n\t3WJLe7FgVZzL9cEGQGh4yebwXapwO7JrwUp12dcHQDuGzs9hq4EQBO858meuuXEVrCNk\n\tF21AdV5OMt16wy6hjk1cHnd3+0dbtSAHkay8uLwvOb+cLXhXEO/7r2ZAdstt/N7dGj9G\n\tLsXA==","X-Gm-Message-State":"AHPjjUhnH0AZNFeNOtgmQ03/k/GsD+lcwzMuTz/hhGe0GBRqGYKFPohD\n\t31qPGGFwDKxSKGLe","X-Google-Smtp-Source":"ADKCNb5SHiaqc+TQPA0gI4ZimdigY9fQsG+dOl378ZDYDwydgg5qeMLfEHaW6v2k4VauHJ4GJes2nA==","X-Received":"by 10.99.5.204 with SMTP id 195mr3724982pgf.231.1504889926223;\n\tFri, 08 Sep 2017 09:58:46 -0700 (PDT)","To":"Jaroslaw Pelczar , qemu-devel@nongnu.org,\n\t\"open list:ARM\" ","References":"\n\t<001801d32891$ec40b930$c4c22b90$@samsung.com>","From":"Richard Henderson ","Message-ID":"<633f5a2d-a333-5c78-1e0c-3af2a4c896f9@linaro.org>","Date":"Fri, 8 Sep 2017 09:58:43 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<001801d32891$ec40b930$c4c22b90$@samsung.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::22a","Subject":"Re: [Qemu-devel] [PATCH 1/1] AArch64: Fix single stepping of ERET\n\tinstruction","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768556,"web_url":"http://patchwork.ozlabs.org/comment/1768556/","msgid":"","list_archive_url":null,"date":"2017-09-14T12:34:34","subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 1/1] AArch64: Fix single\n\tstepping of ERET instruction","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 8 September 2017 at 17:58, Richard Henderson\n wrote:\n> On 09/08/2017 04:02 AM, Jaroslaw Pelczar wrote:\n>> Previously when single stepping through ERET instruction via GDB\n>> would result in debugger entering the \"next\" PC after ERET instruction.\n>> When debugging in kernel mode, this will also cause unintended behavior,\n>> because debugger will try to access memory from EL0 point of view.\n>>\n>> Signed-off-by: Jaroslaw Pelczar \n>> ---\n>> target/arm/translate-a64.c | 1 +\n>> 1 file changed, 1 insertion(+)\n>\n> Reviewed-by: Richard Henderson \n\nApplied, thanks.\n\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"UjEd+ENS\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtJ1K61S5z9sP1\n\tfor ;\n\tThu, 14 Sep 2017 22:36:21 +1000 (AEST)","from localhost ([::1]:47610 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsTNT-0007bb-TP\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 08:36:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59035)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsTM9-00071B-GN\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 08:34:58 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsTM8-0001Mx-Bb\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 08:34:57 -0400","from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:47982)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsTM8-0001Jv-3y\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 08:34:56 -0400","by mail-wm0-x22a.google.com with SMTP id 13so593524wmq.2\n\tfor ; Thu, 14 Sep 2017 05:34:55 -0700 (PDT)","by 10.223.139.215 with HTTP; Thu, 14 Sep 2017 05:34:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=G+MebRNtbp+czYxcbUarIFSXo96/Od+mLtLgs0xfI1I=;\n\tb=UjEd+ENS+CdCPgU93sK/DCxd2G11YYlJ11V66LN0RfkWdT9f+A+cheZ7VsFvRLcTrV\n\t6l3wAutdKOwStGOqlHjfpGb+W1YmSXhHomdDfQ71awQf4lbTBHcG1JP2/xds6FVTxu8T\n\tEUg+2IDXZldEKVd2pzdgq9zKelO16dEe7pTBw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=G+MebRNtbp+czYxcbUarIFSXo96/Od+mLtLgs0xfI1I=;\n\tb=M0+qpSTLl1HeKPvpieVKPxUDNfN3bk7J69R1fjsO3UzijnH0hvB82dcqXd6sRcn57Z\n\tGsIQHs/ulMc+OTfBP0rNoeJJlaK9IKTqL8B8jsO4X8PAuSNLPCdjz7+VHNkMeTI42+eA\n\tRT0u+mTidMjRc++diccAySsW/xko31q5Y/AgyJIeGl/6kfNIJE13hHPwUKVpVKOf8/UF\n\txbVYhywUe+xSMA1ndyicnleovyt8SS7SitE3Y3UwTgO8kt3HbKF4Fk69LfKwk2lA8W8o\n\t6eMPUH7ytouF/11sd31vrplUBOuGTETzs8Pj4Fu/RARq0iQmbWOOse6VaXdLQ+YJHI+4\n\tZLmg==","X-Gm-Message-State":"AHPjjUhYvDabLIeZA20rF1Do+muMY0UXoAwHp5fKyWl8aZOs8yHQvAlQ\n\tOFIRZMSH9Qt8vn6DuX1wPhNAc8UaMkUgtQJR5lJCLw==","X-Google-Smtp-Source":"AOwi7QB3Ck5nMwKxEGM5uGvbBkO2gkhUX5UMQHdo7l1GOg+IaQgWy4nhD+ZMRQixrVkf4paalcFPMwG/JYkLBXEJ5Ps=","X-Received":"by 10.28.23.5 with SMTP id 5mr1746085wmx.62.1505392494924;\n\tThu, 14 Sep 2017 05:34:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<633f5a2d-a333-5c78-1e0c-3af2a4c896f9@linaro.org>","References":"\n\t<001801d32891$ec40b930$c4c22b90$@samsung.com>\n\t<633f5a2d-a333-5c78-1e0c-3af2a4c896f9@linaro.org>","From":"Peter Maydell ","Date":"Thu, 14 Sep 2017 13:34:34 +0100","Message-ID":"","To":"Richard Henderson ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::22a","Subject":"Re: [Qemu-devel] [Qemu-arm] [PATCH 1/1] AArch64: Fix single\n\tstepping of ERET instruction","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"\"open list:ARM\" ,\n\tJaroslaw Pelczar ,\n\tQEMU Developers ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]