[{"id":1766816,"web_url":"http://patchwork.ozlabs.org/comment/1766816/","msgid":"<5bb799fe-f455-adfa-e1c0-84f14c088536@denx.de>","list_archive_url":null,"date":"2017-09-12T09:29:41","subject":"Re: [swupdate] [PATCH 2/3] tmpdir: make use of get_tmpdir()","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/people/5771/","name":"Stefano Babic","email":"sbabic@denx.de"},"content":"On 08/09/2017 15:45, Christian Storm wrote:\n> Adapt the usages of former #define'd TMPDIR to\n> make use of get_tmpdir() instead.\n> \n> Signed-off-by: Christian Storm \n> ---\n> core/cpio_utils.c | 1 +\n> core/swupdate.c | 16 ++++++++++++----\n> corelib/installer.c | 11 +++++++++--\n> corelib/stream_interface.c | 3 ++-\n> handlers/archive_handler.c | 9 ++++++++-\n> handlers/boot_handler.c | 1 +\n> handlers/raw_handler.c | 2 ++\n> handlers/shell_scripthandler.c | 10 ++++++----\n> include/globals.h | 8 ++++----\n> 9 files changed, 45 insertions(+), 16 deletions(-)\n> \n> diff --git a/core/cpio_utils.c b/core/cpio_utils.c\n> index c3df86f..e8651a3 100644\n> --- a/core/cpio_utils.c\n> +++ b/core/cpio_utils.c\n> @@ -342,6 +342,7 @@ off_t extract_sw_description(int fd, const char *descfile, off_t start)\n> \tchar output_file[64];\n> \tuint32_t checksum;\n> \tint fdout;\n> +\tconst char* TMPDIR = get_tmpdir();\n> \n> \tif (extract_cpio_header(fd, &fdh, &offset)) {\n> \t\tERROR(\"CPIO Header wrong\\n\");\n> diff --git a/core/swupdate.c b/core/swupdate.c\n> index 1f0ba0d..3057000 100644\n> --- a/core/swupdate.c\n> +++ b/core/swupdate.c\n> @@ -305,7 +305,9 @@ static int install_from_file(char *fname, int check)\n> \t\tpos);\n> #endif\n> \n> -\tret = parse(&swcfg, TMPDIR SW_DESCRIPTION_FILENAME);\n> +\tchar* swdescfilename = alloca(strlen(get_tmpdir())+strlen(SW_DESCRIPTION_FILENAME)+1);\n> +\tsprintf(swdescfilename, \"%s%s\", get_tmpdir(), SW_DESCRIPTION_FILENAME);\n> +\tret = parse(&swcfg, swdescfilename);\n> \tif (ret) {\n> \t\tERROR(\"failed to parse \" SW_DESCRIPTION_FILENAME \"!\\n\");\n> \t\texit(1);\n> @@ -394,6 +396,12 @@ static int parse_image_selector(const char *selector, struct swupdate_cfg *sw)\n> \treturn 0;\n> }\n> \n> +static void create_directory(const char* path) {\n> +\tchar* dpath = alloca(strlen(get_tmpdir())+strlen(path)+1);\n> +\tsprintf(dpath, \"%s%s\", get_tmpdir(), path);\n> +\tmkdir(dpath, 0777);\n> +}\n> +\n> static void swupdate_init(struct swupdate_cfg *sw)\n> {\n> \t/* Initialize internal tree to store configuration */\n> @@ -407,9 +415,9 @@ static void swupdate_init(struct swupdate_cfg *sw)\n> \n> \n> \t/* Create directories for scripts */\n> -\tmkdir(SCRIPTS_DIR, 0777);\n> -\tmkdir(DATASRC_DIR, 0777);\n> -\tmkdir(DATADST_DIR, 0777);\n> +\tcreate_directory(SCRIPTS_DIR_SUFFIX);\n> +\tcreate_directory(DATASRC_DIR_SUFFIX);\n> +\tcreate_directory(DATADST_DIR_SUFFIX);\n> \n> #ifdef CONFIG_MTD\n> \tmtd_init();\n> diff --git a/corelib/installer.c b/corelib/installer.c\n> index ad0e0f1..8a188a1 100644\n> --- a/corelib/installer.c\n> +++ b/corelib/installer.c\n> @@ -86,6 +86,7 @@ int check_if_required(struct imglist *list, struct filehdr *pfdh,\n> \tint skip = SKIP_FILE;\n> \tstruct img_type *img;\n> \tint img_skip = 0;\n> +\tconst char* TMPDIR = get_tmpdir();\n> \n> \t/*\n> \t * Check that not more as one image wnat to be streamed\n> @@ -204,7 +205,9 @@ static int update_bootloader_env(void)\n> \tint ret = 0;\n> \n> \tTRACE(\"Updating bootloader environment\");\n> -\tret = bootloader_apply_list((char *)BOOT_SCRIPT);\n> +\tchar* bootscript = alloca(strlen(get_tmpdir())+strlen(BOOT_SCRIPT_SUFFIX)+1);\n> +\tsprintf(bootscript, \"%s%s\", get_tmpdir(), BOOT_SCRIPT_SUFFIX);\n> +\tret = bootloader_apply_list(bootscript);\n> \tif (ret < 0)\n> \t\tERROR(\"Error updating bootloader environment\");\n> \n> @@ -250,6 +253,7 @@ int install_images(struct swupdate_cfg *sw, int fdsw, int fromfile)\n> \tchar filename[64];\n> \tstruct filehdr fdh;\n> \tstruct stat buf;\n> +\tconst char* TMPDIR = get_tmpdir();\n> \n> \t/* Extract all scripts, preinstall scripts must be run now */\n> \tif (fromfile) {\n> @@ -268,7 +272,9 @@ int install_images(struct swupdate_cfg *sw, int fdsw, int fromfile)\n> \t}\n> \n> \t/* Update u-boot environment */\n> -\tret = prepare_boot_script(sw, BOOT_SCRIPT);\n> +\tchar* bootscript = alloca(strlen(TMPDIR)+strlen(BOOT_SCRIPT_SUFFIX)+1);\n> +\tsprintf(bootscript, \"%s%s\", TMPDIR, BOOT_SCRIPT_SUFFIX);\n> +\tret = prepare_boot_script(sw, bootscript);\n> \tif (ret) {\n> \t\treturn ret;\n> \t}\n> @@ -377,6 +383,7 @@ void cleanup_files(struct swupdate_cfg *software) {\n> \tstruct img_type *img;\n> \tstruct dict_entry *bootvar;\n> \tstruct hw_type *hw;\n> +\tconst char* TMPDIR = get_tmpdir();\n> \n> \tLIST_FOREACH(img, &software->images, next) {\n> \t\tif (img->fname[0]) {\n> diff --git a/corelib/stream_interface.c b/corelib/stream_interface.c\n> index 30e99ce..fb56c96 100644\n> --- a/corelib/stream_interface.c\n> +++ b/corelib/stream_interface.c\n> @@ -89,6 +89,7 @@ static int extract_file_to_tmp(int fd, const char *fname, unsigned long *poffs)\n> \tstruct filehdr fdh;\n> \tint fdout;\n> \tuint32_t checksum;\n> +\tconst char* TMPDIR = get_tmpdir();\n> \n> \tif (extract_cpio_header(fd, &fdh, poffs)) {\n> \t\treturn -1;\n> @@ -135,7 +136,7 @@ static int extract_files(int fd, struct swupdate_cfg *software)\n> \tint fdout;\n> \tstruct img_type *img, *part;\n> \tchar output_file[MAX_IMAGE_FNAME];\n> -\n> +\tconst char* TMPDIR = get_tmpdir();\n> \n> \t/* preset the info about the install parts */\n> \n> diff --git a/handlers/archive_handler.c b/handlers/archive_handler.c\n> index 0568a41..f86d1f2 100644\n> --- a/handlers/archive_handler.c\n> +++ b/handlers/archive_handler.c\n> @@ -34,7 +34,7 @@\n> #include \"handler.h\"\n> #include \"util.h\"\n> \n> -#define FIFO\tTMPDIR \"archivfifo\"\n> +#define FIFO_FILE_NAME \"archivfifo\"\n> \n> /* Just to turn on during development */\n> static int debug = 0;\n> @@ -103,6 +103,8 @@ extract(void *p)\n> \t * Enabling bzip2 is more expensive because the libbz2 library\n> \t * isn't very well factored.\n> \t */\n> +\tchar* FIFO = alloca(strlen(get_tmpdir())+strlen(FIFO_FILE_NAME)+1);\n> +\tsprintf(FIFO, \"%s%s\", get_tmpdir(), FIFO_FILE_NAME);\n> \tif ((r = archive_read_open_filename(a, FIFO, 4096))) {\n> \t\tERROR(\"archive_read_open_filename(): %s %d\\n\",\n> \t\t archive_error_string(a), r);\n> @@ -154,6 +156,9 @@ static int install_archive_image(struct img_type *img,\n> \tvoid *status;\n> \tint use_mount = (strlen(img->device) && strlen(img->filesystem)) ? 1 : 0;\n> \n> +\tchar* DATADST_DIR = alloca(strlen(get_tmpdir())+strlen(DATADST_DIR_SUFFIX)+1);\n> +\tsprintf(DATADST_DIR, \"%s%s\", get_tmpdir(), DATADST_DIR_SUFFIX);\n> +\n> \tpthread_attr_init(&attr);\n> \tpthread_attr_setdetachstate(&attr, PTHREAD_CREATE_JOINABLE);\n> \n> @@ -182,6 +187,8 @@ static int install_archive_image(struct img_type *img,\n> \t\t}\n> \t}\n> \n> +\tchar* FIFO = alloca(strlen(get_tmpdir())+strlen(FIFO_FILE_NAME)+1);\n> +\tsprintf(FIFO, \"%s%s\", get_tmpdir(), FIFO_FILE_NAME);\n> \tunlink(FIFO);\n> \tret = mkfifo(FIFO, 0666);\n> \tif (ret) {\n> diff --git a/handlers/boot_handler.c b/handlers/boot_handler.c\n> index f2d4aaf..41f87f7 100644\n> --- a/handlers/boot_handler.c\n> +++ b/handlers/boot_handler.c\n> @@ -44,6 +44,7 @@ static int install_boot_environment(struct img_type *img,\n> \tchar filename[64];\n> \tstruct stat statbuf;\n> \n> +\tconst char* TMPDIR = get_tmpdir();\n> \tif (snprintf(filename, sizeof(filename), \"%s%s\", TMPDIR,\n> \t\t img->fname) >= (int)sizeof(filename)) {\n> \t\tERROR(\"Path too long: %s%s\", TMPDIR, img->fname);\n> diff --git a/handlers/raw_handler.c b/handlers/raw_handler.c\n> index 4b567fb..91e9bb7 100644\n> --- a/handlers/raw_handler.c\n> +++ b/handlers/raw_handler.c\n> @@ -59,6 +59,8 @@ static int install_raw_file(struct img_type *img,\n> \tint fdout;\n> \tint ret = 0;\n> \tint use_mount = (strlen(img->device) && strlen(img->filesystem)) ? 1 : 0;\n> +\tchar* DATADST_DIR = alloca(strlen(get_tmpdir())+strlen(DATADST_DIR_SUFFIX)+1);\n> +\tsprintf(DATADST_DIR, \"%s%s\", get_tmpdir(), DATADST_DIR_SUFFIX);\n> \n> \tif (strlen(img->path) == 0) {\n> \t\tERROR(\"Missing path attribute\");\n> diff --git a/handlers/shell_scripthandler.c b/handlers/shell_scripthandler.c\n> index adda3ad..9095a5f 100644\n> --- a/handlers/shell_scripthandler.c\n> +++ b/handlers/shell_scripthandler.c\n> @@ -40,17 +40,19 @@ static void shell_postinstall_handler(void);\n> static int execute_shell_script(struct img_type *img, const char *fnname)\n> {\n> \tint ret;\n> -\tchar shellscript[MAX_IMAGE_FNAME +\n> -\t\tstrlen(SCRIPTS_DIR) + strlen(\"postinst\") + 2];\n> +\tconst char* TMPDIR = get_tmpdir();\n> +\n> +\tchar shellscript[MAX_IMAGE_FNAME + strlen(TMPDIR) +\n> +\t\tstrlen(SCRIPTS_DIR_SUFFIX) + strlen(\"postinst\") + 2];\n> \n> \tsnprintf(shellscript, sizeof(shellscript),\n> -\t\t\"%s%s\", TMPDIR, img->fname);\n> +\t\t\"%s%s%s\", TMPDIR, SCRIPTS_DIR_SUFFIX, img->fname);\n> \tif (chmod(shellscript, S_IRUSR | S_IWUSR | S_IXUSR)) {\n> \t\tERROR(\"Execution bit cannot be set for %s\", shellscript);\n> \t\treturn -1;\n> \t}\n> \tsnprintf(shellscript, sizeof(shellscript),\n> -\t\t\"%s%s %s\", TMPDIR, img->fname, fnname);\n> +\t\t\"%s%s%s %s\", TMPDIR, SCRIPTS_DIR_SUFFIX, img->fname, fnname);\n> \n> \tret = system(shellscript);\n> \tif (WIFEXITED(ret)) {\n> diff --git a/include/globals.h b/include/globals.h\n> index 9e0c2b9..6e87839 100644\n> --- a/include/globals.h\n> +++ b/include/globals.h\n> @@ -34,10 +34,10 @@\n> #define MAX_SEEK_STRING_SIZE\t32\n> \n> /* These are fixed path to temporary files */\n> -#define SCRIPTS_DIR\tTMPDIR \"scripts/\"\n> -#define DATASRC_DIR\tTMPDIR \"datasrc/\"\n> -#define DATADST_DIR\tTMPDIR \"datadst/\"\n> -#define BOOT_SCRIPT\tTMPDIR \"boot-script\"\n> +#define SCRIPTS_DIR_SUFFIX\t\"scripts/\"\n> +#define DATASRC_DIR_SUFFIX\t\"datasrc/\"\n> +#define DATADST_DIR_SUFFIX\t\"datadst/\"\n> +#define BOOT_SCRIPT_SUFFIX\t\"boot-script\"\n> \n> #endif\n> \n> \nApplied to -master, thanks !\n\nBest regards,\nStefano Babic","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:400c:c09::237;\n\thelo=mail-wm0-x237.google.com;\n\tenvelope-from=swupdate+bncbaabbc6s33gqkgqezitv3dy@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"GvrKBLdA\"; dkim-atps=neutral"],"Received":["from mail-wm0-x237.google.com (mail-wm0-x237.google.com\n\t[IPv6:2a00:1450:400c:c09::237])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrzz16rfqz9s82\n\tfor ;\n\tTue, 12 Sep 2017 19:29:49 +1000 (AEST)","by mail-wm0-x237.google.com with SMTP id b82sf697050wmh.8\n\tfor ;\n\tTue, 12 Sep 2017 02:29:49 -0700 (PDT)","by 10.28.43.71 with SMTP id r68ls241690wmr.14.gmail; Tue, 12 Sep\n\t2017 02:29:46 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net.\n\t[2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id\n\tv184si131407wmf.9.2017.09.12.02.29.46\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 02:29:46 -0700 (PDT)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xrzyy4Szrz1qvn9;\n\tTue, 12 Sep 2017 11:29:46 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.84])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xrzyy4DPjz1qsQG;\n\tTue, 12 Sep 2017 11:29:46 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id WnMPDYuQzXYB; Tue, 12 Sep 2017 11:29:44 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tTue, 12 Sep 2017 11:29:44 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 3A5C045405CE;\n\tTue, 12 Sep 2017 11:29:44 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id zFyVYfC4P0cP; Tue, 12 Sep 2017 11:29:41 +0200 (CEST)","from [192.168.178.132] (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id A665945405CD;\n\tTue, 12 Sep 2017 11:29:41 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1505208587; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=GcfuGaucP9dyrICe4P592GXNi2eEJGOgiOkLA0gJue7jrjC4pTu8I4V9Kn9CoAfQY1\n\tLsWEOPNojed4nANQMY5g6Q/WWoFcipRtNgxEVc+nX+eJFNPSRHGq4w7Hm6kBJ95jmLho\n\tBlPgzhtY9kpfwNepUoi6cZwBsPJxlXMXerPrOOdO6ewFEtnEdWRRh5D8sEgdYFHv9MIO\n\t/6sB62QBHBnEXyHH9c8zQGzu3m8bqqTwoebFcoza9c+9GtAOKeGRclbf9ltaJExxsHWv\n\toH10cbDp9F5SECKcwpREFrKzJSj+wlCE17ULKj/jsazKlLeqZed7xRjlRQWyVXOQTBNy\n\t3afg==","i=1; a=rsa-sha256; t=1505208586; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=y8KECFr461pWXPykQCdzYczc9G7WOgszQDfzo3nYRqAaNuWIvKY09JgxXgo1i7QbA+\n\tYdZ+iGoRVTKy87R/2u0FjZCOKb0d1IXbRfmqaTVAtOG6rVgoXEGRTJCUR2eMblz34ha+\n\tZyR+CG5wBRBhiEppFch8b5mv1EDCkghfA/RMsPcHv3iJoIIgqhFphiArvv9hED70JT1Z\n\tLE0SiwyYpw2PCXzF26Ozp5eF8sRlfzK9GDvMp05L4k0Jx8wjR4a+krOrEFnfIIdw4JO9\n\tZggxLUbsIRuOqjC5ujGAVupwwwXtVpXyy5XAzz8OITz+hRkoUk9ifsZ2NlgMTIKTlmv9\n\te2Kg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:content-language:in-reply-to\n\t:mime-version:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results:arc-message-signature:sender\n\t:dkim-signature:arc-authentication-results;\n\tbh=a1LiSzLic7ESyAVT2Kci1xNTc/nQSyVXii3x0nokSbk=;\n\tb=WPm6xMJnesKImZupx41MXSiBXXLvPKkLzTlG73fJb6SMT6k3D7ve5GzJbaLqc2TZwh\n\tADljY9viyHM5cEck7ilOWvAOcr6AliGTup7nqYJROYMXqbKnwWPrkhSNunhM1BcVethf\n\trpbztLjFPIEk1GKvHh03Px/gG0vMHzzP5hrIZwWsqZ08JG0D56psIK/SpB7ZDfufhpVE\n\t7FZoxCCRRgFqxvdwp1AygiueolhYIpZ67EYmCLOAzMouJss5nlGb050+dHGWduQUVjPj\n\tHBCUhFoKYtu1Min4M8BZwBhHEd75a3g+n+m+Ha268CoxtfHN39wgo53m1gDj4omXZm34\n\tp8PA==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=content-transfer-encoding:content-language:in-reply-to:mime-version\n\t:user-agent:date:message-id:from:references:to:subject\n\t:arc-authentication-results;\n\tbh=76/GeNG67CHLBLJ/6F3E8f361LSdVyGtecOpZi2jUO8=;\n\tb=pNNx9ic6Xqe7VPMpc1MYdvSHOnXL42Wt5TSeVBNy/1kgBHmO2v5M2U8mooeDqFqFDp\n\tjGnVaK1RXvmKBz7e2wfws1Q5jCPd3TNxewuLUkEo+EQobbKjC8FRiHBlvI/bf3tGXzTb\n\tIFhA+ZhmMqMWaDz8hd2PFDntxPImEVx/VgvjzG4fmtEp5LLCnzCEXHZKlnFD7BoUIZPW\n\t4KfE59W3xg8FyHZGEgo2AprXA5VZm8IBQ403TCb3iabmKwSAoPwYwQPUxllgvmp55Mej\n\tizN+jB3m4pR2D07lnCLDAEZ7X0NtxASgyrmHCPTzRF2iOpXCnKoQMhZnp7UTHd3d1zUn\n\teu7g=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:subject:to:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:x-original-sender\n\t:x-original-authentication-results:precedence:mailing-list:list-id\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=a1LiSzLic7ESyAVT2Kci1xNTc/nQSyVXii3x0nokSbk=;\n\tb=GvrKBLdA1Ye++6bVMRZKuCUWobkZ/YtjrF/W6vIn6zt00Y1rHmM8osbV/9tBA/7L3n\n\tE2S8ret3l34kviCOghDLuWHscPW4cnvLWnrhczaZ52gEW6iVSX0J52252l3inV6Ro++6\n\tqcYjZoSFFkdV1JbgH7WYazARA33zKTpThFw5PWX2Ic+xIW6a1bKZWlvee0usmXYpTs2i\n\twNCbw+BQ1C3BFgoqN0jzXX8yS+oAzJ4b5oIN9ktvgrAM3miSjHsx6uJUpgib5viz08a6\n\tOA44b89t4uyUNovAFVNbrWRpPdmpForCOWKiM9DKWI/Z91E1w186IUzjX3hDHVLVeBwi\n\t3KRg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:subject:to:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:x-spam-checked-in-group:list-post:list-help\n\t:list-archive:list-subscribe:list-unsubscribe;\n\tbh=a1LiSzLic7ESyAVT2Kci1xNTc/nQSyVXii3x0nokSbk=;\n\tb=e6+HZQUk2prnOEd0ZZAPWt5Y72SJiXyi5r9BtvNprVNjOfcy26mutCCIWPLIyQ3UnR\n\t12tFOzfPwuiJYR/nq7nndMWh0dmSAUdbM8xOMvZl654kghOWbf0AquudO+su9hdu+6Am\n\txjXwE7sl1Exb9hriN7mSQ72tTvu3qdCQmUCkGYIMOumomy+UY0Sa8vAcZPTSCvGb7miF\n\tTn8OJhKbruRDe+pkf0NT1WhLnr2d7z7/P+p/LFTcjesjnCoAkRtlq3oK5EX1yEuE9209\n\tipIj0bOcxoHqhGgU4R9UDdeHXwmXhkuriIvUqPlI/Hc6qN76D+Rdyk5SIsVVTION0NME\n\t80oA==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHPjjUjHRA1kACTwbA1FLHZW6a/5AVGf1MapKoL3GJrGgBwuJXfIYkEU\n\tcI01ro2CTMgsRLxvM1dmIUg=","X-Google-Smtp-Source":"AOwi7QBY3xD61Es5zwPYPy2zd9sI79TVLaJ91OYY4tgzNoBWCgNfi7pmXSfuRgrKQgL8+zQNlXKL/A==","X-Received":["by 10.28.109.83 with SMTP id i80mr23234wmc.28.1505208587253;\n\tTue, 12 Sep 2017 02:29:47 -0700 (PDT)","by 10.28.212.14 with SMTP id l14mr31409wmg.11.1505208586835;\n\tTue, 12 Sep 2017 02:29:46 -0700 (PDT)"],"X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither\n\tpermitted nor denied by best guess record for domain of\n\tsbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"Subject":"Re: [swupdate] [PATCH 2/3] tmpdir: make use of get_tmpdir()","To":"Christian Storm , swupdate@googlegroups.com","References":"<20170908134547.9170-1-christian.storm@siemens.com>\n\t<20170908134547.9170-2-christian.storm@siemens.com>","From":"Stefano Babic ","Message-ID":"<5bb799fe-f455-adfa-e1c0-84f14c088536@denx.de>","Date":"Tue, 12 Sep 2017 11:29:41 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170908134547.9170-2-christian.storm@siemens.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Language":"de-DE","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied\n\tby best\n\tguess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"}}]