[{"id":1766161,"web_url":"http://patchwork.ozlabs.org/comment/1766161/","msgid":"","list_archive_url":null,"date":"2017-09-11T09:23:40","subject":"ACK/cmnt: [SRU][Zesty][azure][PATCH 1/1] CIFS: Fix maximum SMB2\n\theader size","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 08.09.2017 15:06, Joseph Salisbury wrote:\n> From: Pavel Shilovsky \n> \n> BugLink: http://bugs.launchpad.net/bugs/1713884\n> \n> Currently the maximum size of SMB2/3 header is set incorrectly which\n> leads to hanging of directory listing operations on encrypted SMB3\n> connections. Fix this by setting the maximum size to 170 bytes that\n> is calculated as RFC1002 length field size (4) + transform header\n> size (52) + SMB2 header size (64) + create response size (56).\n> \n> Cc: \n> Signed-off-by: Pavel Shilovsky \n> Signed-off-by: Steve French \n> Acked-by: Sachin Prabhu \n> (cherry picked from commit 9e37b1784f2be9397a903307574ee565bbadfd75)\n> Signed-off-by: Joseph Salisbury \nAcked-by: Stefan Bader \n\n> ---\n\nNote that this is part of 4.4.87 stable for Xenial.\n\n-Stefan\n> fs/cifs/smb2pdu.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h\n> index 18700fd..2826882 100644\n> --- a/fs/cifs/smb2pdu.h\n> +++ b/fs/cifs/smb2pdu.h\n> @@ -84,8 +84,8 @@\n> \n> #define NUMBER_OF_SMB2_COMMANDS\t0x0013\n> \n> -/* BB FIXME - analyze following length BB */\n> -#define MAX_SMB2_HDR_SIZE 0x78 /* 4 len + 64 hdr + (2*24 wct) + 2 bct + 2 pad */\n> +/* 4 len + 52 transform hdr + 64 hdr + 56 create rsp */\n> +#define MAX_SMB2_HDR_SIZE 0x00b0\n> \n> #define SMB2_PROTO_NUMBER cpu_to_le32(0x424d53fe)\n> #define SMB2_TRANSFORM_PROTO_NUM cpu_to_le32(0x424d53fd)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrMtb4RKKz9s75;\n\tMon, 11 Sep 2017 19:23:51 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1drKwR-0003BA-33; Mon, 11 Sep 2017 09:23:43 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1drKwP-0003Ad-Cl\n\tfor kernel-team@lists.ubuntu.com; Mon, 11 Sep 2017 09:23:41 +0000","from 1.general.smb.uk.vpn ([10.172.193.28])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1drKwP-0005ZD-51\n\tfor kernel-team@lists.ubuntu.com; Mon, 11 Sep 2017 09:23:41 +0000"],"Subject":"ACK/cmnt: [SRU][Zesty][azure][PATCH 1/1] CIFS: Fix maximum SMB2\n\theader size","To":"kernel-team@lists.ubuntu.com","References":"\n\t","From":"Stefan Bader ","Message-ID":"","Date":"Mon, 11 Sep 2017 11:23:40 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============8084722073061296889==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1766244,"web_url":"http://patchwork.ozlabs.org/comment/1766244/","msgid":"<2e50d6c8-6ae6-542a-71a3-d09b32bdc3e8@canonical.com>","list_archive_url":null,"date":"2017-09-11T11:37:46","subject":"ACK: [SRU][Xenial][Zesty][Artful][azure][PATCH 1/1] CIFS: Fix\n\tmaximum SMB2 header size","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/","name":"Colin Ian King","email":"colin.king@canonical.com"},"content":"On 08/09/17 14:06, Joseph Salisbury wrote:\n> From: Pavel Shilovsky \n> \n> BugLink: http://bugs.launchpad.net/bugs/1713884\n> \n> Currently the maximum size of SMB2/3 header is set incorrectly which\n> leads to hanging of directory listing operations on encrypted SMB3\n> connections. Fix this by setting the maximum size to 170 bytes that\n> is calculated as RFC1002 length field size (4) + transform header\n> size (52) + SMB2 header size (64) + create response size (56).\n> \n> Cc: \n> Signed-off-by: Pavel Shilovsky \n> Signed-off-by: Steve French \n> Acked-by: Sachin Prabhu \n> (cherry picked from commit 9e37b1784f2be9397a903307574ee565bbadfd75)\n> Signed-off-by: Joseph Salisbury \n> ---\n> fs/cifs/smb2pdu.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h\n> index 18700fd..2826882 100644\n> --- a/fs/cifs/smb2pdu.h\n> +++ b/fs/cifs/smb2pdu.h\n> @@ -84,8 +84,8 @@\n> \n> #define NUMBER_OF_SMB2_COMMANDS\t0x0013\n> \n> -/* BB FIXME - analyze following length BB */\n> -#define MAX_SMB2_HDR_SIZE 0x78 /* 4 len + 64 hdr + (2*24 wct) + 2 bct + 2 pad */\n> +/* 4 len + 52 transform hdr + 64 hdr + 56 create rsp */\n> +#define MAX_SMB2_HDR_SIZE 0x00b0\n> \n> #define SMB2_PROTO_NUMBER cpu_to_le32(0x424d53fe)\n> #define SMB2_TRANSFORM_PROTO_NUM cpu_to_le32(0x424d53fd)\n> \nClean cherry pick.\n\nAcked-by: Colin Ian King ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrQsD1ZFYz9sBd;\n\tMon, 11 Sep 2017 21:37:52 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1drN2C-0007Gr-Od; Mon, 11 Sep 2017 11:37:48 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1drN2B-0007G5-0Q\n\tfor kernel-team@lists.ubuntu.com; Mon, 11 Sep 2017 11:37:47 +0000","from 1.general.cking.uk.vpn ([10.172.193.212])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1drN2A-0003NI-Mh; Mon, 11 Sep 2017 11:37:46 +0000"],"Subject":"ACK: [SRU][Xenial][Zesty][Artful][azure][PATCH 1/1] CIFS: Fix\n\tmaximum SMB2 header size","To":"kernel-team@lists.ubuntu.com","References":"\n\t","From":"Colin Ian King ","Message-ID":"<2e50d6c8-6ae6-542a-71a3-d09b32bdc3e8@canonical.com>","Date":"Mon, 11 Sep 2017 12:37:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1769186,"web_url":"http://patchwork.ozlabs.org/comment/1769186/","msgid":"","list_archive_url":null,"date":"2017-09-15T13:26:37","subject":"APPLIED X/Z: [SRU][Xenial][Zesty][Artful][azure][PATCH 1/1] CIFS:\n\tFix maximum SMB2 header size","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 08.09.2017 15:06, Joseph Salisbury wrote:\n> From: Pavel Shilovsky \n> \n> BugLink: http://bugs.launchpad.net/bugs/1713884\n> \n> Currently the maximum size of SMB2/3 header is set incorrectly which\n> leads to hanging of directory listing operations on encrypted SMB3\n> connections. Fix this by setting the maximum size to 170 bytes that\n> is calculated as RFC1002 length field size (4) + transform header\n> size (52) + SMB2 header size (64) + create response size (56).\n> \n> Cc: \n> Signed-off-by: Pavel Shilovsky \n> Signed-off-by: Steve French \n> Acked-by: Sachin Prabhu \n> (cherry picked from commit 9e37b1784f2be9397a903307574ee565bbadfd75)\n> Signed-off-by: Joseph Salisbury \n> ---\n> fs/cifs/smb2pdu.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h\n> index 18700fd..2826882 100644\n> --- a/fs/cifs/smb2pdu.h\n> +++ b/fs/cifs/smb2pdu.h\n> @@ -84,8 +84,8 @@\n> \n> #define NUMBER_OF_SMB2_COMMANDS\t0x0013\n> \n> -/* BB FIXME - analyze following length BB */\n> -#define MAX_SMB2_HDR_SIZE 0x78 /* 4 len + 64 hdr + (2*24 wct) + 2 bct + 2 pad */\n> +/* 4 len + 52 transform hdr + 64 hdr + 56 create rsp */\n> +#define MAX_SMB2_HDR_SIZE 0x00b0\n> \n> #define SMB2_PROTO_NUMBER cpu_to_le32(0x424d53fe)\n> #define SMB2_TRANSFORM_PROTO_NUM cpu_to_le32(0x424d53fd)\n> \nApplied to Xenial and Zesty master-next","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtx515LYKz9sRm;\n\tFri, 15 Sep 2017 23:26:45 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dsqdk-0006S5-FC; Fri, 15 Sep 2017 13:26:40 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dsqdi-0006Pe-Ij\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 13:26:38 +0000","from 1.general.smb.uk.vpn ([10.172.193.28])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dsqdi-0004kV-AY\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 13:26:38 +0000"],"Subject":"APPLIED X/Z: [SRU][Xenial][Zesty][Artful][azure][PATCH 1/1] CIFS:\n\tFix maximum SMB2 header size","To":"kernel-team@lists.ubuntu.com","References":"\n\t","From":"Stefan Bader ","Message-ID":"","Date":"Fri, 15 Sep 2017 15:26:37 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============3451808580790406208==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1771820,"web_url":"http://patchwork.ozlabs.org/comment/1771820/","msgid":"<20170920130102.32ypruzazmmgis7l@ubuntu-xps13>","list_archive_url":null,"date":"2017-09-20T13:01:02","subject":"Re: [SRU][Xenial][Zesty][Artful][azure][PATCH 1/1] CIFS: Fix maximum\n\tSMB2 header size","submitter":{"id":6957,"url":"http://patchwork.ozlabs.org/api/people/6957/","name":"Seth Forshee","email":"seth.forshee@canonical.com"},"content":"On Fri, Sep 08, 2017 at 09:06:11AM -0400, Joseph Salisbury wrote:\n> From: Pavel Shilovsky \n> \n> BugLink: http://bugs.launchpad.net/bugs/1713884\n> \n> Currently the maximum size of SMB2/3 header is set incorrectly which\n> leads to hanging of directory listing operations on encrypted SMB3\n> connections. Fix this by setting the maximum size to 170 bytes that\n> is calculated as RFC1002 length field size (4) + transform header\n> size (52) + SMB2 header size (64) + create response size (56).\n> \n> Cc: \n> Signed-off-by: Pavel Shilovsky \n> Signed-off-by: Steve French \n> Acked-by: Sachin Prabhu \n> (cherry picked from commit 9e37b1784f2be9397a903307574ee565bbadfd75)\n> Signed-off-by: Joseph Salisbury \n\nArtful master-next already includes this patch by virtue of having been\nupdated to 4.13.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy0HD4dGZz9sNr;\n\tWed, 20 Sep 2017 23:01:12 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1duecl-0001Xw-HU; Wed, 20 Sep 2017 13:01:07 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1duecj-0001Xa-V9\n\tfor kernel-team@lists.ubuntu.com; Wed, 20 Sep 2017 13:01:05 +0000","from mail-io0-f199.google.com ([209.85.223.199])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1duecj-0001hv-Kq\n\tfor kernel-team@lists.ubuntu.com; Wed, 20 Sep 2017 13:01:05 +0000","by mail-io0-f199.google.com with SMTP id f72so4263319ioj.7\n\tfor ;\n\tWed, 20 Sep 2017 06:01:05 -0700 (PDT)","from localhost ([2605:a601:aae:1b20:901a:53d5:a72d:b43])\n\tby smtp.gmail.com with ESMTPSA id\n\ta138sm922392ioe.86.2017.09.20.06.01.02\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 06:01:02 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=t3bMV/haK8Nvqff5o7cyTZQkcU/gH7KMu6YogonGXrU=;\n\tb=KDNDVFqZt9FDAQFQIcagrPbkpraHW/mJslcxetRyJrmseyEACFyUCe/osltYlBin80\n\tBjB4CPG+oOzYCUCvUklIudRo0GuSMO+jnWSMB4xHJvmH5e8vimFmhe5zSTDtEUB38mYz\n\tMMVSzUzFgl+4ODXOGcBcV3xF/ZpoVUDftNpoVJYn5/kQKzBBHCqoTspCr43VH8MX9wsq\n\toyL1UJws6+6YyaKzp4ZZ9ArdFXad4fe/iIg8egVnHb/LVXYbyfwuRTmbh/HcRN6JJIJj\n\ts/qb1vUb88UNd4bShrMbk4/btXUr3FyRPsZPqS76vQahbMIcljpuVEy4lix+Gi54VUEy\n\trvXw==","X-Gm-Message-State":"AHPjjUhy5uzLRnI15vLBMshrmZlkdD5+el7B2bSi3NvOEGiUmxn2E9XC\n\tJRyWhoT6iwFcgLpQMpKHaX43Sht9TDKdlad8NI1m/s3jTLiYWN9rOZPKByotkNMmj33STlJEtJq\n\tLtSa+/TTj7iJi9mdulNkhUiMw2RGzi28Ov1QdvHv3Ug==","X-Received":["by 10.107.180.207 with SMTP id d198mr2625912iof.0.1505912464522; \n\tWed, 20 Sep 2017 06:01:04 -0700 (PDT)","by 10.107.180.207 with SMTP id d198mr2625826iof.0.1505912463830; \n\tWed, 20 Sep 2017 06:01:03 -0700 (PDT)"],"X-Google-Smtp-Source":"AOwi7QBvpwVJePjy7x2CZ8L9sUFAlwYTmyC0NFb/YhuM9cjRZGPi63SYNuBy28KfGbjrEed2pBRbTQ==","Date":"Wed, 20 Sep 2017 08:01:02 -0500","From":"Seth Forshee ","To":"Joseph Salisbury ","Subject":"Re: [SRU][Xenial][Zesty][Artful][azure][PATCH 1/1] CIFS: Fix maximum\n\tSMB2 header size","Message-ID":"<20170920130102.32ypruzazmmgis7l@ubuntu-xps13>","References":"\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170609 (1.8.3)","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-team@lists.ubuntu.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]