[{"id":1765394,"web_url":"http://patchwork.ozlabs.org/comment/1765394/","msgid":"<20170908140322.GD25219@lunn.ch>","list_archive_url":null,"date":"2017-09-08T14:03:22","subject":"Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for\n\tSocionext UniPhier AVE","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> +\teth: ethernet@65000000 {\n> +\t\tcompatible = \"socionext,uniphier-ave4\";\n> +\t\treg = <0x65000000 0x8500>;\n> +\t\tinterrupts = <0 66 4>;\n> +\t\tpinctrl-names = \"default\";\n> +\t\tpinctrl-0 = <&pinctrl_ether_rgmii>;\n> +\t\tphy-mode = \"rgmii\";\n> +\t\tsocionext,desc-bits = <64>;\n> +\t\tlocal-mac-address = [00 00 00 00 00 00];\n> +\n> +\t\t#address-cells = <1>;\n> +\t\t#size-cells = <0>;\n\n> +\t\tethphy: ethphy@1 {\n> +\t\t\treg = <1>;\n> +\t\t};\n\n\nSo you normally have an mdio node, and the phy as a children of that\nnode.\n\n       mdio {\n                ethphy: ethernet-phy@6 {\n                        reg = <6>;\n                };\n        };\n\n\tAndrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpfDs0CZPz9s7G\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  9 Sep 2017 00:03:41 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754823AbdIHOD3 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 8 Sep 2017 10:03:29 -0400","from vps0.lunn.ch ([178.209.37.122]:33029 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751738AbdIHOD2 (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tFri, 8 Sep 2017 10:03:28 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dqJsR-0007D5-2x; Fri, 08 Sep 2017 16:03:23 +0200"],"Date":"Fri, 8 Sep 2017 16:03:22 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Kunihiko Hayashi <hayashi.kunihiko@socionext.com>","Cc":"netdev@vger.kernel.org, \"David S. Miller\" <davem@davemloft.net>,\n\tFlorian Fainelli <f.fainelli@gmail.com>,\n\tRob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tMasahiro Yamada <yamada.masahiro@socionext.com>,\n\tMasami Hiramatsu <masami.hiramatsu@linaro.org>,\n\tJassi Brar <jaswinder.singh@linaro.org>","Subject":"Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for\n\tSocionext UniPhier AVE","Message-ID":"<20170908140322.GD25219@lunn.ch>","References":"<1504875731-3680-1-git-send-email-hayashi.kunihiko@socionext.com>\n\t<1504875731-3680-2-git-send-email-hayashi.kunihiko@socionext.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1504875731-3680-2-git-send-email-hayashi.kunihiko@socionext.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765583,"web_url":"http://patchwork.ozlabs.org/comment/1765583/","msgid":"<0d9fb986-ca31-0f86-122f-b2679faeb2f4@gmail.com>","list_archive_url":null,"date":"2017-09-08T18:54:31","subject":"Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for\n\tSocionext UniPhier AVE","submitter":{"id":2800,"url":"http://patchwork.ozlabs.org/api/people/2800/","name":"Florian Fainelli","email":"f.fainelli@gmail.com"},"content":"On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote:\n> DT bindings for the AVE ethernet controller found on Socionext's\n> UniPhier platforms.\n> \n> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>\n> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>\n> ---\n>  .../bindings/net/socionext,uniphier-ave4.txt       | 44 ++++++++++++++++++++++\n>  1 file changed, 44 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt\n> \n> diff --git a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt\n> new file mode 100644\n> index 0000000..57ae96d\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt\n> @@ -0,0 +1,44 @@\n> +* Socionext AVE ethernet controller\n> +\n> +This describes the devicetree bindings for AVE ethernet controller\n> +implemented on Socionext UniPhier SoCs.\n> +\n> +Required properties:\n> + - compatible:  Should be \"socionext,uniphier-ave4\"\n> + - reg: Address where registers are mapped and size of region.\n> + - interrupts: IRQ common for mac and phy interrupts.\n> + - phy-mode: See ethernet.txt in the same directory.\n> + - #address-cells: Must be <1>.\n> + - #size-cells: Must be <0>.\n> + - Node, with 'reg' property, for each PHY on the MDIO bus.\n> +\n> +Optional properties:\n> + - socionext,desc-bits: 32/64 descriptor size. Default 32.\n\n32 bits, this has an unit. Why is this configurable through Device Tree\nand if this is describing the HW, as it should, why is not that inferred\nfrom the compatible string?\n\n> + - local-mac-address: See ethernet.txt in the same directory.\n> + - pinctrl-names: List of assigned state names, see pinctrl\n> +\tbinding documentation.\n> + - pinctrl-0: List of phandles to configure the GPIO pin used\n> +\tas interrupt line, see also generic and your platform\n> +\tspecific pinctrl binding documentation.\n> + - socionext,internal-phy-interrupt: Boolean to denote if the\n> +\tPHY interrupt is internally handled by the MAC.\n\nInteresting, why do you need to declare this as opposed to also\ndetermining this entirely from the compatible string of the Ethernet MAC?\n\n> +\n> +\n> +Example:\n> +\n> +\teth: ethernet@65000000 {\n> +\t\tcompatible = \"socionext,uniphier-ave4\";\n> +\t\treg = <0x65000000 0x8500>;\n> +\t\tinterrupts = <0 66 4>;\n> +\t\tpinctrl-names = \"default\";\n> +\t\tpinctrl-0 = <&pinctrl_ether_rgmii>;\n> +\t\tphy-mode = \"rgmii\";\n> +\t\tsocionext,desc-bits = <64>;\n> +\t\tlocal-mac-address = [00 00 00 00 00 00];\n> +\n> +\t\t#address-cells = <1>;\n> +\t\t#size-cells = <0>;\n\nThere is no phy-handle property, yet there clearly seems to be one\nattached, and I think Andrew now also responded to that in the driver\npatch, this needs fixing.\n\n> +\t\tethphy: ethphy@1 {\n> +\t\t\treg = <1>;\n> +\t\t};\n> +\t};\n>","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"QkRUCxq0\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpmhs1NbYz9t16\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat,  9 Sep 2017 04:54:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756774AbdIHSyk (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 8 Sep 2017 14:54:40 -0400","from mail-qt0-f195.google.com ([209.85.216.195]:37292 \"EHLO\n\tmail-qt0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756615AbdIHSyi (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 8 Sep 2017 14:54:38 -0400","by mail-qt0-f195.google.com with SMTP id h21so2059981qth.4;\n\tFri, 08 Sep 2017 11:54:37 -0700 (PDT)","from [10.112.156.244] ([192.19.255.250])\n\tby smtp.googlemail.com with ESMTPSA id\n\tk11sm1803493qkh.51.2017.09.08.11.54.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 11:54:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=HOCAHgX3Tz2058eCer1QAWpOp9qL57i/jSXTHTTMS2M=;\n\tb=QkRUCxq0wfdpU8F8ftYxy6aQVWerqoYH0Sa9ACG7j7uLL3ZFifBzc5gq9GPqOmf0kr\n\tb86tEzHTbNmiwCTg0Ph+j803cHWbtqOrqPJu3gXrfA1LZmkySeICvstEZM5qtxFNRlhF\n\tzvfMl2h7Yt9ToqEPCcZCvKYS1aPIFW05Wrr0QXbL1gWRlZW+V9QcPtZ1gCNWE+Zt2ylu\n\t84Y/zc3VLBDAG3yZXMNWFRBf64FjZhPHq99HImHr+LVEKKJsPtuV66jZxP18yFQJjNn2\n\tiwgIMjA4ZpuXzke1sQBjCK34r/lLlilmaTiE/NeVJ3mXJTsHtU2+YfVvimn3FfIkSFHa\n\tA+KA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=HOCAHgX3Tz2058eCer1QAWpOp9qL57i/jSXTHTTMS2M=;\n\tb=jNK8cU1DJTMOMQHNnIO9vYwK69Dks6AgdP5gJJVVuHA//aVb+6qqciyKfG362GD+21\n\tVgJsQ9egxs+GoBosvrckmuT6UVCXSkCKhewsfixt2ktVzuKDJGySdGjoijGU8GT3HEwn\n\tDPq4x6xMEEWYKL01yv5cAG6PeaLrZJKG/ZLm1XBrzXgCq41MPZa23ZbivdXD7KgZ2414\n\tWlNv4MB5IKYsZNBdDoNHyJIzCGN0+lfX3zgVmcGJiaXeNdYUjIJ3UHOG+SDRSjS5ZbPG\n\tyoBQn83cU4F9N2xjEBhd3eYeiG4QGK19vYVx8LLUJOoM7oFsEBuiXnK8rFqb7BssMnpL\n\tCOQA==","X-Gm-Message-State":"AHPjjUiv2MzCNwv1Q1xd7PTCK2h9ASTpHyT05Q5vIdbL/NwUhhmZUjLI\n\tG6FzKTKufvg7aw==","X-Google-Smtp-Source":"AOwi7QDyt//cKnb7zL36/5MFoHAu2Y7Y4+CA9VMzytopx/sna6Tti0rZjlDGWhGiHEmY0tw6eUfQRA==","X-Received":"by 10.200.15.13 with SMTP id e13mr5528746qtk.295.1504896877301; \n\tFri, 08 Sep 2017 11:54:37 -0700 (PDT)","Subject":"Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for\n\tSocionext UniPhier AVE","To":"Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,\n\tnetdev@vger.kernel.org, \"David S. Miller\" <davem@davemloft.net>,\n\tAndrew Lunn <andrew@lunn.ch>","Cc":"Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tMasahiro Yamada <yamada.masahiro@socionext.com>,\n\tMasami Hiramatsu <masami.hiramatsu@linaro.org>,\n\tJassi Brar <jaswinder.singh@linaro.org>","References":"<1504875731-3680-1-git-send-email-hayashi.kunihiko@socionext.com>\n\t<1504875731-3680-2-git-send-email-hayashi.kunihiko@socionext.com>","From":"Florian Fainelli <f.fainelli@gmail.com>","Message-ID":"<0d9fb986-ca31-0f86-122f-b2679faeb2f4@gmail.com>","Date":"Fri, 8 Sep 2017 11:54:31 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504875731-3680-2-git-send-email-hayashi.kunihiko@socionext.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1766088,"web_url":"http://patchwork.ozlabs.org/comment/1766088/","msgid":"<20170911161130.671B.4A936039@socionext.com>","list_archive_url":null,"date":"2017-09-11T07:11:31","subject":"Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for\n\tSocionext UniPhier AVE","submitter":{"id":71700,"url":"http://patchwork.ozlabs.org/api/people/71700/","name":"Kunihiko Hayashi","email":"hayashi.kunihiko@socionext.com"},"content":"Hi Andrew,\n\nOn Fri, 8 Sep 2017 16:03:22 +0200 <andrew@lunn.ch> wrote:\n\n> > +\teth: ethernet@65000000 {\n> > +\t\tcompatible = \"socionext,uniphier-ave4\";\n> > +\t\treg = <0x65000000 0x8500>;\n> > +\t\tinterrupts = <0 66 4>;\n> > +\t\tpinctrl-names = \"default\";\n> > +\t\tpinctrl-0 = <&pinctrl_ether_rgmii>;\n> > +\t\tphy-mode = \"rgmii\";\n> > +\t\tsocionext,desc-bits = <64>;\n> > +\t\tlocal-mac-address = [00 00 00 00 00 00];\n> > +\n> > +\t\t#address-cells = <1>;\n> > +\t\t#size-cells = <0>;\n> \n> > +\t\tethphy: ethphy@1 {\n> > +\t\t\treg = <1>;\n> > +\t\t};\n> \n> \n> So you normally have an mdio node, and the phy as a children of that\n> node.\n> \n>        mdio {\n>                 ethphy: ethernet-phy@6 {\n>                         reg = <6>;\n>                 };\n>         };\n> \n> \tAndrew\n\nI see. I'll rewrite the binding example using mdio node.\n\n---\nBest Regards,\nKunihiko Hayashi","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrJy16998z9s83\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 11 Sep 2017 17:11:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751076AbdIKHLe (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 11 Sep 2017 03:11:34 -0400","from mx.socionext.com ([202.248.49.38]:13289 \"EHLO\n\tmx.socionext.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751017AbdIKHLd (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 11 Sep 2017 03:11:33 -0400","from unknown (HELO kinkan-ex.css.socionext.com) ([172.31.9.52])\n\tby mx.socionext.com with ESMTP; 11 Sep 2017 16:11:32 +0900","from mail.mfilter.local (unknown [10.213.24.61])\n\tby kinkan-ex.css.socionext.com (Postfix) with ESMTP id DAAFE180070;\n\tMon, 11 Sep 2017 16:11:31 +0900 (JST)","from 172.31.9.53 (172.31.9.53) by m-FILTER with ESMTP;\n\tMon, 11 Sep 2017 16:11:31 +0900","from yuzu.css.socionext.com (yuzu [172.31.8.45])\n\tby iyokan.css.socionext.com (Postfix) with ESMTP id A333140512;\n\tMon, 11 Sep 2017 16:11:31 +0900 (JST)","from [127.0.0.1] (unknown [10.213.134.37])\n\tby yuzu.css.socionext.com (Postfix) with ESMTP id 5F2B4120480;\n\tMon, 11 Sep 2017 16:11:31 +0900 (JST)"],"Date":"Mon, 11 Sep 2017 16:11:31 +0900","From":"Kunihiko Hayashi <hayashi.kunihiko@socionext.com>","To":"Andrew Lunn <andrew@lunn.ch>","Subject":"Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for\n\tSocionext UniPhier AVE","Cc":"<netdev@vger.kernel.org>, \"David S. Miller\" <davem@davemloft.net>,\n\tFlorian Fainelli <f.fainelli@gmail.com>,\n\tRob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,\n\t<linux-arm-kernel@lists.infradead.org>,\n\t<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,\n\tMasahiro Yamada <yamada.masahiro@socionext.com>,\n\tMasami Hiramatsu <masami.hiramatsu@linaro.org>,\n\tJassi Brar <jaswinder.singh@linaro.org>","In-Reply-To":"<20170908140322.GD25219@lunn.ch>","References":"<1504875731-3680-2-git-send-email-hayashi.kunihiko@socionext.com>\n\t<20170908140322.GD25219@lunn.ch>","Message-Id":"<20170911161130.671B.4A936039@socionext.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"","Content-Transfer-Encoding":"7bit","X-Mailer":"Becky! ver. 2.70 [ja]","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1766089,"web_url":"http://patchwork.ozlabs.org/comment/1766089/","msgid":"<20170911161151.671C.4A936039@socionext.com>","list_archive_url":null,"date":"2017-09-11T07:11:51","subject":"Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for\n\tSocionext UniPhier AVE","submitter":{"id":71700,"url":"http://patchwork.ozlabs.org/api/people/71700/","name":"Kunihiko Hayashi","email":"hayashi.kunihiko@socionext.com"},"content":"Hi Florian,\n\nOn Fri, 8 Sep 2017 11:54:31 -0700 <f.fainelli@gmail.com> wrote:\n\n> On 09/08/2017 06:02 AM, Kunihiko Hayashi wrote:\n> > DT bindings for the AVE ethernet controller found on Socionext's\n> > UniPhier platforms.\n> > \n> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>\n> > Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>\n> > ---\n> >  .../bindings/net/socionext,uniphier-ave4.txt       | 44 ++++++++++++++++++++++\n> >  1 file changed, 44 insertions(+)\n> >  create mode 100644 Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt\n> > \n> > diff --git a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt\n> > new file mode 100644\n> > index 0000000..57ae96d\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.txt\n> > @@ -0,0 +1,44 @@\n> > +* Socionext AVE ethernet controller\n> > +\n> > +This describes the devicetree bindings for AVE ethernet controller\n> > +implemented on Socionext UniPhier SoCs.\n> > +\n> > +Required properties:\n> > + - compatible:  Should be \"socionext,uniphier-ave4\"\n> > + - reg: Address where registers are mapped and size of region.\n> > + - interrupts: IRQ common for mac and phy interrupts.\n> > + - phy-mode: See ethernet.txt in the same directory.\n> > + - #address-cells: Must be <1>.\n> > + - #size-cells: Must be <0>.\n> > + - Node, with 'reg' property, for each PHY on the MDIO bus.\n> > +\n> > +Optional properties:\n> > + - socionext,desc-bits: 32/64 descriptor size. Default 32.\n> \n> 32 bits, this has an unit. Why is this configurable through Device Tree\n> and if this is describing the HW, as it should, why is not that inferred\n> from the compatible string?\n\nI've thought the common compatible string was reasonable for all UniPhier\nSoCs. However, since there are some different features among SoCs\nlike \"desc-bits\" etc. and such feature would increase from now on,\nit's convenient to add compatible strings for each SoCs.\n\n> > + - local-mac-address: See ethernet.txt in the same directory.\n> > + - pinctrl-names: List of assigned state names, see pinctrl\n> > +\tbinding documentation.\n> > + - pinctrl-0: List of phandles to configure the GPIO pin used\n> > +\tas interrupt line, see also generic and your platform\n> > +\tspecific pinctrl binding documentation.\n> > + - socionext,internal-phy-interrupt: Boolean to denote if the\n> > +\tPHY interrupt is internally handled by the MAC.\n> \n> Interesting, why do you need to declare this as opposed to also\n> determining this entirely from the compatible string of the Ethernet MAC?\n\nThis property was added after determining to use common compatible string.\nI'll re-consider to use compatible strings for each SoCs.\n\n> \n> > +\n> > +\n> > +Example:\n> > +\n> > +\teth: ethernet@65000000 {\n> > +\t\tcompatible = \"socionext,uniphier-ave4\";\n> > +\t\treg = <0x65000000 0x8500>;\n> > +\t\tinterrupts = <0 66 4>;\n> > +\t\tpinctrl-names = \"default\";\n> > +\t\tpinctrl-0 = <&pinctrl_ether_rgmii>;\n> > +\t\tphy-mode = \"rgmii\";\n> > +\t\tsocionext,desc-bits = <64>;\n> > +\t\tlocal-mac-address = [00 00 00 00 00 00];\n> > +\n> > +\t\t#address-cells = <1>;\n> > +\t\t#size-cells = <0>;\n> \n> There is no phy-handle property, yet there clearly seems to be one\n> attached, and I think Andrew now also responded to that in the driver\n> patch, this needs fixing.\n\nSurely phy-handle is missing in this. I'll fix it with mdio node.\n\n> > +\t\tethphy: ethphy@1 {\n> > +\t\t\treg = <1>;\n> > +\t\t};\n> > +\t};\n> > \n> \n> \n> -- \n> Florian\n\n---\nBest Regards,\nKunihiko Hayashi","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrJyb1NzFz9s2G\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 11 Sep 2017 17:12:07 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751217AbdIKHLz (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tMon, 11 Sep 2017 03:11:55 -0400","from mx.socionext.com ([202.248.49.38]:13308 \"EHLO\n\tmx.socionext.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751153AbdIKHLy (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tMon, 11 Sep 2017 03:11:54 -0400","from unknown (HELO iyokan-ex.css.socionext.com) ([172.31.9.54])\n\tby mx.socionext.com with ESMTP; 11 Sep 2017 16:11:53 +0900","from mail.mfilter.local (unknown [10.213.24.62])\n\tby iyokan-ex.css.socionext.com (Postfix) with ESMTP id 75071610C6;\n\tMon, 11 Sep 2017 16:11:52 +0900 (JST)","from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP;\n\tMon, 11 Sep 2017 16:11:52 +0900","from yuzu.css.socionext.com (yuzu [172.31.8.45])\n\tby kinkan.css.socionext.com (Postfix) with ESMTP id F05881A0E16;\n\tMon, 11 Sep 2017 16:11:51 +0900 (JST)","from [127.0.0.1] (unknown [10.213.134.37])\n\tby yuzu.css.socionext.com (Postfix) with ESMTP id AEABE120480;\n\tMon, 11 Sep 2017 16:11:51 +0900 (JST)"],"Date":"Mon, 11 Sep 2017 16:11:51 +0900","From":"Kunihiko Hayashi <hayashi.kunihiko@socionext.com>","To":"Florian Fainelli <f.fainelli@gmail.com>","Subject":"Re: [PATCH net-next 1/3] dt-bindings: net: add DT bindings for\n\tSocionext UniPhier AVE","Cc":"netdev@vger.kernel.org, \"David S. Miller\" <davem@davemloft.net>,\n\tAndrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,\n\tMark Rutland <mark.rutland@arm.com>,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org,\n\tMasahiro Yamada <yamada.masahiro@socionext.com>,\n\tMasami Hiramatsu <masami.hiramatsu@linaro.org>,\n\tJassi Brar <jaswinder.singh@linaro.org>","In-Reply-To":"<0d9fb986-ca31-0f86-122f-b2679faeb2f4@gmail.com>","References":"<1504875731-3680-2-git-send-email-hayashi.kunihiko@socionext.com>\n\t<0d9fb986-ca31-0f86-122f-b2679faeb2f4@gmail.com>","Message-Id":"<20170911161151.671C.4A936039@socionext.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"","Content-Transfer-Encoding":"7bit","X-Mailer":"Becky! ver. 2.70 [ja]","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]