[{"id":1765321,"web_url":"http://patchwork.ozlabs.org/comment/1765321/","msgid":"<707d49a9-51cf-abe4-78bc-07343181ecce@redhat.com>","list_archive_url":null,"date":"2017-09-08T12:59:48","subject":"Re: [Qemu-devel] [PATCH 2/2] usb: only build usb-host with\n\tCONFIG_USB=y","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 08.09.2017 13:12, Gerd Hoffmann wrote:\n> Signed-off-by: Gerd Hoffmann \n> ---\n> hw/usb/Makefile.objs | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs\n> index a43ebbc17f..757e365562 100644\n> --- a/hw/usb/Makefile.objs\n> +++ b/hw/usb/Makefile.objs\n> @@ -38,7 +38,7 @@ endif\n> common-obj-$(CONFIG_USB_REDIR) += redirect.o quirks.o\n> \n> # usb pass-through\n> -ifeq ($(CONFIG_LIBUSB),y)\n> +ifeq ($(CONFIG_LIBUSB)$(CONFIG_USB),yy)\n> common-obj-y += host-libusb.o host-legacy.o\n> else\n> common-obj-y += host-stub.o\n\nStrange that you did not need the hack with \"common-obj-$(CONFIG_ALL)\"\nin this patch like I had to do in the patch that I sent today... but\nI've just checked it, and it seems to work this way. So:\n\nTested-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpcqq1FMcz9ryk\n\tfor ;\n\tFri, 8 Sep 2017 23:00:21 +1000 (AEST)","from localhost ([::1]:45335 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqItP-0000ND-MW\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 09:00:19 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53613)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqIt4-0000N3-QW\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 08:59:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqIt0-0001JG-VI\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 08:59:58 -0400","from mx1.redhat.com ([209.132.183.28]:38710)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqIt0-0001Ic-P1\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 08:59:54 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 57D05356D4\n\tfor ; Fri, 8 Sep 2017 12:59:53 +0000 (UTC)","from [10.36.116.21] (ovpn-116-21.ams2.redhat.com [10.36.116.21])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 8C276600CA;\n\tFri, 8 Sep 2017 12:59:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 57D05356D4","To":"Gerd Hoffmann , qemu-devel@nongnu.org","References":"<20170908111217.21985-1-kraxel@redhat.com>\n\t<20170908111217.21985-3-kraxel@redhat.com>","From":"Thomas Huth ","Message-ID":"<707d49a9-51cf-abe4-78bc-07343181ecce@redhat.com>","Date":"Fri, 8 Sep 2017 14:59:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170908111217.21985-3-kraxel@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tFri, 08 Sep 2017 12:59:53 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 2/2] usb: only build usb-host with\n\tCONFIG_USB=y","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]