[{"id":1765701,"web_url":"http://patchwork.ozlabs.org/comment/1765701/","msgid":"<20170908.210905.626281012369795940.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-09T04:09:05","subject":"Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of\n\tIS_ERR()","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Dan Carpenter \nDate: Fri, 8 Sep 2017 13:31:37 +0300\n\n> devm_ioremap_resource() never returns NULL, it only returns error\n> pointers so this test needs to be changed.\n> \n> Fixes: d0438bd6aa09 (\"phy: add the mvebu cp110 comphy driver\")\n> Signed-off-by: Dan Carpenter \n> ---\n> This driver apparently is going through the net tree, but netdev isn't\n> listed as handling it in MAINTAINERS. Kishon, do you know what's up\n> with that?\n\nYeah let's sort this out before I apply this fix to my tree.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xq10g4Ww3z9sBZ\n\tfor ;\n\tSat, 9 Sep 2017 14:09:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751154AbdIIEJH (ORCPT );\n\tSat, 9 Sep 2017 00:09:07 -0400","from shards.monkeyblade.net ([184.105.139.130]:43202 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750899AbdIIEJG (ORCPT\n\t); Sat, 9 Sep 2017 00:09:06 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id E6F491353953E;\n\tFri, 8 Sep 2017 21:09:05 -0700 (PDT)"],"Date":"Fri, 08 Sep 2017 21:09:05 -0700 (PDT)","Message-Id":"<20170908.210905.626281012369795940.davem@davemloft.net>","To":"dan.carpenter@oracle.com","Cc":"kishon@ti.com, antoine.tenart@free-electrons.com,\n\tnetdev@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of\n\tIS_ERR()","From":"David Miller ","In-Reply-To":"<20170908103137.zck6bw66sge4fhua@mwanda>","References":"<20170908103137.zck6bw66sge4fhua@mwanda>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 08 Sep 2017 21:09:06 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1766095,"web_url":"http://patchwork.ozlabs.org/comment/1766095/","msgid":"<1bc9c815-08ba-1095-eb6d-a753b3d0c755@ti.com>","list_archive_url":null,"date":"2017-09-11T07:24:47","subject":"Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of\n\tIS_ERR()","submitter":{"id":14965,"url":"http://patchwork.ozlabs.org/api/people/14965/","name":"Kishon Vijay Abraham I","email":"kishon@ti.com"},"content":"Hi,\n\nOn Saturday 09 September 2017 09:39 AM, David Miller wrote:\n> From: Dan Carpenter \n> Date: Fri, 8 Sep 2017 13:31:37 +0300\n> \n>> devm_ioremap_resource() never returns NULL, it only returns error\n>> pointers so this test needs to be changed.\n>>\n>> Fixes: d0438bd6aa09 (\"phy: add the mvebu cp110 comphy driver\")\n>> Signed-off-by: Dan Carpenter \n>> ---\n>> This driver apparently is going through the net tree, but netdev isn't\n>> listed as handling it in MAINTAINERS. Kishon, do you know what's up\n>> with that?\n\nI've reviewed this driver and sometimes the PHY drivers gets merged along with\ntheir consumer driver (In this case mvpp2 ethernet driver). But after it's\nmerged, all further fixes and features go via linux-phy tree (mostly).\n> \n> Yeah let's sort this out before I apply this fix to my tree.\n\nI'll take this fix in linux-phy tree after -rc1 is tagged if that's okay with you.\n\nThanks\nKishon","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"KS+dzeLo\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrKFj1dypz9s4q\n\tfor ;\n\tMon, 11 Sep 2017 17:25:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751038AbdIKHY7 (ORCPT );\n\tMon, 11 Sep 2017 03:24:59 -0400","from lelnx193.ext.ti.com ([198.47.27.77]:20145 \"EHLO\n\tlelnx193.ext.ti.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750989AbdIKHY6 (ORCPT\n\t); Mon, 11 Sep 2017 03:24:58 -0400","from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8B7OoL4011376; \n\tMon, 11 Sep 2017 02:24:50 -0500","from DLEE101.ent.ti.com (dlee101.ent.ti.com [157.170.170.31])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8B7OoLd009220; \n\tMon, 11 Sep 2017 02:24:50 -0500","from DLEE113.ent.ti.com (157.170.170.24) by DLEE101.ent.ti.com\n\t(157.170.170.31) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tMon, 11 Sep 2017 02:24:51 -0500","from dlep32.itg.ti.com (157.170.170.100) by DLEE113.ent.ti.com\n\t(157.170.170.24) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Mon, 11 Sep 2017 02:24:50 -0500","from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8B7OlQO018123;\n\tMon, 11 Sep 2017 02:24:48 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1505114690;\n\tbh=uTxCo1Yi0okxsx5HzT0uecy83/hYNPUQIsGm878/PnI=;\n\th=Subject:To:References:CC:From:Date:In-Reply-To;\n\tb=KS+dzeLoXtJY+wF6W+TMyBZS6je+usHZc5ZZQrH+mqFidXBRxArmPyUaubjAx/Awn\n\tGAxHW1ofv7pLymUWzzy/0dy0NI591K2xvd0GPRH4WW5I4eEbcHp+KziszgOhF+aJtN\n\ttSfoX97LFVWc1Vep/nOTjtmOv0H19VJgUZMAAslc=","Subject":"Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of\n\tIS_ERR()","To":"David Miller , ","References":"<20170908103137.zck6bw66sge4fhua@mwanda>\n\t<20170908.210905.626281012369795940.davem@davemloft.net>","CC":", ,\n\t, ","From":"Kishon Vijay Abraham I ","Message-ID":"<1bc9c815-08ba-1095-eb6d-a753b3d0c755@ti.com>","Date":"Mon, 11 Sep 2017 12:54:47 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<20170908.210905.626281012369795940.davem@davemloft.net>","Content-Type":"text/plain; charset=\"windows-1252\"","Content-Transfer-Encoding":"7bit","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1766412,"web_url":"http://patchwork.ozlabs.org/comment/1766412/","msgid":"<20170911.102934.1357684377387473638.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-11T17:29:34","subject":"Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of\n\tIS_ERR()","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Kishon Vijay Abraham I \nDate: Mon, 11 Sep 2017 12:54:47 +0530\n\n> On Saturday 09 September 2017 09:39 AM, David Miller wrote:\n>> Yeah let's sort this out before I apply this fix to my tree.\n> \n> I'll take this fix in linux-phy tree after -rc1 is tagged if that's okay with you.\n\nNo problem, although I don't see why one would delay bug fixes... ever.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrZgK4w23z9sBd\n\tfor ;\n\tTue, 12 Sep 2017 03:29:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752341AbdIKR3i (ORCPT );\n\tMon, 11 Sep 2017 13:29:38 -0400","from shards.monkeyblade.net ([184.105.139.130]:50484 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751480AbdIKR3h (ORCPT\n\t); Mon, 11 Sep 2017 13:29:37 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id B7D6C10222102;\n\tMon, 11 Sep 2017 10:29:36 -0700 (PDT)"],"Date":"Mon, 11 Sep 2017 10:29:34 -0700 (PDT)","Message-Id":"<20170911.102934.1357684377387473638.davem@davemloft.net>","To":"kishon@ti.com","Cc":"dan.carpenter@oracle.com, antoine.tenart@free-electrons.com,\n\tnetdev@vger.kernel.org, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH net] phy: mvebu-cp110: checking for NULL instead of\n\tIS_ERR()","From":"David Miller ","In-Reply-To":"<1bc9c815-08ba-1095-eb6d-a753b3d0c755@ti.com>","References":"<20170908103137.zck6bw66sge4fhua@mwanda>\n\t<20170908.210905.626281012369795940.davem@davemloft.net>\n\t<1bc9c815-08ba-1095-eb6d-a753b3d0c755@ti.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 11 Sep 2017 10:29:37 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]