[{"id":1765408,"web_url":"http://patchwork.ozlabs.org/comment/1765408/","msgid":"","list_archive_url":null,"date":"2017-09-08T14:17:49","subject":"Re: [ovs-dev] [PATCH v3] netdev-dpdk: reset packet_type for\n\treused\tdp_packets","submitter":{"id":67904,"url":"http://patchwork.ozlabs.org/api/people/67904/","name":"Zoltan Balogh","email":"zoltan.balogh@ericsson.com"},"content":"I'm sorry, this one became corrupt because of my e-mail client.\nSent a 4th one:\nhttps://patchwork.ozlabs.org/patch/811617/\nhttps://mail.openvswitch.org/pipermail/ovs-dev/2017-September/338486.html\n\nZoltan\n\n> -----Original Message-----\n> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev-bounces@openvswitch.org] On Behalf Of Zoltán Balogh\n> Sent: Friday, September 08, 2017 12:01 PM\n> To: 'dev@openvswitch.org' \n> Subject: [ovs-dev] [PATCH v3] netdev-dpdk: reset packet_type for reused dp_packets\n> \n> DPDK uses dp-packet pool for storing received packets. The pool is\n> reused by rxq_recv funcions of the DPDK netdevs. The datapath is\n> capable to modify the packet_type property of packets. For instance\n> when encapsulated L3 packets are received on a ptap gre port.\n> In this case the packet_type property of struct dp_packet can be\n> modified and later the same dp_packet with the modified packet_type\n> can be reused in the rxq_rec function, so it can contain corrupted\n> data.\n> \n> The dp_packet_batch_init_cutlen() in the rxq_recv functions iterates\n> over dp_packets and sets their cutlen. So I modified this function\n> to set packet_type to Ethernet for the dp_packets as well. I also\n> renamed this function because of the added functionality.\n> \n> The dp_packet_batch_init_cutlen() iterates over batch->count dp_packet.\n> Therefore setting of batch->count = nb_rx needs to be done before the\n> former function is invoked. This is an additional fix.\n> \n> Signed-off-by: Zoltan Balogh \n> Signed-off-by: Laszlo Suru \n> Co-authored-by: Laszlo Suru \n> CC: Jan Scheurich \n> CC: Sugesh Chandran \n> CC: Darrell Ball \n> ---\n> lib/dp-packet.h | 3 ++-\n> lib/netdev-dpdk.c | 7 ++++---\n> 2 files changed, 6 insertions(+), 4 deletions(-)\n> \n> diff --git a/lib/dp-packet.h b/lib/dp-packet.h\n> index 046f3ab..b4b721c 100644\n> --- a/lib/dp-packet.h\n> +++ b/lib/dp-packet.h\n> @@ -805,12 +805,13 @@ dp_packet_delete_batch(struct dp_packet_batch *batch, bool may_steal)\n> }\n> static inline void\n> -dp_packet_batch_init_cutlen(struct dp_packet_batch *batch)\n> +dp_packet_batch_init_packet_fields(struct dp_packet_batch *batch)\n> {\n> struct dp_packet *packet;\n> DP_PACKET_BATCH_FOR_EACH (packet, batch) {\n> dp_packet_reset_cutlen(packet);\n> + packet->packet_type = htonl(PT_ETH);\n> }\n> }\n> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\n> index f58e9be..ccccb9a 100644\n> --- a/lib/netdev-dpdk.c\n> +++ b/lib/netdev-dpdk.c\n> @@ -1644,8 +1644,9 @@ netdev_dpdk_vhost_rxq_recv(struct netdev_rxq *rxq,\n> nb_rx, dropped);\n> rte_spinlock_unlock(&dev->stats_lock);\n> - dp_packet_batch_init_cutlen(batch);\n> - batch->count = (int) nb_rx;\n> + batch->count = nb_rx;\n> + dp_packet_batch_init_packet_fields(batch);\n> +\n> return 0;\n> }\n> @@ -1684,8 +1685,8 @@ netdev_dpdk_rxq_recv(struct netdev_rxq *rxq, struct dp_packet_batch *batch)\n> rte_spinlock_unlock(&dev->stats_lock);\n> }\n> - dp_packet_batch_init_cutlen(batch);\n> batch->count = nb_rx;\n> + dp_packet_batch_init_packet_fields(batch);\n> return 0;\n> }\n> --\n> 1.9.1\n> \n> _______________________________________________\n> dev mailing list\n> dev@openvswitch.org\n> https://mail.openvswitch.org/mailman/listinfo/ovs-dev","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"MYcjv2M6\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=zoltan.balogh@ericsson.com; "],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpfYK53XZz9sBd\n\tfor ;\n\tSat, 9 Sep 2017 00:17:57 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 7596DB63;\n\tFri, 8 Sep 2017 14:17:54 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 6C9A0A64\n\tfor ; Fri, 8 Sep 2017 14:17:53 +0000 (UTC)","from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 83D53421\n\tfor ; Fri, 8 Sep 2017 14:17:52 +0000 (UTC)","from ESESSHC007.ericsson.se (Unknown_Domain [153.88.183.39])\n\tby sessmg22.ericsson.net (Symantec Mail Security) with SMTP id\n\t86.F4.20899.E86A2B95; Fri, 8 Sep 2017 16:17:50 +0200 (CEST)","from EUR03-AM5-obe.outbound.protection.outlook.com (153.88.183.145)\n\tby oa.msg.ericsson.com (153.88.183.39) with Microsoft SMTP Server\n\t(TLS) id 14.3.352.0; Fri, 8 Sep 2017 16:17:50 +0200","from AM2PR07MB1042.eurprd07.prod.outlook.com (10.162.37.27) by\n\tAM2PR07MB0580.eurprd07.prod.outlook.com (10.160.33.144) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.35.3; Fri, 8 Sep 2017 14:17:49 +0000","from AM2PR07MB1042.eurprd07.prod.outlook.com\n\t([fe80::7e:2b4e:3774:4ef3]) by\n\tAM2PR07MB1042.eurprd07.prod.outlook.com\n\t([fe80::7e:2b4e:3774:4ef3%13]) with mapi id 15.20.0035.016;\n\tFri, 8 Sep 2017 14:17:49 +0000"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-AuditID":"c1b4fb3a-5ffff700000051a3-78-59b2a68e0e30","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ericsson.onmicrosoft.com; s=selector1-ericsson-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=JIc0UGywYWroHV46BZzjh1EUiDjFvBdBtmF0UDGkk7g=;\n\tb=MYcjv2M6UYlx5hFzYZ+fo4UWn3P4WX2RQmMcXi/JsXgGT1z2wiqb+TZBxhXluWgEWPbLeFN9q0OhYzXqhj5DedKtvfhBT3//Fmpcb6I6YMI0akN7+K5Q3JK9B5/bOHK+JLzUdqwQ7+mya+V3J0YR1qZYNwD2Qm64+rOFABr61OM=","From":"=?iso-8859-1?q?Zolt=E1n_Balogh?= ","To":"\"'dev@openvswitch.org'\" ","Thread-Topic":"[ovs-dev] [PATCH v3] netdev-dpdk: reset packet_type for reused\n\tdp_packets","Thread-Index":"AQHTKK0/ko6BTC5sqkmqig5IY3YhSQ==","Date":"Fri, 8 Sep 2017 14:17:49 +0000","Message-ID":"","References":"","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[91.82.100.59]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; AM2PR07MB0580;\n\t6:b5hREYbUnvzPd/6ds0J5vU9wmGNhF6hHsSsnjn/z6NOwum7wMBotN/pTxbFOa1ZtYDRg115ph40HUBXv5JBQysKGC3+R/cl+vhNEEmUwBICb9vhPSUp3dQzjpFxWxWBfRDwcS2Rf1hzaeLXh4TBXFAmKiXNwALwzr7AaZ2cRlfThSVG0VtvzBe0S9P3CVcLcniY8/dWSPUFA2HXGaE0gu2dAharrxCZfdDn+oWtoY2UkSwBeNpL7xlhBDI+hYxFfPac3uCfIdY2jao7QU9XHVZZc+OS74c6nLlS07qwfmca+XsDr5rEzWsi0WLern0k9i9V27kyS08eqAJQUmTi0Hw==;\n\t5:wC/aQ9+jA82DOcNILA/KgbL+8bp7TrLMyDVMhTZjsABGK9MoISkT/gpV/1OPq7xoZCPfMg0ggxg/bB2jGMO0PsYNjPWmVxO/iMG2GFa712nWTy34dJbK2Kj9p1pUNzy+FjvBo+3o7gm460VLoH1/ubivTQc0iDf43kVXLE9G4+4=;\n\t24:77K1JzNS2uUYSvAYTqQm9/LmgsmsuR7KxjIHmnWM8vhnM2APzjr11wTxzAtHQ0sDk5lAqjjLM/fHMjHhg/wP1a+GCzjO8iLdcTzw4Cmo6QU=;\n\t7:q67gvjFbLIVEtebl1AA9uX7wPHZQ8lwBwwmvO9a6tG162NKC5QUqVQlM0ekNmSeGs/DMwWVPjQMR221m8TWg5/76rZu/YsG2JBAeJCBvW6FF/7dur1m04Wc1AQPrtTJp8uKadylS16yi6mVZ8kdY5vc+Fv6yQFsl1lCZPhbh/q8NjFOmk8SOxX6GxLRqWIlNQeyEX/ITIZw1oDob4QRHPzj8d+L2pydOcnTVgUrGPi0=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"d0bd3b27-6920-4092-2175-08d4f6c4626e","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:AM2PR07MB0580; ","x-ms-traffictypediagnostic":"AM2PR07MB0580:","authentication-results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"MYcjv2M6\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=zoltan.balogh@ericsson.com; "],"x-exchange-antispam-report-test":"UriScan:(37575265505322)(216315784871565)(228905959029699); ","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123564025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:AM2PR07MB0580; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:AM2PR07MB0580; ","x-forefront-prvs":"04244E0DC5","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(199003)(189002)(377454003)(13464003)(53936002)(966005)(6306002)(14454004)(9686003)(99286003)(55016002)(25786009)(66066001)(2900100001)(106356001)(2940100002)(5250100002)(97736004)(478600001)(86362001)(68736007)(6116002)(102836003)(3846002)(110136004)(6246003)(53546010)(54356999)(50986999)(3280700002)(76176999)(3660700001)(6916009)(189998001)(2950100002)(6436002)(6506006)(101416001)(2906002)(81156014)(81166006)(7736002)(305945005)(33656002)(5660300001)(229853002)(7696004)(8936002)(74316002)(105586002)(491001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR07MB0580;\n\tH:AM2PR07MB1042.eurprd07.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: ericsson.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-originalarrivaltime":"08 Sep 2017 14:17:49.0396\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"92e84ceb-fbfd-47ab-be52-080c6b87953f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AM2PR07MB0580","X-OriginatorOrg":"ericsson.com","X-Brightmail-Tracker":"H4sIAAAAAAAAA02SbUhTYRTHe3bvtrvV5Gn5csgkWaE0a6lJSUgZUvRFECJwpejMi4o67V6T\n\t2ad9CUvTtKXLGb5USIqJjMk0tdpslBlplqURZSrKFLXwJUHUdn0W9O33/P//53DO4TCUcpXe\n\ty2TpC1hOr8tRSeR0TaI99Eh5k1UbvtIVFe0a6KFi0fnpsS2UgC7JY9LZnKxCljt6KlWe+at3\n\tDeWvBxq+WWqkRrTkX4IYBnAUDL1QlyA5o8SvEMzPLtIlSOZ5vEbQuHBRMGhcRsGtp3aKpEwi\n\tmPzh9Ka+IzB2IoElOA6+dLslAvviCBi+2y8WeA9OBOvyjIjoWihtn/ZmNLDQ20IJXdD4IHRt\n\tpAiyAifBp8UPSJCVHr7ffEhAGU6GEdt+IYGwP/x527pdkMIB8HWqfpsBY3jcM0gR9gP35KaY\n\tcDBYGxalhINguL4UCZMAtkih+uZPr6GBjsp5RHYSD08eRpPMhAiWXGZvUTVMbJhp0kQymG+U\n\tSoieBFXOO17OhrrNaop8HhDDkKlaQoruA/doKtGHxVBsei+uQIct/w1BWAOjVfckhMOgqXGO\n\tsmyvZTf010zRDYhuQX48y/O5GZGRGpbLusLzeXqNni2wIs81OGzrJzuRY+aME2EGqXYpymut\n\tWqVYV8gX5ToRMJTKV3HC4pEU6bqi6yyXl8Jdy2F5JwpkaFWAIvb5UKISZ+gK2GyWzWe5f66I\n\tke01oqZ49UrPitTd8bLP9ig61n7uamBcUoXPVrOrdnJt8LNBERIelEA/i1kPoSJlv9/1XRB1\n\tO8Im2qdblxMeNB446x7ppNpCTYbTvmXjVrtm8PJqsKtu3CgzaLuKW9JCtWU7NiNCfIoD7Mdn\n\tHePmyo+trmO2nUVjbFvK3MLtqLQ3chXNZ+oi1BTH6/4CH2ziDAkDAAA=","X-Spam-Status":"No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_MED autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH v3] netdev-dpdk: reset packet_type for\n\treused\tdp_packets","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]