[{"id":1766396,"web_url":"http://patchwork.ozlabs.org/comment/1766396/","msgid":"<7497f773-7199-7e68-63a0-99e35e73e1e3@canonical.com>","list_archive_url":null,"date":"2017-09-11T16:51:42","subject":"ACK: [PATCH] lib: fwts_devicetree: constify a few function arguments","submitter":{"id":10593,"url":"http://patchwork.ozlabs.org/api/people/10593/","name":"Alex Hung","email":"alex.hung@canonical.com"},"content":"On 2017-09-08 02:40 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> Code cleanup, constify some function arguments\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/lib/src/fwts_devicetree.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/lib/src/fwts_devicetree.c b/src/lib/src/fwts_devicetree.c\n> index 2fea3c8a..9db63de6 100644\n> --- a/src/lib/src/fwts_devicetree.c\n> +++ b/src/lib/src/fwts_devicetree.c\n> @@ -182,7 +182,7 @@ char *hidewhitespace(char *name)\n> \n> int fwts_dt_property_read_u32(\n> \tvoid *fdt,\n> -\tint offset,\n> +\tconst int offset,\n> \tconst char *pname,\n> \tint *value)\n> {\n> @@ -207,7 +207,7 @@ int fwts_dt_property_read_u32(\n> \n> int fwts_dt_property_read_u32_arr(\n> \tvoid *fdt,\n> -\tint offset,\n> +\tconst int offset,\n> \tconst char *pname,\n> \tint *value,\n> \tint *len)\n> @@ -236,7 +236,7 @@ int fwts_dt_property_read_u32_arr(\n> \n> int fwts_dt_property_read_u64_arr(\n> \tvoid *fdt,\n> -\tint offset,\n> +\tconst int offset,\n> \tconst char *pname,\n> \tuint64_t *value,\n> \tint *len)\n> @@ -261,7 +261,7 @@ int fwts_dt_property_read_u64_arr(\n> int fwts_dt_stringlist_count(\n> \tfwts_framework *fw,\n> \tconst void *fdt,\n> -\tint nodeoffset,\n> +\tconst int nodeoffset,\n> \tconst char *property)\n> {\n> \tconst char *list, *end;\n> \n\n\nAcked-by: Alex Hung ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrYqW3Kldz9s81;\n\tTue, 12 Sep 2017 02:51:51 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1drRw6-0005Q9-8p; Mon, 11 Sep 2017 16:51:50 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1drRw4-0005Pq-Vv\n\tfor fwts-devel@lists.ubuntu.com; Mon, 11 Sep 2017 16:51:48 +0000","from mail-pg0-f72.google.com ([74.125.83.72])\n\tby youngberry.canonical.com with esmtps\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1drRw4-0003GN-KJ\n\tfor fwts-devel@lists.ubuntu.com; Mon, 11 Sep 2017 16:51:48 +0000","by mail-pg0-f72.google.com with SMTP id d8so17506119pgt.1\n\tfor ;\n\tMon, 11 Sep 2017 09:51:48 -0700 (PDT)","from [192.168.1.125] ([207.102.104.225])\n\tby smtp.gmail.com with ESMTPSA id\n\tr66sm8910929pfl.15.2017.09.11.09.51.42\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Sep 2017 09:51:46 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=xDZtLFOqe9u06y31HJ0TatUOg+BsTGmB0hRvx4P/uIA=;\n\tb=CuxiCDfSIdq+7zlTzM92PcHsI5c8exVntGlZLvqADgqfkX04adiTLoX1WzteReuVE2\n\tru1zpK9/iLJYAz8Z96NugP4cCl9wb905ejhogHzud2oMmF577CeyczV5qwzPFxXNZtq+\n\tDoZ8OsuHmSvYeDEyRDmD9y2fLTGYQrKn/C7XZgalhfeXBgBBCbGcu3nkMxG4PDxUZyXM\n\tIcpyH+GoI2D4+604puAsrqLRVHf+XTbPXI5/e5qHVm3GGx/EaLMFam0VZcZQN4LHUn+A\n\tfTTLNXyTphdGAWje7Vwe4xXpiqnA/SBY5lXmS6XsTGv+sFLiaT8/4le1P/IwKq+TRkPe\n\tgPOg==","X-Gm-Message-State":"AHPjjUjILi8cNNO3NF8DJNeusUZuXK4OP4YMG34vAcZpTM+uz6oEKGQS\n\tXNx9r4vBezbN2Ogsjyw8vnyseG7vel3lLur8oRP8CmyCBqEedjP6puqrhOWzT1uO/CMYVB1FDZ/\n\tUQxdMti2qNxMgpg9alqNR2JNRipmgkYg=","X-Received":["by 10.99.3.4 with SMTP id 4mr12535506pgd.203.1505148707149;\n\tMon, 11 Sep 2017 09:51:47 -0700 (PDT)","by 10.99.3.4 with SMTP id 4mr12535500pgd.203.1505148706935;\n\tMon, 11 Sep 2017 09:51:46 -0700 (PDT)"],"X-Google-Smtp-Source":"ADKCNb626C7FGXPZP9W++8FzCR/uaPYjoDMs1EzGOkeV0fI64g7QrHL2obj+2ty/0OYnhGpuiDbK3g==","Subject":"ACK: [PATCH] lib: fwts_devicetree: constify a few function arguments","To":"fwts-devel@lists.ubuntu.com","References":"<20170908094018.9553-1-colin.king@canonical.com>","From":"Alex Hung ","Message-ID":"<7497f773-7199-7e68-63a0-99e35e73e1e3@canonical.com>","Date":"Mon, 11 Sep 2017 09:51:42 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170908094018.9553-1-colin.king@canonical.com>","Content-Language":"en-US","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1772601,"web_url":"http://patchwork.ozlabs.org/comment/1772601/","msgid":"","list_archive_url":null,"date":"2017-09-21T09:16:47","subject":"ACK: [PATCH] lib: fwts_devicetree: constify a few function arguments","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/08/2017 05:40 PM, Colin King wrote:\n> From: Colin Ian King \n> \n> Code cleanup, constify some function arguments\n> \n> Signed-off-by: Colin Ian King \n> ---\n> src/lib/src/fwts_devicetree.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/lib/src/fwts_devicetree.c b/src/lib/src/fwts_devicetree.c\n> index 2fea3c8a..9db63de6 100644\n> --- a/src/lib/src/fwts_devicetree.c\n> +++ b/src/lib/src/fwts_devicetree.c\n> @@ -182,7 +182,7 @@ char *hidewhitespace(char *name)\n> \n> int fwts_dt_property_read_u32(\n> \tvoid *fdt,\n> -\tint offset,\n> +\tconst int offset,\n> \tconst char *pname,\n> \tint *value)\n> {\n> @@ -207,7 +207,7 @@ int fwts_dt_property_read_u32(\n> \n> int fwts_dt_property_read_u32_arr(\n> \tvoid *fdt,\n> -\tint offset,\n> +\tconst int offset,\n> \tconst char *pname,\n> \tint *value,\n> \tint *len)\n> @@ -236,7 +236,7 @@ int fwts_dt_property_read_u32_arr(\n> \n> int fwts_dt_property_read_u64_arr(\n> \tvoid *fdt,\n> -\tint offset,\n> +\tconst int offset,\n> \tconst char *pname,\n> \tuint64_t *value,\n> \tint *len)\n> @@ -261,7 +261,7 @@ int fwts_dt_property_read_u64_arr(\n> int fwts_dt_stringlist_count(\n> \tfwts_framework *fw,\n> \tconst void *fdt,\n> -\tint nodeoffset,\n> +\tconst int nodeoffset,\n> \tconst char *property)\n> {\n> \tconst char *list, *end;\n> \n\n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyWFx5p38z9t3w;\n\tThu, 21 Sep 2017 19:16:53 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1duxbI-0001U0-KJ; Thu, 21 Sep 2017 09:16:52 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1duxbH-0001TV-An\n\tfor fwts-devel@lists.ubuntu.com; Thu, 21 Sep 2017 09:16:51 +0000","from [175.181.226.10] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1duxbG-0004N6-Q1\n\tfor fwts-devel@lists.ubuntu.com; Thu, 21 Sep 2017 09:16:51 +0000"],"Subject":"ACK: [PATCH] lib: fwts_devicetree: constify a few function arguments","To":"fwts-devel@lists.ubuntu.com","References":"<20170908094018.9553-1-colin.king@canonical.com>","From":"ivanhu ","Message-ID":"","Date":"Thu, 21 Sep 2017 17:16:47 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170908094018.9553-1-colin.king@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]