[{"id":1773376,"web_url":"http://patchwork.ozlabs.org/comment/1773376/","msgid":"<986e03df-f312-9dd4-510f-a4e3b6138c39@canonical.com>","list_archive_url":null,"date":"2017-09-22T08:51:25","subject":"ACK: [PATCH 3/3] fwts-test: sync up with new\n\tfwts_acpi_reserved_bits_check","submitter":{"id":14061,"url":"http://patchwork.ozlabs.org/api/people/14061/","name":"Ivan Hu","email":"ivan.hu@canonical.com"},"content":"On 09/08/2017 05:07 PM, Alex Hung wrote:\n> Signed-off-by: Alex Hung \n> ---\n> fwts-test/asf-0001/asf-0002.log | 6 ++--\n> fwts-test/drtm-0001/drtm-0002.log | 5 ++--\n> fwts-test/facs-0001/facs-0002.log | 10 +++----\n> fwts-test/hest-0001/hest-0002.log | 18 ++++++------\n> fwts-test/hmat-0001/hmat-0002.log | 8 +++---\n> fwts-test/iort-0001/iort-0002.log | 58 +++++++++++++++++----------------------\n> fwts-test/nfit-0001/nfit-0002.log | 13 +++++----\n> fwts-test/pmtt-0001/pmtt-0002.log | 4 +--\n> fwts-test/pptt-0001/pptt-0002.log | 8 +++---\n> fwts-test/srat-0001/srat-0002.log | 18 ++++++------\n> fwts-test/waet-0001/waet-0002.log | 6 ++--\n> fwts-test/wsmt-0001/wsmt-0002.log | 5 ++--\n> fwts-test/xenv-0001/xenv-0002.log | 4 +--\n> 13 files changed, 78 insertions(+), 85 deletions(-)\n> \n> diff --git a/fwts-test/asf-0001/asf-0002.log b/fwts-test/asf-0001/asf-0002.log\n> index b8212e7..bee1002 100644\n> --- a/fwts-test/asf-0001/asf-0002.log\n> +++ b/fwts-test/asf-0001/asf-0002.log\n> @@ -8,9 +8,9 @@ asf in the range 0x01..0xff\n> asf FAILED [HIGH] ASF!InfoMinPollWaitTimeInvalid: Test 1, ASF!\n> asf ASF_INFO Minimum Poll Wait Time is 0x0 and must be in the\n> asf range 0x02..0xff\n> -asf FAILED [HIGH] ASF!InfoFeatureFlagsReserved: Test 1, ASF!\n> -asf ASF_INFO Feature Flags is 0xff, however reserved bits [7\n> -asf :1] must be zero\n> +asf FAILED [HIGH] ASF!ReservedBitsNonZero: Test 1, ASF!\n> +asf ASF_INFO Feature Flags Bits [7..1] must be zero, got 0xff\n> +asf instead\n> asf FAILED [MEDIUM] ASF!ReservedNonZero: Test 1, ASF! ASF_INFO\n> asf Reserved1 field must be zero, got 0x10 instead\n> asf FAILED [MEDIUM] ASF!ReservedNonZero: Test 1, ASF! ASF_INFO\n> diff --git a/fwts-test/drtm-0001/drtm-0002.log b/fwts-test/drtm-0001/drtm-0002.log\n> index 01fe9e1..05ed80e 100644\n> --- a/fwts-test/drtm-0001/drtm-0002.log\n> +++ b/fwts-test/drtm-0001/drtm-0002.log\n> @@ -11,8 +11,9 @@ drtm Log_Area_Start: 0x0000000050000000\n> drtm Log_Area_Length: 0x00006000\n> drtm Architecture_Dependent: 0x0000000070000000\n> drtm DRT_Flags: 0x00008000\n> -drtm FAILED [MEDIUM] DRTMBadFlagReservedNonZero: Test 1, DRTM\n> -drtm DRT_Flags Bits [31:4] are reserved, got 0x00008000 instead\n> +drtm FAILED [HIGH] DRTMReservedBitsNonZero: Test 1, DRTM\n> +drtm DRT_Flags Bits [31..4] must be zero, got 0x00008000\n> +drtm instead\n> drtm\n> drtm VTL_Length: 0x00000002\n> drtm Validated_Tables: 0x00000000a0000000\n> diff --git a/fwts-test/facs-0001/facs-0002.log b/fwts-test/facs-0001/facs-0002.log\n> index 6d7cb7c..68b2ee4 100644\n> --- a/fwts-test/facs-0001/facs-0002.log\n> +++ b/fwts-test/facs-0001/facs-0002.log\n> @@ -21,12 +21,10 @@ facs Reserved: 0x00 0x00 0x00 0x00\n> facs Reserved: 0x00 0x00 0x00 0x00\n> facs FAILED [LOW] FACSInvalidReserved1: Test 1, FACS: 1st\n> facs Reserved field is non-zero\n> -facs FAILED [MEDIUM] FACSFlagsReservedBitsSet: Test 1, FACS:\n> -facs Flags field is 0xffffffff and some of the reserved bits\n> -facs [31:2] are set\n> -facs FAILED [MEDIUM] FACSFlagsReservedBitsSet: Test 1, FACS:\n> -facs OSPM Flags field is 0xefefefef and some of the reserved\n> -facs bits [31:1] are set\n> +facs FAILED [HIGH] FACSReservedBitsNonZero: Test 1, FACS Flags\n> +facs Bits [31..2] must be zero, got 0xffffffff instead\n> +facs FAILED [HIGH] FACSReservedBitsNonZero: Test 1, FACS OSPM\n> +facs Flags Bits [31..1] must be zero, got 0xefefefef instead\n> facs FAILED [LOW] FACSInvalidReserved1: Test 1, FACS: 2nd\n> facs Reserved field is non-zero\n> facs\n> diff --git a/fwts-test/hest-0001/hest-0002.log b/fwts-test/hest-0001/hest-0002.log\n> index 274c0cf..88aa45d 100644\n> --- a/fwts-test/hest-0001/hest-0002.log\n> +++ b/fwts-test/hest-0001/hest-0002.log\n> @@ -23,9 +23,9 @@ hest Correctable Error Mask: 0x000011c1\n> hest Advanced Capabilities: 0x00000000\n> hest Root Error Command: 0x00000006\n> hest\n> -hest FAILED [MEDIUM] HESTPciExpressRootPortFlagsReserved: Test\n> -hest 1, HEST PCI Express Root Port Flags Reserved bits [2:7]\n> -hest must be zero, instead got 0x7\n> +hest FAILED [HIGH] HESTReservedBitsNonZero: Test 1, HEST PCI\n> +hest Express Root Port Flags Bits [7..2] must be zero, got 0x07\n> +hest instead\n> hest HEST PCI Express Device AER:\n> hest Type: 0x07\n> hest Source ID: 0x00ff\n> @@ -43,9 +43,9 @@ hest Uncorrectable Severity: 0x0017f011\n> hest Correctable Error Mask: 0x000011c1\n> hest Advanced Capabilities: 0x00000000\n> hest\n> -hest FAILED [MEDIUM] HESTPciExpressDeviceFlagsReserved: Test 1,\n> -hest HEST PCI Express Device Flags Reserved bits [2:7] must be\n> -hest zero, instead got 0x9\n> +hest FAILED [HIGH] HESTReservedBitsNonZero: Test 1, HEST PCI\n> +hest Express Device Flags Bits [7..2] must be zero, got 0x09\n> +hest instead\n> hest FAILED [HIGH] HESTInvalidRecordsToPreallocate: Test 1,\n> hest HEST PCI Express Device Number of Records to Preallocate\n> hest is 0x0 and must be more than zero.\n> @@ -70,9 +70,9 @@ hest 2nd Uncorrectable Mask: 0x00100020\n> hest 2nd Uncurrectable Svrity: 0x0017f011\n> hest 2nd Advanced Capabilities:0x00000000\n> hest\n> -hest FAILED [MEDIUM] HESTPciExpressBridgeFlagsReserved: Test 1,\n> -hest HEST PCI Express Bridge Flags Reserved bits [2:7] must be\n> -hest zero, instead got 0xf\n> +hest FAILED [HIGH] HESTReservedBitsNonZero: Test 1, HEST PCI\n> +hest Express Bridge Flags Bits [7..2] must be zero, got 0x0f\n> +hest instead\n> hest FAILED [HIGH] HESTInvalidRecordsToPreallocate: Test 1,\n> hest HEST PCI Express Bridge Number of Records to Preallocate\n> hest is 0x0 and must be more than zero.\n> diff --git a/fwts-test/hmat-0001/hmat-0002.log b/fwts-test/hmat-0001/hmat-0002.log\n> index d90468b..953413c 100644\n> --- a/fwts-test/hmat-0001/hmat-0002.log\n> +++ b/fwts-test/hmat-0001/hmat-0002.log\n> @@ -16,8 +16,8 @@ hmat System Phy Addr Range Base: 0x0000000000000000\n> hmat System Phy Addr Range Length: 0x0000000000000000\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> hmat field must be zero, got 0x0001 instead\n> -hmat FAILED [HIGH] HMATBadFlags: Test 1, HMAT Flags's\n> -hmat Bits[15..3] must be zero, got 0x000f instead\n> +hmat FAILED [HIGH] HMATReservedBitsNonZero: Test 1, HMAT Flags\n> +hmat Bits [15..3] must be zero, got 0x000f instead\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> hmat field must be zero, got 0x0002 instead\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> @@ -36,8 +36,8 @@ hmat Reserved: 0x00000006\n> hmat Entry Base Unit: 0x0000000000000000\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> hmat field must be zero, got 0x0004 instead\n> -hmat FAILED [CRITICAL] HMATBadFlags: Test 1, HMAT Flags's\n> -hmat Bits[7..5] must be zero, got 0x3f instead\n> +hmat FAILED [HIGH] HMATReservedBitsNonZero: Test 1, HMAT Flags\n> +hmat Bits [7..5] must be zero, got 0x3f instead\n> hmat FAILED [CRITICAL] HMATBadFDataType: Test 1, HMAT Data Type\n> hmat must be 0..5, got 0x06 instead\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> diff --git a/fwts-test/iort-0001/iort-0002.log b/fwts-test/iort-0001/iort-0002.log\n> index 7a0746b..82eb3d0 100644\n> --- a/fwts-test/iort-0001/iort-0002.log\n> +++ b/fwts-test/iort-0001/iort-0002.log\n> @@ -164,36 +164,28 @@ iort FAILED [LOW] IORTNodeRevisionNonZero: Test 1, IORT Node\n> iort Revision field is 0xa0 and should be zero.\n> iort FAILED [MEDIUM] IORTReservedNonZero: Test 1, IORT Node\n> iort Reserved field must be zero, got 0x00008100 instead\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_NsgIrpt Flags field reserved bits [31:1] should\n> -iort be all zero, got 0x2\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_NsgCfgIrpt Flags field reserved bits [31:1]\n> -iort should be all zero, got 0x4\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x8\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x10\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x20\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x40\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0xaa\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0xab\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x92\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x4\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_NsgIrpt Bits [31..1] must be zero, got 0x00000002\n> +iort instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_NsgCfgIrpt Bits [31..1] must be zero, got 0x00000004\n> +iort instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000008 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000010 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000020 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000040 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x000000aa instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x000000ab instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000092 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000004 instead\n> iort FAILED [HIGH] IORTSmmuInterruptsOutsideTable: Test 1, IORT\n> iort SMMU Interrupt 4 is outside the IORT ACPI table. Either\n> iort the offset is incorrect or the IORT table size is too\n> @@ -204,9 +196,9 @@ iort offset is incorrect or the IORT table size or the node is\n> iort too small.\n> iort FAILED [HIGH] IORTSmmuInvalidModel: Test 1, IORT SMMU\n> iort Model is 0x4 and was expecting a model value 0 to 3.\n> -iort FAILED [HIGH] IORTSmmuReservedFlags: Test 1, IORT SMMU\n> -iort Reserved Flags is 0xaa and has some reserved bits [31:2]\n> -iort set when they should be zero.\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT SMMU\n> +iort Reserved Flags Bits [31..2] must be zero, got 0x000000aa\n> +iort instead\n> iort\n> iort FAILED [HIGH] IORTInvalidType: Test 1, IORT Type 0xff is\n> iort invalid, aborting check\n> diff --git a/fwts-test/nfit-0001/nfit-0002.log b/fwts-test/nfit-0001/nfit-0002.log\n> index 02fba5a..2b13fe4 100644\n> --- a/fwts-test/nfit-0001/nfit-0002.log\n> +++ b/fwts-test/nfit-0001/nfit-0002.log\n> @@ -19,8 +19,8 @@ nfit System Physical Address Range Length: 0x000000000c000000\n> nfit Address Range Memory Mapping Attribute: 0x00000000000000ff\n> nfit FAILED [HIGH] NFITBadRangeIndexZero: Test 1, NFIT SPA\n> nfit Range Structure Index must not be zero\n> -nfit FAILED [HIGH] NFITBadFlags: Test 1, NFIT Flags's\n> -nfit Bits[15..2] must be zero, got 0x00000005 instead\n> +nfit FAILED [HIGH] NFITReservedBitsNonZero: Test 1, NFIT Flags\n> +nfit Bits [15..2] must be zero, got 0x0005 instead\n> nfit FAILED [HIGH] NFITBadMemoryMappingAttribute: Test 1, NFIT\n> nfit Memory Mapping Attribute must meet UEFI Spec, got\n> nfit 0x00000000000000ff instead\n> @@ -42,8 +42,8 @@ nfit Interleave Structure Index: 0x0001\n> nfit Interleave Ways: 0x0003\n> nfit NVDIMM State Flags: 0x00fa\n> nfit Reserved: 0x0000\n> -nfit FAILED [HIGH] NFITBadFlags: Test 1, NFIT Flags's\n> -nfit Bits[15..7] must be zero, got 0x000000fa instead\n> +nfit FAILED [HIGH] NFITReservedBitsNonZero: Test 1, NFIT NVDIMM\n> +nfit State Flags Bits [15..7] must be zero, got 0x00fa instead\n> nfit\n> nfit NFIT Subtable:\n> nfit Type: 0x0002\n> @@ -101,8 +101,9 @@ nfit FAILED [HIGH] NFITBadRevisionId: Test 1, NFIT Subsystem\n> nfit Revision ID's BYTE 1 must be zero, got 0xaa01 instead\n> nfit FAILED [HIGH] NFITBadValidField: Test 1, NFIT Valid\n> nfit Field's Bits[7..1] must be zero, got 0x03 instead\n> -nfit FAILED [HIGH] NFITBadFlags: Test 1, NFIT Flags's\n> -nfit Bits[15..1] must be zero, got 0x0003 instead\n> +nfit FAILED [HIGH] NFITReservedBitsNonZero: Test 1, NFIT NVDIMM\n> +nfit Control Region Flags Bits [15..1] must be zero, got 0x0003\n> +nfit instead\n> nfit FAILED [MEDIUM] NFITReservedNonZero: Test 1, NFIT Reserved\n> nfit field must be zero, got 0x0000000000000f00 instead\n> nfit\n> diff --git a/fwts-test/pmtt-0001/pmtt-0002.log b/fwts-test/pmtt-0001/pmtt-0002.log\n> index 2ce24a2..dfa1d00 100644\n> --- a/fwts-test/pmtt-0001/pmtt-0002.log\n> +++ b/fwts-test/pmtt-0001/pmtt-0002.log\n> @@ -95,8 +95,8 @@ pmtt Reserved: 0x00\n> pmtt Length: 0x000c\n> pmtt Flags: 0x0013\n> pmtt Reserved: 0x0000\n> -pmtt FAILED [HIGH] PMTTBadFlags: Test 1, PMTT Flags's\n> -pmtt Bits[15..4] must be zero, got 0x0013 instead\n> +pmtt FAILED [HIGH] PMTTReservedBitsNonZero: Test 1, PMTT Flags\n> +pmtt Bits [15..4] must be zero, got 0x0013 instead\n> pmtt Socket Identifier: 0x0002\n> pmtt Reserved: 0x0000\n> pmtt PMTT Subtable:\n> diff --git a/fwts-test/pptt-0001/pptt-0002.log b/fwts-test/pptt-0001/pptt-0002.log\n> index 4b3f2a6..0c83c65 100644\n> --- a/fwts-test/pptt-0001/pptt-0002.log\n> +++ b/fwts-test/pptt-0001/pptt-0002.log\n> @@ -40,8 +40,8 @@ pptt Private Resources[0]: 0x00000000\n> pptt Private Resources[1]: 0x00000000\n> pptt FAILED [MEDIUM] PPTTReservedNonZero: Test 1, PPTT Reserved\n> pptt field must be zero, got 0x0003 instead\n> -pptt FAILED [HIGH] PPTTBadFlags: Test 1, PPTT Flags's\n> -pptt Bits[31..2] must be zero, got 0x00000007 instead\n> +pptt FAILED [HIGH] PPTTReservedBitsNonZero: Test 1, PPTT Flags\n> +pptt Bits [31..2] must be zero, got 0x00000007 instead\n> pptt\n> pptt Cache Type Structure (Type 1):\n> pptt Type: 0x01\n> @@ -56,8 +56,8 @@ pptt Attributes: 0x00\n> pptt Line size: 0x0000\n> pptt FAILED [MEDIUM] PPTTReservedNonZero: Test 1, PPTT Reserved\n> pptt field must be zero, got 0x0004 instead\n> -pptt FAILED [HIGH] PPTTBadFlags: Test 1, PPTT Flags's\n> -pptt Bits[31..7] must be zero, got 0x000000ff instead\n> +pptt FAILED [HIGH] PPTTReservedBitsNonZero: Test 1, PPTT Flags\n> +pptt Bits [31..7] must be zero, got 0x000000ff instead\n> pptt\n> pptt ID structure (Type 2):\n> pptt Type: 0x02\n> diff --git a/fwts-test/srat-0001/srat-0002.log b/fwts-test/srat-0001/srat-0002.log\n> index 2abc922..9d5b1ff 100644\n> --- a/fwts-test/srat-0001/srat-0002.log\n> +++ b/fwts-test/srat-0001/srat-0002.log\n> @@ -15,9 +15,9 @@ srat Proximity Domain: [16:23] 0x00\n> srat Proximity Domain: [23:31] 0x00\n> srat Clock Domain 0x00000000\n> srat\n> -srat FAILED [MEDIUM] SRATLocalApicSapicAffinityFlags: Test 1,\n> -srat SRAT Local APIC/SPAIC Affinity Flags field reserved bits\n> -srat 1..31 should be zero, got 0x9\n> +srat FAILED [HIGH] SRATReservedBitsNonZero: Test 1, SRAT Local\n> +srat APIC/SPAIC Affinity Flags Bits [31..1] must be zero, got\n> +srat 0x00000009 instead\n> srat SRAT Local APIC/SAPIC Affinity Structure:\n> srat Type: 0x00\n> srat Length: 0x10\n> @@ -76,9 +76,9 @@ srat Reserved: 0x0000000f\n> srat Flags: 0x000000ff\n> srat Reserved: 0x0000000000000000\n> srat\n> -srat FAILED [MEDIUM] SRATMemoryAffinityFlags: Test 1, SRAT\n> -srat Memory Affinity Flags field reserved bits 3..31 should be\n> -srat zero, got 0xff\n> +srat FAILED [HIGH] SRATReservedBitsNonZero: Test 1, SRAT Memory\n> +srat Affinity Flags Bits [31..3] must be zero, got 0x000000ff\n> +srat instead\n> srat SRAT Memory Affinity Structure:\n> srat Type: 0x01\n> srat Length: 0x28\n> @@ -90,9 +90,9 @@ srat Reserved: 0x00000001\n> srat Flags: 0x00000008\n> srat Reserved: 0x0000000000000000\n> srat\n> -srat FAILED [MEDIUM] SRATMemoryAffinityFlags: Test 1, SRAT\n> -srat Memory Affinity Flags field reserved bits 3..31 should be\n> -srat zero, got 0x8\n> +srat FAILED [HIGH] SRATReservedBitsNonZero: Test 1, SRAT Memory\n> +srat Affinity Flags Bits [31..3] must be zero, got 0x00000008\n> +srat instead\n> srat\n> srat ==========================================================\n> srat 0 passed, 4 failed, 0 warning, 0 aborted, 0 skipped, 0\n> diff --git a/fwts-test/waet-0001/waet-0002.log b/fwts-test/waet-0001/waet-0002.log\n> index a8552c2..066ece2 100644\n> --- a/fwts-test/waet-0001/waet-0002.log\n> +++ b/fwts-test/waet-0001/waet-0002.log\n> @@ -6,9 +6,9 @@ waet Emulated Device Flags: 0xfffffffc\n> waet Bit [0] RTC Good: 0\n> waet Bit [1] PM Timer Good: 0\n> waet\n> -waet FAILED [HIGH] WAETFlagReservedNotZero: Test 1, WAET\n> -waet Emulated Device Flags was 0xfffffffc and so some of\n> -waet reserved bits [31:2] are not zero as expected.\n> +waet FAILED [HIGH] WAETReservedBitsNonZero: Test 1, WAET\n> +waet Emulated Device Flags Bits [31..2] must be zero, got\n> +waet 0xfffffffc instead\n> waet\n> waet ==========================================================\n> waet 0 passed, 1 failed, 0 warning, 0 aborted, 0 skipped, 0\n> diff --git a/fwts-test/wsmt-0001/wsmt-0002.log b/fwts-test/wsmt-0001/wsmt-0002.log\n> index b862a8f..52c45c2 100644\n> --- a/fwts-test/wsmt-0001/wsmt-0002.log\n> +++ b/fwts-test/wsmt-0001/wsmt-0002.log\n> @@ -4,8 +4,9 @@ wsmt Test 1 of 1: WSMT Windows SMM Security Mitigations Table\n> wsmt test.\n> wsmt WSMT Windows SMM Security Mitigations Table:\n> wsmt Protection Flags: 0x00000009\n> -wsmt FAILED [MEDIUM] WSMTFlagsReserved: Test 1, WSMT Protection\n> -wsmt Flags reserved bits [3:31] must be zero, instead got 0x9\n> +wsmt FAILED [HIGH] WSMTReservedBitsNonZero: Test 1, WSMT\n> +wsmt Protection Flags Bits [31..3] must be zero, got 0x00000009\n> +wsmt instead\n> wsmt\n> wsmt\n> wsmt ==========================================================\n> diff --git a/fwts-test/xenv-0001/xenv-0002.log b/fwts-test/xenv-0001/xenv-0002.log\n> index ca573a3..c25a0db 100644\n> --- a/fwts-test/xenv-0001/xenv-0002.log\n> +++ b/fwts-test/xenv-0001/xenv-0002.log\n> @@ -6,8 +6,8 @@ xenv GNT Start Address: 0x0000000010000000\n> xenv GNT Size: 0x0000000000002000\n> xenv Evtchn Intr: 0x25000000\n> xenv Evtchn Intr Flags: 0x07\n> -xenv FAILED [HIGH] XENVBadEvtchnIntrFlags: Test 1, XENV Evtchn\n> -xenv Intr Flags was 0x07 and reserved bits [7:2] are not zero.\n> +xenv FAILED [HIGH] XENVReservedBitsNonZero: Test 1, XENV Evtchn\n> +xenv Intr Flags Bits [7..2] must be zero, got 0x07 instead\n> xenv\n> xenv ==========================================================\n> xenv 0 passed, 1 failed, 0 warning, 0 aborted, 0 skipped, 0\n> \n\nAcked-by: Ivan Hu ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz6fF305cz9sPk;\n\tFri, 22 Sep 2017 18:51:33 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dvJgK-0006NU-7e; Fri, 22 Sep 2017 08:51:32 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dvJgH-0006Mk-Uf\n\tfor fwts-devel@lists.ubuntu.com; Fri, 22 Sep 2017 08:51:29 +0000","from [175.181.226.10] (helo=[192.168.31.95])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dvJgH-0000GO-2j\n\tfor fwts-devel@lists.ubuntu.com; Fri, 22 Sep 2017 08:51:29 +0000"],"Subject":"ACK: [PATCH 3/3] fwts-test: sync up with new\n\tfwts_acpi_reserved_bits_check","To":"fwts-devel@lists.ubuntu.com","References":"<1504861633-20512-1-git-send-email-alex.hung@canonical.com>\n\t<1504861633-20512-3-git-send-email-alex.hung@canonical.com>","From":"ivanhu ","Message-ID":"<986e03df-f312-9dd4-510f-a4e3b6138c39@canonical.com>","Date":"Fri, 22 Sep 2017 16:51:25 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504861633-20512-3-git-send-email-alex.hung@canonical.com>","Content-Language":"en-GB","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}},{"id":1774681,"web_url":"http://patchwork.ozlabs.org/comment/1774681/","msgid":"<5ccb1847-ad48-07d8-a70d-ce52491f825f@canonical.com>","list_archive_url":null,"date":"2017-09-25T12:01:59","subject":"ACK: [PATCH 3/3] fwts-test: sync up with new\n\tfwts_acpi_reserved_bits_check","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/","name":"Colin Ian King","email":"colin.king@canonical.com"},"content":"On 08/09/17 10:07, Alex Hung wrote:\n> Signed-off-by: Alex Hung \n> ---\n> fwts-test/asf-0001/asf-0002.log | 6 ++--\n> fwts-test/drtm-0001/drtm-0002.log | 5 ++--\n> fwts-test/facs-0001/facs-0002.log | 10 +++----\n> fwts-test/hest-0001/hest-0002.log | 18 ++++++------\n> fwts-test/hmat-0001/hmat-0002.log | 8 +++---\n> fwts-test/iort-0001/iort-0002.log | 58 +++++++++++++++++----------------------\n> fwts-test/nfit-0001/nfit-0002.log | 13 +++++----\n> fwts-test/pmtt-0001/pmtt-0002.log | 4 +--\n> fwts-test/pptt-0001/pptt-0002.log | 8 +++---\n> fwts-test/srat-0001/srat-0002.log | 18 ++++++------\n> fwts-test/waet-0001/waet-0002.log | 6 ++--\n> fwts-test/wsmt-0001/wsmt-0002.log | 5 ++--\n> fwts-test/xenv-0001/xenv-0002.log | 4 +--\n> 13 files changed, 78 insertions(+), 85 deletions(-)\n> \n> diff --git a/fwts-test/asf-0001/asf-0002.log b/fwts-test/asf-0001/asf-0002.log\n> index b8212e7..bee1002 100644\n> --- a/fwts-test/asf-0001/asf-0002.log\n> +++ b/fwts-test/asf-0001/asf-0002.log\n> @@ -8,9 +8,9 @@ asf in the range 0x01..0xff\n> asf FAILED [HIGH] ASF!InfoMinPollWaitTimeInvalid: Test 1, ASF!\n> asf ASF_INFO Minimum Poll Wait Time is 0x0 and must be in the\n> asf range 0x02..0xff\n> -asf FAILED [HIGH] ASF!InfoFeatureFlagsReserved: Test 1, ASF!\n> -asf ASF_INFO Feature Flags is 0xff, however reserved bits [7\n> -asf :1] must be zero\n> +asf FAILED [HIGH] ASF!ReservedBitsNonZero: Test 1, ASF!\n> +asf ASF_INFO Feature Flags Bits [7..1] must be zero, got 0xff\n> +asf instead\n> asf FAILED [MEDIUM] ASF!ReservedNonZero: Test 1, ASF! ASF_INFO\n> asf Reserved1 field must be zero, got 0x10 instead\n> asf FAILED [MEDIUM] ASF!ReservedNonZero: Test 1, ASF! ASF_INFO\n> diff --git a/fwts-test/drtm-0001/drtm-0002.log b/fwts-test/drtm-0001/drtm-0002.log\n> index 01fe9e1..05ed80e 100644\n> --- a/fwts-test/drtm-0001/drtm-0002.log\n> +++ b/fwts-test/drtm-0001/drtm-0002.log\n> @@ -11,8 +11,9 @@ drtm Log_Area_Start: 0x0000000050000000\n> drtm Log_Area_Length: 0x00006000\n> drtm Architecture_Dependent: 0x0000000070000000\n> drtm DRT_Flags: 0x00008000\n> -drtm FAILED [MEDIUM] DRTMBadFlagReservedNonZero: Test 1, DRTM\n> -drtm DRT_Flags Bits [31:4] are reserved, got 0x00008000 instead\n> +drtm FAILED [HIGH] DRTMReservedBitsNonZero: Test 1, DRTM\n> +drtm DRT_Flags Bits [31..4] must be zero, got 0x00008000\n> +drtm instead\n> drtm \n> drtm VTL_Length: 0x00000002\n> drtm Validated_Tables: 0x00000000a0000000\n> diff --git a/fwts-test/facs-0001/facs-0002.log b/fwts-test/facs-0001/facs-0002.log\n> index 6d7cb7c..68b2ee4 100644\n> --- a/fwts-test/facs-0001/facs-0002.log\n> +++ b/fwts-test/facs-0001/facs-0002.log\n> @@ -21,12 +21,10 @@ facs Reserved: 0x00 0x00 0x00 0x00\n> facs Reserved: 0x00 0x00 0x00 0x00\n> facs FAILED [LOW] FACSInvalidReserved1: Test 1, FACS: 1st\n> facs Reserved field is non-zero\n> -facs FAILED [MEDIUM] FACSFlagsReservedBitsSet: Test 1, FACS:\n> -facs Flags field is 0xffffffff and some of the reserved bits\n> -facs [31:2] are set\n> -facs FAILED [MEDIUM] FACSFlagsReservedBitsSet: Test 1, FACS:\n> -facs OSPM Flags field is 0xefefefef and some of the reserved\n> -facs bits [31:1] are set\n> +facs FAILED [HIGH] FACSReservedBitsNonZero: Test 1, FACS Flags\n> +facs Bits [31..2] must be zero, got 0xffffffff instead\n> +facs FAILED [HIGH] FACSReservedBitsNonZero: Test 1, FACS OSPM\n> +facs Flags Bits [31..1] must be zero, got 0xefefefef instead\n> facs FAILED [LOW] FACSInvalidReserved1: Test 1, FACS: 2nd\n> facs Reserved field is non-zero\n> facs \n> diff --git a/fwts-test/hest-0001/hest-0002.log b/fwts-test/hest-0001/hest-0002.log\n> index 274c0cf..88aa45d 100644\n> --- a/fwts-test/hest-0001/hest-0002.log\n> +++ b/fwts-test/hest-0001/hest-0002.log\n> @@ -23,9 +23,9 @@ hest Correctable Error Mask: 0x000011c1\n> hest Advanced Capabilities: 0x00000000\n> hest Root Error Command: 0x00000006\n> hest \n> -hest FAILED [MEDIUM] HESTPciExpressRootPortFlagsReserved: Test\n> -hest 1, HEST PCI Express Root Port Flags Reserved bits [2:7]\n> -hest must be zero, instead got 0x7\n> +hest FAILED [HIGH] HESTReservedBitsNonZero: Test 1, HEST PCI\n> +hest Express Root Port Flags Bits [7..2] must be zero, got 0x07\n> +hest instead\n> hest HEST PCI Express Device AER:\n> hest Type: 0x07\n> hest Source ID: 0x00ff\n> @@ -43,9 +43,9 @@ hest Uncorrectable Severity: 0x0017f011\n> hest Correctable Error Mask: 0x000011c1\n> hest Advanced Capabilities: 0x00000000\n> hest \n> -hest FAILED [MEDIUM] HESTPciExpressDeviceFlagsReserved: Test 1,\n> -hest HEST PCI Express Device Flags Reserved bits [2:7] must be\n> -hest zero, instead got 0x9\n> +hest FAILED [HIGH] HESTReservedBitsNonZero: Test 1, HEST PCI\n> +hest Express Device Flags Bits [7..2] must be zero, got 0x09\n> +hest instead\n> hest FAILED [HIGH] HESTInvalidRecordsToPreallocate: Test 1,\n> hest HEST PCI Express Device Number of Records to Preallocate\n> hest is 0x0 and must be more than zero.\n> @@ -70,9 +70,9 @@ hest 2nd Uncorrectable Mask: 0x00100020\n> hest 2nd Uncurrectable Svrity: 0x0017f011\n> hest 2nd Advanced Capabilities:0x00000000\n> hest \n> -hest FAILED [MEDIUM] HESTPciExpressBridgeFlagsReserved: Test 1,\n> -hest HEST PCI Express Bridge Flags Reserved bits [2:7] must be\n> -hest zero, instead got 0xf\n> +hest FAILED [HIGH] HESTReservedBitsNonZero: Test 1, HEST PCI\n> +hest Express Bridge Flags Bits [7..2] must be zero, got 0x0f\n> +hest instead\n> hest FAILED [HIGH] HESTInvalidRecordsToPreallocate: Test 1,\n> hest HEST PCI Express Bridge Number of Records to Preallocate\n> hest is 0x0 and must be more than zero.\n> diff --git a/fwts-test/hmat-0001/hmat-0002.log b/fwts-test/hmat-0001/hmat-0002.log\n> index d90468b..953413c 100644\n> --- a/fwts-test/hmat-0001/hmat-0002.log\n> +++ b/fwts-test/hmat-0001/hmat-0002.log\n> @@ -16,8 +16,8 @@ hmat System Phy Addr Range Base: 0x0000000000000000\n> hmat System Phy Addr Range Length: 0x0000000000000000\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> hmat field must be zero, got 0x0001 instead\n> -hmat FAILED [HIGH] HMATBadFlags: Test 1, HMAT Flags's\n> -hmat Bits[15..3] must be zero, got 0x000f instead\n> +hmat FAILED [HIGH] HMATReservedBitsNonZero: Test 1, HMAT Flags\n> +hmat Bits [15..3] must be zero, got 0x000f instead\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> hmat field must be zero, got 0x0002 instead\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> @@ -36,8 +36,8 @@ hmat Reserved: 0x00000006\n> hmat Entry Base Unit: 0x0000000000000000\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> hmat field must be zero, got 0x0004 instead\n> -hmat FAILED [CRITICAL] HMATBadFlags: Test 1, HMAT Flags's\n> -hmat Bits[7..5] must be zero, got 0x3f instead\n> +hmat FAILED [HIGH] HMATReservedBitsNonZero: Test 1, HMAT Flags\n> +hmat Bits [7..5] must be zero, got 0x3f instead\n> hmat FAILED [CRITICAL] HMATBadFDataType: Test 1, HMAT Data Type\n> hmat must be 0..5, got 0x06 instead\n> hmat FAILED [MEDIUM] HMATReservedNonZero: Test 1, HMAT Reserved\n> diff --git a/fwts-test/iort-0001/iort-0002.log b/fwts-test/iort-0001/iort-0002.log\n> index 7a0746b..82eb3d0 100644\n> --- a/fwts-test/iort-0001/iort-0002.log\n> +++ b/fwts-test/iort-0001/iort-0002.log\n> @@ -164,36 +164,28 @@ iort FAILED [LOW] IORTNodeRevisionNonZero: Test 1, IORT Node\n> iort Revision field is 0xa0 and should be zero.\n> iort FAILED [MEDIUM] IORTReservedNonZero: Test 1, IORT Node\n> iort Reserved field must be zero, got 0x00008100 instead\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_NsgIrpt Flags field reserved bits [31:1] should\n> -iort be all zero, got 0x2\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_NsgCfgIrpt Flags field reserved bits [31:1]\n> -iort should be all zero, got 0x4\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x8\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x10\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x20\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x40\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0xaa\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0xab\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x92\n> -iort FAILED [MEDIUM] IORTSMMUIntrFlagsReservedNonZero: Test 1,\n> -iort IORT SMMU_GSV Flags field reserved bits [31:1] should be\n> -iort all zero, got 0x4\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_NsgIrpt Bits [31..1] must be zero, got 0x00000002\n> +iort instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_NsgCfgIrpt Bits [31..1] must be zero, got 0x00000004\n> +iort instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000008 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000010 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000020 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000040 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x000000aa instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x000000ab instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000092 instead\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT\n> +iort SMMU_GSV Bits [31..1] must be zero, got 0x00000004 instead\n> iort FAILED [HIGH] IORTSmmuInterruptsOutsideTable: Test 1, IORT\n> iort SMMU Interrupt 4 is outside the IORT ACPI table. Either\n> iort the offset is incorrect or the IORT table size is too\n> @@ -204,9 +196,9 @@ iort offset is incorrect or the IORT table size or the node is\n> iort too small.\n> iort FAILED [HIGH] IORTSmmuInvalidModel: Test 1, IORT SMMU\n> iort Model is 0x4 and was expecting a model value 0 to 3.\n> -iort FAILED [HIGH] IORTSmmuReservedFlags: Test 1, IORT SMMU\n> -iort Reserved Flags is 0xaa and has some reserved bits [31:2]\n> -iort set when they should be zero.\n> +iort FAILED [HIGH] IORTReservedBitsNonZero: Test 1, IORT SMMU\n> +iort Reserved Flags Bits [31..2] must be zero, got 0x000000aa\n> +iort instead\n> iort \n> iort FAILED [HIGH] IORTInvalidType: Test 1, IORT Type 0xff is\n> iort invalid, aborting check\n> diff --git a/fwts-test/nfit-0001/nfit-0002.log b/fwts-test/nfit-0001/nfit-0002.log\n> index 02fba5a..2b13fe4 100644\n> --- a/fwts-test/nfit-0001/nfit-0002.log\n> +++ b/fwts-test/nfit-0001/nfit-0002.log\n> @@ -19,8 +19,8 @@ nfit System Physical Address Range Length: 0x000000000c000000\n> nfit Address Range Memory Mapping Attribute: 0x00000000000000ff\n> nfit FAILED [HIGH] NFITBadRangeIndexZero: Test 1, NFIT SPA\n> nfit Range Structure Index must not be zero\n> -nfit FAILED [HIGH] NFITBadFlags: Test 1, NFIT Flags's\n> -nfit Bits[15..2] must be zero, got 0x00000005 instead\n> +nfit FAILED [HIGH] NFITReservedBitsNonZero: Test 1, NFIT Flags\n> +nfit Bits [15..2] must be zero, got 0x0005 instead\n> nfit FAILED [HIGH] NFITBadMemoryMappingAttribute: Test 1, NFIT\n> nfit Memory Mapping Attribute must meet UEFI Spec, got\n> nfit 0x00000000000000ff instead\n> @@ -42,8 +42,8 @@ nfit Interleave Structure Index: 0x0001\n> nfit Interleave Ways: 0x0003\n> nfit NVDIMM State Flags: 0x00fa\n> nfit Reserved: 0x0000\n> -nfit FAILED [HIGH] NFITBadFlags: Test 1, NFIT Flags's\n> -nfit Bits[15..7] must be zero, got 0x000000fa instead\n> +nfit FAILED [HIGH] NFITReservedBitsNonZero: Test 1, NFIT NVDIMM\n> +nfit State Flags Bits [15..7] must be zero, got 0x00fa instead\n> nfit \n> nfit NFIT Subtable:\n> nfit Type: 0x0002\n> @@ -101,8 +101,9 @@ nfit FAILED [HIGH] NFITBadRevisionId: Test 1, NFIT Subsystem\n> nfit Revision ID's BYTE 1 must be zero, got 0xaa01 instead\n> nfit FAILED [HIGH] NFITBadValidField: Test 1, NFIT Valid\n> nfit Field's Bits[7..1] must be zero, got 0x03 instead\n> -nfit FAILED [HIGH] NFITBadFlags: Test 1, NFIT Flags's\n> -nfit Bits[15..1] must be zero, got 0x0003 instead\n> +nfit FAILED [HIGH] NFITReservedBitsNonZero: Test 1, NFIT NVDIMM\n> +nfit Control Region Flags Bits [15..1] must be zero, got 0x0003\n> +nfit instead\n> nfit FAILED [MEDIUM] NFITReservedNonZero: Test 1, NFIT Reserved\n> nfit field must be zero, got 0x0000000000000f00 instead\n> nfit \n> diff --git a/fwts-test/pmtt-0001/pmtt-0002.log b/fwts-test/pmtt-0001/pmtt-0002.log\n> index 2ce24a2..dfa1d00 100644\n> --- a/fwts-test/pmtt-0001/pmtt-0002.log\n> +++ b/fwts-test/pmtt-0001/pmtt-0002.log\n> @@ -95,8 +95,8 @@ pmtt Reserved: 0x00\n> pmtt Length: 0x000c\n> pmtt Flags: 0x0013\n> pmtt Reserved: 0x0000\n> -pmtt FAILED [HIGH] PMTTBadFlags: Test 1, PMTT Flags's\n> -pmtt Bits[15..4] must be zero, got 0x0013 instead\n> +pmtt FAILED [HIGH] PMTTReservedBitsNonZero: Test 1, PMTT Flags\n> +pmtt Bits [15..4] must be zero, got 0x0013 instead\n> pmtt Socket Identifier: 0x0002\n> pmtt Reserved: 0x0000\n> pmtt PMTT Subtable:\n> diff --git a/fwts-test/pptt-0001/pptt-0002.log b/fwts-test/pptt-0001/pptt-0002.log\n> index 4b3f2a6..0c83c65 100644\n> --- a/fwts-test/pptt-0001/pptt-0002.log\n> +++ b/fwts-test/pptt-0001/pptt-0002.log\n> @@ -40,8 +40,8 @@ pptt Private Resources[0]: 0x00000000\n> pptt Private Resources[1]: 0x00000000\n> pptt FAILED [MEDIUM] PPTTReservedNonZero: Test 1, PPTT Reserved\n> pptt field must be zero, got 0x0003 instead\n> -pptt FAILED [HIGH] PPTTBadFlags: Test 1, PPTT Flags's\n> -pptt Bits[31..2] must be zero, got 0x00000007 instead\n> +pptt FAILED [HIGH] PPTTReservedBitsNonZero: Test 1, PPTT Flags\n> +pptt Bits [31..2] must be zero, got 0x00000007 instead\n> pptt \n> pptt Cache Type Structure (Type 1):\n> pptt Type: 0x01\n> @@ -56,8 +56,8 @@ pptt Attributes: 0x00\n> pptt Line size: 0x0000\n> pptt FAILED [MEDIUM] PPTTReservedNonZero: Test 1, PPTT Reserved\n> pptt field must be zero, got 0x0004 instead\n> -pptt FAILED [HIGH] PPTTBadFlags: Test 1, PPTT Flags's\n> -pptt Bits[31..7] must be zero, got 0x000000ff instead\n> +pptt FAILED [HIGH] PPTTReservedBitsNonZero: Test 1, PPTT Flags\n> +pptt Bits [31..7] must be zero, got 0x000000ff instead\n> pptt \n> pptt ID structure (Type 2):\n> pptt Type: 0x02\n> diff --git a/fwts-test/srat-0001/srat-0002.log b/fwts-test/srat-0001/srat-0002.log\n> index 2abc922..9d5b1ff 100644\n> --- a/fwts-test/srat-0001/srat-0002.log\n> +++ b/fwts-test/srat-0001/srat-0002.log\n> @@ -15,9 +15,9 @@ srat Proximity Domain: [16:23] 0x00\n> srat Proximity Domain: [23:31] 0x00\n> srat Clock Domain 0x00000000\n> srat \n> -srat FAILED [MEDIUM] SRATLocalApicSapicAffinityFlags: Test 1,\n> -srat SRAT Local APIC/SPAIC Affinity Flags field reserved bits\n> -srat 1..31 should be zero, got 0x9\n> +srat FAILED [HIGH] SRATReservedBitsNonZero: Test 1, SRAT Local\n> +srat APIC/SPAIC Affinity Flags Bits [31..1] must be zero, got\n> +srat 0x00000009 instead\n> srat SRAT Local APIC/SAPIC Affinity Structure:\n> srat Type: 0x00\n> srat Length: 0x10\n> @@ -76,9 +76,9 @@ srat Reserved: 0x0000000f\n> srat Flags: 0x000000ff\n> srat Reserved: 0x0000000000000000\n> srat \n> -srat FAILED [MEDIUM] SRATMemoryAffinityFlags: Test 1, SRAT\n> -srat Memory Affinity Flags field reserved bits 3..31 should be\n> -srat zero, got 0xff\n> +srat FAILED [HIGH] SRATReservedBitsNonZero: Test 1, SRAT Memory\n> +srat Affinity Flags Bits [31..3] must be zero, got 0x000000ff\n> +srat instead\n> srat SRAT Memory Affinity Structure:\n> srat Type: 0x01\n> srat Length: 0x28\n> @@ -90,9 +90,9 @@ srat Reserved: 0x00000001\n> srat Flags: 0x00000008\n> srat Reserved: 0x0000000000000000\n> srat \n> -srat FAILED [MEDIUM] SRATMemoryAffinityFlags: Test 1, SRAT\n> -srat Memory Affinity Flags field reserved bits 3..31 should be\n> -srat zero, got 0x8\n> +srat FAILED [HIGH] SRATReservedBitsNonZero: Test 1, SRAT Memory\n> +srat Affinity Flags Bits [31..3] must be zero, got 0x00000008\n> +srat instead\n> srat \n> srat ==========================================================\n> srat 0 passed, 4 failed, 0 warning, 0 aborted, 0 skipped, 0\n> diff --git a/fwts-test/waet-0001/waet-0002.log b/fwts-test/waet-0001/waet-0002.log\n> index a8552c2..066ece2 100644\n> --- a/fwts-test/waet-0001/waet-0002.log\n> +++ b/fwts-test/waet-0001/waet-0002.log\n> @@ -6,9 +6,9 @@ waet Emulated Device Flags: 0xfffffffc\n> waet Bit [0] RTC Good: 0\n> waet Bit [1] PM Timer Good: 0\n> waet \n> -waet FAILED [HIGH] WAETFlagReservedNotZero: Test 1, WAET\n> -waet Emulated Device Flags was 0xfffffffc and so some of\n> -waet reserved bits [31:2] are not zero as expected.\n> +waet FAILED [HIGH] WAETReservedBitsNonZero: Test 1, WAET\n> +waet Emulated Device Flags Bits [31..2] must be zero, got\n> +waet 0xfffffffc instead\n> waet \n> waet ==========================================================\n> waet 0 passed, 1 failed, 0 warning, 0 aborted, 0 skipped, 0\n> diff --git a/fwts-test/wsmt-0001/wsmt-0002.log b/fwts-test/wsmt-0001/wsmt-0002.log\n> index b862a8f..52c45c2 100644\n> --- a/fwts-test/wsmt-0001/wsmt-0002.log\n> +++ b/fwts-test/wsmt-0001/wsmt-0002.log\n> @@ -4,8 +4,9 @@ wsmt Test 1 of 1: WSMT Windows SMM Security Mitigations Table\n> wsmt test.\n> wsmt WSMT Windows SMM Security Mitigations Table:\n> wsmt Protection Flags: 0x00000009\n> -wsmt FAILED [MEDIUM] WSMTFlagsReserved: Test 1, WSMT Protection\n> -wsmt Flags reserved bits [3:31] must be zero, instead got 0x9\n> +wsmt FAILED [HIGH] WSMTReservedBitsNonZero: Test 1, WSMT\n> +wsmt Protection Flags Bits [31..3] must be zero, got 0x00000009\n> +wsmt instead\n> wsmt \n> wsmt \n> wsmt ==========================================================\n> diff --git a/fwts-test/xenv-0001/xenv-0002.log b/fwts-test/xenv-0001/xenv-0002.log\n> index ca573a3..c25a0db 100644\n> --- a/fwts-test/xenv-0001/xenv-0002.log\n> +++ b/fwts-test/xenv-0001/xenv-0002.log\n> @@ -6,8 +6,8 @@ xenv GNT Start Address: 0x0000000010000000\n> xenv GNT Size: 0x0000000000002000\n> xenv Evtchn Intr: 0x25000000\n> xenv Evtchn Intr Flags: 0x07\n> -xenv FAILED [HIGH] XENVBadEvtchnIntrFlags: Test 1, XENV Evtchn\n> -xenv Intr Flags was 0x07 and reserved bits [7:2] are not zero.\n> +xenv FAILED [HIGH] XENVReservedBitsNonZero: Test 1, XENV Evtchn\n> +xenv Intr Flags Bits [7..2] must be zero, got 0x07 instead\n> xenv \n> xenv ==========================================================\n> xenv 0 passed, 1 failed, 0 warning, 0 aborted, 0 skipped, 0\n> \n\nThanks Alex\n\nAcked-by: Colin Ian King ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=fwts-devel-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3y12kj3fX8z9sRq;\n\tMon, 25 Sep 2017 22:02:05 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dwS5M-0002x9-91; Mon, 25 Sep 2017 12:02:04 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dwS5J-0002w5-R3\n\tfor fwts-devel@lists.ubuntu.com; Mon, 25 Sep 2017 12:02:01 +0000","from 207.110.29.138.ptr.us.xo.net ([207.110.29.138]\n\thelo=[172.20.15.111]) by youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dwS5J-00024d-DJ; Mon, 25 Sep 2017 12:02:01 +0000"],"Subject":"ACK: [PATCH 3/3] fwts-test: sync up with new\n\tfwts_acpi_reserved_bits_check","To":"Alex Hung , fwts-devel@lists.ubuntu.com","References":"<1504861633-20512-1-git-send-email-alex.hung@canonical.com>\n\t<1504861633-20512-3-git-send-email-alex.hung@canonical.com>","From":"Colin Ian King ","Message-ID":"<5ccb1847-ad48-07d8-a70d-ce52491f825f@canonical.com>","Date":"Mon, 25 Sep 2017 13:01:59 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<1504861633-20512-3-git-send-email-alex.hung@canonical.com>","X-BeenThere":"fwts-devel@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Firmware Test Suite Development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"fwts-devel-bounces@lists.ubuntu.com","Sender":"\"fwts-devel\" "}}]