[{"id":1765119,"web_url":"http://patchwork.ozlabs.org/comment/1765119/","msgid":"<20170908071954.j2bhtw4wqa27fald@flea.lan>","list_archive_url":null,"date":"2017-09-08T07:19:54","subject":"Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote:\n> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n> index 1c2387bd5df6..968908761194 100644\n> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n> @@ -50,6 +50,7 @@\n>  \tcompatible = \"friendlyarm,nanopi-neo2\", \"allwinner,sun50i-h5\";\n>  \n>  \taliases {\n> +\t\tethernet0 = &emac;\n>  \t\tserial0 = &uart0;\n>  \t};\n>  \n> @@ -108,6 +109,22 @@\n>  \tstatus = \"okay\";\n>  };\n>  \n> +&emac {\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&emac_rgmii_pins>;\n> +\tphy-supply = <&reg_gmac_3v3>;\n> +\tphy-handle = <&ext_rgmii_phy>;\n> +\tphy-mode = \"rgmii\";\n> +\tstatus = \"okay\";\n> +};\n> +\n> +&mdio {\n> +\text_rgmii_phy: ethernet-phy@7 {\n> +\t\tcompatible = \"ethernet-phy-ieee802.3-c22\";\n> +\t\treg = <7>;\n> +\t};\n> +};\n> +\n\nThis won't compile, you don't have that node in the H5 DTSI.\n\nMaxime","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpTHH3KfHz9s4s\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 17:20:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755073AbdIHHT5 (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 8 Sep 2017 03:19:57 -0400","from mail.free-electrons.com ([62.4.15.54]:36458 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753222AbdIHHT4 (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 8 Sep 2017 03:19:56 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid CCDB92096B; Fri,  8 Sep 2017 09:19:53 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id A59F42095E;\n\tFri,  8 Sep 2017 09:19:53 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Fri, 8 Sep 2017 09:19:54 +0200","From":"Maxime Ripard <maxime.ripard@free-electrons.com>","To":"Corentin Labbe <clabbe.montjoie@gmail.com>","Cc":"robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,\n\tlinux@armlinux.org.uk, catalin.marinas@arm.com,\n\twill.deacon@arm.com, peppe.cavallaro@st.com,\n\talexandre.torgue@st.com, andrew@lunn.ch, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes","Message-ID":"<20170908071954.j2bhtw4wqa27fald@flea.lan>","References":"<20170908071156.5115-1-clabbe.montjoie@gmail.com>\n\t<20170908071156.5115-2-clabbe.montjoie@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"tsk3vhysft3ppq3p\"","Content-Disposition":"inline","In-Reply-To":"<20170908071156.5115-2-clabbe.montjoie@gmail.com>","User-Agent":"NeoMutt/20170714 (1.8.3)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765131,"web_url":"http://patchwork.ozlabs.org/comment/1765131/","msgid":"<20170908073657.GA29999@Red>","list_archive_url":null,"date":"2017-09-08T07:36:57","subject":"Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes","submitter":{"id":64152,"url":"http://patchwork.ozlabs.org/api/people/64152/","name":"Corentin Labbe","email":"clabbe.montjoie@gmail.com"},"content":"On Fri, Sep 08, 2017 at 09:19:54AM +0200, Maxime Ripard wrote:\n> On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote:\n> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n> > index 1c2387bd5df6..968908761194 100644\n> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n> > @@ -50,6 +50,7 @@\n> >  \tcompatible = \"friendlyarm,nanopi-neo2\", \"allwinner,sun50i-h5\";\n> >  \n> >  \taliases {\n> > +\t\tethernet0 = &emac;\n> >  \t\tserial0 = &uart0;\n> >  \t};\n> >  \n> > @@ -108,6 +109,22 @@\n> >  \tstatus = \"okay\";\n> >  };\n> >  \n> > +&emac {\n> > +\tpinctrl-names = \"default\";\n> > +\tpinctrl-0 = <&emac_rgmii_pins>;\n> > +\tphy-supply = <&reg_gmac_3v3>;\n> > +\tphy-handle = <&ext_rgmii_phy>;\n> > +\tphy-mode = \"rgmii\";\n> > +\tstatus = \"okay\";\n> > +};\n> > +\n> > +&mdio {\n> > +\text_rgmii_phy: ethernet-phy@7 {\n> > +\t\tcompatible = \"ethernet-phy-ieee802.3-c22\";\n> > +\t\treg = <7>;\n> > +\t};\n> > +};\n> > +\n> \n> This won't compile, you don't have that node in the H5 DTSI.\n> \n\nSince H5 DTSI include arm/sunxi-h3-h5.dtsi it compiles.\nFurthermore, I restested just now and confirm, it compiles fine.\n\nRegards","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"hYuU312o\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpTg91ylhz9sBW\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 17:37:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754997AbdIHHhL (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 8 Sep 2017 03:37:11 -0400","from mail-wr0-f195.google.com ([209.85.128.195]:34663 \"EHLO\n\tmail-wr0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754655AbdIHHhJ (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 8 Sep 2017 03:37:09 -0400","by mail-wr0-f195.google.com with SMTP id k20so852833wre.1;\n\tFri, 08 Sep 2017 00:37:08 -0700 (PDT)","from Red ([2a01:cb1d:16e:1300:2e56:dcff:fed2:c6d6])\n\tby smtp.googlemail.com with ESMTPSA id\n\tp187sm778939wme.19.2017.09.08.00.37.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 00:37:06 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=RC+KK2cVjz5li0vCbWA567zo24iK+o7JWb/m4pXCP1o=;\n\tb=hYuU312oHOQi3X2t+XipIcLin5e6+X7S3QxXsZcBQG1WAHeNgsaTXYt6TDD8OlAmVc\n\tsw7lFC/fFpE+QAb+lbmxnaKKtRnqY63gLyRdUBbu32fhYJSF+FfqtJ0uKFmakN9miXDj\n\tLOmCyOL/UWkxMS63tUPIfIt7JoLJNU+8hK5ki41GfRctGgqDRgZUT6+IEuqZMRW4Xsgw\n\t38V4ER9uA6UBBILspQ+xRo0WAmxQSh3aPlu3NsAwBaiB7PhxhS2mFX589dQYPwzbbgIg\n\t8x0Q8/53GXpliflE4kFMW0bcTQIL86oNBX7o29x5G8hjue5B5at6BoOj9qHL/Pm7E9/T\n\te3lQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=RC+KK2cVjz5li0vCbWA567zo24iK+o7JWb/m4pXCP1o=;\n\tb=Kr2R/lN7vNr8bV4hw0K/HEhF37raW2inzN1Szu9gfo1eF9XsxuGg6GpI5XKOeC8gKI\n\tA1V2w4JZ5GCSiz3lDiep/AogX52whUiAGz4LHTxYKXW6Emj/J7z2Edq1hfq/ln3w79Z/\n\twfCBHNeafjG8MFb85YKtGLTtU144AcmRfbbcmB/MDMAIflXJNAgdzvDa0Xoj8d5H60Rq\n\tc/arhqlCMHT9DkxNadG1wXSIkpHkZd3QcnllLU4cBCox8e0PH+Fu5nX3iK5SEn+X0JwN\n\txezqiPpksQTdoLIxTg3OFH1n06VCpsjjUzg4luj3nMkEDbS4modGP/4/Ao4n+AQS5CTY\n\t207Q==","X-Gm-Message-State":"AHPjjUguBMS8uBCBTKJoIKXbMG3nTWBVf5b4eLMJnAKFBkxalOFvnhVh\n\tiVdC+WIeO503iFo5","X-Google-Smtp-Source":"ADKCNb4BSK6VnfnP6iqng5iPgrklQ/f9L0fJYn+pDdsUhkk662S/uuxTGs0rmm5LL8Yvn/J3iAygHg==","X-Received":"by 10.223.175.230 with SMTP id y38mr1174260wrd.213.1504856227713;\n\tFri, 08 Sep 2017 00:37:07 -0700 (PDT)","Date":"Fri, 8 Sep 2017 09:36:57 +0200","From":"Corentin Labbe <clabbe.montjoie@gmail.com>","To":"Maxime Ripard <maxime.ripard@free-electrons.com>","Cc":"robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,\n\tlinux@armlinux.org.uk, catalin.marinas@arm.com,\n\twill.deacon@arm.com, peppe.cavallaro@st.com,\n\talexandre.torgue@st.com, andrew@lunn.ch, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes","Message-ID":"<20170908073657.GA29999@Red>","References":"<20170908071156.5115-1-clabbe.montjoie@gmail.com>\n\t<20170908071156.5115-2-clabbe.montjoie@gmail.com>\n\t<20170908071954.j2bhtw4wqa27fald@flea.lan>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170908071954.j2bhtw4wqa27fald@flea.lan>","User-Agent":"Mutt/1.7.2 (2016-11-26)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765133,"web_url":"http://patchwork.ozlabs.org/comment/1765133/","msgid":"<CAGb2v64K3XTLJwZwYmq3r64=3_bHHGTeGyC0gfoJfL5+Ty53ag@mail.gmail.com>","list_archive_url":null,"date":"2017-09-08T07:39:04","subject":"Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes","submitter":{"id":47154,"url":"http://patchwork.ozlabs.org/api/people/47154/","name":"Chen-Yu Tsai","email":"wens@csie.org"},"content":"On Fri, Sep 8, 2017 at 3:36 PM, Corentin Labbe\n<clabbe.montjoie@gmail.com> wrote:\n> On Fri, Sep 08, 2017 at 09:19:54AM +0200, Maxime Ripard wrote:\n>> On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote:\n>> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n>> > index 1c2387bd5df6..968908761194 100644\n>> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n>> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n>> > @@ -50,6 +50,7 @@\n>> >     compatible = \"friendlyarm,nanopi-neo2\", \"allwinner,sun50i-h5\";\n>> >\n>> >     aliases {\n>> > +           ethernet0 = &emac;\n>> >             serial0 = &uart0;\n>> >     };\n>> >\n>> > @@ -108,6 +109,22 @@\n>> >     status = \"okay\";\n>> >  };\n>> >\n>> > +&emac {\n>> > +   pinctrl-names = \"default\";\n>> > +   pinctrl-0 = <&emac_rgmii_pins>;\n>> > +   phy-supply = <&reg_gmac_3v3>;\n>> > +   phy-handle = <&ext_rgmii_phy>;\n>> > +   phy-mode = \"rgmii\";\n>> > +   status = \"okay\";\n>> > +};\n>> > +\n>> > +&mdio {\n>> > +   ext_rgmii_phy: ethernet-phy@7 {\n>> > +           compatible = \"ethernet-phy-ieee802.3-c22\";\n>> > +           reg = <7>;\n>> > +   };\n>> > +};\n>> > +\n>>\n>> This won't compile, you don't have that node in the H5 DTSI.\n>>\n>\n> Since H5 DTSI include arm/sunxi-h3-h5.dtsi it compiles.\n> Furthermore, I restested just now and confirm, it compiles fine.\n\nThe order of your patches are wrong. No individual patch should\nintroduce build failures, not just the whole patch series.\n\nChenYu","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpTjt4bF2z9sBd\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 17:39:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755058AbdIHHjf (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 8 Sep 2017 03:39:35 -0400","from smtp.csie.ntu.edu.tw ([140.112.30.61]:57778 \"EHLO\n\tsmtp.csie.ntu.edu.tw\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754180AbdIHHjd (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 8 Sep 2017 03:39:33 -0400","from mail-wr0-f172.google.com (mail-wr0-f172.google.com\n\t[209.85.128.172])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\t(Authenticated sender: b93043)\n\tby smtp.csie.ntu.edu.tw (Postfix) with ESMTPSA id 3E26820401;\n\tFri,  8 Sep 2017 15:39:28 +0800 (CST)","by mail-wr0-f172.google.com with SMTP id v109so3037790wrc.1;\n\tFri, 08 Sep 2017 00:39:28 -0700 (PDT)","by 10.223.133.253 with HTTP; Fri, 8 Sep 2017 00:39:04 -0700 (PDT)"],"X-Gm-Message-State":"AHPjjUjik8e+V/WpBF2ei9mHsrnFd5aKcGNzpoAaPoMzMixk1xU41lSe\n\t6mpcK7I3oPt6dXCDEdsrhFz/cLLDMg==","X-Google-Smtp-Source":"ADKCNb4zjrLD08tsFqh+johe+JZgliPIz2T6mGCQ2+VKOWqiFaJF0PAfzFPiXcuR1WDMtTnUOOGf/s8zJSo8a4Af/gc=","X-Received":"by 10.223.132.163 with SMTP id 32mr1180729wrg.267.1504856364815; \n\tFri, 08 Sep 2017 00:39:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170908073657.GA29999@Red>","References":"<20170908071156.5115-1-clabbe.montjoie@gmail.com>\n\t<20170908071156.5115-2-clabbe.montjoie@gmail.com>\n\t<20170908071954.j2bhtw4wqa27fald@flea.lan>\n\t<20170908073657.GA29999@Red>","From":"Chen-Yu Tsai <wens@csie.org>","Date":"Fri, 8 Sep 2017 15:39:04 +0800","X-Gmail-Original-Message-ID":"<CAGb2v64K3XTLJwZwYmq3r64=3_bHHGTeGyC0gfoJfL5+Ty53ag@mail.gmail.com>","Message-ID":"<CAGb2v64K3XTLJwZwYmq3r64=3_bHHGTeGyC0gfoJfL5+Ty53ag@mail.gmail.com>","Subject":"Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes","To":"Corentin Labbe <clabbe.montjoie@gmail.com>","Cc":"Maxime Ripard <maxime.ripard@free-electrons.com>,\n\tRob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,\n\tChen-Yu Tsai <wens@csie.org>, Russell King <linux@armlinux.org.uk>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tWill Deacon <will.deacon@arm.com>,\n\tGiuseppe Cavallaro <peppe.cavallaro@st.com>,\n\tAlexandre Torgue <alexandre.torgue@st.com>, Andrew Lunn <andrew@lunn.ch>,\n\tFlorian Fainelli <f.fainelli@gmail.com>, netdev <netdev@vger.kernel.org>,\n\tdevicetree <devicetree@vger.kernel.org>,\n\tlinux-arm-kernel <linux-arm-kernel@lists.infradead.org>,\n\tlinux-kernel <linux-kernel@vger.kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765992,"web_url":"http://patchwork.ozlabs.org/comment/1765992/","msgid":"<20170910185640.GA17417@Red>","list_archive_url":null,"date":"2017-09-10T18:56:40","subject":"Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes","submitter":{"id":64152,"url":"http://patchwork.ozlabs.org/api/people/64152/","name":"Corentin Labbe","email":"clabbe.montjoie@gmail.com"},"content":"On Fri, Sep 08, 2017 at 03:39:04PM +0800, Chen-Yu Tsai wrote:\n> On Fri, Sep 8, 2017 at 3:36 PM, Corentin Labbe\n> <clabbe.montjoie@gmail.com> wrote:\n> > On Fri, Sep 08, 2017 at 09:19:54AM +0200, Maxime Ripard wrote:\n> >> On Fri, Sep 08, 2017 at 09:11:47AM +0200, Corentin Labbe wrote:\n> >> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n> >> > index 1c2387bd5df6..968908761194 100644\n> >> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n> >> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo2.dts\n> >> > @@ -50,6 +50,7 @@\n> >> >     compatible = \"friendlyarm,nanopi-neo2\", \"allwinner,sun50i-h5\";\n> >> >\n> >> >     aliases {\n> >> > +           ethernet0 = &emac;\n> >> >             serial0 = &uart0;\n> >> >     };\n> >> >\n> >> > @@ -108,6 +109,22 @@\n> >> >     status = \"okay\";\n> >> >  };\n> >> >\n> >> > +&emac {\n> >> > +   pinctrl-names = \"default\";\n> >> > +   pinctrl-0 = <&emac_rgmii_pins>;\n> >> > +   phy-supply = <&reg_gmac_3v3>;\n> >> > +   phy-handle = <&ext_rgmii_phy>;\n> >> > +   phy-mode = \"rgmii\";\n> >> > +   status = \"okay\";\n> >> > +};\n> >> > +\n> >> > +&mdio {\n> >> > +   ext_rgmii_phy: ethernet-phy@7 {\n> >> > +           compatible = \"ethernet-phy-ieee802.3-c22\";\n> >> > +           reg = <7>;\n> >> > +   };\n> >> > +};\n> >> > +\n> >>\n> >> This won't compile, you don't have that node in the H5 DTSI.\n> >>\n> >\n> > Since H5 DTSI include arm/sunxi-h3-h5.dtsi it compiles.\n> > Furthermore, I restested just now and confirm, it compiles fine.\n> \n> The order of your patches are wrong. No individual patch should\n> introduce build failures, not just the whole patch series.\n> \n\nYes, I just miss-understood the reason of build failure.\nI will fix the order in the next serie.\n\nThanks\nCorentin Labbe","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"fgohQPO8\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xr0fV543Wz9t2l\n\tfor <patchwork-incoming@ozlabs.org>;\n\tMon, 11 Sep 2017 04:57:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751176AbdIJS4v (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tSun, 10 Sep 2017 14:56:51 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:37722 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750890AbdIJS4t (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Sun, 10 Sep 2017 14:56:49 -0400","by mail-wm0-f65.google.com with SMTP id f4so5268191wmh.4;\n\tSun, 10 Sep 2017 11:56:48 -0700 (PDT)","from Red ([2a01:cb1d:16e:1300:2e56:dcff:fed2:c6d6])\n\tby smtp.googlemail.com with ESMTPSA id\n\t195sm9488221wmj.18.2017.09.10.11.56.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 10 Sep 2017 11:56:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=Tn6Y/gibIeDUWLP6XepEwYMn5CfUT9795D+zkPVsOgM=;\n\tb=fgohQPO8skXp50agxAHfS5PAImtJQlZgdh7h2jz14elaEt7AFcUHJfUBUYyRh0AA0X\n\t5R/fb8vhf946elQINWGOvX4kzyufjM6qJL3KDSm9I82jstau7cWnGfIMAAj1WhIHrdvp\n\t+op+RY/UQfR6QbowlEFcRf5mDdFrJIg7iaNHiWET9hvvqgVjYCswRTQAzzzOk2yV1yNu\n\tnEfNTbX4+zKjVjISrjCN6B7Jqfj0aLWZFnYl/fNdfKV2uP223DAEB1vw9Yn3xIUP6vtT\n\tPZaEKpEmpILCyrcVKDNBHuRu/O8g7ZDJjt3pdJvtZsYVUi2+sAtDSift7Fp/6pMZ8l8L\n\tSW9w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Tn6Y/gibIeDUWLP6XepEwYMn5CfUT9795D+zkPVsOgM=;\n\tb=tyGK31CWfFgq1LxtAHAqQrptyEg3A3ckL2dt35BDj+7L9LXdNJTmMw7O6J/c7MOnC6\n\tItmi1b6A5X5SanmbeiDDnTUa1jiG7M115CUvEbRnGE7AbHdMYjcg/uNhpPvDzG6yxjBk\n\txQh1jgGjb3dqHVP/onRza4L9EznLVZHk56c+j4draWwd2fNehxmeCWrgnn1AyILcyNZk\n\tN+qFqj7FwFddo6b6jmqoSWEayh2jI9SfsauzVAYMFHQ6c/lSs0x9Hu0UZdaC8+2X/K8f\n\tdBViWOeTMVW5osNZJIC2/NwStFkjbr9sr8aFm4y/iSbZBMTQ8Fd4Yot0FRCbbhEf4wWF\n\tq4DA==","X-Gm-Message-State":"AHPjjUjl5foXZWp3DfI/KBHwYQmUHK+mKnmwP4Y/kwbq7CBcHRqaB00n\n\t88+t2q5fiUWrc5A2wFPpJWk=","X-Google-Smtp-Source":"AOwi7QA8PXLzSp5fSp77OyMS7oBZA3DEOWLyHmxvEjp6tuC1OdEUQzwMQ5seKD4u/P1Jl6M4zI3tiw==","X-Received":"by 10.28.208.72 with SMTP id h69mr391597wmg.134.1505069808293;\n\tSun, 10 Sep 2017 11:56:48 -0700 (PDT)","Date":"Sun, 10 Sep 2017 20:56:40 +0200","From":"Corentin Labbe <clabbe.montjoie@gmail.com>","To":"Chen-Yu Tsai <wens@csie.org>","Cc":"Maxime Ripard <maxime.ripard@free-electrons.com>,\n\tRob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,\n\tRussell King <linux@armlinux.org.uk>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tWill Deacon <will.deacon@arm.com>,\n\tGiuseppe Cavallaro <peppe.cavallaro@st.com>,\n\tAlexandre Torgue <alexandre.torgue@st.com>, Andrew Lunn <andrew@lunn.ch>,\n\tFlorian Fainelli <f.fainelli@gmail.com>, netdev <netdev@vger.kernel.org>,\n\tdevicetree <devicetree@vger.kernel.org>,\n\tlinux-arm-kernel <linux-arm-kernel@lists.infradead.org>,\n\tlinux-kernel <linux-kernel@vger.kernel.org>","Subject":"Re: [PATCH v5 01/10] arm64: dts: allwinner: Restore EMAC changes","Message-ID":"<20170910185640.GA17417@Red>","References":"<20170908071156.5115-1-clabbe.montjoie@gmail.com>\n\t<20170908071156.5115-2-clabbe.montjoie@gmail.com>\n\t<20170908071954.j2bhtw4wqa27fald@flea.lan>\n\t<20170908073657.GA29999@Red>\n\t<CAGb2v64K3XTLJwZwYmq3r64=3_bHHGTeGyC0gfoJfL5+Ty53ag@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<CAGb2v64K3XTLJwZwYmq3r64=3_bHHGTeGyC0gfoJfL5+Ty53ag@mail.gmail.com>","User-Agent":"Mutt/1.7.2 (2016-11-26)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]