[{"id":1765258,"web_url":"http://patchwork.ozlabs.org/comment/1765258/","msgid":"","list_archive_url":null,"date":"2017-09-08T11:24:05","subject":"Re: [PATCH v3 5/6] [media] exynos-gsc: Remove unnecessary compatible","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Fri, Sep 8, 2017 at 8:02 AM, Hoegeun Kwon wrote:\n> Currently, the compatible('samsung,exynos5-gsc') is not used.\n> Remove unnecessary compatible.\n>\n> Signed-off-by: Hoegeun Kwon \n> ---\n> Documentation/devicetree/bindings/media/exynos5-gsc.txt | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/Documentation/devicetree/bindings/media/exynos5-gsc.txt b/Documentation/devicetree/bindings/media/exynos5-gsc.txt\n> index daa56d5..1ea05f1 100644\n> --- a/Documentation/devicetree/bindings/media/exynos5-gsc.txt\n> +++ b/Documentation/devicetree/bindings/media/exynos5-gsc.txt\n> @@ -3,9 +3,9 @@\n> G-Scaler is used for scaling and color space conversion on EXYNOS5 SoCs.\n>\n> Required properties:\n> -- compatible: should be \"samsung,exynos5-gsc\" (for Exynos 5250, 5420 and\n> - 5422 SoCs) or \"samsung,exynos5433-gsc\" (Exynos 5433)\n> - or \"samsung,exynos5250-gsc\" or \"samsung,exynos5420-gsc\"\n> +- compatible: should be \"samsung,exynos5250-gsc\", \"samsung,exynos5420-gsc\"\n> + or \"samsung,exynos5433-gsc\" (for Exynos 5250, 5420, 5422,\n> + and 5433 SoCs)\n\nYou should not remove the compatible (neither here nor in the driver)\nbut mark it as deprecated. Removal should happen slightly later.\n\nBest regards,\nKrzysztof\n\n> - reg: should contain G-Scaler physical address location and length.\n> - interrupts: should contain G-Scaler interrupt number\n>\n> @@ -16,7 +16,7 @@ Optional properties:\n> Example:\n>\n> gsc_0: gsc@0x13e00000 {\n> - compatible = \"samsung,exynos5-gsc\";\n> + compatible = \"samsung,exynos5250-gsc;\n> reg = <0x13e00000 0x1000>;\n> interrupts = <0 85 0>;\n> };\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=krzk@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpZhp3B88z9sBW\n\tfor ;\n\tFri, 8 Sep 2017 21:24:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751907AbdIHLYI (ORCPT\n\t);\n\tFri, 8 Sep 2017 07:24:08 -0400","from mail.kernel.org ([198.145.29.99]:46396 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751577AbdIHLYH (ORCPT );\n\tFri, 8 Sep 2017 07:24:07 -0400","from mail-io0-f172.google.com (mail-io0-f172.google.com\n\t[209.85.223.172])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 6A75E22A74;\n\tFri, 8 Sep 2017 11:24:06 +0000 (UTC)","by mail-io0-f172.google.com with SMTP id n69so3914884ioi.5;\n\tFri, 08 Sep 2017 04:24:06 -0700 (PDT)","by 10.107.40.2 with HTTP; Fri, 8 Sep 2017 04:24:05 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 6A75E22A74","X-Gm-Message-State":"AHPjjUiMghTPbdlgA6MytvRv/04AEIU/UUlPuX8EgsmSobs2x8UqKJmg\n\tGoJLXuyNT6Dl/nwgafTZnpXhN++x7Q==","X-Google-Smtp-Source":"AOwi7QBJ2rZeUb+k5ld1rCF5KLwIjAJq2fdGK3CCqNqV5Fc5UZNmK0GVnaF38NwNXmkbEUYxvD5xwAwcf5UeduvKMeY=","X-Received":"by 10.107.68.8 with SMTP id r8mr2982569ioa.116.1504869845777;\n\tFri, 08 Sep 2017 04:24:05 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504850560-27950-6-git-send-email-hoegeun.kwon@samsung.com>","References":"\n\t<1504850560-27950-1-git-send-email-hoegeun.kwon@samsung.com>\n\t<1504850560-27950-6-git-send-email-hoegeun.kwon@samsung.com>","From":"Krzysztof Kozlowski ","Date":"Fri, 8 Sep 2017 13:24:05 +0200","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v3 5/6] [media] exynos-gsc: Remove unnecessary compatible","To":"Hoegeun Kwon ","Cc":"Inki Dae , airlied@linux.ie,\n\tkgene@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,\n\tcatalin.marinas@arm.com, will.deacon@arm.com, mchehab@kernel.org,\n\tSylwester Nawrocki ,\n\tMarek Szyprowski ,\n\tdri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tdevicetree@vger.kernel.org, a.hajda@samsung.com","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]