[{"id":1767358,"web_url":"http://patchwork.ozlabs.org/comment/1767358/","msgid":"","list_archive_url":null,"date":"2017-09-12T21:31:07","subject":"Re: [ovs-dev] [PATCH] put bundle_lookup ahead to simplify the code","submitter":{"id":69140,"url":"http://patchwork.ozlabs.org/api/people/69140/","name":"Gregory Rose","email":"gvrose8192@gmail.com"},"content":"On 09/07/2017 06:51 PM, Duan Jiong wrote:\n> From ba48275f8bb30ed2888c16426726ee9cb3407cd1 Mon Sep 17 00:00:00 2001\n> From: Duan Jiong \n> Date: Fri, 8 Sep 2017 09:48:59 +0800\n> Subject: [PATCH] put bundle_lookup ahead to simplify the code\n> \n> Signed-off-by: Duan Jiong \n> ---\n> ofproto/ofproto-dpif.c | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c\n> index 1a8e829..293780f 100644\n> --- a/ofproto/ofproto-dpif.c\n> +++ b/ofproto/ofproto-dpif.c\n> @@ -3011,15 +3011,16 @@ bundle_set(struct ofproto *ofproto_, void *aux,\n> size_t i;\n> bool ok;\n> \n> + bundle = bundle_lookup(ofproto, aux);\n> +\n> if (!s) {\n> - bundle_destroy(bundle_lookup(ofproto, aux));\n> + bundle_destroy(bundle);\n> return 0;\n> }\n> \n> ovs_assert(s->n_slaves == 1 || s->bond != NULL);\n> ovs_assert((s->lacp != NULL) == (s->lacp_slaves != NULL));\n> \n> - bundle = bundle_lookup(ofproto, aux);\n> if (!bundle) {\n> bundle = xmalloc(sizeof *bundle);\n> \n\nMakes sense...\n\nReviewed-by: Greg Rose ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"dqA7SQ8W\"; dkim-atps=neutral"],"Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsHzQ65wyz9t2W\n\tfor ;\n\tWed, 13 Sep 2017 07:31:14 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id A0FF8B1D;\n\tTue, 12 Sep 2017 21:31:12 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 6701AA64\n\tfor ; Tue, 12 Sep 2017 21:31:11 +0000 (UTC)","from mail-pf0-f196.google.com (mail-pf0-f196.google.com\n\t[209.85.192.196])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id A747D433\n\tfor ; Tue, 12 Sep 2017 21:31:10 +0000 (UTC)","by mail-pf0-f196.google.com with SMTP id i23so1902768pfi.2\n\tfor ; Tue, 12 Sep 2017 14:31:10 -0700 (PDT)","from gizo.bigblue.kilchis.com (67-5-132-83.ptld.qwest.net.\n\t[67.5.132.83]) by smtp.gmail.com with ESMTPSA id\n\t125sm19882351pff.5.2017.09.12.14.31.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Sep 2017 14:31:08 -0700 (PDT)"],"X-Greylist":"whitelisted by SQLgrey-1.7.6","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=HCFeM9hzPxzOLTfeDiyJHhn8XdQ5EASs8t2ab38Zjac=;\n\tb=dqA7SQ8WsdHQs3NVzjhd1P8afbRLi+AyVxg9ZZw6tX/bBAWr5Xw/0NVxBw5piPl9tl\n\tI0GbI5TdgLE9N+zieVoimYxUso4n/Ajy+2HRE4sZu5AJp28Y6aahQ5tKVSyAkMmFBPPN\n\t9IPn/IQe1XHrTmsI5Br+N/aAY1jvelvZ50IseYroPpYI0q1vGSYEZBUYismF1tacD27I\n\tD0DVSRLFdH4/9K6pxAk8tWwG/fiWjFOiaErn94qzYm6nS1WaaVj8FLQ1GeQEU6PoG4CD\n\tY8XG5BWSCV4B85fltPQoLq3P3OZKxTABt2RjVxlcvvuMrPn44rNQNa4ruRFihwRbVgZq\n\tdmiw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=HCFeM9hzPxzOLTfeDiyJHhn8XdQ5EASs8t2ab38Zjac=;\n\tb=uY9MPJ5CMyGNyR8UkdQTWn0fKt4lVGfJGdQ9W1lbM8qyMesx6kFI/MwXXH0CvPMpCH\n\tJYgFnpiwXkI2LlttzK58TUEFY5Sl/camqUaoMeTcDbGz3OwOhFsFFqxH9+yTsbTV1dTZ\n\tcgjr8gIECu0fNINP8kqRtZsClCTvAwRwdBXm00ccPkcDQrB4T2+dXBZQGvwTl5gldbB9\n\tKJtK8/cv58RquXRuajhd1lxcKsaf45rkS77SvEKBTQokceS9RjhGF1TVLZkv6EApXAsF\n\t7+RrBe650Ad/DbJ/nGc/bxEOr9uQpABqLYJSUVlJFLZuCbQDrPMXhGyUq1RMIRP1OcRy\n\t5LQQ==","X-Gm-Message-State":"AHPjjUhE5Bz9Prn5b33r5sheVfEhdqNmhbenj3yTmdgXbHrP13+0Qyn6\n\t/5y8zZzZUia7xrckXqk=","X-Google-Smtp-Source":"AOwi7QDDqU6C9PucLmEjZawtYxZtqhzQQ8o1n8n8zzwQeu5phaVzYVWM9/h/vycoyxOeooPtbXO3KA==","X-Received":"by 10.99.171.9 with SMTP id p9mr3670876pgf.30.1505251869605;\n\tTue, 12 Sep 2017 14:31:09 -0700 (PDT)","To":"Duan Jiong , dev@openvswitch.org","References":"","From":"Greg Rose ","Message-ID":"","Date":"Tue, 12 Sep 2017 14:31:07 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.1.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","X-Spam-Status":"No, score=0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, \n\tRCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Subject":"Re: [ovs-dev] [PATCH] put bundle_lookup ahead to simplify the code","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}},{"id":1798853,"web_url":"http://patchwork.ozlabs.org/comment/1798853/","msgid":"<20171103192830.GX27530@ovn.org>","list_archive_url":null,"date":"2017-11-03T19:28:30","subject":"Re: [ovs-dev] [PATCH] put bundle_lookup ahead to simplify the code","submitter":{"id":67603,"url":"http://patchwork.ozlabs.org/api/people/67603/","name":"Ben Pfaff","email":"blp@ovn.org"},"content":"On Tue, Sep 12, 2017 at 02:31:07PM -0700, Greg Rose wrote:\n> On 09/07/2017 06:51 PM, Duan Jiong wrote:\n> > From ba48275f8bb30ed2888c16426726ee9cb3407cd1 Mon Sep 17 00:00:00 2001\n> >From: Duan Jiong \n> >Date: Fri, 8 Sep 2017 09:48:59 +0800\n> >Subject: [PATCH] put bundle_lookup ahead to simplify the code\n> >\n> >Signed-off-by: Duan Jiong \n> >---\n> > ofproto/ofproto-dpif.c | 5 +++--\n> > 1 file changed, 3 insertions(+), 2 deletions(-)\n> >\n> >diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c\n> >index 1a8e829..293780f 100644\n> >--- a/ofproto/ofproto-dpif.c\n> >+++ b/ofproto/ofproto-dpif.c\n> >@@ -3011,15 +3011,16 @@ bundle_set(struct ofproto *ofproto_, void *aux,\n> > size_t i;\n> > bool ok;\n> >\n> >+ bundle = bundle_lookup(ofproto, aux);\n> >+\n> > if (!s) {\n> >- bundle_destroy(bundle_lookup(ofproto, aux));\n> >+ bundle_destroy(bundle);\n> > return 0;\n> > }\n> >\n> > ovs_assert(s->n_slaves == 1 || s->bond != NULL);\n> > ovs_assert((s->lacp != NULL) == (s->lacp_slaves != NULL));\n> >\n> >- bundle = bundle_lookup(ofproto, aux);\n> > if (!bundle) {\n> > bundle = xmalloc(sizeof *bundle);\n> >\n> \n> Makes sense...\n> \n> Reviewed-by: Greg Rose \n\nI applied this to master. Thanks, Duan and Greg.\n\n(Again, I apologize for the delay.)","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yTBnz2rTwz9s7F\n\tfor ;\n\tSat, 4 Nov 2017 06:28:39 +1100 (AEDT)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 9B3C1D33;\n\tFri, 3 Nov 2017 19:28:37 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 95E9CD2D\n\tfor ; Fri, 3 Nov 2017 19:28:36 +0000 (UTC)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 2B505488\n\tfor ; Fri, 3 Nov 2017 19:28:36 +0000 (UTC)","from ovn.org (unknown [208.91.3.26])\n\t(Authenticated sender: blp@ovn.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id A9B26FB883;\n\tFri, 3 Nov 2017 20:28:33 +0100 (CET)"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-Originating-IP":"208.91.3.26","Date":"Fri, 3 Nov 2017 12:28:30 -0700","From":"Ben Pfaff ","To":"Greg Rose ","Message-ID":"<20171103192830.GX27530@ovn.org>","References":"\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"dev@openvswitch.org","Subject":"Re: [ovs-dev] [PATCH] put bundle_lookup ahead to simplify the code","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"}}]