[{"id":1766567,"web_url":"http://patchwork.ozlabs.org/comment/1766567/","msgid":"<20170911.142857.1205848546110018404.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-11T21:28:57","subject":"Re: [PATCH net] perf/bpf: fix a clang compilation issue","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Yonghong Song \nDate: Thu, 7 Sep 2017 18:36:15 -0700\n\n> clang does not support variable length array for structure member.\n> It has the following error during compilation:\n> \n> kernel/trace/trace_syscalls.c:568:17: error: fields must have a constant size:\n> 'variable length array in structure' extension will never be supported\n> unsigned long args[sys_data->nb_args];\n> ^\n> \n> The fix is to use a fixed array length instead.\n> \n> Reported-by: Nick Desaulniers \n> Signed-off-by: Yonghong Song \n\nApplied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrgzL4Jf8z9s7M\n\tfor ;\n\tTue, 12 Sep 2017 07:29:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751020AbdIKV3A (ORCPT );\n\tMon, 11 Sep 2017 17:29:00 -0400","from shards.monkeyblade.net ([184.105.139.130]:56246 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750877AbdIKV27 (ORCPT\n\t); Mon, 11 Sep 2017 17:28:59 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 9002F101F97D6;\n\tMon, 11 Sep 2017 14:28:58 -0700 (PDT)"],"Date":"Mon, 11 Sep 2017 14:28:57 -0700 (PDT)","Message-Id":"<20170911.142857.1205848546110018404.davem@davemloft.net>","To":"yhs@fb.com","Cc":"peterz@infradead.org, rostedt@goodmis.org, ast@fb.com,\n\tdaniel@iogearbox.net, ndesaulniers@google.com,\n\tnetdev@vger.kernel.org, kernel-team@fb.com","Subject":"Re: [PATCH net] perf/bpf: fix a clang compilation issue","From":"David Miller ","In-Reply-To":"<20170908013615.973478-1-yhs@fb.com>","References":"<20170908013615.973478-1-yhs@fb.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 11 Sep 2017 14:28:58 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1768051,"web_url":"http://patchwork.ozlabs.org/comment/1768051/","msgid":"","list_archive_url":null,"date":"2017-09-13T17:26:48","subject":"Re: [PATCH net] perf/bpf: fix a clang compilation issue","submitter":{"id":72080,"url":"http://patchwork.ozlabs.org/api/people/72080/","name":"Nick Desaulniers","email":"ndesaulniers@google.com"},"content":"great, thanks!\n\nOn Mon, Sep 11, 2017 at 2:28 PM, David Miller wrote:\n> From: Yonghong Song \n> Date: Thu, 7 Sep 2017 18:36:15 -0700\n>\n>> clang does not support variable length array for structure member.\n>> It has the following error during compilation:\n>>\n>> kernel/trace/trace_syscalls.c:568:17: error: fields must have a constant size:\n>> 'variable length array in structure' extension will never be supported\n>> unsigned long args[sys_data->nb_args];\n>> ^\n>>\n>> The fix is to use a fixed array length instead.\n>>\n>> Reported-by: Nick Desaulniers \n>> Signed-off-by: Yonghong Song \n>\n> Applied.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"YM8I754p\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xspW248j7z9ryT\n\tfor ;\n\tThu, 14 Sep 2017 03:26:54 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751645AbdIMR0x (ORCPT );\n\tWed, 13 Sep 2017 13:26:53 -0400","from mail-wm0-f48.google.com ([74.125.82.48]:45631 \"EHLO\n\tmail-wm0-f48.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751279AbdIMR0v (ORCPT\n\t); Wed, 13 Sep 2017 13:26:51 -0400","by mail-wm0-f48.google.com with SMTP id g206so12374195wme.0\n\tfor ; Wed, 13 Sep 2017 10:26:50 -0700 (PDT)","by 10.223.135.18 with HTTP; Wed, 13 Sep 2017 10:26:48 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=google.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=mSPZJCWlt8WXEX3kVjTVQh7x2ppCDY5fB9P/IJCJ/mQ=;\n\tb=YM8I754pbJLH/cabf1Cjiy2Hw7CM19xKqE6nDBS5yv66Yd3Bs/A4R9TO/dmIwozyV4\n\tZi90ivWK/IgQcw1OYWPlDPCNheQym/umCrBnVkrqSOWID3XIMjSvN9rgQ6crm8qAru97\n\tUdUY0aZF+D0Jv6rkPv482b6j/sQ3rZw6kCCvIc8WTmg7vS6YD6V2eZgBD98mIzsCMQyK\n\tNHmG5K1zlHDUxHfMoM2UvHii6GESC/RUM7a9MAvcj7vidDO4p0qix0Av6q5KyAiLkuvX\n\tz6wnvFyzPcuB+hjECdSn0J4Im6+Q02qzW2eDtqCchtnGXpzzu0GgoyY2ggK3jsj34+N6\n\tcfMw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=mSPZJCWlt8WXEX3kVjTVQh7x2ppCDY5fB9P/IJCJ/mQ=;\n\tb=lkSdemt+BB6mDNQiyjz40rJu0czxFJvmbB5kiJclE3ep5mvrDtT1oZmAw1fZ1eSDbl\n\teFdMPBUGb+JriJrYdGFkT+KGpeUaug5fZ65Pa6bPEjrMZEwB9J6n/OEq3DLBWZlef21g\n\tCF7cibqSTwaL0kY0ZwrJGO5ceiRyPaJqrN0QSn3cd2LZ/TqIuYi0QgA0WmmnckCNMfhb\n\tBnMgApyU3RwbHKbv3dM6CCP5xuJ6U4o0ibjTJF1kyQOhuPaW5p22/HiCvL0MOutGEwtu\n\tJS/uCowj+S6jqSYFJxI+NHdlU0GAqgR4Jt8bXx83D3bsJvjY9mJWvn+yAmFrgp83Iunc\n\txqyg==","X-Gm-Message-State":"AHPjjUh7cJO9KRdujF4dg6AZ9YPDEpAFRyOvTxTkBRqImnDcNIb3Ioz4\n\tfrn9dKtQHymPAe1/funtLUELPNhS+sMZObjqjTeuBA==","X-Google-Smtp-Source":"AOwi7QCcGZGhOjYK+lTEY/Q2IiZsUantqBjtRq0r23oaNYj0k85rmupvN/mCo4wgckp50fAl8EV5Z9pIz5kpvlLFdfw=","X-Received":"by 10.28.132.141 with SMTP id g135mr3053176wmd.37.1505323609748; \n\tWed, 13 Sep 2017 10:26:49 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170911.142857.1205848546110018404.davem@davemloft.net>","References":"<20170908013615.973478-1-yhs@fb.com>\n\t<20170911.142857.1205848546110018404.davem@davemloft.net>","From":"Nick Desaulniers ","Date":"Wed, 13 Sep 2017 10:26:48 -0700","Message-ID":"","Subject":"Re: [PATCH net] perf/bpf: fix a clang compilation issue","To":"David Miller ","Cc":"yhs@fb.com, peterz@infradead.org, rostedt@goodmis.org, ast@fb.com,\n\tdaniel@iogearbox.net, netdev@vger.kernel.org, kernel-team@fb.com","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]