[{"id":1765190,"web_url":"http://patchwork.ozlabs.org/comment/1765190/","msgid":"","list_archive_url":null,"date":"2017-09-08T09:28:51","subject":"Re: [Skiboot] [PATCH] hdata: Fix /vpd dtc warnings","submitter":{"id":69578,"url":"http://patchwork.ozlabs.org/api/people/69578/","name":"ppaidipe","email":"ppaidipe@linux.vnet.ibm.com"},"content":"On 2017-09-08 06:16, Oliver O'Halloran wrote:\n> When dealing with HDAT generated device-trees dtc will complain loudly\n> about the missing reg, #size-cells and #address-cells properties of the\n> nodes in the /vpd hierarchy. This patch fixes these so we get a bit \n> more\n> signal and less noise from the dtc warnings.\n> \n> Signed-off-by: Oliver O'Halloran \n> ---\n\nHi Oliver\nLooks like this patch partly fixes this issue\nhttps://github.com/open-power/boston-openpower/issues/379 .\nCan you please have a look into it, Can you fix the remaining\ndtc warnings(under ibm,opal and imc nodes) as well if it easy to fix.\n\nThanks\nPridhiviraj\n\n\n> hdata/spira.c | 3 +++\n> hdata/vpd.c | 8 ++++++++\n> 2 files changed, 11 insertions(+)\n> \n> diff --git a/hdata/spira.c b/hdata/spira.c\n> index 95e1a016642e..291365e82c81 100644\n> --- a/hdata/spira.c\n> +++ b/hdata/spira.c\n> @@ -1181,7 +1181,10 @@ static void dt_init_vpd_node(void)\n> \n> \tdt_vpd = dt_new(dt_root, \"vpd\");\n> \tassert(dt_vpd);\n> +\n> \tdt_add_property_string(dt_vpd, \"compatible\", \"ibm,opal-v3-vpd\");\n> +\tdt_add_property_cells(dt_vpd, \"#address-cells\", 1);\n> +\tdt_add_property_cells(dt_vpd, \"#size-cells\", 0);\n> }\n> \n> static void hostservices_parse(void)\n> diff --git a/hdata/vpd.c b/hdata/vpd.c\n> index d7d57cdad67c..9f3fe010c3e8 100644\n> --- a/hdata/vpd.c\n> +++ b/hdata/vpd.c\n> @@ -405,6 +405,14 @@ static struct dt_node *dt_create_vpd_node(struct\n> dt_node *parent,\n> \t\treturn NULL;\n> \t}\n> \n> +\t/*\n> +\t * no one is sure what this is or what it means, we're adding it here\n> +\t * to stop dtc from complaining about it.\n> +\t */\n> +\tdt_add_property_cells(node, \"reg\", addr);\n> +\tdt_add_property_cells(node, \"#address-cells\", 1);\n> +\tdt_add_property_cells(node, \"#size-cells\", 0);\n> +\n> \t/* Add location code */\n> \tslca_vpd_add_loc_code(node, be16_to_cpu(entry->my_index));\n> \t/* Add FRU label */","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpX4w5zTGz9rxm\n\tfor ;\n\tFri, 8 Sep 2017 19:26:24 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xpX4w51ddzDrc4\n\tfor ;\n\tFri, 8 Sep 2017 19:26:24 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xpX4C28G3zDrnS\n\tfor ; Fri, 8 Sep 2017 19:25:46 +1000 (AEST)","from pps.filterd (m0098414.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv889O8Fc033961\n\tfor ; Fri, 8 Sep 2017 05:25:44 -0400","from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cukeg61qc-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 08 Sep 2017 05:25:44 -0400","from localhost\n\tby e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 8 Sep 2017 03:25:43 -0600","from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18)\n\tby e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 8 Sep 2017 03:25:40 -0600","from b03ledav003.gho.boulder.ibm.com\n\t(b03ledav003.gho.boulder.ibm.com [9.17.130.234])\n\tby b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v889Peum63308030; Fri, 8 Sep 2017 02:25:40 -0700","from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id F2FAB6A03D;\n\tFri, 8 Sep 2017 03:25:39 -0600 (MDT)","from ltc.linux.ibm.com (unknown [9.16.170.189])\n\tby b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP id CCFFE6A03B;\n\tFri, 8 Sep 2017 03:25:39 -0600 (MDT)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=ppaidipe@linux.vnet.ibm.com; receiver=)","MIME-Version":"1.0","Date":"Fri, 08 Sep 2017 14:58:51 +0530","From":"ppaidipe ","To":"\"Oliver O'Halloran\" ","In-Reply-To":"<20170908004605.5125-1-oohall@gmail.com>","References":"<20170908004605.5125-1-oohall@gmail.com>","X-Sender":"ppaidipe@linux.vnet.ibm.com","User-Agent":"Roundcube Webmail/1.0.1","X-TM-AS-GCONF":"00","x-cbid":"17090809-0020-0000-0000-00000CAE2B1C","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007688; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000227; SDB=6.00913966; UDB=6.00458769;\n\tIPR=6.00694224; \n\tBA=6.00005576; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017064;\n\tXFM=3.00000015; UTC=2017-09-08 09:25:42","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090809-0021-0000-0000-00005E0C9FD9","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-08_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709080144","Subject":"Re: [Skiboot] [PATCH] hdata: Fix /vpd dtc warnings","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"skiboot@lists.ozlabs.org, Skiboot\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]