[{"id":1764971,"web_url":"http://patchwork.ozlabs.org/comment/1764971/","msgid":"<20170907215551.GV11248@lunn.ch>","list_archive_url":null,"date":"2017-09-07T21:55:51","subject":"Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Sep 07, 2017 at 09:17:10PM +0000, Tristram.Ha@microchip.com wrote:\n> From: Tristram Ha \n> \n> Add KSZ8795 switch support with SPI access.\n> \n> Signed-off-by: Tristram Ha \n> ---\n> diff --git a/drivers/net/dsa/microchip/Makefile b/drivers/net/dsa/microchip/Makefile\n> index 0961c30..0d8ba48 100644\n> --- a/drivers/net/dsa/microchip/Makefile\n> +++ b/drivers/net/dsa/microchip/Makefile\n> @@ -1,2 +1,4 @@\n> obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz9477.o ksz_common.o\n> obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)\t+= ksz_spi.o\n> +obj-$(CONFIG_MICROCHIP_KSZ8795)\t += ksz8795.o ksz_common.o\n> +obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER)\t+= ksz8795_spi.o\n\nI've not tried it, but i think this breaks the build\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpDmh6YHvz9s4q\n\tfor ;\n\tFri, 8 Sep 2017 07:56:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756017AbdIGVzy (ORCPT );\n\tThu, 7 Sep 2017 17:55:54 -0400","from vps0.lunn.ch ([178.209.37.122]:60133 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752689AbdIGVzx (ORCPT );\n\tThu, 7 Sep 2017 17:55:53 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dq4m7-0007tg-Kr; Thu, 07 Sep 2017 23:55:51 +0200"],"Date":"Thu, 7 Sep 2017 23:55:51 +0200","From":"Andrew Lunn ","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile","Message-ID":"<20170907215551.GV11248@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD41121A80@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41121A80@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764984,"web_url":"http://patchwork.ozlabs.org/comment/1764984/","msgid":"<93AF473E2DA327428DE3D46B72B1E9FD41121B0A@CHN-SV-EXMX02.mchp-main.com>","list_archive_url":null,"date":"2017-09-07T22:29:34","subject":"RE: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile","submitter":{"id":72262,"url":"http://patchwork.ozlabs.org/api/people/72262/","name":"","email":"Tristram.Ha@microchip.com"},"content":"> -----Original Message-----\n> From: Andrew Lunn [mailto:andrew@lunn.ch]\n> Sent: Thursday, September 07, 2017 2:56 PM\n> To: Tristram Ha - C24268\n> Cc: muvarov@gmail.com; pavel@ucw.cz; nathan.leigh.conrad@gmail.com;\n> vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com;\n> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh - C21699\n> Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile\n> \n> On Thu, Sep 07, 2017 at 09:17:10PM +0000, Tristram.Ha@microchip.com wrote:\n> > From: Tristram Ha \n> >\n> > Add KSZ8795 switch support with SPI access.\n> >\n> > Signed-off-by: Tristram Ha \n> > ---\n> > diff --git a/drivers/net/dsa/microchip/Makefile\n> b/drivers/net/dsa/microchip/Makefile\n> > index 0961c30..0d8ba48 100644\n> > --- a/drivers/net/dsa/microchip/Makefile\n> > +++ b/drivers/net/dsa/microchip/Makefile\n> > @@ -1,2 +1,4 @@\n> > obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz9477.o ksz_common.o\n> > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)\t+= ksz_spi.o\n> > +obj-$(CONFIG_MICROCHIP_KSZ8795)\t += ksz8795.o ksz_common.o\n> > +obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER)\t+= ksz8795_spi.o\n> \n> I've not tried it, but i think this breaks the build\n> \n> Andrew\n\nSo you would like to have all 5 patches in 1 patch file?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpFXD1pMZz9s7f\n\tfor ;\n\tFri, 8 Sep 2017 08:30:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756186AbdIGWaW convert rfc822-to-8bit (ORCPT\n\t);\n\tThu, 7 Sep 2017 18:30:22 -0400","from esa4.microchip.iphmx.com ([68.232.154.123]:18188 \"EHLO\n\tesa4.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755564AbdIGWaV (ORCPT\n\t); Thu, 7 Sep 2017 18:30:21 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa4.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t07 Sep 2017 15:29:35 -0700","from CHN-SV-EXMX02.mchp-main.com ([fe80::7dfe:3761:863e:3963]) by\n\tCHN-SV-EXCH04.mchp-main.com ([fe80::6150:8a42:4945:9b1b%16]) with\n\tmapi id 14.03.0352.000; Thu, 7 Sep 2017 15:29:34 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,360,1500966000\"; d=\"scan'208\";a=\"6633719\"","From":"","To":"","CC":", , ,\n\t, ,\n\t, ,\n\t","Subject":"RE: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile","Thread-Topic":"[PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile","Thread-Index":"AdMoGxuWn07a4m7kQ+SGD/RX/JgjxQAAyXygABAfNoAADZI2kA==","Date":"Thu, 7 Sep 2017 22:29:34 +0000","Message-ID":"<93AF473E2DA327428DE3D46B72B1E9FD41121B0A@CHN-SV-EXMX02.mchp-main.com>","References":"<93AF473E2DA327428DE3D46B72B1E9FD41121A80@CHN-SV-EXMX02.mchp-main.com>\n\t<20170907215551.GV11248@lunn.ch>","In-Reply-To":"<20170907215551.GV11248@lunn.ch>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.76.4]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764991,"web_url":"http://patchwork.ozlabs.org/comment/1764991/","msgid":"<20170907224309.GZ11248@lunn.ch>","list_archive_url":null,"date":"2017-09-07T22:43:09","subject":"Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Sep 07, 2017 at 10:29:34PM +0000, Tristram.Ha@microchip.com wrote:\n> > -----Original Message-----\n> > From: Andrew Lunn [mailto:andrew@lunn.ch]\n> > Sent: Thursday, September 07, 2017 2:56 PM\n> > To: Tristram Ha - C24268\n> > Cc: muvarov@gmail.com; pavel@ucw.cz; nathan.leigh.conrad@gmail.com;\n> > vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com;\n> > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh - C21699\n> > Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile\n> > \n> > On Thu, Sep 07, 2017 at 09:17:10PM +0000, Tristram.Ha@microchip.com wrote:\n> > > From: Tristram Ha \n> > >\n> > > Add KSZ8795 switch support with SPI access.\n> > >\n> > > Signed-off-by: Tristram Ha \n> > > ---\n> > > diff --git a/drivers/net/dsa/microchip/Makefile\n> > b/drivers/net/dsa/microchip/Makefile\n> > > index 0961c30..0d8ba48 100644\n> > > --- a/drivers/net/dsa/microchip/Makefile\n> > > +++ b/drivers/net/dsa/microchip/Makefile\n> > > @@ -1,2 +1,4 @@\n> > > obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz9477.o ksz_common.o\n> > > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)\t+= ksz_spi.o\n> > > +obj-$(CONFIG_MICROCHIP_KSZ8795)\t += ksz8795.o ksz_common.o\n> > > +obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER)\t+= ksz8795_spi.o\n> > \n> > I've not tried it, but i think this breaks the build\n> > \n> > Andrew\n> \n> So you would like to have all 5 patches in 1 patch file?\n\nOr maybe this one last? Would that stop the build from breaking?\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpFpz3Cv4z9sDB\n\tfor ;\n\tFri, 8 Sep 2017 08:43:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932587AbdIGWnL (ORCPT );\n\tThu, 7 Sep 2017 18:43:11 -0400","from vps0.lunn.ch ([178.209.37.122]:60203 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1756010AbdIGWnK (ORCPT );\n\tThu, 7 Sep 2017 18:43:10 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dq5Vt-0008HU-2T; Fri, 08 Sep 2017 00:43:09 +0200"],"Date":"Fri, 8 Sep 2017 00:43:09 +0200","From":"Andrew Lunn ","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile","Message-ID":"<20170907224309.GZ11248@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD41121A80@CHN-SV-EXMX02.mchp-main.com>\n\t<20170907215551.GV11248@lunn.ch>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121B0A@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41121B0A@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765167,"web_url":"http://patchwork.ozlabs.org/comment/1765167/","msgid":"<20170908090628.GA17738@amd>","list_archive_url":null,"date":"2017-09-08T09:06:28","subject":"Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"On Fri 2017-09-08 00:43:09, Andrew Lunn wrote:\n> On Thu, Sep 07, 2017 at 10:29:34PM +0000, Tristram.Ha@microchip.com wrote:\n> > > -----Original Message-----\n> > > From: Andrew Lunn [mailto:andrew@lunn.ch]\n> > > Sent: Thursday, September 07, 2017 2:56 PM\n> > > To: Tristram Ha - C24268\n> > > Cc: muvarov@gmail.com; pavel@ucw.cz; nathan.leigh.conrad@gmail.com;\n> > > vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com;\n> > > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh - C21699\n> > > Subject: Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile\n> > > \n> > > On Thu, Sep 07, 2017 at 09:17:10PM +0000, Tristram.Ha@microchip.com wrote:\n> > > > From: Tristram Ha \n> > > >\n> > > > Add KSZ8795 switch support with SPI access.\n> > > >\n> > > > Signed-off-by: Tristram Ha \n> > > > ---\n> > > > diff --git a/drivers/net/dsa/microchip/Makefile\n> > > b/drivers/net/dsa/microchip/Makefile\n> > > > index 0961c30..0d8ba48 100644\n> > > > --- a/drivers/net/dsa/microchip/Makefile\n> > > > +++ b/drivers/net/dsa/microchip/Makefile\n> > > > @@ -1,2 +1,4 @@\n> > > > obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz9477.o ksz_common.o\n> > > > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)\t+= ksz_spi.o\n> > > > +obj-$(CONFIG_MICROCHIP_KSZ8795)\t += ksz8795.o ksz_common.o\n> > > > +obj-$(CONFIG_MICROCHIP_KSZ8795_SPI_DRIVER)\t+= ksz8795_spi.o\n> > > \n> > > I've not tried it, but i think this breaks the build\n> > > \n> > > Andrew\n> > \n> > So you would like to have all 5 patches in 1 patch file?\n> \n> Or maybe this one last? Would that stop the build from breaking?\n\nThis and Kconfig change should come together.. and probably last.\n\t\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpWf42GtQz9sCZ\n\tfor ;\n\tFri, 8 Sep 2017 19:06:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752482AbdIHJGe (ORCPT );\n\tFri, 8 Sep 2017 05:06:34 -0400","from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33797 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752276AbdIHJG3 (ORCPT\n\t); Fri, 8 Sep 2017 05:06:29 -0400","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid 6F272824DD; Fri, 8 Sep 2017 11:06:28 +0200 (CEST)"],"Date":"Fri, 8 Sep 2017 11:06:28 +0200","From":"Pavel Machek ","To":"Andrew Lunn ","Cc":"Tristram.Ha@microchip.com, muvarov@gmail.com,\n\tnathan.leigh.conrad@gmail.com, vivien.didelot@savoirfairelinux.com,\n\tf.fainelli@gmail.com, netdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, Woojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 2/5] Add KSZ8795 switch driver support in Makefile","Message-ID":"<20170908090628.GA17738@amd>","References":"<93AF473E2DA327428DE3D46B72B1E9FD41121A80@CHN-SV-EXMX02.mchp-main.com>\n\t<20170907215551.GV11248@lunn.ch>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121B0A@CHN-SV-EXMX02.mchp-main.com>\n\t<20170907224309.GZ11248@lunn.ch>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"MGYHOYXEY6WxJCY8\"","Content-Disposition":"inline","In-Reply-To":"<20170907224309.GZ11248@lunn.ch>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]