[{"id":1764949,"web_url":"http://patchwork.ozlabs.org/comment/1764949/","msgid":"<20170907212449.GQ11248@lunn.ch>","list_archive_url":null,"date":"2017-09-07T21:24:49","subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Sep 07, 2017 at 09:08:58PM +0000, Tristram.Ha@microchip.com wrote:\n> From: Tristram Ha \n> \n> Break ksz_common.c into 2 files so that the common code can be used by other KSZ switch drivers.\n> \n> Signed-off-by: Tristram Ha \n> ---\n> diff --git a/drivers/net/dsa/microchip/Makefile b/drivers/net/dsa/microchip/Makefile\n> index ed335e2..0961c30 100644\n> --- a/drivers/net/dsa/microchip/Makefile\n> +++ b/drivers/net/dsa/microchip/Makefile\n> @@ -1,2 +1,2 @@\n> -obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz_common.o\n> +obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz9477.o ksz_common.o\n> obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)\t+= ksz_spi.o\n\nHi Tristram\n\nI would of thought this would break the build. You don't add ksz9477.c\nuntil the next patch.\n\nEach patch needs to compile, otherwise you break git bisect.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpD4g29Y4z9s81\n\tfor ;\n\tFri, 8 Sep 2017 07:25:07 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756018AbdIGVYy (ORCPT );\n\tThu, 7 Sep 2017 17:24:54 -0400","from vps0.lunn.ch ([178.209.37.122]:60055 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751456AbdIGVYx (ORCPT );\n\tThu, 7 Sep 2017 17:24:53 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dq4I5-0007MI-Vs; Thu, 07 Sep 2017 23:24:49 +0200"],"Date":"Thu, 7 Sep 2017 23:24:49 +0200","From":"Andrew Lunn ","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","Message-ID":"<20170907212449.GQ11248@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218C4@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219FF@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD411219FF@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764983,"web_url":"http://patchwork.ozlabs.org/comment/1764983/","msgid":"<93AF473E2DA327428DE3D46B72B1E9FD41121AFB@CHN-SV-EXMX02.mchp-main.com>","list_archive_url":null,"date":"2017-09-07T22:26:11","subject":"RE: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","submitter":{"id":72262,"url":"http://patchwork.ozlabs.org/api/people/72262/","name":"","email":"Tristram.Ha@microchip.com"},"content":"> -----Original Message-----\n> From: Andrew Lunn [mailto:andrew@lunn.ch]\n> Sent: Thursday, September 07, 2017 2:25 PM\n> To: Tristram Ha - C24268\n> Cc: muvarov@gmail.com; pavel@ucw.cz; nathan.leigh.conrad@gmail.com;\n> vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com;\n> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh - C21699\n> Subject: Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n> switch drivers.\n> \n> On Thu, Sep 07, 2017 at 09:08:58PM +0000, Tristram.Ha@microchip.com wrote:\n> > From: Tristram Ha \n> >\n> > Break ksz_common.c into 2 files so that the common code can be used by other\n> KSZ switch drivers.\n> >\n> > Signed-off-by: Tristram Ha \n> > ---\n> > diff --git a/drivers/net/dsa/microchip/Makefile\n> > b/drivers/net/dsa/microchip/Makefile\n> > index ed335e2..0961c30 100644\n> > --- a/drivers/net/dsa/microchip/Makefile\n> > +++ b/drivers/net/dsa/microchip/Makefile\n> > @@ -1,2 +1,2 @@\n> > -obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz_common.o\n> > +obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz9477.o ksz_common.o\n> > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)\t+= ksz_spi.o\n> \n> Hi Tristram\n> \n> I would of thought this would break the build. You don't add ksz9477.c until the\n> next patch.\n> \n> Each patch needs to compile, otherwise you break git bisect.\n> \n> Andrew\n\nEventually the file will need to be broken in two, so you would like to see all 3 changes (Makefile, ksz_common.c, and ksz9477.c) in 1 patch file?","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpFRs1LSyz9sDB\n\tfor ;\n\tFri, 8 Sep 2017 08:26:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756131AbdIGW03 convert rfc822-to-8bit (ORCPT\n\t);\n\tThu, 7 Sep 2017 18:26:29 -0400","from esa5.microchip.iphmx.com ([216.71.150.166]:32293 \"EHLO\n\tesa5.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755853AbdIGW02 (ORCPT\n\t); Thu, 7 Sep 2017 18:26:28 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t07 Sep 2017 15:26:13 -0700","from CHN-SV-EXMX02.mchp-main.com ([fe80::7dfe:3761:863e:3963]) by\n\tCHN-SV-EXCH05.mchp-main.com ([fe80::c1bf:7679:c1f8:4560%15]) with\n\tmapi id 14.03.0352.000; Thu, 7 Sep 2017 15:26:12 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,360,1500966000\"; d=\"scan'208\";a=\"4518152\"","From":"","To":"","CC":", , ,\n\t, ,\n\t, ,\n\t","Subject":"RE: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","Thread-Topic":"[PATCH RFC 1/6] The file ksz_common.c will be used by other\n\tKSZ switch drivers.","Thread-Index":"AdMoGk0QxDcqiEQqTT6n0i1H16HhJAAAmvxwAA9r4oAADKbUoA==","Date":"Thu, 7 Sep 2017 22:26:11 +0000","Message-ID":"<93AF473E2DA327428DE3D46B72B1E9FD41121AFB@CHN-SV-EXMX02.mchp-main.com>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218C4@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219FF@CHN-SV-EXMX02.mchp-main.com>\n\t<20170907212449.GQ11248@lunn.ch>","In-Reply-To":"<20170907212449.GQ11248@lunn.ch>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.76.4]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764987,"web_url":"http://patchwork.ozlabs.org/comment/1764987/","msgid":"<20170907224038.GX11248@lunn.ch>","list_archive_url":null,"date":"2017-09-07T22:40:38","subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> > > Signed-off-by: Tristram Ha \n> > > ---\n> > > diff --git a/drivers/net/dsa/microchip/Makefile\n> > > b/drivers/net/dsa/microchip/Makefile\n> > > index ed335e2..0961c30 100644\n> > > --- a/drivers/net/dsa/microchip/Makefile\n> > > +++ b/drivers/net/dsa/microchip/Makefile\n> > > @@ -1,2 +1,2 @@\n> > > -obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz_common.o\n> > > +obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz9477.o ksz_common.o\n> > > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)\t+= ksz_spi.o\n> > \n> > Hi Tristram\n> > \n> > I would of thought this would break the build. You don't add ksz9477.c until the\n> > next patch.\n> > \n> > Each patch needs to compile, otherwise you break git bisect.\n> > \n> > Andrew\n> \n\n> Eventually the file will need to be broken in two, so you would like\n> to see all 3 changes (Makefile, ksz_common.c, and ksz9477.c) in 1\n> patch file?\n\nYou cannot break the build. Each patch must compile on its own.\n\nBreaking changes up into smaller chunks is good. Makes it easier to\nreview. So think about how you can do it without breaking the build,\nbut have smaller changes. For example, move a group of functions at a\ntime?\n\n\tAndrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpFm419hRz9sCZ\n\tfor ;\n\tFri, 8 Sep 2017 08:40:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756154AbdIGWkk (ORCPT );\n\tThu, 7 Sep 2017 18:40:40 -0400","from vps0.lunn.ch ([178.209.37.122]:60189 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1755853AbdIGWkj (ORCPT );\n\tThu, 7 Sep 2017 18:40:39 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dq5TS-0008Ds-4N; Fri, 08 Sep 2017 00:40:38 +0200"],"Date":"Fri, 8 Sep 2017 00:40:38 +0200","From":"Andrew Lunn ","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","Message-ID":"<20170907224038.GX11248@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218C4@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219FF@CHN-SV-EXMX02.mchp-main.com>\n\t<20170907212449.GQ11248@lunn.ch>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121AFB@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41121AFB@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765017,"web_url":"http://patchwork.ozlabs.org/comment/1765017/","msgid":"<20170908004000.GA2746@lunn.ch>","list_archive_url":null,"date":"2017-09-08T00:40:00","subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Sep 07, 2017 at 09:08:58PM +0000, Tristram.Ha@microchip.com wrote:\n> From: Tristram Ha \n\nHi Tristram\n\nAnother process thing you are missing. Patch subject should follow a\npattern:\n\ngit log --oneline drivers/net/dsa/mv88e6xxx\nbb0a2675f72b net: dsa: mv88e6xxx: Enable CMODE config support for 6390X\nb3e05aa12319 net: dsa: mv88e6xxx: add a multi_chip info flag\n68b8f60cf70d net: dsa: mv88e6xxx: add Energy Detect ops\n9069c13a4867 net: dsa: mv88e6xxx: add a global2_addr info flag\n9e907d739cc3 net: dsa: mv88e6xxx: add POT operation\na2a05db8a5ed net: dsa: mv88e6xxx: add POT flag to 88E6390\n51c901a77562 net: dsa: mv88e6xxx: distinguish Global 2 Rsvd2CPU\nd6c5e6aff50c net: dsa: mv88e6xxx: add number of Global 2 IRQs\n74e60241ce14 net: dsa: mv88e6xxx: remove 88E6185 G2 interrupt\n2466f64ae4e9 net: dsa: mv88e6xxx: remove unused capabilities\n\nPlease set the subject line in your patches similarly.\n\n Andrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpJPy153hz9sQl\n\tfor ;\n\tFri, 8 Sep 2017 10:40:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753062AbdIHAkG (ORCPT );\n\tThu, 7 Sep 2017 20:40:06 -0400","from vps0.lunn.ch ([178.209.37.122]:60289 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1753044AbdIHAkE (ORCPT );\n\tThu, 7 Sep 2017 20:40:04 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dq7Ky-0000jZ-7l; Fri, 08 Sep 2017 02:40:00 +0200"],"Date":"Fri, 8 Sep 2017 02:40:00 +0200","From":"Andrew Lunn ","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","Message-ID":"<20170908004000.GA2746@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218C4@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219FF@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD411219FF@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765164,"web_url":"http://patchwork.ozlabs.org/comment/1765164/","msgid":"<20170908085650.GC16834@amd>","list_archive_url":null,"date":"2017-09-08T08:56:50","subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"On Thu 2017-09-07 21:08:58, Tristram.Ha@microchip.com wrote:\n> From: Tristram Ha \n> \n> Break ksz_common.c into 2 files so that the common code can be used by other KSZ switch drivers.\n> \n> Signed-off-by: Tristram Ha \n> ---\n> diff --git a/drivers/net/dsa/microchip/Makefile b/drivers/net/dsa/microchip/Makefile\n> index ed335e2..0961c30 100644\n> --- a/drivers/net/dsa/microchip/Makefile\n> +++ b/drivers/net/dsa/microchip/Makefile\n> @@ -1,2 +1,2 @@\n> -obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz_common.o\n> +obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz9477.o ksz_common.o\n> obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)\t+= ksz_spi.o\n\nI believe you should also rename option to CONFIG_MICROCHIP_KSZ_9477\nhere... and introduce appropriate Kconfig change.\n\n\t\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpWRC5G6dz9sBZ\n\tfor ;\n\tFri, 8 Sep 2017 18:57:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756248AbdIHI4z (ORCPT );\n\tFri, 8 Sep 2017 04:56:55 -0400","from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33477 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754751AbdIHI4w (ORCPT\n\t); Fri, 8 Sep 2017 04:56:52 -0400","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid 0857C824E9; Fri, 8 Sep 2017 10:56:50 +0200 (CEST)"],"Date":"Fri, 8 Sep 2017 10:56:50 +0200","From":"Pavel Machek ","To":"Tristram.Ha@microchip.com","Cc":"andrew@lunn.ch, muvarov@gmail.com, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","Message-ID":"<20170908085650.GC16834@amd>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218C4@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219FF@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"zCKi3GIZzVBPywwA\"","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD411219FF@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765165,"web_url":"http://patchwork.ozlabs.org/comment/1765165/","msgid":"<20170908085739.GD16834@amd>","list_archive_url":null,"date":"2017-09-08T08:57:40","subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"> > > Signed-off-by: Tristram Ha \n> > > ---\n> > > diff --git a/drivers/net/dsa/microchip/Makefile\n> > > b/drivers/net/dsa/microchip/Makefile\n> > > index ed335e2..0961c30 100644\n> > > --- a/drivers/net/dsa/microchip/Makefile\n> > > +++ b/drivers/net/dsa/microchip/Makefile\n> > > @@ -1,2 +1,2 @@\n> > > -obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz_common.o\n> > > +obj-$(CONFIG_MICROCHIP_KSZ)\t += ksz9477.o ksz_common.o\n> > > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER)\t+= ksz_spi.o\n> > \n> > Hi Tristram\n> > \n> > I would of thought this would break the build. You don't add ksz9477.c until the\n> > next patch.\n> > \n> > Each patch needs to compile, otherwise you break git bisect.\n> > \n> > Andrew\n> \n> Eventually the file will need to be broken in two, so you would like\n>to see all 3 changes (Makefile, ksz_common.c, and ksz9477.c) in 1\n> patch file?\n\nYes please.\n\t\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpWS15N4Bz9sBW\n\tfor ;\n\tFri, 8 Sep 2017 18:57:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932514AbdIHI5n (ORCPT );\n\tFri, 8 Sep 2017 04:57:43 -0400","from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33520 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932121AbdIHI5l (ORCPT\n\t); Fri, 8 Sep 2017 04:57:41 -0400","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid 4A357824E9; Fri, 8 Sep 2017 10:57:40 +0200 (CEST)"],"Date":"Fri, 8 Sep 2017 10:57:40 +0200","From":"Pavel Machek ","To":"Tristram.Ha@microchip.com","Cc":"andrew@lunn.ch, muvarov@gmail.com, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ\n\tswitch drivers.","Message-ID":"<20170908085739.GD16834@amd>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218C4@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219FF@CHN-SV-EXMX02.mchp-main.com>\n\t<20170907212449.GQ11248@lunn.ch>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121AFB@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ylS2wUBXLOxYXZFQ\"","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41121AFB@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]