[{"id":1764961,"web_url":"http://patchwork.ozlabs.org/comment/1764961/","msgid":"<20170907214036.GS11248@lunn.ch>","list_archive_url":null,"date":"2017-09-07T21:40:36","subject":"Re: [PATCH RFC 5/6] Switch SPI driver calls its own driver switch\n\tregister function","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Sep 07, 2017 at 09:09:22PM +0000, Tristram.Ha@microchip.com wrote:\n> From: Tristram Ha \n> \n> SPI driver calls own specific switch register function.\n> Shutdown callback function is added to reset switch to default state.\n> \n> Signed-off-by: Tristram Ha \n> ---\n> diff --git a/drivers/net/dsa/microchip/ksz_spi.c b/drivers/net/dsa/microchip/ksz_spi.c\n> index c519469..d03eb83 100644\n> --- a/drivers/net/dsa/microchip/ksz_spi.c\n> +++ b/drivers/net/dsa/microchip/ksz_spi.c\n> @@ -25,6 +25,8 @@\n> \n> #include \"ksz_priv.h\"\n> \n> +int ksz9477_switch_register(struct ksz_device *dev);\n\nHi Tristram\n\nThis should be placed in a header file somewhere, not here.\n\n> +static void ksz_spi_shutdown(struct spi_device *spi) {\n> +\tstruct ksz_device *dev = spi_get_drvdata(spi);\n> +\n> +\tif (dev)\n> +\t\tdev->dev_ops->reset(dev);\n\nshutdown seems like a better name for this op, not reset.\n\n> +}\n> +\n> static const struct of_device_id ksz_dt_ids[] = {\n> \t{ .compatible = \"microchip,ksz9477\" },\n> \t{},\n> @@ -207,6 +217,7 @@ static int ksz_spi_remove(struct spi_device *spi)\n> \t},\n> \t.probe\t= ksz_spi_probe,\n> \t.remove\t= ksz_spi_remove,\n> +\t.shutdown = ksz_spi_shutdown,\n> };\n> \n> module_spi_driver(ksz_spi_driver);","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpDQp48DYz9sBW\n\tfor ;\n\tFri, 8 Sep 2017 07:40:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932336AbdIGVkj (ORCPT );\n\tThu, 7 Sep 2017 17:40:39 -0400","from vps0.lunn.ch ([178.209.37.122]:60091 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1755853AbdIGVki (ORCPT );\n\tThu, 7 Sep 2017 17:40:38 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1dq4XM-0007bh-57; Thu, 07 Sep 2017 23:40:36 +0200"],"Date":"Thu, 7 Sep 2017 23:40:36 +0200","From":"Andrew Lunn ","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 5/6] Switch SPI driver calls its own driver switch\n\tregister function","Message-ID":"<20170907214036.GS11248@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218F4@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121A1B@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41121A1B@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]