[{"id":1765026,"web_url":"http://patchwork.ozlabs.org/comment/1765026/","msgid":"<20170908011243.GC2746@lunn.ch>","list_archive_url":null,"date":"2017-09-08T01:12:43","subject":"Re: [PATCH RFC 3/6] The file ksz_common.c contains common code\n\tshared by all KSZ switch drivers","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"Hi Tristram\n\nYou patches are so badly mangled that they won't apply. So i'm\nguessing a bit here...\n\nWhat i think is you can do this in three patches:\n\n1) Straight rename of ksz_common.c to ksz9477.c. Makefile changes to\n   fit, no code changes.\n2) Move common code back into ksz_common.c. Makefile changes to fit.\n3) ksz9477.c prefix name changes\n\nIt looks like there is not too much common code in ksz_common.c. So\ndoing it this way makes the changes minimal, and things compile at\neach stage.\n\nRemember to use -M with git format-patch.\n\n\t Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpK7x5mTwz9sCZ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 11:13:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752265AbdIHBMr (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 21:12:47 -0400","from vps0.lunn.ch ([178.209.37.122]:60327 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750944AbdIHBMq (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 7 Sep 2017 21:12:46 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dq7qd-00013s-Cx; Fri, 08 Sep 2017 03:12:43 +0200"],"Date":"Fri, 8 Sep 2017 03:12:43 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 3/6] The file ksz_common.c contains common code\n\tshared by all KSZ switch drivers","Message-ID":"<20170908011243.GC2746@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218DC@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121A0D@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41121A0D@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]