[{"id":1764955,"web_url":"http://patchwork.ozlabs.org/comment/1764955/","msgid":"<20170907213242.GR11248@lunn.ch>","list_archive_url":null,"date":"2017-09-07T21:32:42","subject":"Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n\tksz_common.c","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Thu, Sep 07, 2017 at 09:09:04PM +0000, Tristram.Ha@microchip.com wrote:\n> From: Tristram Ha <Tristram.Ha@microchip.com>\n> \n> Create new ksz9477.c file from original ksz_common.c.\n> \n> Signed-off-by: Tristram Ha <Tristram.Ha@microchip.com>\n> ---\n> diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c\n> new file mode 100644\n> index 0000000..bc722b4\n> --- /dev/null\n> +++ b/drivers/net/dsa/microchip/ksz9477.c\n> @@ -0,0 +1,1317 @@\n> +/*\n> + * Microchip switch driver main logic\n> + *\n> + * Copyright (C) 2017\n> + *\n> + * Permission to use, copy, modify, and/or distribute this software for \n> +any\n> + * purpose with or without fee is hereby granted, provided that the \n> +above\n\nTristram\n\nIt looks like something hand mangled this comment. \"any\" and \"above\"\nappear to be on a line on there own.\n\n> + * copyright notice and this permission notice appear in all copies.\n> + *\n> + * THE SOFTWARE IS PROVIDED \"AS IS\" AND THE AUTHOR DISCLAIMS ALL \n> +WARRANTIES\n> + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF\n> + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE \n> +FOR\n> + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY \n> +DAMAGES\n> + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN \n> +AN\n> + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT \n> +OF\n> + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.\n> + */\n> +\n> +#include <linux/delay.h>\n> +#include <linux/export.h>\n> +#include <linux/gpio.h>\n> +#include <linux/kernel.h>\n> +#include <linux/module.h>\n> +#include <linux/platform_data/microchip-ksz.h>\n> +#include <linux/phy.h>\n> +#include <linux/etherdevice.h>\n> +#include <linux/if_bridge.h>\n> +#include <net/dsa.h>\n> +#include <net/switchdev.h>\n> +\n> +#include \"ksz_priv.h\"\n> +#include \"ksz_9477_reg.h\"\n> +\n> +static const struct {\n> +\tint index;\n> +\tchar string[ETH_GSTRING_LEN];\n> +} mib_names[TOTAL_SWITCH_COUNTER_NUM] = {\n> +\t{ 0x00, \"rx_hi\" },\n> +\t{ 0x01, \"rx_undersize\" },\n> +\t{ 0x02, \"rx_fragments\" },\n> +\t{ 0x03, \"rx_oversize\" },\n> +\t{ 0x04, \"rx_jabbers\" },\n> +\t{ 0x05, \"rx_symbol_err\" },\n> +\t{ 0x06, \"rx_crc_err\" },\n> +\t{ 0x07, \"rx_align_err\" },\n> +\t{ 0x08, \"rx_mac_ctrl\" },\n> +\t{ 0x09, \"rx_pause\" },\n> +\t{ 0x0A, \"rx_bcast\" },\n> +\t{ 0x0B, \"rx_mcast\" },\n> +\t{ 0x0C, \"rx_ucast\" },\n> +\t{ 0x0D, \"rx_64_or_less\" },\n> +\t{ 0x0E, \"rx_65_127\" },\n> +\t{ 0x0F, \"rx_128_255\" },\n> +\t{ 0x10, \"rx_256_511\" },\n> +\t{ 0x11, \"rx_512_1023\" },\n> +\t{ 0x12, \"rx_1024_1522\" },\n> +\t{ 0x13, \"rx_1523_2000\" },\n> +\t{ 0x14, \"rx_2001\" },\n> +\t{ 0x15, \"tx_hi\" },\n> +\t{ 0x16, \"tx_late_col\" },\n> +\t{ 0x17, \"tx_pause\" },\n> +\t{ 0x18, \"tx_bcast\" },\n> +\t{ 0x19, \"tx_mcast\" },\n> +\t{ 0x1A, \"tx_ucast\" },\n> +\t{ 0x1B, \"tx_deferred\" },\n> +\t{ 0x1C, \"tx_total_col\" },\n> +\t{ 0x1D, \"tx_exc_col\" },\n> +\t{ 0x1E, \"tx_single_col\" },\n> +\t{ 0x1F, \"tx_mult_col\" },\n> +\t{ 0x80, \"rx_total\" },\n> +\t{ 0x81, \"tx_total\" },\n> +\t{ 0x82, \"rx_discards\" },\n> +\t{ 0x83, \"tx_discards\" },\n> +};\n> +\n> +static void ksz_cfg(struct ksz_device *dev, u32 addr, u8 bits, bool \n> +set) {\n\nMore mangling? Should set be on the end of the previous line?\n\n> +static void read_table(struct dsa_switch *ds, u32 *table) {\n> +\tstruct ksz_device *dev = ds->priv;\n> +\n> +\tksz_read32(dev, REG_SW_ALU_VAL_A, &table[0]);\n> +\tksz_read32(dev, REG_SW_ALU_VAL_B, &table[1]);\n> +\tksz_read32(dev, REG_SW_ALU_VAL_C, &table[2]);\n> +\tksz_read32(dev, REG_SW_ALU_VAL_D, &table[3]); }\n> +\n> +static void write_table(struct dsa_switch *ds, u32 *table) {\n> +\tstruct ksz_device *dev = ds->priv;\n> +\n> +\tksz_write32(dev, REG_SW_ALU_VAL_A, table[0]);\n> +\tksz_write32(dev, REG_SW_ALU_VAL_B, table[1]);\n> +\tksz_write32(dev, REG_SW_ALU_VAL_C, table[2]);\n> +\tksz_write32(dev, REG_SW_ALU_VAL_D, table[3]); }\n\nMore mangling? } at the end of a line?\n\nI will stop reading now and wait for a v2 this is not corrupt.\n\n  Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpDFp2Cncz9s81\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 07:33:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932448AbdIGVcq (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 17:32:46 -0400","from vps0.lunn.ch ([178.209.37.122]:60068 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S932373AbdIGVco (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 7 Sep 2017 17:32:44 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dq4Pi-0007QV-Rk; Thu, 07 Sep 2017 23:32:42 +0200"],"Date":"Thu, 7 Sep 2017 23:32:42 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n\tksz_common.c","Message-ID":"<20170907213242.GR11248@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218CF@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121A06@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41121A06@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764982,"web_url":"http://patchwork.ozlabs.org/comment/1764982/","msgid":"<93AF473E2DA327428DE3D46B72B1E9FD41121AEB@CHN-SV-EXMX02.mchp-main.com>","list_archive_url":null,"date":"2017-09-07T22:20:36","subject":"RE: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n\tksz_common.c","submitter":{"id":72262,"url":"http://patchwork.ozlabs.org/api/people/72262/","name":"","email":"Tristram.Ha@microchip.com"},"content":"> -----Original Message-----\n> From: Andrew Lunn [mailto:andrew@lunn.ch]\n> Sent: Thursday, September 07, 2017 2:33 PM\n> To: Tristram Ha - C24268\n> Cc: muvarov@gmail.com; pavel@ucw.cz; nathan.leigh.conrad@gmail.com;\n> vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com;\n> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh - C21699\n> Subject: Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n> ksz_common.c\n> \n> On Thu, Sep 07, 2017 at 09:09:04PM +0000, Tristram.Ha@microchip.com wrote:\n> > From: Tristram Ha <Tristram.Ha@microchip.com>\n> >\n> > Create new ksz9477.c file from original ksz_common.c.\n> >\n> > Signed-off-by: Tristram Ha <Tristram.Ha@microchip.com>\n> > ---\n> > diff --git a/drivers/net/dsa/microchip/ksz9477.c\n> > b/drivers/net/dsa/microchip/ksz9477.c\n> > new file mode 100644\n> > index 0000000..bc722b4\n> > --- /dev/null\n> > +++ b/drivers/net/dsa/microchip/ksz9477.c\n> > @@ -0,0 +1,1317 @@\n> > +/*\n> > + * Microchip switch driver main logic\n> > + *\n> > + * Copyright (C) 2017\n> > + *\n> > + * Permission to use, copy, modify, and/or distribute this software\n> > +for any\n> > + * purpose with or without fee is hereby granted, provided that the\n> > +above\n> \n> Tristram\n> \n> It looks like something hand mangled this comment. \"any\" and \"above\"\n> appear to be on a line on there own.\n> \n> > + * copyright notice and this permission notice appear in all copies.\n> > + *\n> > + * THE SOFTWARE IS PROVIDED \"AS IS\" AND THE AUTHOR DISCLAIMS ALL\n> > +WARRANTIES\n> > + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES\n> OF\n> > + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE\n> > +LIABLE FOR\n> > + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY\n> > +DAMAGES\n> > + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER\n> IN\n> > +AN\n> > + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION,\n> ARISING\n> > +OUT OF\n> > + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.\n> > + */\n> > +\n> > +#include <linux/delay.h>\n> > +#include <linux/export.h>\n> > +#include <linux/gpio.h>\n> > +#include <linux/kernel.h>\n> > +#include <linux/module.h>\n> > +#include <linux/platform_data/microchip-ksz.h>\n> > +#include <linux/phy.h>\n> > +#include <linux/etherdevice.h>\n> > +#include <linux/if_bridge.h>\n> > +#include <net/dsa.h>\n> > +#include <net/switchdev.h>\n> > +\n> > +#include \"ksz_priv.h\"\n> > +#include \"ksz_9477_reg.h\"\n> > +\n> > +static const struct {\n> > +\tint index;\n> > +\tchar string[ETH_GSTRING_LEN];\n> > +} mib_names[TOTAL_SWITCH_COUNTER_NUM] = {\n> > +\t{ 0x00, \"rx_hi\" },\n> > +\t{ 0x01, \"rx_undersize\" },\n> > +\t{ 0x02, \"rx_fragments\" },\n> > +\t{ 0x03, \"rx_oversize\" },\n> > +\t{ 0x04, \"rx_jabbers\" },\n> > +\t{ 0x05, \"rx_symbol_err\" },\n> > +\t{ 0x06, \"rx_crc_err\" },\n> > +\t{ 0x07, \"rx_align_err\" },\n> > +\t{ 0x08, \"rx_mac_ctrl\" },\n> > +\t{ 0x09, \"rx_pause\" },\n> > +\t{ 0x0A, \"rx_bcast\" },\n> > +\t{ 0x0B, \"rx_mcast\" },\n> > +\t{ 0x0C, \"rx_ucast\" },\n> > +\t{ 0x0D, \"rx_64_or_less\" },\n> > +\t{ 0x0E, \"rx_65_127\" },\n> > +\t{ 0x0F, \"rx_128_255\" },\n> > +\t{ 0x10, \"rx_256_511\" },\n> > +\t{ 0x11, \"rx_512_1023\" },\n> > +\t{ 0x12, \"rx_1024_1522\" },\n> > +\t{ 0x13, \"rx_1523_2000\" },\n> > +\t{ 0x14, \"rx_2001\" },\n> > +\t{ 0x15, \"tx_hi\" },\n> > +\t{ 0x16, \"tx_late_col\" },\n> > +\t{ 0x17, \"tx_pause\" },\n> > +\t{ 0x18, \"tx_bcast\" },\n> > +\t{ 0x19, \"tx_mcast\" },\n> > +\t{ 0x1A, \"tx_ucast\" },\n> > +\t{ 0x1B, \"tx_deferred\" },\n> > +\t{ 0x1C, \"tx_total_col\" },\n> > +\t{ 0x1D, \"tx_exc_col\" },\n> > +\t{ 0x1E, \"tx_single_col\" },\n> > +\t{ 0x1F, \"tx_mult_col\" },\n> > +\t{ 0x80, \"rx_total\" },\n> > +\t{ 0x81, \"tx_total\" },\n> > +\t{ 0x82, \"rx_discards\" },\n> > +\t{ 0x83, \"tx_discards\" },\n> > +};\n> > +\n> > +static void ksz_cfg(struct ksz_device *dev, u32 addr, u8 bits, bool\n> > +set) {\n> \n> More mangling? Should set be on the end of the previous line?\n> \n> > +static void read_table(struct dsa_switch *ds, u32 *table) {\n> > +\tstruct ksz_device *dev = ds->priv;\n> > +\n> > +\tksz_read32(dev, REG_SW_ALU_VAL_A, &table[0]);\n> > +\tksz_read32(dev, REG_SW_ALU_VAL_B, &table[1]);\n> > +\tksz_read32(dev, REG_SW_ALU_VAL_C, &table[2]);\n> > +\tksz_read32(dev, REG_SW_ALU_VAL_D, &table[3]); }\n> > +\n> > +static void write_table(struct dsa_switch *ds, u32 *table) {\n> > +\tstruct ksz_device *dev = ds->priv;\n> > +\n> > +\tksz_write32(dev, REG_SW_ALU_VAL_A, table[0]);\n> > +\tksz_write32(dev, REG_SW_ALU_VAL_B, table[1]);\n> > +\tksz_write32(dev, REG_SW_ALU_VAL_C, table[2]);\n> > +\tksz_write32(dev, REG_SW_ALU_VAL_D, table[3]); }\n> \n> More mangling? } at the end of a line?\n> \n> I will stop reading now and wait for a v2 this is not corrupt.\n> \n>   Andrew\n\nSorry about that.  It seems my e-mail system wraps the line too soon.","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpFKr4WBsz9s71\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 08:21:36 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932400AbdIGWVY convert rfc822-to-8bit (ORCPT\n\t<rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 18:21:24 -0400","from esa1.microchip.iphmx.com ([68.232.147.91]:2688 \"EHLO\n\tesa1.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755853AbdIGWVX (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Thu, 7 Sep 2017 18:21:23 -0400","from exsmtp03.microchip.com (HELO email.microchip.com)\n\t([198.175.253.49])\n\tby esa1.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t07 Sep 2017 15:20:37 -0700","from CHN-SV-EXMX02.mchp-main.com ([fe80::7dfe:3761:863e:3963]) by\n\tchn-sv-exch03.mchp-main.com ([fe80::9916:1afa:df82:7a64%13]) with\n\tmapi id 14.03.0352.000; Thu, 7 Sep 2017 15:20:37 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,360,1500966000\"; d=\"scan'208\";a=\"7204748\"","From":"<Tristram.Ha@microchip.com>","To":"<andrew@lunn.ch>","CC":"<muvarov@gmail.com>, <pavel@ucw.cz>, <nathan.leigh.conrad@gmail.com>,\n\t<vivien.didelot@savoirfairelinux.com>, <f.fainelli@gmail.com>,\n\t<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,\n\t<Woojung.Huh@microchip.com>","Subject":"RE: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n\tksz_common.c","Thread-Topic":"[PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n\tksz_common.c","Thread-Index":"AdMoGj41K/xPwoG/RLOqTZHbh44b4QAAoZiAAA+veQAADQ9cYA==","Date":"Thu, 7 Sep 2017 22:20:36 +0000","Message-ID":"<93AF473E2DA327428DE3D46B72B1E9FD41121AEB@CHN-SV-EXMX02.mchp-main.com>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218CF@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121A06@CHN-SV-EXMX02.mchp-main.com>\n\t<20170907213242.GR11248@lunn.ch>","In-Reply-To":"<20170907213242.GR11248@lunn.ch>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.76.4]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1764989,"web_url":"http://patchwork.ozlabs.org/comment/1764989/","msgid":"<20170907224142.GY11248@lunn.ch>","list_archive_url":null,"date":"2017-09-07T22:41:42","subject":"Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n\tksz_common.c","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> Sorry about that.  It seems my e-mail system wraps the line too soon.\n\ngit send-email should solve your problems.\n\n    Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpFnJ41GGz9sDB\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 08:41:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932636AbdIGWlp (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 18:41:45 -0400","from vps0.lunn.ch ([178.209.37.122]:60197 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1756158AbdIGWlo (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 7 Sep 2017 18:41:44 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dq5UU-0008Fl-Jz; Fri, 08 Sep 2017 00:41:42 +0200"],"Date":"Fri, 8 Sep 2017 00:41:42 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n\tksz_common.c","Message-ID":"<20170907224142.GY11248@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218CF@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121A06@CHN-SV-EXMX02.mchp-main.com>\n\t<20170907213242.GR11248@lunn.ch>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121AEB@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41121AEB@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765020,"web_url":"http://patchwork.ozlabs.org/comment/1765020/","msgid":"<20170908004615.GB2746@lunn.ch>","list_archive_url":null,"date":"2017-09-08T00:46:15","subject":"Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n\tksz_common.c","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"> +static void ksz_port_cfg(struct ksz_device *dev, int port, int offset, u8 bits,\n> +\t\t\t bool set)\n\nHi Tristram\n\nAs you move these functions around, it would be good to change the\nprefix to ksz9477_\n\nYou have similar functions in the KSZ8795 driver. It is good to keep\nthe names different. This is useful when looking at stack dumps, etc.\n\n    Andrew","headers":{"Return-Path":"<netdev-owner@vger.kernel.org>","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpJY45JfWz9sBZ\n\tfor <patchwork-incoming@ozlabs.org>;\n\tFri,  8 Sep 2017 10:46:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753101AbdIHAqR (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tThu, 7 Sep 2017 20:46:17 -0400","from vps0.lunn.ch ([178.209.37.122]:60297 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752966AbdIHAqR (ORCPT <rfc822;netdev@vger.kernel.org>);\n\tThu, 7 Sep 2017 20:46:17 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1dq7R1-0000ou-2f; Fri, 08 Sep 2017 02:46:15 +0200"],"Date":"Fri, 8 Sep 2017 02:46:15 +0200","From":"Andrew Lunn <andrew@lunn.ch>","To":"Tristram.Ha@microchip.com","Cc":"muvarov@gmail.com, pavel@ucw.cz, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 2/6] Create new file ksz9477.c from KSZ9477 code in\n\tksz_common.c","Message-ID":"<20170908004615.GB2746@lunn.ch>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218CF@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41121A06@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41121A06@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<netdev.vger.kernel.org>","X-Mailing-List":"netdev@vger.kernel.org"}}]