[{"id":1765069,"web_url":"http://patchwork.ozlabs.org/comment/1765069/","msgid":"<7ad4baf4-b325-ec96-3494-aa91a83d6173@redhat.com>","list_archive_url":null,"date":"2017-09-08T03:58:08","subject":"Re: [Qemu-devel] [PATCH v3 07/21] s390x: move subsystem_reset() to\n\ts390-virtio-ccw.h","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 07.09.2017 22:13, David Hildenbrand wrote:\n> Implemented in s390-virtio-ccw.c, so move it to the right header.\n> We can also drop the extern. Fix up one include.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> include/hw/s390x/s390-virtio-ccw.h | 2 ++\n> target/s390x/cpu.h | 1 -\n> target/s390x/diag.c | 1 +\n> 3 files changed, 3 insertions(+), 1 deletion(-)\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpNpw3ZC2z9t16\n\tfor ;\n\tFri, 8 Sep 2017 13:58:46 +1000 (AEST)","from localhost ([::1]:43190 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqARH-0001XU-W8\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 23:58:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46145)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqAQu-0001XC-AC\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 23:58:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqAQp-0005J1-QP\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 23:58:20 -0400","from mx1.redhat.com ([209.132.183.28]:40718)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqAQp-0005Ie-L6\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 23:58:15 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6DC995D68C;\n\tFri, 8 Sep 2017 03:58:14 +0000 (UTC)","from [10.36.116.21] (ovpn-116-21.ams2.redhat.com [10.36.116.21])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id C670A5D964;\n\tFri, 8 Sep 2017 03:58:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6DC995D68C","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170907201335.13956-1-david@redhat.com>\n\t<20170907201335.13956-8-david@redhat.com>","From":"Thomas Huth ","Message-ID":"<7ad4baf4-b325-ec96-3494-aa91a83d6173@redhat.com>","Date":"Fri, 8 Sep 2017 05:58:08 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170907201335.13956-8-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tFri, 08 Sep 2017 03:58:14 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 07/21] s390x: move subsystem_reset() to\n\ts390-virtio-ccw.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato ,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf , borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765140,"web_url":"http://patchwork.ozlabs.org/comment/1765140/","msgid":"","list_archive_url":null,"date":"2017-09-08T07:50:02","subject":"Re: [Qemu-devel] [PATCH v3 07/21] s390x: move subsystem_reset() to\n\ts390-virtio-ccw.h","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/07/2017 10:13 PM, David Hildenbrand wrote:\n> Implemented in s390-virtio-ccw.c, so move it to the right header.\n> We can also drop the extern. Fix up one include.\n> \n> Signed-off-by: David Hildenbrand \n\nAcked-by: Christian Borntraeger \n\n> ---\n> include/hw/s390x/s390-virtio-ccw.h | 2 ++\n> target/s390x/cpu.h | 1 -\n> target/s390x/diag.c | 1 +\n> 3 files changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/include/hw/s390x/s390-virtio-ccw.h b/include/hw/s390x/s390-virtio-ccw.h\n> index 41a9d2862b..a9a90c2022 100644\n> --- a/include/hw/s390x/s390-virtio-ccw.h\n> +++ b/include/hw/s390x/s390-virtio-ccw.h\n> @@ -56,4 +56,6 @@ bool gs_allowed(void);\n> */\n> bool css_migration_enabled(void);\n> \n> +void subsystem_reset(void);\n> +\n> #endif\n> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\n> index 2343f2f1f7..3aa2e46aac 100644\n> --- a/target/s390x/cpu.h\n> +++ b/target/s390x/cpu.h\n> @@ -721,7 +721,6 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *hostbuf,\n> \n> /* outside of target/s390x/ */\n> S390CPU *s390_cpu_addr2state(uint16_t cpu_addr);\n> -extern void subsystem_reset(void);\n> int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);\n> \n> #endif\n> diff --git a/target/s390x/diag.c b/target/s390x/diag.c\n> index e6b5e6de37..82a623948d 100644\n> --- a/target/s390x/diag.c\n> +++ b/target/s390x/diag.c\n> @@ -20,6 +20,7 @@\n> #include \"hw/watchdog/wdt_diag288.h\"\n> #include \"sysemu/cpus.h\"\n> #include \"hw/s390x/ipl.h\"\n> +#include \"hw/s390x/s390-virtio-ccw.h\"\n> \n> static int modified_clear_reset(S390CPU *cpu)\n> {\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpTyW6t3Zz9s71\n\tfor ;\n\tFri, 8 Sep 2017 17:50:43 +1000 (AEST)","from localhost ([::1]:43756 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqE3m-0004Ej-4g\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 03:50:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43638)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqE3K-0004EX-R1\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 03:50:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqE3G-0002tz-40\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 03:50:14 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:45335\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqE3F-0002rl-Ut\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 03:50:10 -0400","from pps.filterd (m0098416.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv887naC4116733\n\tfor ; Fri, 8 Sep 2017 03:50:08 -0400","from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cumuxeqar-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 08 Sep 2017 03:50:08 -0400","from localhost\n\tby e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 8 Sep 2017 08:50:06 +0100","from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)\n\tby e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tFri, 8 Sep 2017 08:50:03 +0100","from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com\n\t[9.149.105.61])\n\tby b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v887o25n20119762; Fri, 8 Sep 2017 07:50:02 GMT","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 945A411C04A;\n\tFri, 8 Sep 2017 08:46:21 +0100 (BST)","from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 56F1E11C050;\n\tFri, 8 Sep 2017 08:46:21 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.228])\n\tby d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tFri, 8 Sep 2017 08:46:21 +0100 (BST)"],"To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170907201335.13956-1-david@redhat.com>\n\t<20170907201335.13956-8-david@redhat.com>","From":"Christian Borntraeger ","Date":"Fri, 8 Sep 2017 09:50:02 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170907201335.13956-8-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17090807-0040-0000-0000-000003D87937","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090807-0041-0000-0000-000025D97DAB","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-08_05:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709080119","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v3 07/21] s390x: move subsystem_reset() to\n\ts390-virtio-ccw.h","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]