[{"id":1764906,"web_url":"http://patchwork.ozlabs.org/comment/1764906/","msgid":"","list_archive_url":null,"date":"2017-09-07T19:28:40","subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","submitter":{"id":70551,"url":"http://patchwork.ozlabs.org/api/people/70551/","name":"Cyrille Pitchen","email":"cyrille.pitchen@wedev4u.fr"},"content":"Hi again,\n\nLe 07/09/2017 à 20:54, Cyrille Pitchen a écrit :\n> debug purpose only, should not be merged!\n> \n> Signed-off-by: Cyrille Pitchen \n> ---\n> \n> Hi Geert,\n> \n> Can you apply this patch on your tree then report me what was printed, please?\n> I have an idea of the root cause of your issue then a potential work-around\n> but I first need to validate my assumption to confirm that the work-around\n> would actually work.\n>\n\nIf you could also dump the value of the 'addr' argument of\nspi_nor_read_sfdp_dma_unsafe() just before the for () loop below in the\nvery same function. Actually, I suspect the SFDP tables of your SPI NOR\nmemory sample to have been programmed with invalid values, neither\ncompliant with the JEDEC JESD216 specification nor with the Cypress\ndatasheet for this memory part.\n\n> For instance, here is what I get with a Macronix MX25L25673G (same JEDEC ID as\n> MX25L25635E):\n> \n> [ 0.700000] atmel_qspi f0020000.spi: DWORD1 = 0xfffb20e5\n> [ 0.710000] atmel_qspi f0020000.spi: DWORD2 = 0x0fffffff\n> [ 0.710000] atmel_qspi f0020000.spi: DWORD3 = 0x6b08eb44\n> [ 0.720000] atmel_qspi f0020000.spi: DWORD4 = 0xbb043b08\n> [ 0.720000] atmel_qspi f0020000.spi: DWORD5 = 0xfffffffe\n> [ 0.720000] atmel_qspi f0020000.spi: DWORD6 = 0xff00ffff\n> [ 0.730000] atmel_qspi f0020000.spi: DWORD7 = 0xeb44ffff\n> [ 0.730000] atmel_qspi f0020000.spi: DWORD8 = 0x520f200c\n> [ 0.740000] atmel_qspi f0020000.spi: DWORD9 = 0xff00d810\n> [ 0.740000] atmel_qspi f0020000.spi: DWORD10 = 0x00dd59d6\n> [ 0.740000] atmel_qspi f0020000.spi: DWORD11 = 0xdb039f82\n> [ 0.750000] atmel_qspi f0020000.spi: DWORD12 = 0x38670344\n> [ 0.750000] atmel_qspi f0020000.spi: DWORD13 = 0xb030b030\n> [ 0.760000] atmel_qspi f0020000.spi: DWORD14 = 0x5cd5bdf7\n> [ 0.760000] atmel_qspi f0020000.spi: DWORD15 = 0xff299e4a\n> [ 0.760000] atmel_qspi f0020000.spi: DWORD16 = 0x85f950f0\n> [ 0.770000] atmel_qspi f0020000.spi: BFPT version 1.6 (length = 16)\n> [ 0.770000] atmel_qspi f0020000.spi: mx25l25635e (32768 Kbytes)\n> \n> Best regards,\n> \n> Cyrille\n> \n> drivers/mtd/spi-nor/spi-nor.c | 8 +++++++-\n> 1 file changed, 7 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c\n> index 05254dd6a4a0..5066d99b9f50 100644\n> --- a/drivers/mtd/spi-nor/spi-nor.c\n> +++ b/drivers/mtd/spi-nor/spi-nor.c\n> @@ -2136,8 +2136,14 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,\n> \t\treturn err;\n> \n> \t/* Fix endianness of the BFPT DWORDs. */\n> -\tfor (i = 0; i < BFPT_DWORD_MAX; i++)\n> +\tfor (i = 0; i < BFPT_DWORD_MAX; i++) {\n> \t\tbfpt.dwords[i] = le32_to_cpu(bfpt.dwords[i]);\n> +\t\tdev_info(nor->dev, \"DWORD%d = 0x%08x\\n\", i + 1, bfpt.dwords[i]);\n> +\t}\n> +\tdev_info(nor->dev, \"BFPT version %d.%d (length = %u)\\n\",\n> +\t\t bfpt_header->major,\n> +\t\t bfpt_header->minor,\n> +\t\t bfpt_header->length);\n> \n> \t/* Number of address bytes. */\n> \tswitch (bfpt.dwords[BFPT_DWORD(1)] & BFPT_DWORD1_ADDRESS_BYTES_MASK) {\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"e1Y468Y9\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp9WW1N8rz9ryv\n\tfor ;\n\tFri, 8 Sep 2017 05:29:42 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dq2UU-00033z-Lp; Thu, 07 Sep 2017 19:29:30 +0000","from smtp3-g21.free.fr ([212.27.42.3])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dq2U5-0002zo-Gy\n\tfor linux-mtd@lists.infradead.org; Thu, 07 Sep 2017 19:29:07 +0000","from mountainer.wedev4u.int (unknown [82.232.94.13])\n\tby smtp3-g21.free.fr (Postfix) with ESMTP id 2AE1D13F8AD;\n\tThu, 7 Sep 2017 21:28:41 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=GIB482nWbGgdrYUM2xXa4ip5xHNEQ+v+jEUoYMlBw2I=;\n\tb=e1Y468Y9HHgUAh\n\tr1z1xPMawMoG8wSCKEZ0PW7FEJOfz37Dp6JQaE736DtZSzkE0/8ngFdPtFDOeNuZlVwreJOrGXkTw\n\trvyYFeZTRFQbNismsn0Cd7o1/B2Lax0VQ6X/j61dEKMKpDR859sgSgdL2RcvRk2oXIDjgJTCwAMJi\n\tKJ2en+ykfkCojFn8U6DuN7Op79/pbdyGNLlh58PEaJG/haehheDHwOsulPq5Li1g2MvBBrQdDMWdv\n\tpzzaIFSNp/jqH9Oe53b0X7nFdDA6ggzVmsIeldGlaNm+xXE6CmhzBr1Cn2ZBL3kTUN4700U2eIa58\n\tqDUMWMA60bYi1p3qE31g==;","Subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","To":"marek.vasut@gmail.com, linux-mtd@lists.infradead.org,\n\tgeert@linux-m68k.org","References":"\n\t<20170907185456.4631-1-cyrille.pitchen@wedev4u.fr>","From":"Cyrille Pitchen ","Message-ID":"","Date":"Thu, 7 Sep 2017 21:28:40 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170907185456.4631-1-cyrille.pitchen@wedev4u.fr>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170907_122905_882520_574B58C4 ","X-CRM114-Status":"GOOD ( 16.03 )","X-Spam-Score":"-0.2 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [212.27.42.3 listed in list.dnswl.org]\n\t1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist\n\t[URIs: wedev4u.fr]\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"boris.brezillon@free-electrons.com, computersforpeace@gmail.com,\n\tdwmw2@infradead.org, linux-kernel@vger.kernel.org, richard@nod.at","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1766142,"web_url":"http://patchwork.ozlabs.org/comment/1766142/","msgid":"","list_archive_url":null,"date":"2017-09-11T08:58:36","subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"Hi Cyrille,\n\nOn Thu, Sep 7, 2017 at 9:28 PM, Cyrille Pitchen\n wrote:\n>> Can you apply this patch on your tree then report me what was printed, please?\n>> I have an idea of the root cause of your issue then a potential work-around\n>> but I first need to validate my assumption to confirm that the work-around\n>> would actually work.\n\n+m25p80 spi0.0: DWORD1 = 0xffffffff\n+m25p80 spi0.0: DWORD2 = 0xffffffff\n+m25p80 spi0.0: DWORD3 = 0xffffffff\n+m25p80 spi0.0: DWORD4 = 0xffffffff\n+m25p80 spi0.0: DWORD5 = 0xffffffff\n+m25p80 spi0.0: DWORD6 = 0xffffffff\n+m25p80 spi0.0: DWORD7 = 0xffffffff\n+m25p80 spi0.0: DWORD8 = 0xffffffff\n+m25p80 spi0.0: DWORD9 = 0xffffffff\n+m25p80 spi0.0: DWORD10 = 0x00000000\n+m25p80 spi0.0: DWORD11 = 0x00000000\n+m25p80 spi0.0: DWORD12 = 0x00000000\n+m25p80 spi0.0: DWORD13 = 0x00000000\n+m25p80 spi0.0: DWORD14 = 0x00000000\n+m25p80 spi0.0: DWORD15 = 0x00000000\n+m25p80 spi0.0: DWORD16 = 0x00000000\n+m25p80 spi0.0: BFPT version 1.0 (length = 9)\n\n> If you could also dump the value of the 'addr' argument of\n> spi_nor_read_sfdp_dma_unsafe() just before the for () loop below in the\n> very same function. Actually, I suspect the SFDP tables of your SPI NOR\n\n+m25p80 spi0.0: addr = 0x448\n\n> memory sample to have been programmed with invalid values, neither\n> compliant with the JEDEC JESD216 specification nor with the Cypress\n> datasheet for this memory part.\n\nSounds plausible.\nI get the same values when disabling DMA, so it's not due to bad DMA handling.\nAll Renesas boards I have local or remote access to have spansion,s25fl512s.\n\nThanks!\n\nGr{oetje,eeting}s,\n\n Geert\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n -- Linus Torvalds","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"qjvJU5Jf\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"kB/Au1yE\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrMM54rN7z9s7G\n\tfor ;\n\tMon, 11 Sep 2017 19:00:01 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drKZL-0002ch-E9; Mon, 11 Sep 2017 08:59:51 +0000","from mail-pg0-x232.google.com ([2607:f8b0:400e:c05::232])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drKYV-00027a-GH\n\tfor linux-mtd@lists.infradead.org; Mon, 11 Sep 2017 08:59:02 +0000","by mail-pg0-x232.google.com with SMTP id v66so14194901pgb.5\n\tfor ;\n\tMon, 11 Sep 2017 01:58:38 -0700 (PDT)","by 10.100.160.13 with HTTP; Mon, 11 Sep 2017 01:58:36 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=8OL+Fyvfju/Y9r5WQkNqJL9ydvE1QrM2Qei4i++9cew=;\n\tb=qjvJU5JfzIPmC8\n\tlANHrCXFrXvGTrCHjznhJzVL/DXiXSAM3LarqXBrazlTOLyYOOQV5qJi1J9Td5dvF8hRuljfOJuze\n\toVmXW4b92P89p8rTejTQCJVVc3AIA5YvH3bfsnGPBkaw93LRa/bMYXHkiqYda6at47oNuQ6nwduNz\n\tjjKSbkmWodjlCuccoQXQD0Ww6pof3A4oDSdQ6LAHQyp+FgoSexq6GN3ZdtjCZ6oJ2VmSt8F4wdelz\n\tjpUTMc2lyxYazXgPzasAdXifggU9RYfaq95iab336V6ywwEIzeftp8BdQHvAdhc/gbqMLlVae9qcL\n\tvTFOSue7mnDEtLrslYeQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=nGAe1l73wB1TFxN63VuhPWbSxNz+mjXNPxmOPGP91gI=;\n\tb=kB/Au1yEefPljNruhGQRekh4UuuUMGx7S2uD9n1mQp4lZXv80tlnU4H/5rSBSP6ppV\n\tMJXM3lfVzVh87UYAzS0P+vi5IRxDBHS/XdQsgkZKwuy89KPs+CWkh96Cd8p7B634P4oB\n\tsunRoKoJfB3vaVUCSKdmbeHKOOBWpYy53vSZkLDkm7UM4KTL61cZ6ezVYEWCcf+qY6YY\n\tcMtFHteuyLNUBBe41NIcaADUY/uUrKQYMCjOKY0NW0dSnm5NrxVUo1ORp8CRfBGi1FY1\n\tf4hYfRWACPkos91HBWoHnFpo0cJGFJQSq4L9uB51Mt+zfvksOwFKGsWMBk3uqZ7F9N2u\n\tOxHA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=nGAe1l73wB1TFxN63VuhPWbSxNz+mjXNPxmOPGP91gI=;\n\tb=f6tM13S5Zk7O/HthTDOL7R2nGzBGbqrLyBTYlBVx8Bswlavaveo1j6xSSgVPFyEi+D\n\tN0DlFHDfVPN+4aMYjlnAvW5gSD9G3U+aJ4O8b0SYBikh2GAUBonrMzD9X5eoHkhz9+U8\n\tmsnunpxy0PQhQaZp7ZmYM0pHzOTm0tZhv/94to87ZqYyQM0q7D8r0WnlVyYU4yIvFmHk\n\t21B7jzaavokpyEk8Z3HFdt14xsUgN/4mDd3xuA8PqLNr6CGfn/yuP0f8jVrngUgKQ2y3\n\tZhw/a5t6FC8flpC8PWqv4R4hp43vTLHOkGyvvgxtUgw/jEcVOXnPaEDGLutHvHBg2/bs\n\tZbwQ==","X-Gm-Message-State":"AHPjjUjy5MeMqNPVEMdIDRSjxAY6gPpK9aIUHsPJugmxf1d8U8rBsElg\n\tx/d37xjszESE/dMIfc/B2esWydGHtdhrBhs=","X-Google-Smtp-Source":"ADKCNb44F5MFC6S6b965n+inIG7jUGn3VIsY4qtcVYTYPyN55gOSK1kmSw430rObIENZwpm62vi/j+ryTdwXVHQ4LPQ=","X-Received":"by 10.101.74.12 with SMTP id s12mr11420504pgq.63.1505120317410; \n\tMon, 11 Sep 2017 01:58:37 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"\n\t<20170907185456.4631-1-cyrille.pitchen@wedev4u.fr>\n\t","From":"Geert Uytterhoeven ","Date":"Mon, 11 Sep 2017 10:58:36 +0200","X-Google-Sender-Auth":"KHIa4PpiAp-l9ePrfY56-S2thdI","Message-ID":"","Subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","To":"Cyrille Pitchen ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170911_015859_644611_6A155F64 ","X-CRM114-Status":"GOOD ( 13.51 )","X-Spam-Score":"-1.7 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:232 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (geert.uytterhoeven[at]gmail.com)\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and\n\tEnvelopeFrom freemail headers are different","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris BREZILLON ,\n\tRichard Weinberger ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tMarek Vasut ,\n\tMTD Maling List ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1767023,"web_url":"http://patchwork.ozlabs.org/comment/1767023/","msgid":"<20170912151236.33c5ad8f@bbrezillon>","list_archive_url":null,"date":"2017-09-12T13:12:36","subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","submitter":{"id":63120,"url":"http://patchwork.ozlabs.org/api/people/63120/","name":"Boris Brezillon","email":"boris.brezillon@free-electrons.com"},"content":"Hi Geert,\n\nOn Mon, 11 Sep 2017 10:58:36 +0200\nGeert Uytterhoeven wrote:\n\n> Hi Cyrille,\n> \n> On Thu, Sep 7, 2017 at 9:28 PM, Cyrille Pitchen\n> wrote:\n> >> Can you apply this patch on your tree then report me what was printed, please?\n> >> I have an idea of the root cause of your issue then a potential work-around\n> >> but I first need to validate my assumption to confirm that the work-around\n> >> would actually work. \n> \n> +m25p80 spi0.0: DWORD1 = 0xffffffff\n> +m25p80 spi0.0: DWORD2 = 0xffffffff\n> +m25p80 spi0.0: DWORD3 = 0xffffffff\n> +m25p80 spi0.0: DWORD4 = 0xffffffff\n> +m25p80 spi0.0: DWORD5 = 0xffffffff\n> +m25p80 spi0.0: DWORD6 = 0xffffffff\n> +m25p80 spi0.0: DWORD7 = 0xffffffff\n> +m25p80 spi0.0: DWORD8 = 0xffffffff\n> +m25p80 spi0.0: DWORD9 = 0xffffffff\n> +m25p80 spi0.0: DWORD10 = 0x00000000\n> +m25p80 spi0.0: DWORD11 = 0x00000000\n> +m25p80 spi0.0: DWORD12 = 0x00000000\n> +m25p80 spi0.0: DWORD13 = 0x00000000\n> +m25p80 spi0.0: DWORD14 = 0x00000000\n> +m25p80 spi0.0: DWORD15 = 0x00000000\n> +m25p80 spi0.0: DWORD16 = 0x00000000\n> +m25p80 spi0.0: BFPT version 1.0 (length = 9)\n> \n> > If you could also dump the value of the 'addr' argument of\n> > spi_nor_read_sfdp_dma_unsafe() just before the for () loop below in the\n> > very same function. Actually, I suspect the SFDP tables of your SPI NOR \n> \n> +m25p80 spi0.0: addr = 0x448\n> \n> > memory sample to have been programmed with invalid values, neither\n> > compliant with the JEDEC JESD216 specification nor with the Cypress\n> > datasheet for this memory part. \n> \n> Sounds plausible.\n> I get the same values when disabling DMA, so it's not due to bad DMA handling.\n> All Renesas boards I have local or remote access to have spansion,s25fl512s.\n\nCan you try with the following patch?\n\nThanks,\n\nBoris\n\n--->8---\nFrom 000ff63fdb149d87d755483f5edc0aba010da6b4 Mon Sep 17 00:00:00 2001\nFrom: Boris Brezillon \nDate: Tue, 12 Sep 2017 15:10:35 +0200\nSubject: [PATCH] mtd: spi-nor: Check consistency of the memory size extracted\n from the SFDP\n\nOne field of the flash parameter table contains information about the\nflash device size.\nMost of the time the data extracted from this field is valid, but\nsometimes the BFPT section of the SFDP table is corrupted or invalid and\nthis field is set to 0xffffffff, thus resulting in an integer overflow\nwhen setting params->size.\n\nSince NOR devices are anayway always smaller than 2^64 bytes, we can\neasily stop the BFPT parsing if the size reported in this table is\ninvalid.\n\nSigned-off-by: Boris Brezillon \n---\n drivers/mtd/spi-nor/spi-nor.c | 9 +++++++++\n 1 file changed, 9 insertions(+)\n\ndiff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c\nindex cf1d4a15e10a..665ccae1d090 100644\n--- a/drivers/mtd/spi-nor/spi-nor.c\n+++ b/drivers/mtd/spi-nor/spi-nor.c\n@@ -2127,6 +2127,15 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,\n \tparams->size = bfpt.dwords[BFPT_DWORD(2)];\n \tif (params->size & BIT(31)) {\n \t\tparams->size &= ~BIT(31);\n+\n+\t\t/*\n+\t\t * Prevent overflows on params->size. Anyway, a NOR of 1^64\n+\t\t * bytes is unlikely to exist so this error probably means\n+\t\t * the BFPT we are reading is corrupted/wrong.\n+\t\t */\n+\t\tif (params->size > 63)\n+\t\t\treturn -EINVAL;\n+\n \t\tparams->size = 1ULL << params->size;\n \t} else {\n \t\tparams->size++;","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"mhj7vII5\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs4xC3j2wz9s0g\n\tfor ;\n\tTue, 12 Sep 2017 23:13:35 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drl0N-0004Qj-S3; Tue, 12 Sep 2017 13:13:31 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drkzy-0004PG-Ks\n\tfor linux-mtd@lists.infradead.org; Tue, 12 Sep 2017 13:13:09 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 7ED5C208AD; Tue, 12 Sep 2017 15:12:43 +0200 (CEST)","from bbrezillon (cpe-172-88-65-44.socal.res.rr.com [172.88.65.44])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 8A07F2087E;\n\tTue, 12 Sep 2017 15:12:41 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=9lyzB3JshjniMfgnxbflOdjIUY3bSlAgZlYxOiqzY4Q=;\n\tb=mhj7vII5483eSg\n\t/bm6brvpKHZGCAeGQyv2thDOyzgWm+QwHgetRwEk0m2h+X93NLAXJizEbZKeI2da4TUE/TAVmhZQv\n\t3C4VD+1+7o+ocbWTTTDW+NSJD7KAG9MSMjPl/ROEbZzuXOl5DEvITgd8nnf/R6wwIG8tNOhRiqG88\n\tKWOPp6yg3p907v17erHgTdfCPN3OnhBf9OWjxXK23MzWx5i/iVRJ0erTdsGQtdeiXsgx148T0jvk3\n\tPw0wpWVGacMQ1/JAGibWnxBT9639bzS0QnTUH1g5RXmVNf1xGY/c/FbtMIF/hfmKLeGOYpdhnT61/\n\tke9paMrkHFDruN1TbFTA==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 12 Sep 2017 15:12:36 +0200","From":"Boris Brezillon ","To":"Geert Uytterhoeven ","Subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","Message-ID":"<20170912151236.33c5ad8f@bbrezillon>","In-Reply-To":"","References":"\n\t<20170907185456.4631-1-cyrille.pitchen@wedev4u.fr>\n\t\n\t","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170912_061306_977878_42814685 ","X-CRM114-Status":"GOOD ( 23.63 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Richard Weinberger ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tMarek Vasut ,\n\tMTD Maling List ,\n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1767885,"web_url":"http://patchwork.ozlabs.org/comment/1767885/","msgid":"<20170913153305.6cf50c4f@bbrezillon>","list_archive_url":null,"date":"2017-09-13T13:33:05","subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","submitter":{"id":63120,"url":"http://patchwork.ozlabs.org/api/people/63120/","name":"Boris Brezillon","email":"boris.brezillon@free-electrons.com"},"content":"Adding back original recipients (you seem to have trimmed the Cc-list).\n\nHi Geert,\n\nOn Tue, 12 Sep 2017 15:29:23 +0200\nGeert Uytterhoeven wrote:\n\n> Hi Boris,\n> \n> On Tue, Sep 12, 2017 at 3:12 PM, Boris Brezillon\n> wrote:\n> > On Mon, 11 Sep 2017 10:58:36 +0200\n> > Geert Uytterhoeven wrote: \n> >> On Thu, Sep 7, 2017 at 9:28 PM, Cyrille Pitchen\n> >> wrote: \n> >> >> Can you apply this patch on your tree then report me what was printed, please?\n> >> >> I have an idea of the root cause of your issue then a potential work-around\n> >> >> but I first need to validate my assumption to confirm that the work-around\n> >> >> would actually work. \n> >>\n> >> +m25p80 spi0.0: DWORD1 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD2 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD3 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD4 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD5 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD6 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD7 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD8 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD9 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD10 = 0x00000000\n> >> +m25p80 spi0.0: DWORD11 = 0x00000000\n> >> +m25p80 spi0.0: DWORD12 = 0x00000000\n> >> +m25p80 spi0.0: DWORD13 = 0x00000000\n> >> +m25p80 spi0.0: DWORD14 = 0x00000000\n> >> +m25p80 spi0.0: DWORD15 = 0x00000000\n> >> +m25p80 spi0.0: DWORD16 = 0x00000000\n> >> +m25p80 spi0.0: BFPT version 1.0 (length = 9)\n> >> \n> >> > If you could also dump the value of the 'addr' argument of\n> >> > spi_nor_read_sfdp_dma_unsafe() just before the for () loop below in the\n> >> > very same function. Actually, I suspect the SFDP tables of your SPI NOR \n> >>\n> >> +m25p80 spi0.0: addr = 0x448\n> >> \n> >> > memory sample to have been programmed with invalid values, neither\n> >> > compliant with the JEDEC JESD216 specification nor with the Cypress\n> >> > datasheet for this memory part. \n> >>\n> >> Sounds plausible.\n> >> I get the same values when disabling DMA, so it's not due to bad DMA handling.\n> >> All Renesas boards I have local or remote access to have spansion,s25fl512s. \n> >\n> > Can you try with the following patch? \n> \n> Thanks, that fixes it:\n> \n> -m25p80 spi0.0: s25fl512s (0 Kbytes)\n> +m25p80 spi0.0: s25fl512s (65536 Kbytes)\n> 3 ofpart partitions found on MTD device spi0.0\n> Creating 3 MTD partitions on \"spi0.0\":\n> 0x000000000000-0x000000080000 : \"loader\"\n> -mtd: partition \"loader\" is out of reach -- disabled\n> 0x000000080000-0x000000600000 : \"user\"\n> -mtd: partition \"user\" is out of reach -- disabled\n> 0x000000600000-0x000004000000 : \"flash\"\n> -mtd: partition \"flash\" is out of reach -- disabled\n> \n> BTW, perhaps the driver should print a warning, so the user knows his\n> FLASH isn't SFDP compliant?\n\nYep, but I'll let Cyrille fix this aspect in a follow-up patch since\nI'm not sure how specific the error message should be (a generic\n\"failed to read/decode SFDP\" error or something more specific for each\nerror case).\n\n> \n> > --->8--- \n> > From 000ff63fdb149d87d755483f5edc0aba010da6b4 Mon Sep 17 00:00:00 2001\n> > From: Boris Brezillon \n> > Date: Tue, 12 Sep 2017 15:10:35 +0200\n> > Subject: [PATCH] mtd: spi-nor: Check consistency of the memory size extracted\n> > from the SFDP\n> >\n> > One field of the flash parameter table contains information about the\n> > flash device size.\n> > Most of the time the data extracted from this field is valid, but\n> > sometimes the BFPT section of the SFDP table is corrupted or invalid and\n> > this field is set to 0xffffffff, thus resulting in an integer overflow\n> > when setting params->size.\n> >\n> > Since NOR devices are anayway always smaller than 2^64 bytes, we can\n> > easily stop the BFPT parsing if the size reported in this table is\n> > invalid.\n> >\n> > Signed-off-by: Boris Brezillon \n> \n> Tested-by: Geert Uytterhoeven \n\nI'm just waiting for a review from Cyrille or Marek and if they are okay\nI'll queue both patches to l2-mtd and send a PR to Linus (hopefully\nbefore -rc1 is out).\n\nThanks for your help with this bug.\n\nRegards,\n\nBoris","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"kgZh0q5h\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsjLQ1MQMz9sNV\n\tfor ;\n\tWed, 13 Sep 2017 23:34:06 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds7nb-0001Ig-LM; Wed, 13 Sep 2017 13:33:51 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1ds7nX-0001G9-Nb\n\tfor linux-mtd@lists.infradead.org; Wed, 13 Sep 2017 13:33:50 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 0401120997; Wed, 13 Sep 2017 15:33:24 +0200 (CEST)","from bbrezillon (cpe-172-88-65-44.socal.res.rr.com [172.88.65.44])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 3C99B2076A;\n\tWed, 13 Sep 2017 15:33:12 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=7sURkWAg6EqtrOjA+OGSTX++1wCjrlU+zgkw7nEY1yE=;\n\tb=kgZh0q5hXJT4AR\n\t7Omedx88PLOibMwhhUh6CFKl9Jus3A5IC4IFTpVsyjpWMbb8O/boXcjLIMjxhMjHMrwfQDY8w58Vp\n\tMHYnkYv5F+XPuHFGBDw71djxJ1vBHUw0JcstLkU/Axf2B+NW6eSDLT7ylh5YMGvMrMNVx25Em91QT\n\tCuK8L7t6KbhSr7sPSgRoOquhZk4ro4di80Gw+ZLgbYEIE7qinrhkg3XSaN9XHGY739piHNSSAg9aG\n\tmq4iOucWD2OW9IRQC23vDqKrVrL+qGbT3dYheKbMRO26CHXeWMd8vTvacQTBSvEHGiGfVIY/hWF2X\n\tZwJh6jiKKdqr/leGh8NA==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 13 Sep 2017 15:33:05 +0200","From":"Boris Brezillon ","To":"Geert Uytterhoeven ","Subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","Message-ID":"<20170913153305.6cf50c4f@bbrezillon>","In-Reply-To":"","References":"\n\t<20170907185456.4631-1-cyrille.pitchen@wedev4u.fr>\n\t\n\t\n\t<20170912151236.33c5ad8f@bbrezillon>\n\t","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170913_063348_145291_45319B85 ","X-CRM114-Status":"GOOD ( 27.86 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Marek Vasut , Richard Weinberger ,\n\tBrian Norris ,\n\t\"linux-mtd@lists.infradead.org\" ,\n\tCyrille Pitchen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1768725,"web_url":"http://patchwork.ozlabs.org/comment/1768725/","msgid":"<80dd3940-c09d-f246-fbe7-c5533c2640c8@wedev4u.fr>","list_archive_url":null,"date":"2017-09-14T16:44:31","subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","submitter":{"id":70551,"url":"http://patchwork.ozlabs.org/api/people/70551/","name":"Cyrille Pitchen","email":"cyrille.pitchen@wedev4u.fr"},"content":"Le 12/09/2017 à 15:12, Boris Brezillon a écrit :\n> Hi Geert,\n> \n> On Mon, 11 Sep 2017 10:58:36 +0200\n> Geert Uytterhoeven wrote:\n> \n>> Hi Cyrille,\n>>\n>> On Thu, Sep 7, 2017 at 9:28 PM, Cyrille Pitchen\n>> wrote:\n>>>> Can you apply this patch on your tree then report me what was printed, please?\n>>>> I have an idea of the root cause of your issue then a potential work-around\n>>>> but I first need to validate my assumption to confirm that the work-around\n>>>> would actually work. \n>>\n>> +m25p80 spi0.0: DWORD1 = 0xffffffff\n>> +m25p80 spi0.0: DWORD2 = 0xffffffff\n>> +m25p80 spi0.0: DWORD3 = 0xffffffff\n>> +m25p80 spi0.0: DWORD4 = 0xffffffff\n>> +m25p80 spi0.0: DWORD5 = 0xffffffff\n>> +m25p80 spi0.0: DWORD6 = 0xffffffff\n>> +m25p80 spi0.0: DWORD7 = 0xffffffff\n>> +m25p80 spi0.0: DWORD8 = 0xffffffff\n>> +m25p80 spi0.0: DWORD9 = 0xffffffff\n>> +m25p80 spi0.0: DWORD10 = 0x00000000\n>> +m25p80 spi0.0: DWORD11 = 0x00000000\n>> +m25p80 spi0.0: DWORD12 = 0x00000000\n>> +m25p80 spi0.0: DWORD13 = 0x00000000\n>> +m25p80 spi0.0: DWORD14 = 0x00000000\n>> +m25p80 spi0.0: DWORD15 = 0x00000000\n>> +m25p80 spi0.0: DWORD16 = 0x00000000\n>> +m25p80 spi0.0: BFPT version 1.0 (length = 9)\n>>\n>>> If you could also dump the value of the 'addr' argument of\n>>> spi_nor_read_sfdp_dma_unsafe() just before the for () loop below in the\n>>> very same function. Actually, I suspect the SFDP tables of your SPI NOR \n>>\n>> +m25p80 spi0.0: addr = 0x448\n>>\n>>> memory sample to have been programmed with invalid values, neither\n>>> compliant with the JEDEC JESD216 specification nor with the Cypress\n>>> datasheet for this memory part. \n>>\n>> Sounds plausible.\n>> I get the same values when disabling DMA, so it's not due to bad DMA handling.\n>> All Renesas boards I have local or remote access to have spansion,s25fl512s.\n> \n> Can you try with the following patch?\n> \n> Thanks,\n> \n> Boris\n> \n> --->8---\n> From 000ff63fdb149d87d755483f5edc0aba010da6b4 Mon Sep 17 00:00:00 2001\n> From: Boris Brezillon \n> Date: Tue, 12 Sep 2017 15:10:35 +0200\n> Subject: [PATCH] mtd: spi-nor: Check consistency of the memory size extracted\n> from the SFDP\n> \n> One field of the flash parameter table contains information about the\n> flash device size.\n> Most of the time the data extracted from this field is valid, but\n> sometimes the BFPT section of the SFDP table is corrupted or invalid and\n> this field is set to 0xffffffff, thus resulting in an integer overflow\n> when setting params->size.\n> \n> Since NOR devices are anayway always smaller than 2^64 bytes, we can\n> easily stop the BFPT parsing if the size reported in this table is\n> invalid.\n> \n> Signed-off-by: Boris Brezillon \nAcked-by: Cyrille Pitchen \n\nwith few comments below:\n> ---\n> drivers/mtd/spi-nor/spi-nor.c | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c\n> index cf1d4a15e10a..665ccae1d090 100644\n> --- a/drivers/mtd/spi-nor/spi-nor.c\n> +++ b/drivers/mtd/spi-nor/spi-nor.c\n> @@ -2127,6 +2127,15 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,\n> \tparams->size = bfpt.dwords[BFPT_DWORD(2)];\n> \tif (params->size & BIT(31)) {\n> \t\tparams->size &= ~BIT(31);\n> +\n> +\t\t/*\n> +\t\t * Prevent overflows on params->size. Anyway, a NOR of 1^64\ntypo: should be 2^64\n> +\t\t * bytes is unlikely to exist so this error probably means\n\nHere the size is still expressed in bits, not yet in byte, the\nconversion is done right after this chunk.\n> +\t\t * the BFPT we are reading is corrupted/wrong.\n> +\t\t */\n> +\t\tif (params->size > 63)\n> +\t\t\treturn -EINVAL;\n> +\n> \t\tparams->size = 1ULL << params->size;\n> \t} else {\n> \t\tparams->size++;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"lRkqL49X\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtPY46wclz9sPs\n\tfor ;\n\tFri, 15 Sep 2017 02:45:43 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsXGN-0006Sv-SL; Thu, 14 Sep 2017 16:45:15 +0000","from smtp3-g21.free.fr ([212.27.42.3])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsXGH-0005gJ-Kd\n\tfor linux-mtd@lists.infradead.org; Thu, 14 Sep 2017 16:45:12 +0000","from mountainer.wedev4u.int (unknown [82.232.94.13])\n\tby smtp3-g21.free.fr (Postfix) with ESMTP id 2335F13F8B3;\n\tThu, 14 Sep 2017 18:44:32 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=2YyNf/z2Sz72uyrmBzCn4azNHXw20KaDzPMUEjnWVyU=;\n\tb=lRkqL49XsdgFJv\n\t7R9QahNJFJVY5CAzzjrp2N//oVppjvQ/pQuqLQYu6uk/amNZzAokDsz6qMj7qniL6VWBm+aK7i3yz\n\tUkikWnNIZSn3ndJ10aiAoftyV+PCPVU09aQvNL1aneR1fi5NiI0X9pzOkQEvxZ0UcLCpNIQnQgOlo\n\toZDle8EV8C3WDyFyDWf6xPvZ5rPf2qf2ptnzUgtteqRhSY0hPrmLsjKzaWLV4/50KonsgVhe6N2pf\n\tD+gACxHuDI0OtD3WBYFvC/v7ZB4+6birMK0nx0m1LY6oE+BCy0BPBWQYT8BL1j0TwLh3YlgL0qqfe\n\tWIjsbRsXmLTYD/QcOTRw==;","Subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","To":"Boris Brezillon ,\n\tGeert Uytterhoeven ","References":"\n\t<20170907185456.4631-1-cyrille.pitchen@wedev4u.fr>\n\t\n\t\n\t<20170912151236.33c5ad8f@bbrezillon>","From":"Cyrille Pitchen ","Message-ID":"<80dd3940-c09d-f246-fbe7-c5533c2640c8@wedev4u.fr>","Date":"Thu, 14 Sep 2017 18:44:31 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170912151236.33c5ad8f@bbrezillon>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170914_094510_099628_316ACE07 ","X-CRM114-Status":"GOOD ( 25.20 )","X-Spam-Score":"-0.2 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t1.7 URIBL_BLACK Contains an URL listed in the URIBL blacklist\n\t[URIs: wedev4u.com]\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [212.27.42.3 listed in list.dnswl.org]\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Richard Weinberger ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tMarek Vasut ,\n\tMTD Maling List ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1771356,"web_url":"http://patchwork.ozlabs.org/comment/1771356/","msgid":"<20170919221140.384e988a@bbrezillon>","list_archive_url":null,"date":"2017-09-19T20:11:40","subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","submitter":{"id":63120,"url":"http://patchwork.ozlabs.org/api/people/63120/","name":"Boris Brezillon","email":"boris.brezillon@free-electrons.com"},"content":"On Thu, 14 Sep 2017 18:44:31 +0200\nCyrille Pitchen wrote:\n\n> Le 12/09/2017 à 15:12, Boris Brezillon a écrit :\n> > Hi Geert,\n> > \n> > On Mon, 11 Sep 2017 10:58:36 +0200\n> > Geert Uytterhoeven wrote:\n> > \n> >> Hi Cyrille,\n> >>\n> >> On Thu, Sep 7, 2017 at 9:28 PM, Cyrille Pitchen\n> >> wrote: \n> >>>> Can you apply this patch on your tree then report me what was printed, please?\n> >>>> I have an idea of the root cause of your issue then a potential work-around\n> >>>> but I first need to validate my assumption to confirm that the work-around\n> >>>> would actually work. \n> >>\n> >> +m25p80 spi0.0: DWORD1 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD2 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD3 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD4 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD5 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD6 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD7 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD8 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD9 = 0xffffffff\n> >> +m25p80 spi0.0: DWORD10 = 0x00000000\n> >> +m25p80 spi0.0: DWORD11 = 0x00000000\n> >> +m25p80 spi0.0: DWORD12 = 0x00000000\n> >> +m25p80 spi0.0: DWORD13 = 0x00000000\n> >> +m25p80 spi0.0: DWORD14 = 0x00000000\n> >> +m25p80 spi0.0: DWORD15 = 0x00000000\n> >> +m25p80 spi0.0: DWORD16 = 0x00000000\n> >> +m25p80 spi0.0: BFPT version 1.0 (length = 9)\n> >> \n> >>> If you could also dump the value of the 'addr' argument of\n> >>> spi_nor_read_sfdp_dma_unsafe() just before the for () loop below in the\n> >>> very same function. Actually, I suspect the SFDP tables of your SPI NOR \n> >>\n> >> +m25p80 spi0.0: addr = 0x448\n> >> \n> >>> memory sample to have been programmed with invalid values, neither\n> >>> compliant with the JEDEC JESD216 specification nor with the Cypress\n> >>> datasheet for this memory part. \n> >>\n> >> Sounds plausible.\n> >> I get the same values when disabling DMA, so it's not due to bad DMA handling.\n> >> All Renesas boards I have local or remote access to have spansion,s25fl512s. \n> > \n> > Can you try with the following patch?\n> > \n> > Thanks,\n> > \n> > Boris\n> > \n> > --->8--- \n> > From 000ff63fdb149d87d755483f5edc0aba010da6b4 Mon Sep 17 00:00:00 2001\n> > From: Boris Brezillon \n> > Date: Tue, 12 Sep 2017 15:10:35 +0200\n> > Subject: [PATCH] mtd: spi-nor: Check consistency of the memory size extracted\n> > from the SFDP\n> > \n> > One field of the flash parameter table contains information about the\n> > flash device size.\n> > Most of the time the data extracted from this field is valid, but\n> > sometimes the BFPT section of the SFDP table is corrupted or invalid and\n> > this field is set to 0xffffffff, thus resulting in an integer overflow\n> > when setting params->size.\n> > \n> > Since NOR devices are anayway always smaller than 2^64 bytes, we can\n> > easily stop the BFPT parsing if the size reported in this table is\n> > invalid.\n> > \n> > Signed-off-by: Boris Brezillon \n> Acked-by: Cyrille Pitchen \n\nApplied after fixing the things you pointed below.\n\n> \n> with few comments below:\n> > ---\n> > drivers/mtd/spi-nor/spi-nor.c | 9 +++++++++\n> > 1 file changed, 9 insertions(+)\n> > \n> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c\n> > index cf1d4a15e10a..665ccae1d090 100644\n> > --- a/drivers/mtd/spi-nor/spi-nor.c\n> > +++ b/drivers/mtd/spi-nor/spi-nor.c\n> > @@ -2127,6 +2127,15 @@ static int spi_nor_parse_bfpt(struct spi_nor *nor,\n> > \tparams->size = bfpt.dwords[BFPT_DWORD(2)];\n> > \tif (params->size & BIT(31)) {\n> > \t\tparams->size &= ~BIT(31);\n> > +\n> > +\t\t/*\n> > +\t\t * Prevent overflows on params->size. Anyway, a NOR of 1^64 \n> typo: should be 2^64\n> > +\t\t * bytes is unlikely to exist so this error probably means \n> \n> Here the size is still expressed in bits, not yet in byte, the\n> conversion is done right after this chunk.\n> > +\t\t * the BFPT we are reading is corrupted/wrong.\n> > +\t\t */\n> > +\t\tif (params->size > 63)\n> > +\t\t\treturn -EINVAL;\n> > +\n> > \t\tparams->size = 1ULL << params->size;\n> > \t} else {\n> > \t\tparams->size++;\n> > \n> \n> \n> ______________________________________________________\n> Linux MTD discussion mailing list\n> http://lists.infradead.org/mailman/listinfo/linux-mtd/","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Ypryv3o6\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxYvQ67D9z9sBW\n\tfor ;\n\tWed, 20 Sep 2017 06:12:34 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duOsa-000807-Hd; Tue, 19 Sep 2017 20:12:24 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duOsS-0007bI-2B\n\tfor linux-mtd@lists.infradead.org; Tue, 19 Sep 2017 20:12:22 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 07F2020899; Tue, 19 Sep 2017 22:11:52 +0200 (CEST)","from bbrezillon (unknown [91.160.177.164])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id AFD6520752;\n\tTue, 19 Sep 2017 22:11:41 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=QekVlDDepPwZmyB3C0eOahY4yHmVkcxeYLTjTEljxXw=;\n\tb=Ypryv3o6OO56gB\n\t6WyQ+bo+2fty059IkaYrnt+bMy+ZVfQpLpHYmZu9H791hdvAri7ye3INyKezoW+MzFxeQCqhcRdw0\n\tN6X+lClhEnoniwXJzJXEwYxzli3Sx0jvh6V/70V+TSk4p1wFh/2msQW6jvLmOcKVAZguPypGWeB6S\n\tzFvgnEGgmZaWg6e+AYpi8PcyQ4wZBACnk8gxhu+lXcVj8j1T1CQBlJ/DvEuy1o0fX5DyB/53Ha4a5\n\tLNx+SDaqmrkkc5/YyLO3BXYQymEW8yIoNHT7obifPrvPFrOJtsb2IEV7c0I0xKM7FAMAyQC7Hoxl0\n\tM5gcpTu4WS+p3flmbOww==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 19 Sep 2017 22:11:40 +0200","From":"Boris Brezillon ","To":"Cyrille Pitchen ","Subject":"Re: [DEBUG] mtd: spi-nor: dump DWORDs of the Basic Flash Parameter\n\tTable","Message-ID":"<20170919221140.384e988a@bbrezillon>","In-Reply-To":"<80dd3940-c09d-f246-fbe7-c5533c2640c8@wedev4u.fr>","References":"\n\t<20170907185456.4631-1-cyrille.pitchen@wedev4u.fr>\n\t\n\t\n\t<20170912151236.33c5ad8f@bbrezillon>\n\t<80dd3940-c09d-f246-fbe7-c5533c2640c8@wedev4u.fr>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_131216_692967_AF7266B4 ","X-CRM114-Status":"GOOD ( 31.54 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Richard Weinberger ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tMarek Vasut ,\n\tGeert Uytterhoeven , \n\tMTD Maling List ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]