[{"id":1764683,"web_url":"http://patchwork.ozlabs.org/comment/1764683/","msgid":"<92500143-814b-b255-bb7b-c36d5eca5457@arm.com>","list_archive_url":null,"date":"2017-09-07T12:04:41","subject":"Re: [PATCH v4 3/6] irqdomain: move IRQ_DOMAIN_NAME_ALLOCATED define\n\tto the original position","submitter":{"id":7353,"url":"http://patchwork.ozlabs.org/api/people/7353/","name":"Marc Zyngier","email":"marc.zyngier@arm.com"},"content":"On 07/09/17 12:41, Masahiro Yamada wrote:\n> Commit 6a6544e520ab (\"genirq/irqdomain: Remove auto-recursive hierarchy\n> support\") not only deleted IRQ_DOMAIN_FLAG_AUTO_RECURSIVE, but also\n> moved IRQ_DOMAIN_NAME_ALLOCATED up.\n> \n> Get it back to the original position to sort the enum by the bit shift.\n> \n> Signed-off-by: Masahiro Yamada \n> ---\n> \n> Changes in v4:\n> - Newly added\n> \n> \n> include/linux/irqdomain.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h\n> index 81e4889..31be32d 100644\n> --- a/include/linux/irqdomain.h\n> +++ b/include/linux/irqdomain.h\n> @@ -180,9 +180,6 @@ enum {\n> \t/* Irq domain is hierarchical */\n> \tIRQ_DOMAIN_FLAG_HIERARCHY\t= (1 << 0),\n> \n> -\t/* Irq domain name was allocated in __irq_domain_add() */\n> -\tIRQ_DOMAIN_NAME_ALLOCATED\t= (1 << 6),\n> -\n> \t/* Irq domain is an IPI domain with virq per cpu */\n> \tIRQ_DOMAIN_FLAG_IPI_PER_CPU\t= (1 << 2),\n> \n> @@ -195,6 +192,9 @@ enum {\n> \t/* Irq domain implements MSI remapping */\n> \tIRQ_DOMAIN_FLAG_MSI_REMAP\t= (1 << 5),\n> \n> +\t/* Irq domain name was allocated in __irq_domain_add() */\n> +\tIRQ_DOMAIN_NAME_ALLOCATED\t= (1 << 6),\n> +\n\nThe right fix would be to leave it where it is, but to actually fix the\nshift, which is what I should have done the first place.\n\n\tM.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnzfR3bW8z9sMN\n\tfor ;\n\tThu, 7 Sep 2017 22:05:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755272AbdIGMEr (ORCPT );\n\tThu, 7 Sep 2017 08:04:47 -0400","from foss.arm.com ([217.140.101.70]:59148 \"EHLO foss.arm.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1755153AbdIGMEp (ORCPT );\n\tThu, 7 Sep 2017 08:04:45 -0400","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C53881529;\n\tThu, 7 Sep 2017 05:04:44 -0700 (PDT)","from [10.1.206.41] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\tEA1E73F578; Thu, 7 Sep 2017 05:04:42 -0700 (PDT)"],"Subject":"Re: [PATCH v4 3/6] irqdomain: move IRQ_DOMAIN_NAME_ALLOCATED define\n\tto the original position","To":"Masahiro Yamada ,\n\tThomas Gleixner ,\n\tLinus Walleij ,\n\tlinux-gpio@vger.kernel.org, Rob Herring ","Cc":"Jassi Brar ,\n\tdevicetree@vger.kernel.org, Jason Cooper ,\n\tMasami Hiramatsu ,\n\tDavid Daney , linux-kernel@vger.kernel.org","References":"<1504784522-26841-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1504784522-26841-4-git-send-email-yamada.masahiro@socionext.com>","From":"Marc Zyngier ","Organization":"ARM Ltd","Message-ID":"<92500143-814b-b255-bb7b-c36d5eca5457@arm.com>","Date":"Thu, 7 Sep 2017 13:04:41 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1504784522-26841-4-git-send-email-yamada.masahiro@socionext.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1765451,"web_url":"http://patchwork.ozlabs.org/comment/1765451/","msgid":"","list_archive_url":null,"date":"2017-09-08T15:10:36","subject":"Re: [PATCH v4 3/6] irqdomain: move IRQ_DOMAIN_NAME_ALLOCATED define\n\tto the original position","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"2017-09-07 21:04 GMT+09:00 Marc Zyngier :\n> On 07/09/17 12:41, Masahiro Yamada wrote:\n>> Commit 6a6544e520ab (\"genirq/irqdomain: Remove auto-recursive hierarchy\n>> support\") not only deleted IRQ_DOMAIN_FLAG_AUTO_RECURSIVE, but also\n>> moved IRQ_DOMAIN_NAME_ALLOCATED up.\n>>\n>> Get it back to the original position to sort the enum by the bit shift.\n>>\n>> Signed-off-by: Masahiro Yamada \n>> ---\n>>\n>> Changes in v4:\n>> - Newly added\n>>\n>>\n>> include/linux/irqdomain.h | 6 +++---\n>> 1 file changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h\n>> index 81e4889..31be32d 100644\n>> --- a/include/linux/irqdomain.h\n>> +++ b/include/linux/irqdomain.h\n>> @@ -180,9 +180,6 @@ enum {\n>> /* Irq domain is hierarchical */\n>> IRQ_DOMAIN_FLAG_HIERARCHY = (1 << 0),\n>>\n>> - /* Irq domain name was allocated in __irq_domain_add() */\n>> - IRQ_DOMAIN_NAME_ALLOCATED = (1 << 6),\n>> -\n>> /* Irq domain is an IPI domain with virq per cpu */\n>> IRQ_DOMAIN_FLAG_IPI_PER_CPU = (1 << 2),\n>>\n>> @@ -195,6 +192,9 @@ enum {\n>> /* Irq domain implements MSI remapping */\n>> IRQ_DOMAIN_FLAG_MSI_REMAP = (1 << 5),\n>>\n>> + /* Irq domain name was allocated in __irq_domain_add() */\n>> + IRQ_DOMAIN_NAME_ALLOCATED = (1 << 6),\n>> +\n>\n> The right fix would be to leave it where it is, but to actually fix the\n> shift, which is what I should have done the first place.\n\n\nYou are definitely right.\n\nAt first, I missed the fact that (1 << 6) was already used,\nthen I assigned the same value to my new flag.\n\nSo, I tried to fix the list before adding my new one.\n\n\nWithout 5/6, I do not have a good reason to\npush this cosmetic patch only.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"kPu9Ge4r\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpglP2wmQz9s8J\n\tfor ;\n\tSat, 9 Sep 2017 01:11:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756491AbdIHPLb (ORCPT );\n\tFri, 8 Sep 2017 11:11:31 -0400","from conssluserg-06.nifty.com ([210.131.2.91]:63234 \"EHLO\n\tconssluserg-06.nifty.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1756469AbdIHPLa (ORCPT\n\t); Fri, 8 Sep 2017 11:11:30 -0400","from mail-yw0-f172.google.com (mail-yw0-f172.google.com\n\t[209.85.161.172]) (authenticated)\n\tby conssluserg-06.nifty.com with ESMTP id v88FBHU1018069;\n\tSat, 9 Sep 2017 00:11:17 +0900","by mail-yw0-f172.google.com with SMTP id s62so8329233ywg.0;\n\tFri, 08 Sep 2017 08:11:17 -0700 (PDT)","by 10.37.164.225 with HTTP; Fri, 8 Sep 2017 08:10:36 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com v88FBHU1018069","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1504883478;\n\tbh=smEkTAHZgttVdH6rWdOFkVw+dv334g/SHM86rwWfrws=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=kPu9Ge4ra97UASHLMZ63aM1mOmlrPbSuXRyS9C7SFfsXIiZqC5/+AIxWZLiSgyQT7\n\t5cW78oCS7dHSnaQmdTPPvQYdh88/3W3AROnPgliQMlDEu4Qkxxh6j+1XAt+n4uXebY\n\t4w1fdqNhYBVH7HpwpMNhmm7kBUkkn1R9JSYa22poJ8cECnSBIXhQUOJ0JThStqqRrs\n\tjJDbBVyJ9fAoh/iZd+F2J4n0vEAymrinplen9Le2FmGcA3Uz1j4SnNTmK2J8D2GOZ6\n\t/ju2yl1GUIRuUIakN0WfUHRo74ijBLElMfxd1COMTqlZhyOq5qyFsUt3FsO+cPruoR\n\tKb+akjebN5LSA==","X-Nifty-SrcIP":"[209.85.161.172]","X-Gm-Message-State":"AHPjjUhzutZiRYwmFg+6HCcKvOlYeYXwGy9Lg2H5787d3pMWxULumwLm\n\t/ltzyhTlSChd3/1MsexQqF2VA6Lb6Q==","X-Google-Smtp-Source":"ADKCNb7woqtIKImEZUX/LE6V9U4b8Ahusflh4QpBv2/ldhv0BOhRgRVoTeaYWPoNdb1zK0JKBmdFQyzSySwkMeariTQ=","X-Received":"by 10.129.121.4 with SMTP id u4mr2871647ywc.71.1504883476759;\n\tFri, 08 Sep 2017 08:11:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<92500143-814b-b255-bb7b-c36d5eca5457@arm.com>","References":"<1504784522-26841-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1504784522-26841-4-git-send-email-yamada.masahiro@socionext.com>\n\t<92500143-814b-b255-bb7b-c36d5eca5457@arm.com>","From":"Masahiro Yamada ","Date":"Sat, 9 Sep 2017 00:10:36 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v4 3/6] irqdomain: move IRQ_DOMAIN_NAME_ALLOCATED define\n\tto the original position","To":"Marc Zyngier ","Cc":"Thomas Gleixner ,\n\tLinus Walleij ,\n\tlinux-gpio@vger.kernel.org, Rob Herring ,\n\tJassi Brar ,\n\tdevicetree@vger.kernel.org, Jason Cooper ,\n\tMasami Hiramatsu ,\n\tDavid Daney ,\n\tLinux Kernel Mailing List ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]