[{"id":1764661,"web_url":"http://patchwork.ozlabs.org/comment/1764661/","msgid":"<20170907112917.GA28053@spreadtrum.com>","list_archive_url":null,"date":"2017-09-07T11:29:18","subject":"Re: [PATCH 2/2] pinctrl: sprd: fix off by one bugs","submitter":{"id":71631,"url":"http://patchwork.ozlabs.org/api/people/71631/","name":"Baolin Wang","email":"baolin.wang@spreadtrum.com"},"content":"On ε››, 9月 07, 2017 at 02:12:05δΈ‹εˆ +0300, Dan Carpenter wrote:\n> info->groups[] has info->ngroups elements so these comparisons should be\n> >= instead of >.\n> \n> Fixes: 41d32cfce1ae (\"pinctrl: sprd: Add Spreadtrum pin control driver\")\n> Signed-off-by: Dan Carpenter \n\nThanks for fixing my mistakes, please add my tag if it is useful.\nReviewed-by: Baolin Wang \n\n> \n> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c\n> index 673b77bbbc8c..939e1bbf6253 100644\n> --- a/drivers/pinctrl/sprd/pinctrl-sprd.c\n> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c\n> @@ -400,7 +400,7 @@ static int sprd_pmx_set_mux(struct pinctrl_dev *pctldev,\n> \tunsigned long reg;\n> \tunsigned int val = 0;\n> \n> -\tif (group_selector > info->ngroups)\n> +\tif (group_selector >= info->ngroups)\n> \t\treturn -EINVAL;\n> \n> \tswitch (func_selector) {\n> @@ -734,7 +734,7 @@ static int sprd_pinconf_group_get(struct pinctrl_dev *pctldev,\n> \tstruct sprd_pin_group *grp;\n> \tunsigned int pin_id;\n> \n> -\tif (selector > info->ngroups)\n> +\tif (selector >= info->ngroups)\n> \t\treturn -EINVAL;\n> \n> \tgrp = &info->groups[selector];\n> @@ -753,7 +753,7 @@ static int sprd_pinconf_group_set(struct pinctrl_dev *pctldev,\n> \tstruct sprd_pin_group *grp;\n> \tint ret, i;\n> \n> -\tif (selector > info->ngroups)\n> +\tif (selector >= info->ngroups)\n> \t\treturn -EINVAL;\n> \n> \tgrp = &info->groups[selector];\n> @@ -813,7 +813,7 @@ static void sprd_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,\n> \tconst char *name;\n> \tint i, ret;\n> \n> -\tif (selector > info->ngroups)\n> +\tif (selector >= info->ngroups)\n> \t\treturn;\n> \n> \tgrp = &info->groups[selector];\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xnysx3F8Hz9sCZ\n\tfor ;\n\tThu, 7 Sep 2017 21:29:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754862AbdIGL34 (ORCPT );\n\tThu, 7 Sep 2017 07:29:56 -0400","from sci-ig2.spreadtrum.com ([222.66.158.135]:17043 \"EHLO\n\tSHSQR01.spreadtrum.com\" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754495AbdIGL3z (ORCPT\n\t); Thu, 7 Sep 2017 07:29:55 -0400","from ig2.spreadtrum.com (shmbx04.spreadtrum.com [10.0.1.214])\n\tby SHSQR01.spreadtrum.com with ESMTP id v87BTKD6051816\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);\n\tThu, 7 Sep 2017 19:29:20 +0800 (CST)\n\t(envelope-from Baolin.Wang@spreadtrum.com)","from SHCAS02.spreadtrum.com (10.0.1.202) by SHMBX04.spreadtrum.com\n\t(10.0.1.214) with Microsoft SMTP Server (TLS) id 15.0.847.32;\n\tThu, 7 Sep 2017 19:29:23 +0800","from spreadtrum.com (10.0.73.143) by SHCAS02.spreadtrum.com\n\t(10.0.1.250) with Microsoft SMTP Server (TLS) id 15.0.847.32 via\n\tFrontend Transport; Thu, 7 Sep 2017 19:29:23 +0800"],"Date":"Thu, 7 Sep 2017 19:29:18 +0800","From":"Baolin Wang ","To":"Dan Carpenter ","CC":"Linus Walleij ,\n\t, ","Subject":"Re: [PATCH 2/2] pinctrl: sprd: fix off by one bugs","Message-ID":"<20170907112917.GA28053@spreadtrum.com>","Mail-Followup-To":"Dan Carpenter ,\n\tLinus Walleij ,\n\tlinux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org","References":"<20170907072926.56oqezwk4r72yjgt@mwanda>\n\t<20170907073211.zgcgmdfrphtqy3d7@mwanda>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20170907073211.zgcgmdfrphtqy3d7@mwanda>","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-MAIL":"SHSQR01.spreadtrum.com v87BTKD6051816","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1766814,"web_url":"http://patchwork.ozlabs.org/comment/1766814/","msgid":"","list_archive_url":null,"date":"2017-09-12T09:28:19","subject":"Re: [PATCH 2/2] pinctrl: sprd: fix off by one bugs","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Thu, Sep 7, 2017 at 1:12 PM, Dan Carpenter wrote:\n\n> info->groups[] has info->ngroups elements so these comparisons should be\n>>= instead of >.\n>\n> Fixes: 41d32cfce1ae (\"pinctrl: sprd: Add Spreadtrum pin control driver\")\n> Signed-off-by: Dan Carpenter \n\nPatch applied with Baolin's review tag.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"WqRukBdi\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrzxP1S8Cz9s7f\n\tfor ;\n\tTue, 12 Sep 2017 19:28:25 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751433AbdILJ2W (ORCPT );\n\tTue, 12 Sep 2017 05:28:22 -0400","from mail-it0-f52.google.com ([209.85.214.52]:38777 \"EHLO\n\tmail-it0-f52.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751214AbdILJ2U (ORCPT\n\t); Tue, 12 Sep 2017 05:28:20 -0400","by mail-it0-f52.google.com with SMTP id c195so27042903itb.1\n\tfor ;\n\tTue, 12 Sep 2017 02:28:20 -0700 (PDT)","by 10.79.164.78 with HTTP; Tue, 12 Sep 2017 02:28:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=wzHv5sjEytFAfisBa1SWORHGQx2XElwCTNxOvJfDPak=;\n\tb=WqRukBdizipDi606DYyvOq7da5IUl0PdfPh5k4jaye5p1kuzgSXrQFTTVNi75FQ5Vx\n\tkAwKSX63Xjx8h8kXQGslgR/siyziC/rDLmtIPwB502zTS5cGeunWjUD3vQ6QjkZDfNXF\n\tsX24JArOYfed8jKIS49JhO6mNlbohaC6rjvqk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=wzHv5sjEytFAfisBa1SWORHGQx2XElwCTNxOvJfDPak=;\n\tb=XxLMy6enffnxKEgN9jsJHzhDAb5LcMMkLkWKIy1DDj7ojgDWBuNR/NQmGi7kJX/kVo\n\t2W5szy/lQYFga9f5pdUJaJpNc6wQ1VFc5YtESFFRPnxPwMiOcTVMFKF1OHEXwcUOoH9m\n\tLXz3DjkltKrRT9OLfa+tlQrly1zJhsYVt+jvurvIZv6nTz2mkedhedPMOIoqRr4uye8c\n\tgIgCnk/Y2iTrN00sczNUDi+qtCAHA4ervUNLnkfnbT/J3LRx4EizRAQ72ue3W+HKHWmk\n\tHn/21VjfqRdbd1+h2FiTFcdNRZ4oAYj580RNGACsUX4GMgCByXi81SD54XQT7N6wpLPB\n\txJLA==","X-Gm-Message-State":"AHPjjUi23ms6tLIX2mO7t1r3raGVdhNK69D0fdUkTEevzU5RGhmH37AL\n\tKLoBh6AMc/eBE+cylcuaZwfZ51PyoGqBQOBZY9KLUUb5","X-Google-Smtp-Source":"AOwi7QAfeBuA86IJsDjEPQxVxopQ1YIQZZNFDKvvCFKJQCOHEuAfOYGQ+G4EtKTe/4zPW2GwxHJFa0q7bEnbBFEZClo=","X-Received":"by 10.36.123.200 with SMTP id q191mr107852itc.83.1505208499904; \n\tTue, 12 Sep 2017 02:28:19 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170907073211.zgcgmdfrphtqy3d7@mwanda>","References":"<20170907072926.56oqezwk4r72yjgt@mwanda>\n\t<20170907073211.zgcgmdfrphtqy3d7@mwanda>","From":"Linus Walleij ","Date":"Tue, 12 Sep 2017 11:28:19 +0200","Message-ID":"","Subject":"Re: [PATCH 2/2] pinctrl: sprd: fix off by one bugs","To":"Dan Carpenter ","Cc":"Baolin Wang ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\tkernel-janitors@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]