[{"id":1768210,"web_url":"http://patchwork.ozlabs.org/comment/1768210/","msgid":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EAA2C6@ORSMSX104.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-13T21:44:39","subject":"Re: [Intel-wired-lan] [RFC PATCH v3 3/6] i40e: Add infrastructure\n\tfor queue channel support","submitter":{"id":66945,"url":"http://patchwork.ozlabs.org/api/people/66945/","name":"Bowers, AndrewX","email":"andrewx.bowers@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On\n> Behalf Of Amritha Nambiar\n> Sent: Thursday, September 7, 2017 4:00 AM\n> To: intel-wired-lan@lists.osuosl.org; Kirsher, Jeffrey T\n> <jeffrey.t.kirsher@intel.com>\n> Cc: netdev@vger.kernel.org\n> Subject: [Intel-wired-lan] [RFC PATCH v3 3/6] i40e: Add infrastructure for\n> queue channel support\n> \n> This patch sets up the infrastructure for offloading TCs and queue\n> configurations to the hardware by creating HW channels(VSI).\n> A new channel is created for each of the traffic class configuration offloaded\n> via mqprio framework except for the first TC (TC0). TC0 for the main VSI is\n> also reconfigured as per user provided queue parameters. Queue counts\n> that are not power-of-2 are handled by reconfiguring RSS by reprogramming\n> LUTs using the queue count value.\n> This patch also handles configuring the TX rings for the channels, setting up\n> the RX queue map for channel.\n> \n> Also, the channels so created are removed and all the queue configuration is\n> set to default when the qdisc is detached from the root of the device.\n> \n> v3: Addressed Shannon's feedback removing unwanted code, variables,\n> atomic operations (since setup_tc is protected with rtnl_lock held by stack)\n> and other minor clean up.\n> \n> Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com>\n> Signed-off-by: Kiran Patil <kiran.patil@intel.com>\n> ---\n>  drivers/net/ethernet/intel/i40e/i40e.h      |   32 +\n>  drivers/net/ethernet/intel/i40e/i40e_main.c |  718\n> +++++++++++++++++++++++++++\n>  drivers/net/ethernet/intel/i40e/i40e_txrx.h |    2\n>  3 files changed, 743 insertions(+), 9 deletions(-)\n\nTested-by: Andrew Bowers <andrewx.bowers@intel.com>","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=<UNKNOWN>)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xswDZ6JYYz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Sep 2017 07:44:46 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 245A030E6F;\n\tWed, 13 Sep 2017 21:44:45 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id cYhlhjMA4vHd; Wed, 13 Sep 2017 21:44:43 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id A87C6258E6;\n\tWed, 13 Sep 2017 21:44:43 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 526651C3F94\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Sep 2017 21:44:42 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4B7048A49D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Sep 2017 21:44:42 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SJOS1eXdP-dj for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Sep 2017 21:44:41 +0000 (UTC)","from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 9C0018A485\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Sep 2017 21:44:41 +0000 (UTC)","from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga104.jf.intel.com with ESMTP; 13 Sep 2017 14:44:41 -0700","from orsmsx108.amr.corp.intel.com ([10.22.240.6])\n\tby fmsmga005.fm.intel.com with ESMTP; 13 Sep 2017 14:44:41 -0700","from orsmsx163.amr.corp.intel.com (10.22.240.88) by\n\tORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Wed, 13 Sep 2017 14:44:40 -0700","from orsmsx104.amr.corp.intel.com ([169.254.4.142]) by\n\tORSMSX163.amr.corp.intel.com ([169.254.9.160]) with mapi id\n\t14.03.0319.002; Wed, 13 Sep 2017 14:44:40 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,389,1500966000\"; d=\"scan'208\";a=\"151031651\"","From":"\"Bowers, AndrewX\" <andrewx.bowers@intel.com>","To":"\"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>","Thread-Topic":"[Intel-wired-lan] [RFC PATCH v3 3/6] i40e: Add infrastructure\n\tfor queue channel support","Thread-Index":"AQHTJ8iuwRCo3Q1szki61woq2AZouaKzY1XA","Date":"Wed, 13 Sep 2017 21:44:39 +0000","Message-ID":"<26D9FDECA4FBDD4AADA65D8E2FC68A4A10EAA2C6@ORSMSX104.amr.corp.intel.com>","References":"<150478158684.24662.17975701233699487888.stgit@anamdev.jf.intel.com>\n\t<150478201697.24662.17031847488335081374.stgit@anamdev.jf.intel.com>","In-Reply-To":"<150478201697.24662.17031847488335081374.stgit@anamdev.jf.intel.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTJmN2Q3NzQtNGQyNS00NTVmLTg1ZWEtZjk5OThiOTE0OWZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImM0Z0d5V1ZSZlcrSUhNWDR6bGcwdFdKY2VNR1BUQVZjXC84OFluWHdZeGM4PSJ9","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.138]","MIME-Version":"1.0","Subject":"Re: [Intel-wired-lan] [RFC PATCH v3 3/6] i40e: Add infrastructure\n\tfor queue channel support","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}}]