[{"id":1764768,"web_url":"http://patchwork.ozlabs.org/comment/1764768/","msgid":"","list_archive_url":null,"date":"2017-09-07T14:45:20","subject":"Re: [PATCH 3/3] powerpc64le: Disable compiler support for float128\n\twhen reusing ldbl-128","submitter":{"id":4349,"url":"http://patchwork.ozlabs.org/api/people/4349/","name":"Joseph Myers","email":"joseph@codesourcery.com"},"content":"On Thu, 7 Sep 2017, Gabriel F. T. Gomes wrote:\n\n> Some files under sysdeps/ieee754/ldbl-128ibm are able to reuse the\n> implementation in sysdeps/ieee754/ldbl-128 by defining _Float128 to long\n> double. This relies on compiler support for _Float128 being disabled.\n> \n> On powerpc, such support is currently disabled by default, however, it\n> will get enabled by default [1], requiring that this Makefile actively\n> disable compiler support for float128 for the required files.\n\nI think it would be better to stop #include of ldbl-128 files from \nldbl-128ibm. That is, copy the relevant source files (in the case of \ne_expl.c that's actually t_expl.h) to ldbl-128ibm, with _Float128 \nconverted to long double and L() also expanded back to adding L suffixes. \nAnd, in the e_lgammal_r.c case, then eliminate the present LDBL_MANT_DIG \nconditionals from both copies.\n\nLong term I'd like the ldbl-128 files to e.g. use f128 constant suffixes \ndirectly (once we can assume GCC >= 7 to build glibc), with such changes \ncleaning up the code but being incompatible with its use also for \nldbl-128ibm.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list libc-alpha@sourceware.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=sourceware.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=libc-alpha-return-84299-incoming=patchwork.ozlabs.org@sourceware.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tsecure) header.d=sourceware.org header.i=@sourceware.org\n\theader.b=\"iPL65F9e\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp3Cq4tNRz9sRY\n\tfor ;\n\tFri, 8 Sep 2017 00:45:43 +1000 (AEST)","(qmail 31487 invoked by alias); 7 Sep 2017 14:45:36 -0000","(qmail 31459 invoked by uid 89); 7 Sep 2017 14:45:35 -0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; q=dns; s=default; b=QnOkm\n\tWud2ftLdK2Q1FpHfaYAQ6kqvHE+UZC33S4mnP1jnXyW7/AW9GrlOxwSlPUZ+tiNq\n\tfox0wKTYJCxrf/3jiez7X14YCkPBKyfOauWUAveBBWPT1ac56ZxKjQEZ50g3T/Ws\n\tpJpLdJxwZFWzQn64xWPhSTvTdl0YkviPCQroDc=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id\n\t:list-unsubscribe:list-subscribe:list-archive:list-post\n\t:list-help:sender:date:from:to:cc:subject:in-reply-to:message-id\n\t:references:mime-version:content-type; s=default; bh=BU1ZyAKj/r1\n\tWdLDF76CMqqyRJkk=; b=iPL65F9eRypA58pNVIWcrwe3+dBerjqIMVVCc/bDszY\n\t3hV9H5pm2LFwgvsIko1Aom91zG3YpQCKnWcho/EBkc7gT10c/2MHR5BCOCktkmwi\n\tINi+aHoFSKeRRgYpBLIUptYA3IR7J/+mgAk9kccyuxA+lXwf3S9DEfbhcHfxYJac\n\t=","Mailing-List":"contact libc-alpha-help@sourceware.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Subscribe":"","List-Archive":"","List-Post":"","List-Help":",\n\t","Sender":"libc-alpha-owner@sourceware.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.0 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE, SPF_PASS,\n\tURIBL_RED autolearn=ham version=3.3.2 spammy=Hx-languages-length:1217","X-HELO":"relay1.mentorg.com","Date":"Thu, 7 Sep 2017 14:45:20 +0000","From":"Joseph Myers ","To":"\"Gabriel F. T. Gomes\" ","CC":"","Subject":"Re: [PATCH 3/3] powerpc64le: Disable compiler support for float128\n\twhen reusing ldbl-128","In-Reply-To":"<20170907104352.7748-4-gabriel@inconstante.eti.br>","Message-ID":"","References":"<20170907104352.7748-1-gabriel@inconstante.eti.br>\n\t<20170907104352.7748-4-gabriel@inconstante.eti.br>","User-Agent":"Alpine 2.20 (DEB 67 2015-01-07)","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"US-ASCII\"","X-ClientProxiedBy":"svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To\n\tsvr-ies-mbx-01.mgc.mentorg.com (139.181.222.1)"}}]