[{"id":1778579,"web_url":"http://patchwork.ozlabs.org/comment/1778579/","msgid":"<f5096c39-6026-d912-f283-ba7511fa4e93@nvidia.com>","list_archive_url":null,"date":"2017-10-02T20:24:04","subject":"Re: [PATCH 3/4] reset: tegra: check BPMP response return code","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 07/09/17 10:31, Timo Alho wrote:\n> Add checks for return code in BPMP response message.\n> \n> Signed-off-by: Timo Alho <talho@nvidia.com>\n> ---\n>  drivers/reset/tegra/reset-bpmp.c | 9 ++++++++-\n>  1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c\n> index 5daf2ee..fac2db6 100644\n> --- a/drivers/reset/tegra/reset-bpmp.c\n> +++ b/drivers/reset/tegra/reset-bpmp.c\n> @@ -23,6 +23,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,\n>  \tstruct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);\n>  \tstruct mrq_reset_request request;\n>  \tstruct tegra_bpmp_message msg;\n> +\tint err;\n>  \n>  \tmemset(&request, 0, sizeof(request));\n>  \trequest.cmd = command;\n> @@ -33,7 +34,13 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,\n>  \tmsg.tx.data = &request;\n>  \tmsg.tx.size = sizeof(request);\n>  \n> -\treturn tegra_bpmp_transfer(bpmp, &msg);\n> +\terr = tegra_bpmp_transfer(bpmp, &msg);\n> +\tif (err < 0)\n> +\t\treturn err;\n> +\telse if (msg.rx.ret < 0)\n> +\t\treturn -EINVAL;\n> +\n> +\treturn 0;\n>  }\n>  \n>  static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,\n\nAcked-by: Jon Hunter <jonathanh@nvidia.com>\n\nCheers\nJon","headers":{"Return-Path":"<linux-tegra-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5YYx5gGkz9rxm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  3 Oct 2017 07:25:09 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751265AbdJBUZI (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tMon, 2 Oct 2017 16:25:08 -0400","from hqemgate15.nvidia.com ([216.228.121.64]:16359 \"EHLO\n\thqemgate15.nvidia.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751296AbdJBUZH (ORCPT\n\t<rfc822; linux-tegra@vger.kernel.org>); Mon, 2 Oct 2017 16:25:07 -0400","from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by\n\thqemgate15.nvidia.com\n\tid <B59d2a0890003>; Mon, 02 Oct 2017 13:24:44 -0700","from HQMAIL105.nvidia.com ([172.20.161.6])\n\tby hqpgpgate101.nvidia.com (PGP Universal service);\n\tMon, 02 Oct 2017 13:24:50 -0700","from UKMAIL101.nvidia.com (10.26.138.13) by HQMAIL105.nvidia.com\n\t(172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1293.2;\n\tMon, 2 Oct 2017 20:24:09 +0000","from [10.26.11.81] (10.26.11.81) by UKMAIL101.nvidia.com\n\t(10.26.138.13) with Microsoft SMTP Server (TLS) id 15.0.1293.2;\n\tMon, 2 Oct 2017 20:24:06 +0000"],"X-PGP-Universal":"processed;\n\tby hqpgpgate101.nvidia.com on Mon, 02 Oct 2017 13:24:50 -0700","Subject":"Re: [PATCH 3/4] reset: tegra: check BPMP response return code","To":"Timo Alho <talho@nvidia.com>, <thierry.reding@gmail.com>","CC":"<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>","References":"<cover.1504776489.git.talho@nvidia.com>\n\t<00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com>","From":"Jon Hunter <jonathanh@nvidia.com>","Message-ID":"<f5096c39-6026-d912-f283-ba7511fa4e93@nvidia.com>","Date":"Mon, 2 Oct 2017 21:24:04 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com>","X-Originating-IP":"[10.26.11.81]","X-ClientProxiedBy":"UKMAIL102.nvidia.com (10.26.138.15) To\n\tUKMAIL101.nvidia.com (10.26.138.13)","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-tegra.vger.kernel.org>","X-Mailing-List":"linux-tegra@vger.kernel.org"}},{"id":1788225,"web_url":"http://patchwork.ozlabs.org/comment/1788225/","msgid":"<20171017104043.GB30589@ulmo>","list_archive_url":null,"date":"2017-10-17T10:40:43","subject":"Re: [PATCH 3/4] reset: tegra: check BPMP response return code","submitter":{"id":26234,"url":"http://patchwork.ozlabs.org/api/people/26234/","name":"Thierry Reding","email":"thierry.reding@gmail.com"},"content":"On Thu, Sep 07, 2017 at 12:31:03PM +0300, Timo Alho wrote:\n> Add checks for return code in BPMP response message.\n> \n> Signed-off-by: Timo Alho <talho@nvidia.com>\n> ---\n>  drivers/reset/tegra/reset-bpmp.c | 9 ++++++++-\n>  1 file changed, 8 insertions(+), 1 deletion(-)\n\nHi Philipp,\n\nWould you provide an Acked-by on this so that I can take it into the\nTegra tree? There's a build dependency on patch 1/4 in the series.\n\nQuoting in full since you were not previously on Cc, unfortunately.\n\nTimo, please remember to always Cc the relevant maintainers.\n\nThierry\n\n> diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c\n> index 5daf2ee..fac2db6 100644\n> --- a/drivers/reset/tegra/reset-bpmp.c\n> +++ b/drivers/reset/tegra/reset-bpmp.c\n> @@ -23,6 +23,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,\n>  \tstruct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);\n>  \tstruct mrq_reset_request request;\n>  \tstruct tegra_bpmp_message msg;\n> +\tint err;\n>  \n>  \tmemset(&request, 0, sizeof(request));\n>  \trequest.cmd = command;\n> @@ -33,7 +34,13 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,\n>  \tmsg.tx.data = &request;\n>  \tmsg.tx.size = sizeof(request);\n>  \n> -\treturn tegra_bpmp_transfer(bpmp, &msg);\n> +\terr = tegra_bpmp_transfer(bpmp, &msg);\n> +\tif (err < 0)\n> +\t\treturn err;\n> +\telse if (msg.rx.ret < 0)\n> +\t\treturn -EINVAL;\n> +\n> +\treturn 0;\n>  }\n>  \n>  static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,\n> -- \n> 2.7.4\n>","headers":{"Return-Path":"<linux-tegra-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"i2SWsaQe\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGWtn4NCMz9sP1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 Oct 2017 21:40:49 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751058AbdJQKks (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 17 Oct 2017 06:40:48 -0400","from mail-qk0-f196.google.com ([209.85.220.196]:57105 \"EHLO\n\tmail-qk0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750748AbdJQKkr (ORCPT\n\t<rfc822;linux-tegra@vger.kernel.org>);\n\tTue, 17 Oct 2017 06:40:47 -0400","by mail-qk0-f196.google.com with SMTP id l194so1356949qke.13;\n\tTue, 17 Oct 2017 03:40:47 -0700 (PDT)","from localhost\n\t(p200300E41BE4FD00CEAD5B94E1CFD280.dip0.t-ipconnect.de.\n\t[2003:e4:1be4:fd00:cead:5b94:e1cf:d280])\n\tby smtp.gmail.com with ESMTPSA id\n\tp39sm6293237qta.18.2017.10.17.03.40.45\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 17 Oct 2017 03:40:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=lv4cYh2O/ZCAxRMyQEMQN/K98gTnzfr1HDkzxn3x414=;\n\tb=i2SWsaQea5bZm38lRCyLCH8zE2HE5Sl+vbOKOAHC2Q0ji5O+Tv7PXS9zOhOXBIqzJD\n\tTx3wyU/H9ISZJZWipgECrOMCvC4HXDZBjL+MlSOCsq9A4rH7LpbF/5C+TKAu6gkiw1p2\n\tuAXokHvLx6+HbQFGMFfDu5dNmBSThuxtsX1c/0grg6doxg+kj8IovfK0GPp6vT/N6QiL\n\tH+tOQHuCOsYHdVYIJwAGR4hYdAvnZdaBFodZzn2kh6PkdDy7M5lL98GaryRSrI4J6u7h\n\tV8gbCpn+WtIxWgCeltmvidNFnj9i7YKtsD32gWQx1hTLo7QRhvKY/ibOtUnlZ+WaVfTI\n\tOX7Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=lv4cYh2O/ZCAxRMyQEMQN/K98gTnzfr1HDkzxn3x414=;\n\tb=f/+My/3xGnNM4YIzgilfHpRW6RNKD+af/1BdTtrNgnaSou1TaxuuAhYFJm75mI8T3G\n\tYHXNi+8Vdp8AGPPi6vem+IxnpXA48Qee59GQYjStveC9Uk6E/WVz4cP25WdgPrPO5Bli\n\tsny/Hdpl4ujVxJ7HPn06/elGCt50i4XKXybDGqIWF7VtaKioanWXR/lGRLk3BieXUDXt\n\t/SASjP5QQeGxeC/rVdyWAsQxf8ALzn0Y3UErU0nbNMcqzdxcn4bgxuDK3PiVJZJv5WWN\n\tKkxpJG00zfNx6Wv3ZwNDV+QlumDOZOXpvUiE3ayosZO3yqP+VW9+ceCrF3/D0RVuxnyy\n\tct8w==","X-Gm-Message-State":"AMCzsaVXAYp5IDKMdiIX6dke5GTiiLmCz2AaVuIMJn5zmZ2DqQTONgaG\n\tcWJCtpEIcQQEYpitjWpFQUg=","X-Google-Smtp-Source":"ABhQp+TzjpoICPyW6LLr75Yd+rY3EhlGJt2pfxX4KL2zTAhufIpRtGiywYw3nPiKxz/Ud8iuTKzSGQ==","X-Received":"by 10.233.230.10 with SMTP id z10mr16689075qkf.8.1508236846508; \n\tTue, 17 Oct 2017 03:40:46 -0700 (PDT)","Date":"Tue, 17 Oct 2017 12:40:43 +0200","From":"Thierry Reding <thierry.reding@gmail.com>","To":"Philipp Zabel <p.zabel@pengutronix.de>","Cc":"Timo Alho <talho@nvidia.com>, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 3/4] reset: tegra: check BPMP response return code","Message-ID":"<20171017104043.GB30589@ulmo>","References":"<cover.1504776489.git.talho@nvidia.com>\n\t<00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"cmJC7u66zC7hs+87\"","Content-Disposition":"inline","In-Reply-To":"<00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-tegra.vger.kernel.org>","X-Mailing-List":"linux-tegra@vger.kernel.org"}},{"id":1788236,"web_url":"http://patchwork.ozlabs.org/comment/1788236/","msgid":"<1508237537.6854.8.camel@pengutronix.de>","list_archive_url":null,"date":"2017-10-17T10:52:17","subject":"Re: [PATCH 3/4] reset: tegra: check BPMP response return code","submitter":{"id":16215,"url":"http://patchwork.ozlabs.org/api/people/16215/","name":"Philipp Zabel","email":"p.zabel@pengutronix.de"},"content":"Hi Thierry,\n\nOn Tue, 2017-10-17 at 12:40 +0200, Thierry Reding wrote:\n> On Thu, Sep 07, 2017 at 12:31:03PM +0300, Timo Alho wrote:\n> > Add checks for return code in BPMP response message.\n> > \n> > Signed-off-by: Timo Alho <talho@nvidia.com>\n> > ---\n> >  drivers/reset/tegra/reset-bpmp.c | 9 ++++++++-\n> >  1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> Hi Philipp,\n> \n> Would you provide an Acked-by on this so that I can take it into the\n> Tegra tree? There's a build dependency on patch 1/4 in the series.\n\nAcked-by: Philipp Zabel <p.zabel@pengutronix.de>\n\nto take this via the Tegra tree.\n\n> Quoting in full since you were not previously on Cc, unfortunately.\n> \n> Timo, please remember to always Cc the relevant maintainers.\n> \n> Thierry\n> \n> > diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c\n> > index 5daf2ee..fac2db6 100644\n> > --- a/drivers/reset/tegra/reset-bpmp.c\n> > +++ b/drivers/reset/tegra/reset-bpmp.c\n> > @@ -23,6 +23,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,\n> >  \tstruct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);\n> >  \tstruct mrq_reset_request request;\n> >  \tstruct tegra_bpmp_message msg;\n> > +\tint err;\n> >  \n> >  \tmemset(&request, 0, sizeof(request));\n> >  \trequest.cmd = command;\n> > @@ -33,7 +34,13 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,\n> >  \tmsg.tx.data = &request;\n> >  \tmsg.tx.size = sizeof(request);\n> >  \n> > -\treturn tegra_bpmp_transfer(bpmp, &msg);\n> > +\terr = tegra_bpmp_transfer(bpmp, &msg);\n> > +\tif (err < 0)\n> > +\t\treturn err;\n> > +\telse if (msg.rx.ret < 0)\n> > +\t\treturn -EINVAL;\n\nI don't really understand why you complicate the call sites like this\ninstead of just letting tegra_bmp_transfer return -EINVAL if msg.rx.ret\n< 0, but I haven't seen the other patches.\n\nregards\nPhilipp\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-tegra\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<linux-tegra-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGX865mS3z9sDB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 Oct 2017 21:52:22 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755733AbdJQKwV (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 17 Oct 2017 06:52:21 -0400","from metis.ext.4.pengutronix.de ([92.198.50.35]:60987 \"EHLO\n\tmetis.ext.4.pengutronix.de\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753333AbdJQKwV (ORCPT\n\t<rfc822;linux-tegra@vger.kernel.org>);\n\tTue, 17 Oct 2017 06:52:21 -0400","from lupine.hi.pengutronix.de\n\t([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine)\n\tby metis.ext.pengutronix.de with esmtp (Exim 4.84_2)\n\t(envelope-from <p.zabel@pengutronix.de>)\n\tid 1e4PTv-0002rH-4Y; Tue, 17 Oct 2017 12:52:19 +0200"],"Message-ID":"<1508237537.6854.8.camel@pengutronix.de>","Subject":"Re: [PATCH 3/4] reset: tegra: check BPMP response return code","From":"Philipp Zabel <p.zabel@pengutronix.de>","To":"Thierry Reding <thierry.reding@gmail.com>","Cc":"Timo Alho <talho@nvidia.com>, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Date":"Tue, 17 Oct 2017 12:52:17 +0200","In-Reply-To":"<20171017104043.GB30589@ulmo>","References":"<cover.1504776489.git.talho@nvidia.com>\n\t<00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com>\n\t<20171017104043.GB30589@ulmo>","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.22.6-1+deb9u1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-SA-Exim-Connect-IP":"2001:67c:670:100:3ad5:47ff:feaf:1a17","X-SA-Exim-Mail-From":"p.zabel@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"linux-tegra@vger.kernel.org","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-tegra.vger.kernel.org>","X-Mailing-List":"linux-tegra@vger.kernel.org"}},{"id":1788291,"web_url":"http://patchwork.ozlabs.org/comment/1788291/","msgid":"<20171017114910.GA684@ulmo>","list_archive_url":null,"date":"2017-10-17T11:49:10","subject":"Re: [PATCH 3/4] reset: tegra: check BPMP response return code","submitter":{"id":26234,"url":"http://patchwork.ozlabs.org/api/people/26234/","name":"Thierry Reding","email":"thierry.reding@gmail.com"},"content":"On Tue, Oct 17, 2017 at 12:52:17PM +0200, Philipp Zabel wrote:\n> Hi Thierry,\n> \n> On Tue, 2017-10-17 at 12:40 +0200, Thierry Reding wrote:\n> > On Thu, Sep 07, 2017 at 12:31:03PM +0300, Timo Alho wrote:\n> > > Add checks for return code in BPMP response message.\n> > > \n> > > Signed-off-by: Timo Alho <talho@nvidia.com>\n> > > ---\n> > >  drivers/reset/tegra/reset-bpmp.c | 9 ++++++++-\n> > >  1 file changed, 8 insertions(+), 1 deletion(-)\n> > \n> > Hi Philipp,\n> > \n> > Would you provide an Acked-by on this so that I can take it into the\n> > Tegra tree? There's a build dependency on patch 1/4 in the series.\n> \n> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>\n> \n> to take this via the Tegra tree.\n\nThanks!\n\n> > Quoting in full since you were not previously on Cc, unfortunately.\n> > \n> > Timo, please remember to always Cc the relevant maintainers.\n> > \n> > Thierry\n> > \n> > > diff --git a/drivers/reset/tegra/reset-bpmp.c b/drivers/reset/tegra/reset-bpmp.c\n> > > index 5daf2ee..fac2db6 100644\n> > > --- a/drivers/reset/tegra/reset-bpmp.c\n> > > +++ b/drivers/reset/tegra/reset-bpmp.c\n> > > @@ -23,6 +23,7 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,\n> > >  \tstruct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);\n> > >  \tstruct mrq_reset_request request;\n> > >  \tstruct tegra_bpmp_message msg;\n> > > +\tint err;\n> > >  \n> > >  \tmemset(&request, 0, sizeof(request));\n> > >  \trequest.cmd = command;\n> > > @@ -33,7 +34,13 @@ static int tegra_bpmp_reset_common(struct reset_controller_dev *rstc,\n> > >  \tmsg.tx.data = &request;\n> > >  \tmsg.tx.size = sizeof(request);\n> > >  \n> > > -\treturn tegra_bpmp_transfer(bpmp, &msg);\n> > > +\terr = tegra_bpmp_transfer(bpmp, &msg);\n> > > +\tif (err < 0)\n> > > +\t\treturn err;\n> > > +\telse if (msg.rx.ret < 0)\n> > > +\t\treturn -EINVAL;\n> \n> I don't really understand why you complicate the call sites like this\n> instead of just letting tegra_bmp_transfer return -EINVAL if msg.rx.ret\n> < 0, but I haven't seen the other patches.\n\nTimo replied to a similar question from Jon here:\n\n\thttps://patchwork.ozlabs.org/patch/810934/\n\nEssentially this boils down to that there are cases where we may want to\nknow the exact error because it is relevant. In this case, we don't, but\nBPMP provides a number of other services where the errors may be useful.\n\nThierry","headers":{"Return-Path":"<linux-tegra-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"nS8XWzMw\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGYPm5G56z9sNc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 Oct 2017 22:49:16 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753275AbdJQLtP (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 17 Oct 2017 07:49:15 -0400","from mail-qk0-f193.google.com ([209.85.220.193]:50014 \"EHLO\n\tmail-qk0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752852AbdJQLtO (ORCPT\n\t<rfc822;linux-tegra@vger.kernel.org>);\n\tTue, 17 Oct 2017 07:49:14 -0400","by mail-qk0-f193.google.com with SMTP id q83so1585013qke.6;\n\tTue, 17 Oct 2017 04:49:14 -0700 (PDT)","from localhost\n\t(p200300E41BE4FD00CEAD5B94E1CFD280.dip0.t-ipconnect.de.\n\t[2003:e4:1be4:fd00:cead:5b94:e1cf:d280])\n\tby smtp.gmail.com with ESMTPSA id\n\tp31sm4772190qtj.12.2017.10.17.04.49.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 17 Oct 2017 04:49:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=sOmb/h0ErMpqIXM64OAUcrzUCUhUFuDpHKpdYzW0V5E=;\n\tb=nS8XWzMwXIVD+8oR7e6qQPOGpoktHGRghtng7jZDRTZ2XcKNLlg+SAyI7wKBQ3eKTT\n\tpMWaQX4WE3V2d3ONbIjA/hZQJDeG6ntiZFIisD070ooP27JuxZhWIgZGzrChRCw5jKCV\n\tRz2OIhGdJd6NFaQkVmt3t9DNBiEw4Mnryvps8FOUUajrElqc7hkR520S0rgt3mkCt5pB\n\toQhtfyDMLu15QADY6RG+DAZYzYe+TteKBSs8VnnpHJnRcAoaMT4sqsQieCNVuaG+/Ng3\n\txMr2xziYd2BkbEzgEIoUsKfEcQuBhCefAZWRScDKpjz6mJ+bRJO7QFrsvdrstos1jfMw\n\tvFNw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=sOmb/h0ErMpqIXM64OAUcrzUCUhUFuDpHKpdYzW0V5E=;\n\tb=uQHkF5xcrziEG4WGfI2Z+X03YXmLX0No7DDC5/rUUPnTXYeg2Yk8Zji64Zg5Kkmivo\n\ttjoXIZ5UIfEts2jkjERlL5VUuonlekPPcRgvmxbL+kSvhHwrxV4k+w4g1G34BfPykiNX\n\tdFdP3ObO4vGzErQd9QFochtfkaFWVjZzbk+38fkuM4vPtBaM5QccTYfhcBPJmtecWG0S\n\tWNGcPFSvNa6zQVYTiFFdFmj9g9ncRFsFk/I1wmgIRaa0kro5i2eEFpIVYZpGTIMIfTpJ\n\toNfjtChLqfBbyEjtx2BJq/chrBGjhzzsJZJ3uGcOlpReYhJX/8w+firKuyz5r2DJe709\n\tvJKQ==","X-Gm-Message-State":"AMCzsaVXA/gUflKEuF6XnVXYLjiAv11B7I4YqSVn+QWuV6vJ3cHEaT6f\n\tpUYzJqZTJXorIPdF4BR+s68=","X-Google-Smtp-Source":"AOwi7QB+875DEoZaJmeaVad+0QEzyBIZba64tzf2Hza+6aqw3HhbDRO27DhI3gJSpbiyY6frNFamnQ==","X-Received":"by 10.55.75.15 with SMTP id y15mr16655395qka.321.1508240953383; \n\tTue, 17 Oct 2017 04:49:13 -0700 (PDT)","Date":"Tue, 17 Oct 2017 13:49:10 +0200","From":"Thierry Reding <thierry.reding@gmail.com>","To":"Philipp Zabel <p.zabel@pengutronix.de>","Cc":"Timo Alho <talho@nvidia.com>, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 3/4] reset: tegra: check BPMP response return code","Message-ID":"<20171017114910.GA684@ulmo>","References":"<cover.1504776489.git.talho@nvidia.com>\n\t<00e7714871d7568e9fc848dc5f76d14e07984a1e.1504776489.git.talho@nvidia.com>\n\t<20171017104043.GB30589@ulmo>\n\t<1508237537.6854.8.camel@pengutronix.de>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"EeQfGwPcQSOJBaQU\"","Content-Disposition":"inline","In-Reply-To":"<1508237537.6854.8.camel@pengutronix.de>","User-Agent":"Mutt/1.9.1 (2017-09-22)","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-tegra.vger.kernel.org>","X-Mailing-List":"linux-tegra@vger.kernel.org"}}]