[{"id":1778584,"web_url":"http://patchwork.ozlabs.org/comment/1778584/","msgid":"","list_archive_url":null,"date":"2017-10-02T20:26:12","subject":"Re: [PATCH 4/4] soc/tegra: bpmp: check BPMP response return code","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 07/09/17 10:31, Timo Alho wrote:\n> Add checks for return code in BPMP response message.\n> \n> Signed-off-by: Timo Alho \n> ---\n> drivers/soc/tegra/powergate-bpmp.c | 15 +++++++++++++--\n> 1 file changed, 13 insertions(+), 2 deletions(-)\n> \n> diff --git a/drivers/soc/tegra/powergate-bpmp.c b/drivers/soc/tegra/powergate-bpmp.c\n> index 8fc3560..82c7e27 100644\n> --- a/drivers/soc/tegra/powergate-bpmp.c\n> +++ b/drivers/soc/tegra/powergate-bpmp.c\n> @@ -42,6 +42,7 @@ static int tegra_bpmp_powergate_set_state(struct tegra_bpmp *bpmp,\n> {\n> \tstruct mrq_pg_request request;\n> \tstruct tegra_bpmp_message msg;\n> +\tint err;\n> \n> \tmemset(&request, 0, sizeof(request));\n> \trequest.cmd = CMD_PG_SET_STATE;\n> @@ -53,7 +54,13 @@ static int tegra_bpmp_powergate_set_state(struct tegra_bpmp *bpmp,\n> \tmsg.tx.data = &request;\n> \tmsg.tx.size = sizeof(request);\n> \n> -\treturn tegra_bpmp_transfer(bpmp, &msg);\n> +\terr = tegra_bpmp_transfer(bpmp, &msg);\n> +\tif (err < 0)\n> +\t\treturn err;\n> +\telse if (msg.rx.ret < 0)\n> +\t\treturn -EINVAL;\n> +\n> +\treturn 0;\n> }\n> \n> static int tegra_bpmp_powergate_get_state(struct tegra_bpmp *bpmp,\n> @@ -80,6 +87,8 @@ static int tegra_bpmp_powergate_get_state(struct tegra_bpmp *bpmp,\n> \terr = tegra_bpmp_transfer(bpmp, &msg);\n> \tif (err < 0)\n> \t\treturn PG_STATE_OFF;\n> +\telse if (msg.rx.ret < 0)\n> +\t\treturn -EINVAL;\n> \n> \treturn response.get_state.state;\n> }\n> @@ -106,6 +115,8 @@ static int tegra_bpmp_powergate_get_max_id(struct tegra_bpmp *bpmp)\n> \terr = tegra_bpmp_transfer(bpmp, &msg);\n> \tif (err < 0)\n> \t\treturn err;\n> +\telse if (msg.rx.ret < 0)\n> +\t\treturn -EINVAL;\n> \n> \treturn response.get_max_id.max_id;\n> }\n> @@ -132,7 +143,7 @@ static char *tegra_bpmp_powergate_get_name(struct tegra_bpmp *bpmp,\n> \tmsg.rx.size = sizeof(response);\n> \n> \terr = tegra_bpmp_transfer(bpmp, &msg);\n> -\tif (err < 0)\n> +\tif (err < 0 || msg.rx.ret < 0)\n> \t\treturn NULL;\n> \n> \treturn kstrdup(response.get_name.name, GFP_KERNEL);\n\nAcked-by: Jon Hunter \n\nCheers\nJon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y5Ygc4NSKz9t5q\n\tfor ;\n\tTue, 3 Oct 2017 07:30:04 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751263AbdJBUaD (ORCPT );\n\tMon, 2 Oct 2017 16:30:03 -0400","from hqemgate14.nvidia.com ([216.228.121.143]:2287 \"EHLO\n\thqemgate14.nvidia.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751132AbdJBUaC (ORCPT\n\t); Mon, 2 Oct 2017 16:30:02 -0400","from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by\n\thqemgate14.nvidia.com\n\tid ; Mon, 02 Oct 2017 13:29:23 -0700","from HQMAIL103.nvidia.com ([172.20.161.6])\n\tby hqpgpgate101.nvidia.com (PGP Universal service);\n\tMon, 02 Oct 2017 13:29:31 -0700","from UKMAIL101.nvidia.com (10.26.138.13) by HQMAIL103.nvidia.com\n\t(172.20.187.11) with Microsoft SMTP Server (TLS) id 15.0.1293.2;\n\tMon, 2 Oct 2017 20:26:18 +0000","from [10.26.11.81] (10.26.11.81) by UKMAIL101.nvidia.com\n\t(10.26.138.13) with Microsoft SMTP Server (TLS) id 15.0.1293.2;\n\tMon, 2 Oct 2017 20:26:15 +0000"],"X-PGP-Universal":"processed;\n\tby hqpgpgate101.nvidia.com on Mon, 02 Oct 2017 13:29:31 -0700","Subject":"Re: [PATCH 4/4] soc/tegra: bpmp: check BPMP response return code","To":"Timo Alho , ","CC":", ","References":"\n\t<8be4357544ffb9a60e116bc0a666189b93951c91.1504776489.git.talho@nvidia.com>","From":"Jon Hunter ","Message-ID":"","Date":"Mon, 2 Oct 2017 21:26:12 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<8be4357544ffb9a60e116bc0a666189b93951c91.1504776489.git.talho@nvidia.com>","X-Originating-IP":"[10.26.11.81]","X-ClientProxiedBy":"UKMAIL102.nvidia.com (10.26.138.15) To\n\tUKMAIL101.nvidia.com (10.26.138.13)","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"}},{"id":1788226,"web_url":"http://patchwork.ozlabs.org/comment/1788226/","msgid":"<20171017104108.GC30589@ulmo>","list_archive_url":null,"date":"2017-10-17T10:41:08","subject":"Re: [PATCH 4/4] soc/tegra: bpmp: check BPMP response return code","submitter":{"id":26234,"url":"http://patchwork.ozlabs.org/api/people/26234/","name":"Thierry Reding","email":"thierry.reding@gmail.com"},"content":"On Thu, Sep 07, 2017 at 12:31:04PM +0300, Timo Alho wrote:\n> Add checks for return code in BPMP response message.\n> \n> Signed-off-by: Timo Alho \n> ---\n> drivers/soc/tegra/powergate-bpmp.c | 15 +++++++++++++--\n> 1 file changed, 13 insertions(+), 2 deletions(-)\n\nApplied, thanks.\n\nThierry","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-tegra-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"d0Pma2NW\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGWvF4zscz9s9Y\n\tfor ;\n\tTue, 17 Oct 2017 21:41:13 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1761249AbdJQKlM (ORCPT );\n\tTue, 17 Oct 2017 06:41:12 -0400","from mail-qk0-f194.google.com ([209.85.220.194]:54602 \"EHLO\n\tmail-qk0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1761248AbdJQKlL (ORCPT\n\t);\n\tTue, 17 Oct 2017 06:41:11 -0400","by mail-qk0-f194.google.com with SMTP id n5so1358867qke.11;\n\tTue, 17 Oct 2017 03:41:11 -0700 (PDT)","from localhost\n\t(p200300E41BE4FD00CEAD5B94E1CFD280.dip0.t-ipconnect.de.\n\t[2003:e4:1be4:fd00:cead:5b94:e1cf:d280])\n\tby smtp.gmail.com with ESMTPSA id\n\to74sm5763752qkl.58.2017.10.17.03.41.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 17 Oct 2017 03:41:10 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=nhraZ124cnECKRr0gRPxXLjLQp4NVfHh1ScqYMt8SDY=;\n\tb=d0Pma2NWqOUMKAraUOvL0BScY10q0SHLK4IFWbPWns4yFGdt6qUusRUwCHSchwTjWb\n\tYLPjSwyy4Ff8OWxYpsUFzDvrHWliSBu81LTorszciYUfM+qYfGmgFplQD4q5tCIgHbTC\n\te28/26f/eitVtYDnHVWQHAIfYxpU6bZK0jdK+lVtBXxAaUxlCnCPt/wbtyfVuJpUrAT5\n\tXTE3t6XWxpITFfml4IgB7KrJf8XoC7B992YnvwECxxP4aUBUPgM9kuUuszpg6NajYU7t\n\tyZtYYqSjksvAousZiYprk4qNxMa83GFpILD3su16vTQz+aib5fgpMiRjC2NKYJIhWQ/e\n\tMy/Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=nhraZ124cnECKRr0gRPxXLjLQp4NVfHh1ScqYMt8SDY=;\n\tb=P/mtwKE5X9L5f9hYvXqGNdXoT9ggnSPzVzAvDP6Fet6DTwwVj1b/bLtjBWQyf4sfAX\n\tASwHr0Tde+zEuc1cW/rR5wr3Z44/OLHW7ZaRRBLAJPeUNKAG4y3QyuT1Gz6T2vfJyrY7\n\tlkH3syHon0McqWMR22kSsv/KwNE1ybCPrufSGRgHs7E6byVephVXqR8H8mUbgZyIA41w\n\tkVODq/xj72sCs2x3IDvnW1mvn9MbksEktW+YMjzc7wYcxFbmaP3Jl2bFJgn0c7Z3YHOj\n\t5zZqkfEeqmdQyUwrlrM/HeRA7s+agQVZ+P4kXF9Zu72Jv1jEZ0quZAD+6H0i5DqJYDvc\n\tFrRA==","X-Gm-Message-State":"AMCzsaWMdDttikruOk4gx/ccwo5rq23doZMTSBv4sTnpk09HjUsc0hJM\n\thrIlNWMRY7xA+eohFYAMeqw=","X-Google-Smtp-Source":"ABhQp+Rjh7Jc9swdy4tPIosaNVF8MiLXjWghz6wJDcAJHAmtwLyW5DXC/+FBo2vyUKnx9z0xg+lzHQ==","X-Received":"by 10.55.18.13 with SMTP id c13mr18283986qkh.81.1508236870902;\n\tTue, 17 Oct 2017 03:41:10 -0700 (PDT)","Date":"Tue, 17 Oct 2017 12:41:08 +0200","From":"Thierry Reding ","To":"Timo Alho ","Cc":"linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org","Subject":"Re: [PATCH 4/4] soc/tegra: bpmp: check BPMP response return code","Message-ID":"<20171017104108.GC30589@ulmo>","References":"\n\t<8be4357544ffb9a60e116bc0a666189b93951c91.1504776489.git.talho@nvidia.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"UFHRwCdBEJvubb2X\"","Content-Disposition":"inline","In-Reply-To":"<8be4357544ffb9a60e116bc0a666189b93951c91.1504776489.git.talho@nvidia.com>","User-Agent":"Mutt/1.9.1 (2017-09-22)","Sender":"linux-tegra-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-tegra@vger.kernel.org"}}]